Fix the off-by-one a little differently, and correct a refresh problem

[wxWidgets.git] / src / cocoa / radiobut.mm

diff --git a/src/cocoa/radiobut.mm b/src/cocoa/radiobut.mm
index 020b1952131b199dc1cebff41bcd175bd958b1a1..ab8197bd6001bc66af289b373108866af2aa07ad 100644 (file)
--- a/src/cocoa/radiobut.mm
+++ b/src/cocoa/radiobut.mm
@@ -9,12 +9,20 @@
 // Licence:    wxWindows license
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:    wxWindows license
 /////////////////////////////////////////////////////////////////////////////
 

-#include "wx/app.h"
-#include "wx/radiobut.h"
-#include "wx/log.h"
+#include "wx/wxprec.h"
+#ifndef WX_PRECOMP
+    #include "wx/log.h"
+    #include "wx/app.h"
+    #include "wx/radiobut.h"
+#endif //WX_PRECOMP

 
 #import <AppKit/NSButton.h>
 
 #import <AppKit/NSButton.h>

-#import <Foundation/NSString.h>
+#include "wx/cocoa/string.h"
+#include "wx/cocoa/autorelease.h"
+
+#include "wx/listimpl.cpp"
+
+WX_DEFINE_LIST(wxRadioButtonList);

 
 IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl)
 // wxRadioButtonBase == wxControl
 
 IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl)
 // wxRadioButtonBase == wxControl


@@ -30,38 +38,123 @@ bool wxRadioButton::Create(wxWindow *parent, wxWindowID winid,
            const wxValidator& validator,
            const wxString& name)
 {
            const wxValidator& validator,
            const wxString& name)
 {

+    wxAutoNSAutoreleasePool pool;
+    m_radioMaster = NULL;

     if(!CreateControl(parent,winid,pos,size,style,validator,name))
         return false;
     if(!CreateControl(parent,winid,pos,size,style,validator,name))
         return false;

+    if(style&wxRB_GROUP)
+    {
+        m_radioMaster = this;
+        m_radioSlaves.Append(this);
+    }
+    else if(style&wxRB_SINGLE)
+        m_radioMaster = NULL;
+    else
+    {
+        for(wxWindowList::compatibility_iterator siblingNode= GetParent()->GetChildren().GetLast();
+            siblingNode;
+            siblingNode = siblingNode->GetPrevious())
+        {
+            wxRadioButton *radioButton  = wxDynamicCast(siblingNode->GetData(),wxRadioButton);
+            if(radioButton && radioButton!=this)
+            {
+                m_radioMaster = radioButton->m_radioMaster;
+                wxASSERT_MSG(m_radioMaster,
+                    wxT("Previous radio button should be part of a group"));
+                // Don't crash, assume user meant wxRB_SINGLE
+                if(m_radioMaster)
+                    m_radioMaster->m_radioSlaves.Append(this);
+                break;
+            }
+        }
+    }
+

     m_cocoaNSView = NULL;
     m_cocoaNSView = NULL;

-    NSRect cocoaRect = NSMakeRect(10,10,20,20);
-    SetNSButton([[NSButton alloc] initWithFrame: cocoaRect]);
+    SetNSButton([[NSButton alloc] initWithFrame: MakeDefaultNSRect(size)]);

     [m_cocoaNSView release];
     [GetNSButton() setButtonType: NSRadioButton];
     [m_cocoaNSView release];
     [GetNSButton() setButtonType: NSRadioButton];

-    [GetNSButton() setTitle:[NSString stringWithCString: label.c_str()]];
+    [GetNSButton() setTitle:wxNSStringWithWxString(label)];
+    // If it's the first in a group, it should be selected
+    if(style&wxRB_GROUP)
+        [GetNSButton() setState: NSOnState];

     [GetNSControl() sizeToFit];
 
     if(m_parent)
         m_parent->CocoaAddChild(this);
     [GetNSControl() sizeToFit];
 
     if(m_parent)
         m_parent->CocoaAddChild(this);

+    SetInitialFrameRect(pos,size);
+

     return true;
 }
 
 wxRadioButton::~wxRadioButton()
 {
     return true;
 }
 
 wxRadioButton::~wxRadioButton()
 {

-    CocoaRemoveFromParent();
-    SetNSButton(NULL);
+    if(m_radioMaster==this)
+    {
+        // First get rid of ourselves (we should ALWAYS be at the head)
+        wxRadioButtonList::compatibility_iterator slaveNode =
+            m_radioSlaves.GetFirst();
+        wxASSERT(slaveNode);
+        wxASSERT(slaveNode->GetData() == this);
+        m_radioSlaves.DeleteNode(slaveNode);
+    
+        // Now find the new master
+        wxRadioButton *newMaster = NULL;
+        slaveNode = m_radioSlaves.GetFirst();
+        if(slaveNode)
+            newMaster = slaveNode->GetData();
+    
+        // For each node (including the new master) set the master, remove
+        // it from this list, and add it to the new master's list
+        for(; slaveNode; slaveNode = m_radioSlaves.GetFirst())
+        {
+            wxRadioButton *radioButton = slaveNode->GetData();
+            wxASSERT(radioButton->m_radioMaster == this);
+            radioButton->m_radioMaster = newMaster;
+            newMaster->m_radioSlaves.Append(radioButton);
+            m_radioSlaves.DeleteNode(slaveNode);
+        }
+    }
+    else if(m_radioMaster)
+    {
+        m_radioMaster->m_radioSlaves.DeleteObject(this);
+        m_radioMaster = NULL;
+    }
+    // normal stuff
+    DisassociateNSButton(GetNSButton());

 }
 
 }
 

-void wxRadioButton::SetValue(bool)
+void wxRadioButton::SetValue(bool value)

 {
 {

+    if(value)
+        [GetNSButton() setState: NSOnState];
+    else
+        [GetNSButton() setState: NSOffState];

 }
 
 bool wxRadioButton::GetValue() const
 {
 }
 
 bool wxRadioButton::GetValue() const
 {

-    return false;
+    int state = [GetNSButton() state];
+    wxASSERT(state!=NSMixedState);
+    return state==NSOnState;

 }
 
 void wxRadioButton::Cocoa_wxNSButtonAction(void)
 {
 }
 
 void wxRadioButton::Cocoa_wxNSButtonAction(void)
 {

-    wxLogDebug("wxRadioButton");
+    wxLogTrace(wxTRACE_COCOA,wxT("wxRadioButton"));
+    if(m_radioMaster && ([GetNSButton() state] == NSOnState))
+    {
+        for(wxRadioButtonList::compatibility_iterator slaveNode =
+                m_radioMaster->m_radioSlaves.GetFirst();
+            slaveNode; slaveNode = slaveNode->GetNext())
+        {
+            wxRadioButton *radioButton = slaveNode->GetData();
+            if(radioButton!=this)
+                radioButton->SetValue(false);
+        }
+    }
+    wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, GetId());
+    InitCommandEvent(event); //    event.SetEventObject(this);
+    event.SetInt(GetValue());
+    Command(event);

 }
 
 }