[ 1509599 ] 'Split pickers page in widgets sample' with more icons and rebaking.

[wxWidgets.git] / src / gtk / region.cpp

diff --git a/src/gtk/region.cpp b/src/gtk/region.cpp
index e14e12d10f371cba3b2de4361e16079c389c89c4..0fd5a8ac44b7ab088d2f2f204c32ba5888ae81b0 100644 (file)
--- a/src/gtk/region.cpp
+++ b/src/gtk/region.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        gtk/region.cpp
+// Name:        src/gtk/region.cpp

 // Purpose:
 // Author:      Robert Roebling
 // Modified:    VZ at 05.10.00: use AllocExclusive(), comparison fixed
 // Purpose:
 // Author:      Robert Roebling
 // Modified:    VZ at 05.10.00: use AllocExclusive(), comparison fixed


@@ -12,20 +12,22 @@
 // declarations
 // ============================================================================
 
 // declarations
 // ============================================================================
 

-#ifdef __GNUG__
-    #pragma implementation "region.h"
-#endif
-

 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------
 

-#include "wx/log.h"
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"

 
 #include "wx/region.h"
 
 
 #include "wx/region.h"
 

+#ifndef WX_PRECOMP
+    #include "wx/log.h"
+#endif
+

 #include "wx/gtk/private.h"
 
 #include "wx/gtk/private.h"
 

+

 // ----------------------------------------------------------------------------
 // wxRegionRefData: private class containing the information about the region
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // wxRegionRefData: private class containing the information about the region
 // ----------------------------------------------------------------------------


@@ -37,20 +39,13 @@ public:
     {
         m_region = NULL;
     }
     {
         m_region = NULL;
     }

-    
+

     wxRegionRefData(const wxRegionRefData& refData)
         : wxObjectRefData()
     {
     wxRegionRefData(const wxRegionRefData& refData)
         : wxObjectRefData()
     {

-#ifdef __WXGTK20__

         m_region = gdk_region_copy(refData.m_region);
         m_region = gdk_region_copy(refData.m_region);

-#else
-        m_region = gdk_region_new();
-        GdkRegion *regCopy = gdk_regions_union(m_region, refData.m_region);
-        gdk_region_destroy(m_region);
-        m_region = regCopy;
-#endif

     }
     }

-    
+

     ~wxRegionRefData()
     {
         if (m_region)
     ~wxRegionRefData()
     {
         if (m_region)


@@ -83,16 +78,10 @@ void wxRegion::InitRect(wxCoord x, wxCoord y, wxCoord w, wxCoord h)
     rect.y = y;
     rect.width = w;
     rect.height = h;
     rect.y = y;
     rect.width = w;
     rect.height = h;

-    
+

     m_refData = new wxRegionRefData();
     m_refData = new wxRegionRefData();

-    
-#ifdef __WXGTK20__
+

     M_REGIONDATA->m_region = gdk_region_rectangle( &rect );
     M_REGIONDATA->m_region = gdk_region_rectangle( &rect );

-#else
-    GdkRegion *reg = gdk_region_new();
-    M_REGIONDATA->m_region = gdk_region_union_with_rect( reg, &rect );
-    gdk_region_destroy( reg );
-#endif

 }
 
 wxRegion::wxRegion( GdkRegion *region )
 }
 
 wxRegion::wxRegion( GdkRegion *region )


@@ -144,12 +133,12 @@ wxObjectRefData *wxRegion::CloneRefData(const wxObjectRefData *data) const
 // wxRegion comparison
 // ----------------------------------------------------------------------------
 
 // wxRegion comparison
 // ----------------------------------------------------------------------------
 

-bool wxRegion::operator==( const wxRegion& region )
+bool wxRegion::operator==( const wxRegion& region ) const

 {
 {

-    if (m_refData == region.m_refData) return TRUE;
+    if (m_refData == region.m_refData) return true;
+
+    if (!m_refData || !region.m_refData) return false;

 
 

-    if (!m_refData || !region.m_refData) return FALSE;
-    

     // compare the regions themselves, not the pointers to ref data!
     return gdk_region_equal(M_REGIONDATA->m_region,
                             M_REGIONDATA_OF(region)->m_region);
     // compare the regions themselves, not the pointers to ref data!
     return gdk_region_equal(M_REGIONDATA->m_region,
                             M_REGIONDATA_OF(region)->m_region);


@@ -166,37 +155,30 @@ void wxRegion::Clear()
 
 bool wxRegion::Union( wxCoord x, wxCoord y, wxCoord width, wxCoord height )
 {
 
 bool wxRegion::Union( wxCoord x, wxCoord y, wxCoord width, wxCoord height )
 {

-    GdkRectangle rect;
-    rect.x = x;
-    rect.y = y;
-    rect.width = width;
-    rect.height = height;
-    
-    if (!m_refData)
+    // workaround for a strange GTK/X11 bug: taking union with an empty
+    // rectangle results in an empty region which is definitely not what we
+    // want
+    if ( !width || !height )
+        return true;
+
+    if ( !m_refData )

     {
     {

-        m_refData = new wxRegionRefData();
-#ifdef __WXGTK20__
-        M_REGIONDATA->m_region = gdk_region_rectangle( &rect );
-#else
-        GdkRegion *reg = gdk_region_new();
-        M_REGIONDATA->m_region = gdk_region_union_with_rect( reg, &rect );
-        gdk_region_destroy( reg );
-#endif
+        InitRect(x, y, width, height);

     }
     else
     {
         AllocExclusive();
 
     }
     else
     {
         AllocExclusive();
 

-#ifdef __WXGTK20__
+        GdkRectangle rect;
+        rect.x = x;
+        rect.y = y;
+        rect.width = width;
+        rect.height = height;
+

         gdk_region_union_with_rect( M_REGIONDATA->m_region, &rect );
         gdk_region_union_with_rect( M_REGIONDATA->m_region, &rect );

-#else
-        GdkRegion *reg = gdk_region_union_with_rect( M_REGIONDATA->m_region, &rect );
-        gdk_region_destroy( M_REGIONDATA->m_region );
-        M_REGIONDATA->m_region = reg;
-#endif

     }
 
     }
 

-    return TRUE;
+    return true;

 }
 
 bool wxRegion::Union( const wxRect& rect )
 }
 
 bool wxRegion::Union( const wxRect& rect )


@@ -207,7 +189,7 @@ bool wxRegion::Union( const wxRect& rect )
 bool wxRegion::Union( const wxRegion& region )
 {
     if (region.IsNull())
 bool wxRegion::Union( const wxRegion& region )
 {
     if (region.IsNull())

-        return FALSE;
+        return false;

 
     if (!m_refData)
     {
 
     if (!m_refData)
     {


@@ -219,15 +201,9 @@ bool wxRegion::Union( const wxRegion& region )
         AllocExclusive();
     }
 
         AllocExclusive();
     }
 

-#ifdef __WXGTK20__

     gdk_region_union( M_REGIONDATA->m_region, region.GetRegion() );
     gdk_region_union( M_REGIONDATA->m_region, region.GetRegion() );

-#else
-    GdkRegion *reg = gdk_regions_union( M_REGIONDATA->m_region, region.GetRegion() );
-    gdk_region_destroy( M_REGIONDATA->m_region );
-    M_REGIONDATA->m_region = reg;
-#endif

 
 

-    return TRUE;
+    return true;

 }
 
 bool wxRegion::Intersect( wxCoord x, wxCoord y, wxCoord width, wxCoord height )
 }
 
 bool wxRegion::Intersect( wxCoord x, wxCoord y, wxCoord width, wxCoord height )


@@ -240,37 +216,26 @@ bool wxRegion::Intersect( wxCoord x, wxCoord y, wxCoord width, wxCoord height )
 bool wxRegion::Intersect( const wxRect& rect )
 {
     wxRegion reg( rect );
 bool wxRegion::Intersect( const wxRect& rect )
 {
     wxRegion reg( rect );

-    
+

     return Intersect( reg );
 }
 
 bool wxRegion::Intersect( const wxRegion& region )
 {
     if (region.IsNull())
     return Intersect( reg );
 }
 
 bool wxRegion::Intersect( const wxRegion& region )
 {
     if (region.IsNull())

-        return FALSE;
+        return false;

 
     if (!m_refData)
     {
 
     if (!m_refData)
     {

-        m_refData = new wxRegionRefData();
-        M_REGIONDATA->m_region = gdk_region_new();
-        
-        // leave here 
-        return TRUE;
-    }
-    else
-    {
-        AllocExclusive();
+        // intersecting with invalid region doesn't make sense
+        return false;

     }
 
     }
 

-#ifdef __WXGTK20__
+    AllocExclusive();
+

     gdk_region_intersect( M_REGIONDATA->m_region, region.GetRegion() );
     gdk_region_intersect( M_REGIONDATA->m_region, region.GetRegion() );

-#else
-    GdkRegion *reg = gdk_regions_intersect( M_REGIONDATA->m_region, region.GetRegion() );
-    gdk_region_destroy( M_REGIONDATA->m_region );
-    M_REGIONDATA->m_region = reg;
-#endif

 
 

-    return TRUE;
+    return true;

 }
 
 bool wxRegion::Subtract( wxCoord x, wxCoord y, wxCoord width, wxCoord height )
 }
 
 bool wxRegion::Subtract( wxCoord x, wxCoord y, wxCoord width, wxCoord height )


@@ -288,27 +253,19 @@ bool wxRegion::Subtract( const wxRect& rect )
 bool wxRegion::Subtract( const wxRegion& region )
 {
     if (region.IsNull())
 bool wxRegion::Subtract( const wxRegion& region )
 {
     if (region.IsNull())

-        return FALSE;
+        return false;

 
     if (!m_refData)
     {
 
     if (!m_refData)
     {

-        m_refData = new wxRegionRefData();
-        M_REGIONDATA->m_region = gdk_region_new();
-    }
-    else
-    {
-        AllocExclusive();
+        // subtracting from an invalid region doesn't make sense
+        return false;

     }
 
     }
 

-#ifdef __WXGTK20__
+    AllocExclusive();
+

     gdk_region_subtract( M_REGIONDATA->m_region, region.GetRegion() );
     gdk_region_subtract( M_REGIONDATA->m_region, region.GetRegion() );

-#else
-    GdkRegion *reg = gdk_regions_subtract( M_REGIONDATA->m_region, region.GetRegion() );
-    gdk_region_destroy( M_REGIONDATA->m_region );
-    M_REGIONDATA->m_region = reg;
-#endif

 
 

-    return TRUE;
+    return true;

 }
 
 bool wxRegion::Xor( wxCoord x, wxCoord y, wxCoord width, wxCoord height )
 }
 
 bool wxRegion::Xor( wxCoord x, wxCoord y, wxCoord width, wxCoord height )


@@ -326,27 +283,30 @@ bool wxRegion::Xor( const wxRect& rect )
 bool wxRegion::Xor( const wxRegion& region )
 {
     if (region.IsNull())
 bool wxRegion::Xor( const wxRegion& region )
 {
     if (region.IsNull())

-        return FALSE;
+        return false;

 
     if (!m_refData)
     {
 
     if (!m_refData)
     {

-        m_refData = new wxRegionRefData();
-        M_REGIONDATA->m_region = gdk_region_new();
-    }
-    else
-    {
-        AllocExclusive();
+        return false;

     }
 
     }
 

-#ifdef __WXGTK20__
+    AllocExclusive();
+

     gdk_region_xor( M_REGIONDATA->m_region, region.GetRegion() );
     gdk_region_xor( M_REGIONDATA->m_region, region.GetRegion() );

-#else
-    GdkRegion *reg = gdk_regions_xor( M_REGIONDATA->m_region, region.GetRegion() );
-    gdk_region_destroy( M_REGIONDATA->m_region );
-    M_REGIONDATA->m_region = reg;
-#endif

 
 

-    return TRUE;
+    return true;
+}
+
+bool wxRegion::Offset( wxCoord x, wxCoord y )
+{
+    if (!m_refData)
+        return false;
+
+    AllocExclusive();
+
+    gdk_region_offset( M_REGIONDATA->m_region, x, y );
+
+    return true;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -380,22 +340,10 @@ wxRect wxRegion::GetBox() const
     return wxRect( x, y, w, h );
 }
 
     return wxRect( x, y, w, h );
 }
 

-bool wxRegion::Offset( wxCoord x, wxCoord y )
-{
-    if (!m_refData)
-        return FALSE;
-
-    AllocExclusive();
-
-    gdk_region_offset( M_REGIONDATA->m_region, x, y );
-
-    return TRUE;
-}
-

 bool wxRegion::Empty() const
 {
     if (!m_refData)
 bool wxRegion::Empty() const
 {
     if (!m_refData)

-        return TRUE;
+        return true;

 
     return gdk_region_empty( M_REGIONDATA->m_region );
 }
 
     return gdk_region_empty( M_REGIONDATA->m_region );
 }


@@ -453,27 +401,6 @@ GdkRegion *wxRegion::GetRegion() const
 // wxRegionIterator
 // ----------------------------------------------------------------------------
 
 // wxRegionIterator
 // ----------------------------------------------------------------------------
 

-#ifndef __WXGTK20__
-
-// the following structures must match the private structures
-// in X11 region code ( xc/lib/X11/region.h )
-
-// this makes the Region type transparent
-// and we have access to the region rectangles
-
-#include <gdk/gdkprivate.h>
-
-struct _XBox {
-    short x1, x2, y1, y2;
-};
-
-struct _XRegion {
-    long   size , numRects;
-    _XBox *rects, extents;
-};
-
-#endif
-

 class wxRIRefData: public wxObjectRefData
 {
 public:
 class wxRIRefData: public wxObjectRefData
 {
 public:


@@ -498,16 +425,15 @@ void wxRIRefData::CreateRects( const wxRegion& region )
     delete [] m_rects;
 
     Init();
     delete [] m_rects;
 
     Init();

-    
+

     GdkRegion *gdkregion = region.GetRegion();
     if (!gdkregion)
         return;
     GdkRegion *gdkregion = region.GetRegion();
     if (!gdkregion)
         return;

-    
-#ifdef __WXGTK20__
+

     GdkRectangle *gdkrects = NULL;
     gint numRects = 0;
     gdk_region_get_rectangles( gdkregion, &gdkrects, &numRects );
     GdkRectangle *gdkrects = NULL;
     gint numRects = 0;
     gdk_region_get_rectangles( gdkregion, &gdkrects, &numRects );

-    
+

     m_numRects = numRects;
     if (numRects)
     {
     m_numRects = numRects;
     if (numRects)
     {


@@ -523,26 +449,6 @@ void wxRIRefData::CreateRects( const wxRegion& region )
         }
     }
     g_free( gdkrects );
         }
     }
     g_free( gdkrects );

-#else // GTK+ 1.x
-    Region r = ((GdkRegionPrivate *)gdkregion)->xregion;
-    if (r)
-    {
-        m_numRects = r->numRects;
-        if (m_numRects)
-        {
-            m_rects = new wxRect[m_numRects];
-            for (size_t i=0; i < m_numRects; ++i)
-            {
-                _XBox &xr = r->rects[i];
-                wxRect &wr = m_rects[i];
-                wr.x = xr.x1;
-                wr.y = xr.y1;
-                wr.width = xr.x2-xr.x1;
-                wr.height = xr.y2-xr.y1;
-            }
-        }
-    }
-#endif // GTK+ 2.0/1.x

 }
 
 wxRegionIterator::wxRegionIterator()
 }
 
 wxRegionIterator::wxRegionIterator()


@@ -569,42 +475,48 @@ bool wxRegionIterator::HaveRects() const
     return m_current < ((wxRIRefData*)m_refData)->m_numRects;
 }
 
     return m_current < ((wxRIRefData*)m_refData)->m_numRects;
 }
 

-wxRegionIterator::operator bool () const
+wxRegionIterator& wxRegionIterator::operator ++ ()

 {
 {

-    return HaveRects();
-}
+    if (HaveRects())
+        ++m_current;

 
 

-void wxRegionIterator::operator ++ ()
-{
-    if (HaveRects()) ++m_current;
+    return *this;

 }
 
 }
 

-void wxRegionIterator::operator ++ (int)
+wxRegionIterator wxRegionIterator::operator ++ (int)

 {
 {

-    if (HaveRects()) ++m_current;
+    wxRegionIterator tmp = *this;
+    if (HaveRects())
+        ++m_current;
+
+    return tmp;

 }
 
 wxCoord wxRegionIterator::GetX() const
 {
 }
 
 wxCoord wxRegionIterator::GetX() const
 {

-    if( !HaveRects() ) return 0;
+    wxCHECK_MSG( HaveRects(), 0, _T("invalid wxRegionIterator") );
+

     return ((wxRIRefData*)m_refData)->m_rects[m_current].x;
 }
 
 wxCoord wxRegionIterator::GetY() const
 {
     return ((wxRIRefData*)m_refData)->m_rects[m_current].x;
 }
 
 wxCoord wxRegionIterator::GetY() const
 {

-    if( !HaveRects() ) return 0;
+    wxCHECK_MSG( HaveRects(), 0, _T("invalid wxRegionIterator") );
+

     return ((wxRIRefData*)m_refData)->m_rects[m_current].y;
 }
 
 wxCoord wxRegionIterator::GetW() const
 {
     return ((wxRIRefData*)m_refData)->m_rects[m_current].y;
 }
 
 wxCoord wxRegionIterator::GetW() const
 {

-    if( !HaveRects() ) return -1;
+    wxCHECK_MSG( HaveRects(), 0, _T("invalid wxRegionIterator") );
+

     return ((wxRIRefData*)m_refData)->m_rects[m_current].width;
 }
 
 wxCoord wxRegionIterator::GetH() const
 {
     return ((wxRIRefData*)m_refData)->m_rects[m_current].width;
 }
 
 wxCoord wxRegionIterator::GetH() const
 {

-    if( !HaveRects() ) return -1;
+    wxCHECK_MSG( HaveRects(), 0, _T("invalid wxRegionIterator") );
+

     return ((wxRIRefData*)m_refData)->m_rects[m_current].height;
 }
 
     return ((wxRIRefData*)m_refData)->m_rects[m_current].height;
 }
 


@@ -616,4 +528,3 @@ wxRect wxRegionIterator::GetRect() const
 
     return r;
 }
 
     return r;
 }

-