fix wxBitmapComboBox Gtk-CRITICAL assertion `GTK_IS_ENTRY (entry)' failed

[wxWidgets.git] / include / wx / choicebk.h

diff --git a/include/wx/choicebk.h b/include/wx/choicebk.h
index 46014cc251c8a978d1399b90d3128c77626648b6..6c9f7d4980229b65276404d6c59adfe99b781011 100644 (file)
--- a/include/wx/choicebk.h
+++ b/include/wx/choicebk.h
@@ -18,6 +18,7 @@
 
 #include "wx/bookctrl.h"
 #include "wx/choice.h"
 
 #include "wx/bookctrl.h"
 #include "wx/choice.h"

+#include "wx/containr.h"

 
 class WXDLLIMPEXP_FWD_CORE wxChoice;
 
 
 class WXDLLIMPEXP_FWD_CORE wxChoice;
 


@@ -36,13 +37,10 @@ wxDECLARE_EXPORTED_EVENT( WXDLLIMPEXP_CORE, wxEVT_COMMAND_CHOICEBOOK_PAGE_CHANGI
 // wxChoicebook
 // ----------------------------------------------------------------------------
 
 // wxChoicebook
 // ----------------------------------------------------------------------------
 

-class WXDLLIMPEXP_CORE wxChoicebook : public wxBookCtrlBase
+class WXDLLIMPEXP_CORE wxChoicebook : public wxNavigationEnabled<wxBookCtrlBase>

 {
 public:
 {
 public:

-    wxChoicebook()
-    {
-        Init();
-    }
+    wxChoicebook() { }

 
     wxChoicebook(wxWindow *parent,
                  wxWindowID id,
 
     wxChoicebook(wxWindow *parent,
                  wxWindowID id,


@@ -51,8 +49,6 @@ public:
                  long style = 0,
                  const wxString& name = wxEmptyString)
     {
                  long style = 0,
                  const wxString& name = wxEmptyString)
     {

-        Init();
-

         (void)Create(parent, id, pos, size, style, name);
     }
 
         (void)Create(parent, id, pos, size, style, name);
     }
 


@@ -65,17 +61,15 @@ public:
                 const wxString& name = wxEmptyString);
 
 
                 const wxString& name = wxEmptyString);
 
 

-    virtual int GetSelection() const;

     virtual bool SetPageText(size_t n, const wxString& strText);
     virtual wxString GetPageText(size_t n) const;
     virtual int GetPageImage(size_t n) const;
     virtual bool SetPageImage(size_t n, int imageId);
     virtual bool SetPageText(size_t n, const wxString& strText);
     virtual wxString GetPageText(size_t n) const;
     virtual int GetPageImage(size_t n) const;
     virtual bool SetPageImage(size_t n, int imageId);

-    virtual wxSize CalcSizeFromPage(const wxSize& sizePage) const;

     virtual bool InsertPage(size_t n,
                             wxWindow *page,
                             const wxString& text,
                             bool bSelect = false,
     virtual bool InsertPage(size_t n,
                             wxWindow *page,
                             const wxString& text,
                             bool bSelect = false,

-                            int imageId = -1);
+                            int imageId = NO_IMAGE);

     virtual int SetSelection(size_t n)
         { return DoSetSelection(n, SetSelection_SendEvent); }
     virtual int ChangeSelection(size_t n) { return DoSetSelection(n); }
     virtual int SetSelection(size_t n)
         { return DoSetSelection(n, SetSelection_SendEvent); }
     virtual int ChangeSelection(size_t n) { return DoSetSelection(n); }


@@ -86,18 +80,20 @@ public:
     // returns the choice control
     wxChoice* GetChoiceCtrl() const { return (wxChoice*)m_bookctrl; }
 
     // returns the choice control
     wxChoice* GetChoiceCtrl() const { return (wxChoice*)m_bookctrl; }
 

+    // Override this to return true because the part of parent window
+    // background between our controlling wxChoice and the page area should
+    // show through.
+    virtual bool HasTransparentBackground() { return true; }
+

 protected:
     virtual void DoSetWindowVariant(wxWindowVariant variant);
 
     virtual wxWindow *DoRemovePage(size_t page);
 
 protected:
     virtual void DoSetWindowVariant(wxWindowVariant variant);
 
     virtual wxWindow *DoRemovePage(size_t page);
 

-    // get the size which the choice control should have
-    virtual wxSize GetControllerSize() const;
-

     void UpdateSelectedPage(size_t newsel)
     {
         m_selection = static_cast<int>(newsel);
     void UpdateSelectedPage(size_t newsel)
     {
         m_selection = static_cast<int>(newsel);

-        GetChoiceCtrl()->Select(newsel);
+        GetChoiceCtrl()->Select(m_selection);

     }
 
     wxBookCtrlEvent* CreatePageChangingEvent() const;
     }
 
     wxBookCtrlEvent* CreatePageChangingEvent() const;


@@ -106,13 +102,7 @@ protected:
     // event handlers
     void OnChoiceSelected(wxCommandEvent& event);
 
     // event handlers
     void OnChoiceSelected(wxCommandEvent& event);
 

-    // the currently selected page or wxNOT_FOUND if none
-    int m_selection;
-

 private:
 private:

-    // common part of all constructors
-    void Init();
-

     DECLARE_EVENT_TABLE()
     DECLARE_DYNAMIC_CLASS_NO_COPY(wxChoicebook)
 };
     DECLARE_EVENT_TABLE()
     DECLARE_DYNAMIC_CLASS_NO_COPY(wxChoicebook)
 };


@@ -122,7 +112,7 @@ private:
 // ----------------------------------------------------------------------------
 
 // wxChoicebookEvent is obsolete and defined for compatibility only
 // ----------------------------------------------------------------------------
 
 // wxChoicebookEvent is obsolete and defined for compatibility only

-typedef wxBookCtrlEvent wxChoicebookEvent;
+#define wxChoicebookEvent wxBookCtrlEvent

 typedef wxBookCtrlEventFunction wxChoicebookEventFunction;
 #define wxChoicebookEventHandler(func) wxBookCtrlEventHandler(func)
 
 typedef wxBookCtrlEventFunction wxChoicebookEventFunction;
 #define wxChoicebookEventHandler(func) wxBookCtrlEventHandler(func)