Initial revision

[wxWidgets.git] / src / msw / notebook.cpp

diff --git a/src/msw/notebook.cpp b/src/msw/notebook.cpp
index 52bf8dcd0dea663992d6fede27a2ae32ce5f91e9..185a915c58371ac75858c62ce13781887ced3fe4 100644 (file)
--- a/src/msw/notebook.cpp
+++ b/src/msw/notebook.cpp
@@ -22,16 +22,16 @@
 
 // wxWindows
 #ifndef WX_PRECOMP
 
 // wxWindows
 #ifndef WX_PRECOMP

-  #include  <wx/string.h>
+  #include  "wx/string.h"

 #endif  // WX_PRECOMP
 
 #endif  // WX_PRECOMP
 

-#include  <wx/log.h>
-#include  <wx/imaglist.h>
-#include  <wx/event.h>
-#include  <wx/control.h>
-#include  <wx/notebook.h>
+#include  "wx/log.h"
+#include  "wx/imaglist.h"
+#include  "wx/event.h"
+#include  "wx/control.h"
+#include  "wx/notebook.h"

 
 

-#include  <wx/msw/private.h>
+#include  "wx/msw/private.h"

 
 // Windows standard headers
 #ifndef   __WIN95__
 
 // Windows standard headers
 #ifndef   __WIN95__


@@ -42,11 +42,13 @@
 
 #ifndef __TWIN32__
 #ifdef __GNUWIN32__
 
 #ifndef __TWIN32__
 #ifdef __GNUWIN32__

+#ifndef wxUSE_NORLANDER_HEADERS

   #include "wx/msw/gnuwin32/extra.h"
 #endif
 #endif
   #include "wx/msw/gnuwin32/extra.h"
 #endif
 #endif

+#endif

 
 

-#if !defined(__GNUWIN32__) || defined(__TWIN32__)
+#if !defined(__GNUWIN32__) || defined(__TWIN32__) || defined(wxUSE_NORLANDER_HEADERS)

   #include <commctrl.h>
 #endif
 
   #include <commctrl.h>
 #endif
 


@@ -60,12 +62,28 @@
 // hide the ugly cast
 #define m_hwnd    (HWND)GetHWND()
 
 // hide the ugly cast
 #define m_hwnd    (HWND)GetHWND()
 

+// ----------------------------------------------------------------------------
+// constants
+// ----------------------------------------------------------------------------
+
+// This is a work-around for missing defines in gcc-2.95 headers
+#ifndef TCS_RIGHT
+    #define TCS_RIGHT       0x0002
+#endif
+
+#ifndef TCS_VERTICAL
+    #define TCS_VERTICAL    0x0080
+#endif
+
+#ifndef TCS_BOTTOM
+    #define TCS_BOTTOM      TCS_RIGHT
+#endif
+

 // ----------------------------------------------------------------------------
 // event table
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 // event table
 // ----------------------------------------------------------------------------
 

-#if !USE_SHARED_LIBRARIES
-  BEGIN_EVENT_TABLE(wxNotebook, wxControl)
+BEGIN_EVENT_TABLE(wxNotebook, wxControl)

     EVT_NOTEBOOK_PAGE_CHANGED(-1, wxNotebook::OnSelChange)
 
     EVT_SIZE(wxNotebook::OnSize)
     EVT_NOTEBOOK_PAGE_CHANGED(-1, wxNotebook::OnSelChange)
 
     EVT_SIZE(wxNotebook::OnSize)


@@ -73,11 +91,10 @@
     EVT_SET_FOCUS(wxNotebook::OnSetFocus)
 
     EVT_NAVIGATION_KEY(wxNotebook::OnNavigationKey)
     EVT_SET_FOCUS(wxNotebook::OnSetFocus)
 
     EVT_NAVIGATION_KEY(wxNotebook::OnNavigationKey)

-  END_EVENT_TABLE()
+END_EVENT_TABLE()

 
 

-  IMPLEMENT_DYNAMIC_CLASS(wxNotebook, wxControl)
-  IMPLEMENT_DYNAMIC_CLASS(wxNotebookEvent, wxNotifyEvent)
-#endif
+IMPLEMENT_DYNAMIC_CLASS(wxNotebook, wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxNotebookEvent, wxNotifyEvent)

 
 // ============================================================================
 // implementation
 
 // ============================================================================
 // implementation


@@ -142,6 +159,13 @@ bool wxNotebook::Create(wxWindow *parent,
     tabStyle &= WS_BORDER;
   if (m_windowStyle & wxNB_FIXEDWIDTH)
     tabStyle |= TCS_FIXEDWIDTH ;
     tabStyle &= WS_BORDER;
   if (m_windowStyle & wxNB_FIXEDWIDTH)
     tabStyle |= TCS_FIXEDWIDTH ;

+  if (m_windowStyle & wxNB_BOTTOM)
+    tabStyle |= TCS_RIGHT;
+  if (m_windowStyle & wxNB_LEFT)
+    tabStyle |= TCS_VERTICAL;
+  if (m_windowStyle & wxNB_RIGHT)
+    tabStyle |= TCS_VERTICAL|TCS_RIGHT;
+

 
   if ( !MSWCreate(GetId(), GetParent(), WC_TABCONTROL,
                   this, NULL, pos.x, pos.y, size.x, size.y,
 
   if ( !MSWCreate(GetId(), GetParent(), WC_TABCONTROL,
                   this, NULL, pos.x, pos.y, size.x, size.y,


@@ -186,7 +210,7 @@ int wxNotebook::GetRowCount() const
 
 int wxNotebook::SetSelection(int nPage)
 {
 
 int wxNotebook::SetSelection(int nPage)
 {

-  wxCHECK_MSG( IS_VALID_PAGE(nPage), -1, _T("notebook page out of range") );
+  wxCHECK_MSG( IS_VALID_PAGE(nPage), -1, wxT("notebook page out of range") );

 
   ChangePage(m_nSelection, nPage);
 
 
   ChangePage(m_nSelection, nPage);
 


@@ -205,7 +229,7 @@ void wxNotebook::AdvanceSelection(bool bForward)
 
 bool wxNotebook::SetPageText(int nPage, const wxString& strText)
 {
 
 bool wxNotebook::SetPageText(int nPage, const wxString& strText)
 {

-  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, _T("notebook page out of range") );
+  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, wxT("notebook page out of range") );

 
   TC_ITEM tcItem;
   tcItem.mask = TCIF_TEXT;
 
   TC_ITEM tcItem;
   tcItem.mask = TCIF_TEXT;


@@ -216,7 +240,7 @@ bool wxNotebook::SetPageText(int nPage, const wxString& strText)
 
 wxString wxNotebook::GetPageText(int nPage) const
 {
 
 wxString wxNotebook::GetPageText(int nPage) const
 {

-  wxCHECK_MSG( IS_VALID_PAGE(nPage), _T(""), _T("notebook page out of range") );
+  wxCHECK_MSG( IS_VALID_PAGE(nPage), wxT(""), wxT("notebook page out of range") );

 
   wxChar buf[256];
   TC_ITEM tcItem;
 
   wxChar buf[256];
   TC_ITEM tcItem;


@@ -233,7 +257,7 @@ wxString wxNotebook::GetPageText(int nPage) const
 
 int wxNotebook::GetPageImage(int nPage) const
 {
 
 int wxNotebook::GetPageImage(int nPage) const
 {

-  wxCHECK_MSG( IS_VALID_PAGE(nPage), -1, _T("notebook page out of range") );
+  wxCHECK_MSG( IS_VALID_PAGE(nPage), -1, wxT("notebook page out of range") );

 
   TC_ITEM tcItem;
   tcItem.mask = TCIF_IMAGE;
 
   TC_ITEM tcItem;
   tcItem.mask = TCIF_IMAGE;


@@ -243,7 +267,7 @@ int wxNotebook::GetPageImage(int nPage) const
 
 bool wxNotebook::SetPageImage(int nPage, int nImage)
 {
 
 bool wxNotebook::SetPageImage(int nPage, int nImage)
 {

-  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, _T("notebook page out of range") );
+  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, wxT("notebook page out of range") );

 
   TC_ITEM tcItem;
   tcItem.mask = TCIF_IMAGE;
 
   TC_ITEM tcItem;
   tcItem.mask = TCIF_IMAGE;


@@ -273,7 +297,7 @@ void wxNotebook::SetTabSize(const wxSize& sz)
 // remove one page from the notebook
 bool wxNotebook::DeletePage(int nPage)
 {
 // remove one page from the notebook
 bool wxNotebook::DeletePage(int nPage)
 {

-  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, _T("notebook page out of range") );
+  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, wxT("notebook page out of range") );

 
   if ( m_nSelection == nPage ) {
       // advance selection backwards - the page being deleted shouldn't be left
 
   if ( m_nSelection == nPage ) {
       // advance selection backwards - the page being deleted shouldn't be left


@@ -290,6 +314,9 @@ bool wxNotebook::DeletePage(int nPage)
       // no selection if the notebook became empty
       m_nSelection = -1;
   }
       // no selection if the notebook became empty
       m_nSelection = -1;
   }

+  else
+      m_nSelection = TabCtrl_GetCurSel(m_hwnd);
+

 
   return TRUE;
 }
 
   return TRUE;
 }


@@ -297,12 +324,17 @@ bool wxNotebook::DeletePage(int nPage)
 // remove one page from the notebook, without deleting
 bool wxNotebook::RemovePage(int nPage)
 {
 // remove one page from the notebook, without deleting
 bool wxNotebook::RemovePage(int nPage)
 {

-  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, _T("notebook page out of range") );
+  wxCHECK_MSG( IS_VALID_PAGE(nPage), FALSE, wxT("notebook page out of range") );

 
   TabCtrl_DeleteItem(m_hwnd, nPage);
 
   m_aPages.Remove(nPage);
 
 
   TabCtrl_DeleteItem(m_hwnd, nPage);
 
   m_aPages.Remove(nPage);
 

+  if ( m_aPages.IsEmpty() )
+      m_nSelection = -1;
+    else
+      m_nSelection = TabCtrl_GetCurSel(m_hwnd);
+

   return TRUE;
 }
 
   return TRUE;
 }
 


@@ -318,6 +350,8 @@ bool wxNotebook::DeleteAllPages()
 
   TabCtrl_DeleteAllItems(m_hwnd);
 
 
   TabCtrl_DeleteAllItems(m_hwnd);
 

+  m_nSelection = -1;
+

   return TRUE;
 }
 
   return TRUE;
 }
 


@@ -340,41 +374,41 @@ bool wxNotebook::InsertPage(int nPage,
   wxASSERT( pPage != NULL );
   wxCHECK( IS_VALID_PAGE(nPage) || nPage == GetPageCount(), FALSE );
 
   wxASSERT( pPage != NULL );
   wxCHECK( IS_VALID_PAGE(nPage) || nPage == GetPageCount(), FALSE );
 

-  // add the tab to the control
+  // do add the tab to the control
+
+  // init all fields to 0

   TC_ITEM tcItem;
   TC_ITEM tcItem;

-  tcItem.mask    = 0;
+  memset(&tcItem, 0, sizeof(tcItem));

 
 

-  if (imageId != -1)
+  if ( imageId != -1 )

   {
     tcItem.mask |= TCIF_IMAGE;
     tcItem.iImage  = imageId;
   }
   {
     tcItem.mask |= TCIF_IMAGE;
     tcItem.iImage  = imageId;
   }

-  else
-    tcItem.iImage  = 0;

 
 

-  if (!strText.IsEmpty())
+  if ( !strText.IsEmpty() )

   {
   {

-    tcItem.mask    |= TCIF_TEXT;
-    tcItem.pszText = (wxChar *)strText.c_str();
+    tcItem.mask |= TCIF_TEXT;
+    tcItem.pszText = (wxChar *)strText.c_str(); // const_cast

   }
   }

-  else
-    tcItem.pszText = (wxChar *) NULL;

 
   if ( TabCtrl_InsertItem(m_hwnd, nPage, &tcItem) == -1 ) {
 
   if ( TabCtrl_InsertItem(m_hwnd, nPage, &tcItem) == -1 ) {

-    wxLogError(_T("Can't create the notebook page '%s'."), strText.c_str());
+    wxLogError(wxT("Can't create the notebook page '%s'."), strText.c_str());
+

     return FALSE;
   }
 
     return FALSE;
   }
 

+  // if the inserted page is before the selected one, we must update the
+  // index of the selected page
+  if ( nPage <= m_nSelection )
+  {
+    // one extra page added
+    m_nSelection++;
+  }
+

   // save the pointer to the page
   m_aPages.Insert(pPage, nPage);
 
   // save the pointer to the page
   m_aPages.Insert(pPage, nPage);
 

-  // some page must be selected: either this one or the first one if there is
-  // still no selection
-  if ( bSelect )
-    m_nSelection = nPage;
-  else if ( m_nSelection == -1 )
-    m_nSelection = 0;
-

   // don't show pages by default (we'll need to adjust their size first)
   HWND hwnd = GetWinHwnd(pPage);
   SetWindowLong(hwnd, GWL_STYLE, GetWindowLong(hwnd, GWL_STYLE) & ~WS_VISIBLE);
   // don't show pages by default (we'll need to adjust their size first)
   HWND hwnd = GetWinHwnd(pPage);
   SetWindowLong(hwnd, GWL_STYLE, GetWindowLong(hwnd, GWL_STYLE) & ~WS_VISIBLE);


@@ -382,10 +416,24 @@ bool wxNotebook::InsertPage(int nPage,
   // this updates internal flag too - otherwise it will get out of sync
   pPage->Show(FALSE);
 
   // this updates internal flag too - otherwise it will get out of sync
   pPage->Show(FALSE);
 

-  // FIXME this is ugly, I'm breaking my own rules... but needed to get display
-  //       right (why?)
-  wxSizeEvent event;
-  OnSize(event);
+  // fit the notebook page to the tab control's display area
+  RECT rc;
+  rc.left = rc.top = 0;
+  GetSize((int *)&rc.right, (int *)&rc.bottom);
+  TabCtrl_AdjustRect(m_hwnd, FALSE, &rc);
+  pPage->SetSize(rc.left, rc.top, rc.right - rc.left, rc.bottom - rc.top);
+
+
+  // some page should be selected: either this one or the first one if there is
+  // still no selection
+  int selNew = -1;
+  if ( bSelect )
+    selNew = nPage;
+  else if ( m_nSelection == -1 )
+    selNew = 0;
+
+  if ( selNew != -1 )
+    SetSelection(selNew);

 
   return TRUE;
 }
 
   return TRUE;
 }


@@ -396,14 +444,6 @@ bool wxNotebook::InsertPage(int nPage,
 
 void wxNotebook::OnSize(wxSizeEvent& event)
 {
 
 void wxNotebook::OnSize(wxSizeEvent& event)
 {

-  // make sure the current page is shown and has focus (it's useful because all
-  // pages are created invisible initially)
-  if ( m_nSelection != -1 ) {
-    wxNotebookPage *pPage = m_aPages[m_nSelection];
-    pPage->Show(TRUE);
-    pPage->SetFocus();
-  }
-

   // fit the notebook page to the tab control's display area
   RECT rc;
   rc.left = rc.top = 0;
   // fit the notebook page to the tab control's display area
   RECT rc;
   rc.left = rc.top = 0;


@@ -414,8 +454,6 @@ void wxNotebook::OnSize(wxSizeEvent& event)
   for ( size_t nPage = 0; nPage < nCount; nPage++ ) {
     wxNotebookPage *pPage = m_aPages[nPage];
     pPage->SetSize(rc.left, rc.top, rc.right - rc.left, rc.bottom - rc.top);
   for ( size_t nPage = 0; nPage < nCount; nPage++ ) {
     wxNotebookPage *pPage = m_aPages[nPage];
     pPage->SetSize(rc.left, rc.top, rc.right - rc.left, rc.bottom - rc.top);

-    if ( pPage->GetAutoLayout() )
-      pPage->Layout();

   }
 
   event.Skip();
   }
 
   event.Skip();


@@ -426,12 +464,10 @@ void wxNotebook::OnSelChange(wxNotebookEvent& event)
   // is it our tab control?
   if ( event.GetEventObject() == this )
   {
   // is it our tab control?
   if ( event.GetEventObject() == this )
   {

-      // don't call ChangePage() here because it will generate redundant
-      // notification events

       int sel = event.GetOldSelection();
       if ( sel != -1 )
         m_aPages[sel]->Show(FALSE);
       int sel = event.GetOldSelection();
       if ( sel != -1 )
         m_aPages[sel]->Show(FALSE);

-      
+

       sel = event.GetSelection();
       if ( sel != -1 )
       {
       sel = event.GetSelection();
       if ( sel != -1 )
       {


@@ -439,7 +475,7 @@ void wxNotebook::OnSelChange(wxNotebookEvent& event)
         pPage->Show(TRUE);
         pPage->SetFocus();
       }
         pPage->Show(TRUE);
         pPage->SetFocus();
       }

-      
+

       m_nSelection = sel;
   }
 
       m_nSelection = sel;
   }
 


@@ -520,7 +556,8 @@ bool wxNotebook::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM* result)
 // wxNotebook helper functions
 // ----------------------------------------------------------------------------
 
 // wxNotebook helper functions
 // ----------------------------------------------------------------------------
 

-// hide the currently active panel and show the new one
+// generate the page changing and changed events, hide the currently active
+// panel and show the new one

 void wxNotebook::ChangePage(int nOldSel, int nSel)
 {
   // MT-FIXME should use a real semaphore
 void wxNotebook::ChangePage(int nOldSel, int nSel)
 {
   // MT-FIXME should use a real semaphore


@@ -549,16 +586,8 @@ void wxNotebook::ChangePage(int nOldSel, int nSel)
     return;
   }
 
     return;
   }
 

-  if ( nOldSel != -1 )
-    m_aPages[nOldSel]->Show(FALSE);
-
-  wxNotebookPage *pPage = m_aPages[nSel];
-  pPage->Show(TRUE);
-  pPage->SetFocus();
-

   event.SetEventType(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED);
   ProcessEvent(event);
 
   event.SetEventType(wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED);
   ProcessEvent(event);
 

-  m_nSelection = nSel;

   s_bInsideChangePage = FALSE;
 }
   s_bInsideChangePage = FALSE;
 }