wxTextCtrk::GetRange() shouldn't crash on out of range request

[wxWidgets.git] / src / common / valtext.cpp

diff --git a/src/common/valtext.cpp b/src/common/valtext.cpp
index 7da74055f5c58e23358f79885b06c6da4b847937..8c69b0692be75eb86e2778bd72956ea8555999ee 100644 (file)
--- a/src/common/valtext.cpp
+++ b/src/common/valtext.cpp
@@ -1,62 +1,60 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        valtext.cpp
+// Name:        src/common/valtext.cpp

 // Purpose:     wxTextValidator
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Purpose:     wxTextValidator
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$

-// Copyright:   (c) Julian Smart and Markus Holzem
-// Licence:    wxWindows license
+// Copyright:   (c) Julian Smart
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "valtext.h"
-#endif
-

 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__

-#pragma hdrstop
+  #pragma hdrstop

 #endif
 
 #endif
 

-#ifndef WX_PRECOMP
-#include <stdio.h>
-#include "wx/textctrl.h"
-#include "wx/utils.h"
-#include "wx/msgdlg.h"
-#include "wx/intl.h"
-#endif
+#if wxUSE_VALIDATORS && (wxUSE_TEXTCTRL || wxUSE_COMBOBOX)

 
 #include "wx/valtext.h"
 
 
 #include "wx/valtext.h"
 

+#ifndef WX_PRECOMP
+  #include <stdio.h>
+  #include "wx/textctrl.h"
+  #include "wx/combobox.h"
+  #include "wx/utils.h"
+  #include "wx/msgdlg.h"
+  #include "wx/intl.h"
+#endif
+

 #include <ctype.h>
 #include <string.h>
 #include <stdlib.h>
 
 #include <ctype.h>
 #include <string.h>
 #include <stdlib.h>
 

-#if !USE_SHARED_LIBRARY

 IMPLEMENT_DYNAMIC_CLASS(wxTextValidator, wxValidator)
 
 BEGIN_EVENT_TABLE(wxTextValidator, wxValidator)
 IMPLEMENT_DYNAMIC_CLASS(wxTextValidator, wxValidator)
 
 BEGIN_EVENT_TABLE(wxTextValidator, wxValidator)

-       EVT_CHAR(wxTextValidator::OnChar)
+    EVT_CHAR(wxTextValidator::OnChar)

 END_EVENT_TABLE()
 END_EVENT_TABLE()

-#endif

 
 static bool wxIsNumeric(const wxString& val);
 
 wxTextValidator::wxTextValidator(long style, wxString *val)
 {
 
 static bool wxIsNumeric(const wxString& val);
 
 wxTextValidator::wxTextValidator(long style, wxString *val)
 {

-       m_validatorStyle = style ;
-       m_stringValue = val ;
+    m_validatorStyle = style;
+    m_stringValue = val;

 /*
     m_refData = new wxVTextRefData;
 
 /*
     m_refData = new wxVTextRefData;
 

-       M_VTEXTDATA->m_validatorStyle = style ;
-       M_VTEXTDATA->m_stringValue = val ;
+    M_VTEXTDATA->m_validatorStyle = style;
+    M_VTEXTDATA->m_stringValue = val;

 */
 }
 
 wxTextValidator::wxTextValidator(const wxTextValidator& val)
 */
 }
 
 wxTextValidator::wxTextValidator(const wxTextValidator& val)

+    : wxValidator()

 {
     Copy(val);
 }
 {
     Copy(val);
 }


@@ -65,249 +63,244 @@ bool wxTextValidator::Copy(const wxTextValidator& val)
 {
     wxValidator::Copy(val);
 
 {
     wxValidator::Copy(val);
 

-       m_validatorStyle = val.m_validatorStyle ;
-       m_stringValue = val.m_stringValue ;
-
-       wxNode *node = val.m_includeList.First() ;
-       while ( node )
-       {
-               char *s = (char *)node->Data();
-               m_includeList.Add(s);
-               node = node->Next();
-       }
-       node = val.m_excludeList.First() ;
-       while ( node )
-       {
-               char *s = (char *)node->Data();
-               m_excludeList.Add(s);
-               node = node->Next();
-       }
-    return TRUE;
+    m_validatorStyle = val.m_validatorStyle;
+    m_stringValue = val.m_stringValue;
+
+    m_includes    = val.m_includes;
+    m_excludes    = val.m_excludes;
+
+    return true;

 }
 
 }
 

-wxTextValidator::~wxTextValidator()
+wxTextEntry *wxTextValidator::GetTextEntry()

 {
 {

+#if wxUSE_TEXTCTRL
+    if (m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)))
+    {
+        return (wxTextCtrl*)m_validatorWindow;
+    }
+#endif
+
+#if wxUSE_COMBOBOX
+    if (m_validatorWindow->IsKindOf(CLASSINFO(wxComboBox)))
+    {
+        return (wxComboBox*)m_validatorWindow;
+    }
+#endif
+
+    wxFAIL_MSG(
+        _T("wxTextValidator can only be used with wxTextCtrl or wxComboBox")
+    );
+
+    return NULL;

 }
 
 static bool wxIsAlpha(const wxString& val)
 {
 }
 
 static bool wxIsAlpha(const wxString& val)
 {

-       int i;
-       for ( i = 0; i < (int)val.Length(); i++)
-       {
-               if (!isalpha(val[i]))
-                       return FALSE;
-       }
-       return TRUE;
+    int i;
+    for ( i = 0; i < (int)val.length(); i++)
+    {
+        if (!wxIsalpha(val[i]))
+            return false;
+    }
+    return true;

 }
 
 static bool wxIsAlphaNumeric(const wxString& val)
 {
 }
 
 static bool wxIsAlphaNumeric(const wxString& val)
 {

-       int i;
-       for ( i = 0; i < (int)val.Length(); i++)
-       {
-               if (!isalnum(val[i]))
-                       return FALSE;
-       }
-       return TRUE;
+    int i;
+    for ( i = 0; i < (int)val.length(); i++)
+    {
+        if (!wxIsalnum(val[i]))
+            return false;
+    }
+    return true;

 }
 
 // Called when the value in the window must be validated.
 // This function can pop up an error message.
 bool wxTextValidator::Validate(wxWindow *parent)
 {
 }
 
 // Called when the value in the window must be validated.
 // This function can pop up an error message.
 bool wxTextValidator::Validate(wxWindow *parent)
 {

-       if ( !m_validatorWindow )
-               return FALSE;
-       if ( !m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
-               return FALSE;
-       if ( !m_stringValue )
-               return FALSE;
-
-       wxTextCtrl *control = (wxTextCtrl *) m_validatorWindow ;
-
-       // If window is disabled, don't validate
-       if ( !control->Enabled() )
-               return FALSE;
-
-       wxString val(control->GetValue());
-
-       if ( m_validatorStyle & wxFILTER_INCLUDE_LIST )
-       {
-               if ( !m_includeList.Member(val) )
-               {
-            m_validatorWindow->SetFocus();
-                       char buf[512];
-                       sprintf(buf, _("%s is invalid."), (const char *)val);
-                       wxMessageBox(buf, _("Validation conflict"), wxOK | wxICON_EXCLAMATION, parent);
-                       return FALSE;
-               }
-       }
-       if ( m_validatorStyle & wxFILTER_EXCLUDE_LIST )
-       {
-               if ( m_excludeList.Member(val) )
-               {
-            m_validatorWindow->SetFocus();
-                       char buf[512];
-                       sprintf(buf, _("%s is invalid."), (const char *)val);
-                       wxMessageBox(buf, _("Validation conflict"), wxOK | wxICON_EXCLAMATION, parent);
-                       return FALSE;
-               }
-       }
-       if ( (m_validatorStyle & wxFILTER_ASCII) && !val.IsAscii() )
-       {
-            m_validatorWindow->SetFocus();
-                       char buf[512];
-                       sprintf(buf, _("%s should only contain ASCII characters."), (const char *)val);
-                       wxMessageBox(buf, _("Validation conflict"), wxOK | wxICON_EXCLAMATION, parent);
-                       return FALSE;
-       }
-       if ( (m_validatorStyle & wxFILTER_ALPHA) && !wxIsAlpha(val) )
-       {
-            m_validatorWindow->SetFocus();
-                       char buf[512];
-                       sprintf(buf, _("%s should only contain alphabetic characters."), (const char *)val);
-                       wxMessageBox(buf, _("Validation conflict"), wxOK | wxICON_EXCLAMATION, parent);
-                       return FALSE;
-       }
-       if ( (m_validatorStyle & wxFILTER_ALPHANUMERIC) && !wxIsAlphaNumeric(val))
-       {
-            m_validatorWindow->SetFocus();
-                       char buf[512];
-                       sprintf(buf, _("%s should only contain alphabetic or numeric characters."), (const char *)val);
-                       wxMessageBox(buf,_("Validation conflict"), wxOK | wxICON_EXCLAMATION, parent);
-                       return FALSE;
-       }
-       if ( (m_validatorStyle & wxFILTER_NUMERIC) && !wxIsNumeric(val))
-
-       {
-            m_validatorWindow->SetFocus();
-                       char buf[512];
-                       sprintf(buf, _("%s should be numeric."), (const char *)val);
-                       wxMessageBox(buf, _("Validation conflict"), wxOK | wxICON_EXCLAMATION, parent);
-                       return FALSE;
-       }
-
-       return TRUE ;
+    // If window is disabled, simply return
+    if ( !m_validatorWindow->IsEnabled() )
+        return true;
+
+    wxTextEntry * const text = GetTextEntry();
+    if ( !text )
+        return false;
+
+    wxString val(text->GetValue());
+
+    bool ok = true;
+
+    // NB: this format string should contian exactly one '%s'
+    wxString errormsg;
+
+    bool includes = (m_validatorStyle & wxFILTER_INCLUDE_LIST) != 0;
+    if ( includes || (m_validatorStyle & wxFILTER_EXCLUDE_LIST) )
+    {
+        // if includes, it's only ok to have the members of the list,
+        // otherwise it's only ok to have non-members
+        ok = includes == (m_includes.Index(val) != wxNOT_FOUND);
+        if ( !ok )
+        {
+            errormsg = _("'%s' is invalid");
+        }
+    }
+    else if ( (m_validatorStyle & wxFILTER_ASCII) && !val.IsAscii() )
+    {
+        ok = false;
+
+        errormsg = _("'%s' should only contain ASCII characters.");
+    }
+    else if ( (m_validatorStyle & wxFILTER_ALPHA) && !wxIsAlpha(val) )
+    {
+        ok = false;
+
+        errormsg = _("'%s' should only contain alphabetic characters.");
+    }
+    else if ( (m_validatorStyle & wxFILTER_ALPHANUMERIC) && !wxIsAlphaNumeric(val))
+    {
+        ok = false;
+
+        errormsg = _("'%s' should only contain alphabetic or numeric characters.");
+    }
+    else if ( (m_validatorStyle & wxFILTER_NUMERIC) && !wxIsNumeric(val))
+    {
+        ok = false;
+
+        errormsg = _("'%s' should be numeric.");
+    }
+    else if ( (m_validatorStyle & wxFILTER_INCLUDE_CHAR_LIST) && !IsInCharIncludes(val))
+    {
+        //it's only ok to have the members of the list
+        errormsg = _("'%s' is invalid");
+        ok = false;
+    }
+    else if ( (m_validatorStyle & wxFILTER_EXCLUDE_CHAR_LIST) && !IsNotInCharExcludes(val))
+    {
+        // it's only ok to have non-members of the list
+        errormsg = _("'%s' is invalid");
+        ok = false;
+    }
+
+    if ( !ok )
+    {
+        wxASSERT_MSG( !errormsg.empty(), _T("you forgot to set errormsg") );
+
+        m_validatorWindow->SetFocus();
+
+        wxString buf;
+        buf.Printf(errormsg, val.c_str());
+
+        wxMessageBox(buf, _("Validation conflict"),
+                     wxOK | wxICON_EXCLAMATION, parent);
+    }
+
+    return ok;

 }
 
 // Called to transfer data to the window
 bool wxTextValidator::TransferToWindow(void)
 {
 }
 
 // Called to transfer data to the window
 bool wxTextValidator::TransferToWindow(void)
 {

-       if ( !m_validatorWindow )
-               return FALSE;
-       if ( !m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
-               return FALSE;
-       if ( !m_stringValue )
-               return FALSE;
+    if ( m_stringValue )
+    {
+        wxTextEntry * const text = GetTextEntry();
+        if ( !text )
+            return false;

 
 

-       wxTextCtrl *control = (wxTextCtrl *) m_validatorWindow ;
-       control->SetValue(* m_stringValue) ;
+        text->SetValue(*m_stringValue);
+    }

 
 

-       return TRUE;
+    return true;

 }
 
 // Called to transfer data to the window
 bool wxTextValidator::TransferFromWindow(void)
 {
 }
 
 // Called to transfer data to the window
 bool wxTextValidator::TransferFromWindow(void)
 {

-       if ( !m_validatorWindow )
-               return FALSE;
-       if ( !m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
-               return FALSE;
-       if ( !m_stringValue )
-               return FALSE;
+    if ( m_stringValue )
+    {
+        wxTextEntry * const text = GetTextEntry();
+        if ( !text )
+            return false;

 
 

-       wxTextCtrl *control = (wxTextCtrl *) m_validatorWindow ;
-       * m_stringValue = control->GetValue() ;
+        *m_stringValue = text->GetValue();
+    }

 
 

-       return TRUE;
+    return true;

 }
 
 }
 

-void wxTextValidator::SetIncludeList(const wxStringList& list)
+bool wxTextValidator::IsInCharIncludes(const wxString& val)

 {
 {

-/*
-       if ( !M_VTEXTDATA )
-               return;
-*/
-
-       m_includeList.Clear();
-       // TODO: replace with =
-       wxNode *node = list.First() ;
-       while ( node )
-       {
-               char *s = (char *)node->Data();
-               m_includeList.Add(s);
-               node = node->Next();
-       }
+    size_t i;
+    for ( i = 0; i < val.length(); i++)
+    {
+        if (m_includes.Index((wxString) val[i]) == wxNOT_FOUND)
+            return false;
+    }
+    return true;

 }
 
 }
 

-void wxTextValidator::SetExcludeList(const wxStringList& list)
+bool wxTextValidator::IsNotInCharExcludes(const wxString& val)

 {
 {

-/*
-       if ( !M_VTEXTDATA )
-               return;
-*/
-
-       m_excludeList.Clear();
-       // TODO: replace with =
-       wxNode *node = list.First() ;
-       while ( node )
-       {
-               char *s = (char *)node->Data();
-               m_excludeList.Add(s);
-               node = node->Next();
-       }
+    size_t i;
+    for ( i = 0; i < val.length(); i++)
+    {
+       if (m_excludes.Index((wxString) val[i]) != wxNOT_FOUND)
+            return false;
+    }
+    return true;

 }
 
 void wxTextValidator::OnChar(wxKeyEvent& event)
 {
 /*
 }
 
 void wxTextValidator::OnChar(wxKeyEvent& event)
 {
 /*

-       if ( !M_VTEXTDATA )
-               return;
+    if ( !M_VTEXTDATA )
+        return;

 */
 
 */
 

-       if ( !m_validatorWindow )
-               return;
-
-       wxTextCtrl *textCtrl = (wxTextCtrl *)m_validatorWindow;
-
-       int keyCode = event.KeyCode();
-       if ( keyCode == WXK_DELETE || keyCode == WXK_RETURN || keyCode == WXK_BACK)
-       {
-               textCtrl->wxTextCtrl::OnChar(event);
-               return ;
-       }
-
-       if ( (m_validatorStyle & wxFILTER_ASCII) && !isascii(keyCode) )
-       {
-               wxBell();
-               return;
-       }
-       if ( (m_validatorStyle & wxFILTER_ALPHA) && !isalpha(keyCode) )
-       {
-               wxBell();
-               return;
-       }
-       if ( (m_validatorStyle & wxFILTER_ALPHANUMERIC) && !isalnum(keyCode) )
-       {
-               wxBell();
-               return;
-       }
-       if ( (m_validatorStyle & wxFILTER_NUMERIC) && !isdigit(keyCode) && keyCode != '.' )
-       {
-               wxBell();
-               return;
-       }
-
-       textCtrl->wxTextCtrl::OnChar(event);
+    if ( m_validatorWindow )
+    {
+        int keyCode = event.GetKeyCode();
+
+        // we don't filter special keys and Delete
+        if (
+             !(keyCode < WXK_SPACE || keyCode == WXK_DELETE || keyCode > WXK_START) &&
+             (
+              ((m_validatorStyle & wxFILTER_INCLUDE_CHAR_LIST) && !IsInCharIncludes(wxString((wxChar) keyCode, 1))) ||
+              ((m_validatorStyle & wxFILTER_EXCLUDE_CHAR_LIST) && !IsNotInCharExcludes(wxString((wxChar) keyCode, 1))) ||
+              ((m_validatorStyle & wxFILTER_ASCII) && !isascii(keyCode)) ||
+              ((m_validatorStyle & wxFILTER_ALPHA) && !wxIsalpha(keyCode)) ||
+              ((m_validatorStyle & wxFILTER_ALPHANUMERIC) && !wxIsalnum(keyCode)) ||
+              ((m_validatorStyle & wxFILTER_NUMERIC) && !wxIsdigit(keyCode)
+                                && keyCode != wxT('.') && keyCode != wxT(',') && keyCode != wxT('-') && keyCode != wxT('+') && keyCode != wxT('e') && keyCode != wxT('E'))
+             )
+           )
+        {
+            if ( !wxValidator::IsSilent() )
+                wxBell();
+
+            // eat message
+            return;
+        }
+    }
+
+    event.Skip();

 }
 
 static bool wxIsNumeric(const wxString& val)
 {
 }
 
 static bool wxIsNumeric(const wxString& val)
 {

-       int i;
-       for ( i = 0; i < (int)val.Length(); i++)
-       {
-               if ((!isdigit(val[i])) && (val[i] != '.'))
-                       return FALSE;
-       }
-       return TRUE;
+    int i;
+    for ( i = 0; i < (int)val.length(); i++)
+    {
+        // Allow for "," (French) as well as "." -- in future we should
+        // use wxSystemSettings or other to do better localisation
+        if ((!wxIsdigit(val[i])) && (val[i] != wxT('.')) && (val[i] != wxT(',')) && (val[i] != wxT('e')) && (val[i] != wxT('E')) && (val[i] != wxT('+')) && (val[i] != wxT('-')))
+            return false;
+    }
+    return true;

 }
 
 }
 

+
+#endif
+  // wxUSE_VALIDATORS && (wxUSE_TEXTCTRL || wxUSE_COMBOBOX)