fix another memory leak in SetCommand() (coverity checker CID 52)

[wxWidgets.git] / src / motif / statbmp.cpp

diff --git a/src/motif/statbmp.cpp b/src/motif/statbmp.cpp
index e0d2ac766ee4578c0faa08eb1ddff6b70fca8fa7..77941b93fbe2e5987fef73c34d2b109a5e43b681 100644 (file)
--- a/src/motif/statbmp.cpp
+++ b/src/motif/statbmp.cpp
@@ -9,9 +9,8 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "statbmp.h"
-#endif
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"

 
 #include "wx/defs.h"
 
 
 #include "wx/defs.h"
 


@@ -23,7 +22,6 @@
 #include <Xm/Xm.h>
 #include <Xm/Label.h>
 #include <Xm/LabelG.h>
 #include <Xm/Xm.h>
 #include <Xm/Label.h>
 #include <Xm/LabelG.h>

-#include <Xm/RowColumn.h>

 #ifdef __VMS__
 #pragma message enable nosimpint
 #endif
 #ifdef __VMS__
 #pragma message enable nosimpint
 #endif


@@ -43,24 +41,17 @@ bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
            long style,
            const wxString& name)
 {
            long style,
            const wxString& name)
 {

+    if( !CreateControl( parent, id, pos, size, style, wxDefaultValidator,
+                        name ) )
+        return false;
+

     m_messageBitmap = bitmap;
     m_messageBitmapOriginal = bitmap;
     m_messageBitmap = bitmap;
     m_messageBitmapOriginal = bitmap;

-    SetName(name);
-    m_backgroundColour = parent->GetBackgroundColour();
-    m_foregroundColour = parent->GetForegroundColour();
-    if (parent) parent->AddChild(this);
-
-    if ( id == -1 )
-        m_windowId = (int)NewControlId();
-    else
-        m_windowId = id;
-
-    m_windowStyle = style;

 
     Widget parentWidget = (Widget) parent->GetClientWidget();
 
     m_mainWidget = (WXWidget) XtVaCreateManagedWidget ("staticBitmap",
 
     Widget parentWidget = (Widget) parent->GetClientWidget();
 
     m_mainWidget = (WXWidget) XtVaCreateManagedWidget ("staticBitmap",

-#if USE_GADGETS
+#if wxUSE_GADGETS

                     xmLabelGadgetClass, parentWidget,
 #else
                     xmLabelWidgetClass, parentWidget,
                     xmLabelGadgetClass, parentWidget,
 #else
                     xmLabelWidgetClass, parentWidget,


@@ -72,20 +63,18 @@ bool wxStaticBitmap::Create(wxWindow *parent, wxWindowID id,
 
     DoSetBitmap();
 
 
     DoSetBitmap();
 

-    m_font = parent->GetFont();
-    ChangeFont(FALSE);
-
-    SetCanAddEventHandler(TRUE);
+    ChangeFont(false);

 
     wxSize actualSize(size);
     // work around the cases where the bitmap is a wxNull(Icon/Bitmap)
     if (actualSize.x == -1)
 
     wxSize actualSize(size);
     // work around the cases where the bitmap is a wxNull(Icon/Bitmap)
     if (actualSize.x == -1)

-        actualSize.x = bitmap.GetWidth() ? bitmap.GetWidth() : 1;
+        actualSize.x = bitmap.Ok() ? bitmap.GetWidth() : 1;

     if (actualSize.y == -1)
     if (actualSize.y == -1)

-        actualSize.y = bitmap.GetHeight() ? bitmap.GetHeight() : 1;
-    AttachWidget (parent, m_mainWidget, (WXWidget) NULL, pos.x, pos.y, actualSize.x, actualSize.y);
+        actualSize.y = bitmap.Ok() ? bitmap.GetHeight() : 1;
+    AttachWidget (parent, m_mainWidget, (WXWidget) NULL,
+                  pos.x, pos.y, actualSize.x, actualSize.y);

 
 

-    return TRUE;
+    return true;

 }
 
 wxStaticBitmap::~wxStaticBitmap()
 }
 
 wxStaticBitmap::~wxStaticBitmap()


@@ -96,9 +85,7 @@ wxStaticBitmap::~wxStaticBitmap()
 void wxStaticBitmap::DoSetBitmap()
 {
     Widget widget = (Widget) m_mainWidget;
 void wxStaticBitmap::DoSetBitmap()
 {
     Widget widget = (Widget) m_mainWidget;

-    int x, y, w1, h1, w2, h2;
-
-    GetPosition(&x, &y);
+    int w2, h2;

 
     if (m_messageBitmapOriginal.Ok())
     {
 
     if (m_messageBitmapOriginal.Ok())
     {


@@ -121,19 +108,20 @@ void wxStaticBitmap::DoSetBitmap()
             wxBitmap newBitmap = wxCreateMaskedBitmap(m_messageBitmapOriginal, col);
             m_messageBitmap = newBitmap;
 
             wxBitmap newBitmap = wxCreateMaskedBitmap(m_messageBitmapOriginal, col);
             m_messageBitmap = newBitmap;
 

-            pixmap = (Pixmap) m_messageBitmap.GetPixmap();
+            pixmap = (Pixmap) m_messageBitmap.GetDrawable();

         }
         else
         }
         else

-            pixmap = (Pixmap) m_messageBitmap.GetLabelPixmap(widget);
+        {
+            m_bitmapCache.SetBitmap( m_messageBitmap );
+            pixmap = (Pixmap)m_bitmapCache.GetLabelPixmap(widget);
+        }

 
         XtVaSetValues (widget,
             XmNlabelPixmap, pixmap,
             XmNlabelType, XmPIXMAP,
             NULL);
 
         XtVaSetValues (widget,
             XmNlabelPixmap, pixmap,
             XmNlabelType, XmPIXMAP,
             NULL);

-        GetSize(&w1, &h1);

 
 

-        if (! (w1 == w2) && (h1 == h2))
-            SetSize(x, y, w2, h2);
+        SetSize(w2, h2);

     }
     else
     {
     }
     else
     {


@@ -154,21 +142,18 @@ void wxStaticBitmap::SetBitmap(const wxBitmap& bitmap)
     DoSetBitmap();
 }
 
     DoSetBitmap();
 }
 

-void wxStaticBitmap::ChangeFont(bool keepOriginalSize)
-{
-    wxWindow::ChangeFont(keepOriginalSize);
-}
-

 void wxStaticBitmap::ChangeBackgroundColour()
 {
     wxWindow::ChangeBackgroundColour();
 
     // must recalculate the background colour
 void wxStaticBitmap::ChangeBackgroundColour()
 {
     wxWindow::ChangeBackgroundColour();
 
     // must recalculate the background colour

+    m_bitmapCache.SetColoursChanged();

     DoSetBitmap();
 }
 
 void wxStaticBitmap::ChangeForegroundColour()
 {
     DoSetBitmap();
 }
 
 void wxStaticBitmap::ChangeForegroundColour()
 {

+    m_bitmapCache.SetColoursChanged();

     wxWindow::ChangeForegroundColour();
 }
 
     wxWindow::ChangeForegroundColour();
 }