Compilaton fixes.

[wxWidgets.git] / src / msw / radiobut.cpp

diff --git a/src/msw/radiobut.cpp b/src/msw/radiobut.cpp
index d41d744284dc7ac87a63d29da9ef908361ba89bb..4cff6cf1e3e1af2ada229bf821fc8f7386d9dd64 100644 (file)
--- a/src/msw/radiobut.cpp
+++ b/src/msw/radiobut.cpp
@@ -1,14 +1,22 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        radiobut.cpp
+// Name:        msw/radiobut.cpp

 // Purpose:     wxRadioButton
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Purpose:     wxRadioButton
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$

-// Copyright:   (c) Julian Smart and Markus Holzem
-// Licence:     wxWindows license
+// Copyright:   (c) Julian Smart
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

+// ============================================================================
+// declarations
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------
+

 #ifdef __GNUG__
 #pragma implementation "radiobut.h"
 #endif
 #ifdef __GNUG__
 #pragma implementation "radiobut.h"
 #endif


@@ -20,267 +28,257 @@
 #pragma hdrstop
 #endif
 
 #pragma hdrstop
 #endif
 

+#if wxUSE_RADIOBTN
+

 #ifndef WX_PRECOMP
 #ifndef WX_PRECOMP

-#include <stdio.h>
-#include "wx/setup.h"

 #include "wx/radiobut.h"
 #include "wx/settings.h"
 #include "wx/brush.h"
 #include "wx/radiobut.h"
 #include "wx/settings.h"
 #include "wx/brush.h"

+#include "wx/dcscreen.h"

 #endif
 
 #include "wx/msw/private.h"
 
 #endif
 
 #include "wx/msw/private.h"
 

+// ============================================================================
+// wxRadioButton implementation
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// wxRadioButton creation
+// ----------------------------------------------------------------------------
+

 IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl)
 IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl)

-// IMPLEMENT_DYNAMIC_CLASS(wxBitmapRadioButton, wxRadioButton)

 
 

-bool wxRadioButton::MSWCommand(WXUINT param, WXWORD WXUNUSED(id))
+void wxRadioButton::Init()

 {
 {

-  if (param == BN_CLICKED)
-  {
-    wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, m_windowId);
-    event.SetEventObject( this );
-    event.SetInt( GetValue() );
-    ProcessCommand(event);
-    return TRUE;
-  }
-  else return FALSE;
+    m_focusJustSet = FALSE;

 }
 
 }
 

-bool wxRadioButton::Create(wxWindow *parent, wxWindowID id,
-       const wxString& label,
-           const wxPoint& pos,
-           const wxSize& size, long style,
-           const wxValidator& validator,
-           const wxString& name)
+bool wxRadioButton::Create(wxWindow *parent,
+                           wxWindowID id,
+                           const wxString& label,
+                           const wxPoint& pos,
+                           const wxSize& size,
+                           long style,
+                           const wxValidator& validator,
+                           const wxString& name)

 {
 {

-  SetName(name);
-#if wxUSE_VALIDATORS
-  SetValidator(validator);
-#endif // wxUSE_VALIDATORS
-
-  if (parent) parent->AddChild(this);
-
-  SetBackgroundColour(parent->GetBackgroundColour());
-  SetForegroundColour(parent->GetForegroundColour());
-
-  if ( id == -1 )
-    m_windowId = (int)NewControlId();
-  else
-  m_windowId = id;
-
-  int x = pos.x;
-  int y = pos.y;
-  int width = size.x;
-  int height = size.y;
-
-  m_windowStyle = style ;
-
-  long groupStyle = 0;
-  if (m_windowStyle & wxRB_GROUP)
-    groupStyle = WS_GROUP;
-
-//  long msStyle = groupStyle | RADIO_FLAGS;
-  long msStyle = groupStyle | BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE /* | WS_CLIPSIBLINGS */;
+    if ( !CreateControl(parent, id, pos, size, style, validator, name) )
+        return FALSE;
+
+    long msStyle = WS_TABSTOP;
+    if ( HasFlag(wxRB_GROUP) )
+        msStyle |= WS_GROUP;
+
+    /*
+       wxRB_SINGLE is a temporary workaround for the following problem: if you
+       have 2 radiobuttons in the same group but which are not consecutive in
+       the dialog, Windows can enter an infinite loop! The simplest way to
+       reproduce it is to create radio button, then a panel and then another
+       radio button: then checking the last button hangs the app.
+
+       Ideally, we'd detect (and avoid) such situation automatically but for
+       now, as I don't know how to do it, just allow the user to create
+       BS_RADIOBUTTON buttons for such situations.
+     */
+    msStyle |= HasFlag(wxRB_SINGLE) ? BS_RADIOBUTTON : BS_AUTORADIOBUTTON;
+
+    if ( HasFlag(wxCLIP_SIBLINGS) )
+        msStyle |= WS_CLIPSIBLINGS;
+
+    if ( !MSWCreateControl(_T("BUTTON"), msStyle, pos, size, label, 0) )
+        return FALSE;
+
+    // for compatibility with wxGTK, the first radio button in a group is
+    // always checked (this makes sense anyhow as you need to ensure that at
+    // least one button in the group is checked and this is the simlpest way to
+    // do it)
+    if ( HasFlag(wxRB_GROUP) )
+        SetValue(TRUE);

 
 

-  bool want3D;
-  WXDWORD exStyle = Determine3DEffects(0, &want3D) ;
-
-  // Even with extended styles, need to combine with WS_BORDER
-  // for them to look right.
-/*
-  if ( want3D || wxStyleHasBorder(m_windowStyle) )
-    msStyle |= WS_BORDER;
-*/
-
-  m_hWnd = (WXHWND) CreateWindowEx(exStyle, RADIO_CLASS, (const wxChar *)label,
-                          msStyle,0,0,0,0,
-                          (HWND) parent->GetHWND(), (HMENU)m_windowId, wxGetInstance(), NULL);
-
-  wxCHECK_MSG( m_hWnd, FALSE, wxT("Failed to create radiobutton") );
-
-#if wxUSE_CTL3D
-  if (want3D)
-  {
-    Ctl3dSubclassCtl((HWND) m_hWnd);
-   m_useCtl3D = TRUE;
-  }
-#endif
-
-  SetFont(parent->GetFont());
+    return TRUE;
+}

 
 

-  // Subclass again for purposes of dialog editing mode
-  SubclassWin((WXHWND)m_hWnd);
+// ----------------------------------------------------------------------------
+// wxRadioButton functions
+// ----------------------------------------------------------------------------

 
 

-//  SetValue(value);
+void wxRadioButton::SetValue(bool value)
+{
+    // BST_CHECKED is defined as 1, BST_UNCHECKED as 0, so we can just pass
+    // value as is (we don't use BST_XXX here as they're not defined for Win16)
+    (void)::SendMessage(GetHwnd(), BM_SETCHECK, (WPARAM)value, 0L);

 
 

-  // start GRW fix
-  if (label != wxT(""))
-  {
-    int label_width, label_height;
-    GetTextExtent(label, &label_width, &label_height, NULL, NULL, & this->GetFont());
-    if (width < 0)
-      width = (int)(label_width + RADIO_SIZE);
-    if (height<0)
+    // if we set the value of one radio button we also must clear all the other
+    // buttons in the same group: Windows doesn't do it automatically
+    if ( value )

     {
     {

-      height = (int)(label_height);
-      if (height < RADIO_SIZE)
-        height = RADIO_SIZE;
+        const wxWindowList& siblings = GetParent()->GetChildren();
+        wxWindowList::compatibility_iterator nodeThis = siblings.Find(this);
+        wxCHECK_RET( nodeThis, _T("radio button not a child of its parent?") );
+
+        // if it's not the first item of the group ...
+        if ( !HasFlag(wxRB_GROUP) )
+        {
+            // ... turn off all radio buttons before it
+            for ( wxWindowList::compatibility_iterator nodeBefore = nodeThis->GetPrevious();
+                  nodeBefore;
+                  nodeBefore = nodeBefore->GetPrevious() )
+            {
+                wxRadioButton *btn = wxDynamicCast(nodeBefore->GetData(),
+                                                   wxRadioButton);
+                if ( !btn )
+                {
+                    // the radio buttons in a group must be consecutive, so
+                    // there are no more of them
+                    break;
+                }
+
+                btn->SetValue(FALSE);
+
+                if ( btn->HasFlag(wxRB_GROUP) )
+                {
+                    // even if there are other radio buttons before this one,
+                    // they're not in the same group with us
+                    break;
+                }
+            }
+        }
+
+        // ... and also turn off all buttons after this one
+        for ( wxWindowList::compatibility_iterator nodeAfter = nodeThis->GetNext();
+              nodeAfter;
+              nodeAfter = nodeAfter->GetNext() )
+        {
+            wxRadioButton *btn = wxDynamicCast(nodeAfter->GetData(),
+                                               wxRadioButton);
+
+            if ( !btn || btn->HasFlag(wxRB_GROUP) )
+            {
+                // no more buttons or the first button of the next group
+                break;
+            }
+
+            btn->SetValue(FALSE);
+        }

     }
     }

-  }
-  else
-  {
-    if (width < 0)
-      width = RADIO_SIZE;
-    if (height < 0)
-      height = RADIO_SIZE;
-  }
-  // end GRW fix
-
-  SetSize(x, y, width, height);
-
-  // for compatibility with wxGTK, the first radio button in a group is
-  // always checked (this makes sense anyhow as you need to ensure that at
-  // least one button in the group is checked and this is the simlpest way to
-  // do it)
-  if ( m_windowStyle & wxRB_GROUP )
-      SetValue(TRUE);
-
-  return TRUE;

 }
 
 }
 

-
-void wxRadioButton::SetLabel(const wxString& label)
+bool wxRadioButton::GetValue() const

 {
 {

-  SetWindowText((HWND) GetHWND(), (const wxChar *)label);
+    // NB: this will also return TRUE for BST_INDETERMINATE value if we ever
+    //     have 3-state radio buttons
+    return ::SendMessage(GetHwnd(), BM_GETCHECK, 0, 0L) != 0;

 }
 
 }
 

-void wxRadioButton::SetValue(bool value)
-{
-// Following necessary for Win32s, because Win32s translate BM_SETCHECK
-  SendMessage((HWND) GetHWND(), BM_SETCHECK, (WPARAM)value, 0L);
-}
+// ----------------------------------------------------------------------------
+// wxRadioButton event processing
+// ----------------------------------------------------------------------------

 
 

-// Get single selection
-bool wxRadioButton::GetValue(void) const
+void wxRadioButton::Command (wxCommandEvent& event)

 {
 {

-  return (SendMessage((HWND) GetHWND(), BM_GETCHECK, 0, 0L) != 0);
+    SetValue(event.m_commandInt != 0);
+    ProcessCommand(event);

 }
 
 }
 

-void wxRadioButton::Command (wxCommandEvent & event)
+void wxRadioButton::SetFocus()

 {
 {

-  SetValue ( (event.m_commandInt != 0) );
-  ProcessCommand (event);
+    // when the radio button receives a WM_SETFOCUS message it generates a
+    // BN_CLICKED which is totally unexpected and leads to catastrophic results
+    // if you pop up a dialog from the radio button event handler as, when the
+    // dialog is dismissed, the focus is returned to the radio button which
+    // generates BN_CLICKED which leads to showing another dialog and so on
+    // without end!
+    //
+    // to avoid this, we drop the pseudo BN_CLICKED events generated when the
+    // button gains focus
+    m_focusJustSet = TRUE;
+
+    wxControl::SetFocus();

 }
 
 }
 

-WXHBRUSH wxRadioButton::OnCtlColor(WXHDC pDC, WXHWND WXUNUSED(pWnd), WXUINT WXUNUSED(nCtlColor),
-#if wxUSE_CTL3D
-                               WXUINT message,
-                               WXWPARAM wParam,
-                               WXLPARAM lParam
-#else
-                               WXUINT WXUNUSED(message),
-                               WXWPARAM WXUNUSED(wParam),
-                               WXLPARAM WXUNUSED(lParam)
-#endif
-    )
+bool wxRadioButton::MSWCommand(WXUINT param, WXWORD WXUNUSED(id))

 {
 {

-#if wxUSE_CTL3D
-    if ( m_useCtl3D )
+    if ( param != BN_CLICKED )
+        return FALSE;
+
+    if ( m_focusJustSet )

     {
     {

-        HBRUSH hbrush = Ctl3dCtlColorEx(message, wParam, lParam);
-        return (WXHBRUSH) hbrush;
+        // see above: we want to ignore this event
+        m_focusJustSet = FALSE;
+    }
+    else // a real clicked event
+    {
+        bool isChecked = GetValue();
+
+        if ( HasFlag(wxRB_SINGLE) )
+        {
+            // when we use a "manual" radio button, we have to check the button
+            // ourselves -- but it's reset to unchecked state by the user code
+            // (presumably when another button is pressed)
+            if ( !isChecked )
+                SetValue(TRUE);
+        }
+
+        wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, GetId());
+        event.SetEventObject( this );
+        event.SetInt(isChecked);
+
+        ProcessCommand(event);

     }
     }

-#endif // wxUSE_CTL3D

 
 

-    HDC hdc = (HDC)pDC;
-    if (GetParent()->GetTransparentBackground())
-        SetBkMode(hdc, TRANSPARENT);
-    else
-        SetBkMode(hdc, OPAQUE);
+    return TRUE;
+}

 
 

-    wxColour colBack = GetBackgroundColour();
+// ----------------------------------------------------------------------------
+// wxRadioButton geometry
+// ----------------------------------------------------------------------------

 
 

-    if (!IsEnabled())
-        colBack = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE);
+wxSize wxRadioButton::DoGetBestSize() const
+{
+    static int s_radioSize = 0;

 
 

-    ::SetBkColor(hdc, wxColourToRGB(colBack));
-    ::SetTextColor(hdc, wxColourToRGB(GetForegroundColour()));
+    if ( !s_radioSize )
+    {
+        wxScreenDC dc;
+        dc.SetFont(wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT));

 
 

-    wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBack, wxSOLID);
+        s_radioSize = dc.GetCharHeight();
+    }

 
 

-    return (WXHBRUSH)brush->GetResourceHandle();
-}
+    wxString str = GetLabel();

 
 

-// Not implemented
-#if 0
-bool wxBitmapRadioButton::Create(wxWindow *parent, wxWindowID id,
-       const wxBitmap *bitmap,
-           const wxPoint& pos,
-           const wxSize& size, long style,
-           const wxValidator& validator,
-           const wxString& name)
-{
-  SetName(name);
-  SetValidator(validator);
-
-  if (parent) parent->AddChild(this);
-  SetBackgroundColour(parent->GetBackgroundColour());
-  SetForegroundColour(parent->GetForegroundColour());
-
-  if ( id == -1 )
-    m_windowId = (int)NewControlId();
-  else
-  m_windowId = id;
-
-  int x = pos.x;
-  int y = pos.y;
-  int width = size.x;
-  int height = size.y;
-  m_windowStyle = style ;
-
-  long groupStyle = 0;
-  if (m_windowStyle & wxRB_GROUP)
-    groupStyle = WS_GROUP;
-
-//  long msStyle = groupStyle | RADIO_FLAGS;
-  long msStyle = groupStyle | BS_RADIOBUTTON | WS_CHILD | WS_VISIBLE ;
-
-  m_hWnd = (WXHWND) CreateWindowEx(MakeExtendedStyle(m_windowStyle), RADIO_CLASS, "toggle",
-                          msStyle,0,0,0,0,
-                          (HWND) parent->GetHWND(), (HMENU)m_windowId, wxGetInstance(), NULL);
-
-  wxCHECK_MSG( m_hWnd, "Failed to create radio button", FALSE );
-
-#if wxUSE_CTL3D
-  if (!(GetParent()->GetWindowStyleFlag() & wxUSER_COLOURS))
-  {
-    Ctl3dSubclassCtl((HWND) GetHWND());
-    m_useCtl3D = TRUE;
-  }
-#endif
-
-  // Subclass again for purposes of dialog editing mode
-  SubclassWin(GetHWND());
+    int wRadio, hRadio;
+    if ( !str.empty() )
+    {
+        GetTextExtent(str, &wRadio, &hRadio);
+        wRadio += s_radioSize + GetCharWidth();

 
 

-  SetSize(x, y, width, height);
+        if ( hRadio < s_radioSize )
+            hRadio = s_radioSize;
+    }
+    else
+    {
+        wRadio = s_radioSize;
+        hRadio = s_radioSize;
+    }

 
 

-  return TRUE;
+    return wxSize(wRadio, hRadio);

 }
 
 }
 

-void wxBitmapRadioButton::SetLabel(const wxBitmap *bitmap)
+long wxRadioButton::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)

 {
 {

-}
+    if (nMsg == WM_SETFOCUS)
+    {
+        m_focusJustSet = TRUE;

 
 

-void wxBitmapRadioButton::SetValue(bool value)
-{
-// Following necessary for Win32s, because Win32s translate BM_SETCHECK
-  SendMessage((HWND) GetHWND(), BM_SETCHECK, (WPARAM)value, 0L);
-}
+        long ret = wxControl::MSWWindowProc(nMsg, wParam, lParam);

 
 

-// Get single selection, for single choice list items
-bool wxBitmapRadioButton::GetValue(void) const
-{
-  return (bool)SendMessage((HWND) GetHWND(), BM_GETCHECK, 0, 0L);
+        m_focusJustSet = FALSE;
+
+        return ret;
+    }
+    return wxControl::MSWWindowProc(nMsg, wParam, lParam);

 }
 
 }
 

-#endif
+#endif // wxUSE_RADIOBTN