Fix centering of top-level children of wxMDIParentFrame on Mac

[wxWidgets.git] / src / mac / carbon / window.cpp

diff --git a/src/mac/carbon/window.cpp b/src/mac/carbon/window.cpp
index a6bb697f8f7301774017e744d19e99718c245b37..83c5fba382ea6b6fbbff05b5fac9594a2a19c012 100644 (file)
--- a/src/mac/carbon/window.cpp
+++ b/src/mac/carbon/window.cpp
@@ -46,7 +46,9 @@
 
 #define wxWINDOW_HSCROLL 5998
 #define wxWINDOW_VSCROLL 5997
 
 #define wxWINDOW_HSCROLL 5998
 #define wxWINDOW_VSCROLL 5997

-#define MAC_SCROLLBAR_SIZE 16
+
+#define MAC_SCROLLBAR_SIZE 15
+#define MAC_SMALL_SCROLLBAR_SIZE 11

 
 #include "wx/mac/uma.h"
 #ifndef __DARWIN__
 
 #include "wx/mac/uma.h"
 #ifndef __DARWIN__


@@ -58,7 +60,7 @@
 
 #if TARGET_API_MAC_OSX
 #ifndef __HIVIEW__
 
 #if TARGET_API_MAC_OSX
 #ifndef __HIVIEW__

-       #include <HIToolbox/HIView.h>
+    #include <HIToolbox/HIView.h>

 #endif
 #endif
 
 #endif
 #endif
 


@@ -82,8 +84,6 @@ BEGIN_EVENT_TABLE(wxWindowMac, wxWindowBase)
     EVT_NC_PAINT(wxWindowMac::OnNcPaint)
     EVT_ERASE_BACKGROUND(wxWindowMac::OnEraseBackground)
 // TODO    EVT_PAINT(wxWindowMac::OnPaint)
     EVT_NC_PAINT(wxWindowMac::OnNcPaint)
     EVT_ERASE_BACKGROUND(wxWindowMac::OnEraseBackground)
 // TODO    EVT_PAINT(wxWindowMac::OnPaint)

-    EVT_SYS_COLOUR_CHANGED(wxWindowMac::OnSysColourChanged)
-    EVT_INIT_DIALOG(wxWindowMac::OnInitDialog)

     EVT_SET_FOCUS(wxWindowMac::OnSetFocus)
     EVT_KILL_FOCUS(wxWindowMac::OnSetFocus)
     EVT_MOUSE_EVENTS(wxWindowMac::OnMouseEvent)
     EVT_SET_FOCUS(wxWindowMac::OnSetFocus)
     EVT_KILL_FOCUS(wxWindowMac::OnSetFocus)
     EVT_MOUSE_EVENTS(wxWindowMac::OnMouseEvent)


@@ -98,16 +98,64 @@ END_EVENT_TABLE()
 
 #define wxMAC_USE_THEME_BORDER 1
 
 
 #define wxMAC_USE_THEME_BORDER 1
 

+// ---------------------------------------------------------------------------
+// Utility Routines to move between different coordinate systems
+// ---------------------------------------------------------------------------
+
+/*
+ * Right now we have the following setup :
+ * a border that is not part of the native control is always outside the
+ * control's border (otherwise we loose all native intelligence, future ways
+ * may be to have a second embedding control responsible for drawing borders
+ * and backgrounds eventually)
+ * so all this border calculations have to be taken into account when calling
+ * native methods or getting native oriented data
+ * so we have three coordinate systems here
+ * wx client coordinates
+ * wx window coordinates (including window frames)
+ * native coordinates
+ */
+
+//
+// originating from native control
+//
+
+
+void wxMacNativeToWindow( const wxWindow* window , RgnHandle handle )
+{
+    OffsetRgn( handle , window->MacGetLeftBorderSize() , window->MacGetTopBorderSize() ) ;
+}
+
+void wxMacNativeToWindow( const wxWindow* window , Rect *rect )
+{
+    OffsetRect( rect , window->MacGetLeftBorderSize() , window->MacGetTopBorderSize() ) ;
+}
+
+//
+// directed towards native control
+//
+
+void wxMacWindowToNative( const wxWindow* window , RgnHandle handle )
+{
+    OffsetRgn( handle , -window->MacGetLeftBorderSize() , -window->MacGetTopBorderSize() );
+}
+
+void wxMacWindowToNative( const wxWindow* window , Rect *rect )
+{
+    OffsetRect( rect , -window->MacGetLeftBorderSize() , -window->MacGetTopBorderSize() ) ;
+}
+
+

 // ---------------------------------------------------------------------------
 // Carbon Events
 // ---------------------------------------------------------------------------
 // ---------------------------------------------------------------------------
 // Carbon Events
 // ---------------------------------------------------------------------------

- 
+

 extern long wxMacTranslateKey(unsigned char key, unsigned char code) ;
 pascal OSStatus wxMacSetupControlBackground( ControlRef iControl , SInt16 iMessage , SInt16 iDepth , Boolean iIsColor ) ;
 
 #if TARGET_API_MAC_OSX
 
 extern long wxMacTranslateKey(unsigned char key, unsigned char code) ;
 pascal OSStatus wxMacSetupControlBackground( ControlRef iControl , SInt16 iMessage , SInt16 iDepth , Boolean iIsColor ) ;
 
 #if TARGET_API_MAC_OSX
 

-#if MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_3 
+#if MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_3

 enum {
   kEventControlVisibilityChanged = 157
 };
 enum {
   kEventControlVisibilityChanged = 157
 };


@@ -124,12 +172,12 @@ static const EventTypeSpec eventList[] =
     { kEventClassControl , kEventControlEnabledStateChanged } ,
     { kEventClassControl , kEventControlHiliteChanged } ,
     { kEventClassControl , kEventControlSetFocusPart } ,
     { kEventClassControl , kEventControlEnabledStateChanged } ,
     { kEventClassControl , kEventControlHiliteChanged } ,
     { kEventClassControl , kEventControlSetFocusPart } ,

-  
-    { kEventClassService , kEventServiceGetTypes },         
-    { kEventClassService , kEventServiceCopy },         
-    { kEventClassService , kEventServicePaste },  
-    
- //    { kEventClassControl , kEventControlInvalidateForSizeChange } , // 10.3 only
+
+    { kEventClassService , kEventServiceGetTypes },
+    { kEventClassService , kEventServiceCopy },
+    { kEventClassService , kEventServicePaste },
+
+ //    { kEventClassControl , kEventControlInvalidateForSizeChange } , // 10.3 only

 //  { kEventClassControl , kEventControlBoundsChanged } ,
 #endif
 } ;
 //  { kEventClassControl , kEventControlBoundsChanged } ,
 #endif
 } ;


@@ -139,7 +187,7 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl
     OSStatus result = eventNotHandledErr ;
 
     wxMacCarbonEvent cEvent( event ) ;
     OSStatus result = eventNotHandledErr ;
 
     wxMacCarbonEvent cEvent( event ) ;

-    
+

     ControlRef controlRef ;
     wxWindowMac* thisWindow = (wxWindowMac*) data ;
 
     ControlRef controlRef ;
     wxWindowMac* thisWindow = (wxWindowMac*) data ;
 


@@ -151,15 +199,25 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl
         case kEventControlDraw :
             {
                 RgnHandle updateRgn = NULL ;
         case kEventControlDraw :
             {
                 RgnHandle updateRgn = NULL ;

-
+                RgnHandle allocatedRgn = NULL ;

                 wxRegion visRegion = thisWindow->MacGetVisibleRegion() ;
                 wxRegion visRegion = thisWindow->MacGetVisibleRegion() ;

-                if ( cEvent.GetParameter<RgnHandle>(kEventParamRgnHandle, &updateRgn) != noErr ) 
+                if ( cEvent.GetParameter<RgnHandle>(kEventParamRgnHandle, &updateRgn) != noErr )

                 {
                     updateRgn = (RgnHandle) visRegion.GetWXHRGN() ;
                 }
                 {
                     updateRgn = (RgnHandle) visRegion.GetWXHRGN() ;
                 }

-                // GrafPtr myport = cEvent.GetParameter<GrafPtr>(kEventParamGrafPort,typeGrafPtr) ;
+                else
+                {
+                    if ( thisWindow->MacGetLeftBorderSize() != 0 || thisWindow->MacGetTopBorderSize() != 0 )
+                    {
+                        allocatedRgn = NewRgn() ;
+                        CopyRgn( updateRgn , allocatedRgn ) ;
+                        // hide the given region by the new region that must be shifted
+                        wxMacNativeToWindow( thisWindow , allocatedRgn ) ;
+                        updateRgn = allocatedRgn ;
+                    }
+                }

 
 

-#if 0 
+#if 0

               // in case we would need a coregraphics compliant background erase first
                 // now usable to track redraws
                 CGContextRef cgContext = cEvent.GetParameter<CGContextRef>(kEventParamCGContextRef) ;
               // in case we would need a coregraphics compliant background erase first
                 // now usable to track redraws
                 CGContextRef cgContext = cEvent.GetParameter<CGContextRef>(kEventParamCGContextRef) ;


@@ -167,23 +225,25 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl
                 {
                     static float color = 0.5 ;
                     static channel = 0 ;
                 {
                     static float color = 0.5 ;
                     static channel = 0 ;

-                       HIRect bounds;
-                       HIViewGetBounds( controlRef, &bounds );
-                                   CGContextSetRGBFillColor( cgContext, channel == 0 ? color : 0.5 , 
-                                       channel == 1 ? color : 0.5 , channel == 2 ? color : 0.5 , 1 );
-                                   CGContextFillRect( cgContext, bounds );
-                                   color += 0.1 ;
-                                   if ( color > 0.9 )
-                                   {
-                                       color = 0.5 ;
-                                       channel++ ;
-                                       if ( channel == 3 )
-                                           channel = 0 ;
-                                   }
+                     HIRect bounds;
+                       HIViewGetBounds( controlRef, &bounds );
+                    CGContextSetRGBFillColor( cgContext, channel == 0 ? color : 0.5 ,
+                        channel == 1 ? color : 0.5 , channel == 2 ? color : 0.5 , 1 );
+                    CGContextFillRect( cgContext, bounds );
+                    color += 0.1 ;
+                    if ( color > 0.9 )
+                    {
+                        color = 0.5 ;
+                        channel++ ;
+                        if ( channel == 3 )
+                            channel = 0 ;
+                    }

                 }
 #endif
                 if ( thisWindow->MacDoRedraw( updateRgn , cEvent.GetTicks() ) )
                     result = noErr ;
                 }
 #endif
                 if ( thisWindow->MacDoRedraw( updateRgn , cEvent.GetTicks() ) )
                     result = noErr ;

+                if ( allocatedRgn )
+                    DisposeRgn( allocatedRgn ) ;

             }
             break ;
         case kEventControlVisibilityChanged :
             }
             break ;
         case kEventControlVisibilityChanged :


@@ -219,7 +279,7 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl
                     // panel wants to track the window which was the last to have focus in it
                     wxChildFocusEvent eventFocus(thisWindow);
                     thisWindow->GetEventHandler()->ProcessEvent(eventFocus);
                     // panel wants to track the window which was the last to have focus in it
                     wxChildFocusEvent eventFocus(thisWindow);
                     thisWindow->GetEventHandler()->ProcessEvent(eventFocus);

-                    
+

         #if wxUSE_CARET
                     if ( thisWindow->GetCaret() )
                     {
         #if wxUSE_CARET
                     if ( thisWindow->GetCaret() )
                     {


@@ -252,7 +312,7 @@ static pascal OSStatus wxMacWindowServiceEventHandler( EventHandlerCallRef handl
     OSStatus result = eventNotHandledErr ;
 
     wxMacCarbonEvent cEvent( event ) ;
     OSStatus result = eventNotHandledErr ;
 
     wxMacCarbonEvent cEvent( event ) ;

-    
+

     ControlRef controlRef ;
     wxWindowMac* thisWindow = (wxWindowMac*) data ;
     wxTextCtrl* textCtrl = wxDynamicCast( thisWindow , wxTextCtrl ) ;
     ControlRef controlRef ;
     wxWindowMac* thisWindow = (wxWindowMac*) data ;
     wxTextCtrl* textCtrl = wxDynamicCast( thisWindow , wxTextCtrl ) ;


@@ -266,13 +326,13 @@ static pascal OSStatus wxMacWindowServiceEventHandler( EventHandlerCallRef handl
                 long from, to ;
                 textCtrl->GetSelection( &from , &to ) ;
 
                 long from, to ;
                 textCtrl->GetSelection( &from , &to ) ;
 

-                CFMutableArrayRef copyTypes = 0 , pasteTypes = 0;                 
+                CFMutableArrayRef copyTypes = 0 , pasteTypes = 0;

                 if( from != to )
                     copyTypes = cEvent.GetParameter< CFMutableArrayRef >( kEventParamServiceCopyTypes , typeCFMutableArrayRef ) ;
                 if ( textCtrl->IsEditable() )
                     pasteTypes = cEvent.GetParameter< CFMutableArrayRef >( kEventParamServicePasteTypes , typeCFMutableArrayRef ) ;
                 if( from != to )
                     copyTypes = cEvent.GetParameter< CFMutableArrayRef >( kEventParamServiceCopyTypes , typeCFMutableArrayRef ) ;
                 if ( textCtrl->IsEditable() )
                     pasteTypes = cEvent.GetParameter< CFMutableArrayRef >( kEventParamServicePasteTypes , typeCFMutableArrayRef ) ;

-                
-                static const OSType textDataTypes[] = { kTXNTextData /* , 'utxt' ,  'PICT', 'MooV',     'AIFF' */  }; 
+
+                static const OSType textDataTypes[] = { kTXNTextData /* , 'utxt' ,  'PICT', 'MooV',     'AIFF' */  };

                 for ( size_t i = 0 ; i < WXSIZEOF(textDataTypes) ; ++i )
                 {
                     CFStringRef typestring = CreateTypeStringWithOSType(textDataTypes[i]);
                 for ( size_t i = 0 ; i < WXSIZEOF(textDataTypes) ; ++i )
                 {
                     CFStringRef typestring = CreateTypeStringWithOSType(textDataTypes[i]);


@@ -309,7 +369,7 @@ static pascal OSStatus wxMacWindowServiceEventHandler( EventHandlerCallRef handl
                 verify_noerr( GetScrapFlavorSize (scrapRef, kTXNTextData, &textSize) ) ;
                 textSize++ ;
                 char *content = new char[textSize] ;
                 verify_noerr( GetScrapFlavorSize (scrapRef, kTXNTextData, &textSize) ) ;
                 textSize++ ;
                 char *content = new char[textSize] ;

-                GetScrapFlavorData (scrapRef, kTXNTextData, &pastedSize, content );  
+                GetScrapFlavorData (scrapRef, kTXNTextData, &pastedSize, content );

                 content[textSize-1] = 0 ;
 #if wxUSE_UNICODE
                 textCtrl->WriteText( wxString( content , wxConvLocal )  );
                 content[textSize-1] = 0 ;
 #if wxUSE_UNICODE
                 textCtrl->WriteText( wxString( content , wxConvLocal )  );


@@ -321,12 +381,15 @@ static pascal OSStatus wxMacWindowServiceEventHandler( EventHandlerCallRef handl
             }
             break ;
     }
             }
             break ;
     }

-    
+

     return result ;
     return result ;

-} 
+}

 
 pascal OSStatus wxMacWindowEventHandler( EventHandlerCallRef handler , EventRef event , void *data )
 {
 
 pascal OSStatus wxMacWindowEventHandler( EventHandlerCallRef handler , EventRef event , void *data )
 {

+    EventRef formerEvent = (EventRef) wxTheApp->MacGetCurrentEvent() ;
+    EventHandlerCallRef formerEventHandlerCallRef = (EventHandlerCallRef) wxTheApp->MacGetCurrentEventHandlerCallRef() ;
+    wxTheApp->MacSetCurrentEvent( event , handler ) ;

     OSStatus result = eventNotHandledErr ;
 
     switch ( GetEventClass( event ) )
     OSStatus result = eventNotHandledErr ;
 
     switch ( GetEventClass( event ) )


@@ -339,6 +402,7 @@ pascal OSStatus wxMacWindowEventHandler( EventHandlerCallRef handler , EventRef
         default :
             break ;
     }
         default :
             break ;
     }

+    wxTheApp->MacSetCurrentEvent( formerEvent, formerEventHandlerCallRef ) ;

     return result ;
 }
 
     return result ;
 }
 


@@ -347,7 +411,7 @@ DEFINE_ONE_SHOT_HANDLER_GETTER( wxMacWindowEventHandler )
 // ---------------------------------------------------------------------------
 // UserPane events for non OSX builds
 // ---------------------------------------------------------------------------
 // ---------------------------------------------------------------------------
 // UserPane events for non OSX builds
 // ---------------------------------------------------------------------------

- 
+

 static pascal void wxMacControlUserPaneDrawProc(ControlRef control, SInt16 part)
 {
     wxWindow * win = wxFindControlFromMacControl(control) ;
 static pascal void wxMacControlUserPaneDrawProc(ControlRef control, SInt16 part)
 {
     wxWindow * win = wxFindControlFromMacControl(control) ;


@@ -404,7 +468,7 @@ static pascal void wxMacControlUserPaneBackgroundProc(ControlRef control, Contro
     win->MacControlUserPaneBackgroundProc(info) ;
 }
 
     win->MacControlUserPaneBackgroundProc(info) ;
 }
 

-void wxWindowMac::MacControlUserPaneDrawProc(wxInt16 part) 
+void wxWindowMac::MacControlUserPaneDrawProc(wxInt16 part)

 {
     RgnHandle rgn = NewRgn() ;
     GetClip( rgn ) ;
 {
     RgnHandle rgn = NewRgn() ;
     GetClip( rgn ) ;


@@ -414,35 +478,35 @@ void wxWindowMac::MacControlUserPaneDrawProc(wxInt16 part)
     DisposeRgn( rgn ) ;
 }
 
     DisposeRgn( rgn ) ;
 }
 

-wxInt16 wxWindowMac::MacControlUserPaneHitTestProc(wxInt16 x, wxInt16 y) 
+wxInt16 wxWindowMac::MacControlUserPaneHitTestProc(wxInt16 x, wxInt16 y)

 {
     return kControlNoPart ;
 }
 
 {
     return kControlNoPart ;
 }
 

-wxInt16 wxWindowMac::MacControlUserPaneTrackingProc(wxInt16 x, wxInt16 y, void* actionProc) 
+wxInt16 wxWindowMac::MacControlUserPaneTrackingProc(wxInt16 x, wxInt16 y, void* actionProc)

 {
     return kControlNoPart ;
 }
 
 {
     return kControlNoPart ;
 }
 

-void wxWindowMac::MacControlUserPaneIdleProc() 
+void wxWindowMac::MacControlUserPaneIdleProc()

 {
 }
 
 {
 }
 

-wxInt16 wxWindowMac::MacControlUserPaneKeyDownProc(wxInt16 keyCode, wxInt16 charCode, wxInt16 modifiers) 
+wxInt16 wxWindowMac::MacControlUserPaneKeyDownProc(wxInt16 keyCode, wxInt16 charCode, wxInt16 modifiers)

 {
     return kControlNoPart ;
 }
 
 {
     return kControlNoPart ;
 }
 

-void wxWindowMac::MacControlUserPaneActivateProc(bool activating) 
+void wxWindowMac::MacControlUserPaneActivateProc(bool activating)

 {
 }
 
 {
 }
 

-wxInt16 wxWindowMac::MacControlUserPaneFocusProc(wxInt16 action) 
+wxInt16 wxWindowMac::MacControlUserPaneFocusProc(wxInt16 action)

 {
     return kControlNoPart ;
 }
 
 {
     return kControlNoPart ;
 }
 

-void wxWindowMac::MacControlUserPaneBackgroundProc(void* info) 
+void wxWindowMac::MacControlUserPaneBackgroundProc(void* info)

 {
 }
 
 {
 }
 


@@ -459,6 +523,7 @@ ControlUserPaneBackgroundUPP gControlUserPaneBackgroundUPP = NULL ;
 // implementation
 // ===========================================================================
 
 // implementation
 // ===========================================================================
 

+#if KEY_wxList_DEPRECATED

 wxList wxWinMacControlList(wxKEY_INTEGER);
 
 wxWindow *wxFindControlFromMacControl(ControlRef inControl )
 wxList wxWinMacControlList(wxKEY_INTEGER);
 
 wxWindow *wxFindControlFromMacControl(ControlRef inControl )


@@ -483,6 +548,42 @@ void wxRemoveMacControlAssociation(wxWindow *control)
 {
     wxWinMacControlList.DeleteObject(control);
 }
 {
     wxWinMacControlList.DeleteObject(control);
 }

+#else
+
+WX_DECLARE_HASH_MAP(ControlRef, wxWindow*, wxPointerHash, wxPointerEqual, MacControlMap);
+
+static MacControlMap wxWinMacControlList;
+
+wxWindow *wxFindControlFromMacControl(ControlRef inControl )
+{
+    MacControlMap::iterator node = wxWinMacControlList.find(inControl);
+
+    return (node == wxWinMacControlList.end()) ? NULL : node->second;
+}
+
+void wxAssociateControlWithMacControl(ControlRef inControl, wxWindow *control)
+{
+    // adding NULL ControlRef is (first) surely a result of an error and
+    // (secondly) breaks native event processing
+    wxCHECK_RET( inControl != (ControlRef) NULL, wxT("attempt to add a NULL WindowRef to window list") );
+
+    wxWinMacControlList[inControl] = control;
+}
+
+void wxRemoveMacControlAssociation(wxWindow *control)
+{
+   // iterate over all the elements in the class
+    MacControlMap::iterator it;
+    for ( it = wxWinMacControlList.begin(); it != wxWinMacControlList.end(); ++it )
+    {
+        if ( it->second == control )
+        {
+            wxWinMacControlList.erase(it);
+            break;
+        }
+    }
+}
+#endif // deprecated wxList

 
 // UPP functions
 ControlActionUPP wxMacLiveScrollbarActionUPP = NULL ;
 
 // UPP functions
 ControlActionUPP wxMacLiveScrollbarActionUPP = NULL ;


@@ -490,7 +591,7 @@ ControlActionUPP wxMacLiveScrollbarActionUPP = NULL ;
 ControlColorUPP wxMacSetupControlBackgroundUPP = NULL ;
 
 // we have to setup the brush in the current port and return noErr
 ControlColorUPP wxMacSetupControlBackgroundUPP = NULL ;
 
 // we have to setup the brush in the current port and return noErr

-// or return an error code so that the control manager walks further up the 
+// or return an error code so that the control manager walks further up the

 // hierarchy to find a correct background
 
 pascal OSStatus wxMacSetupControlBackground( ControlRef iControl , SInt16 iMessage , SInt16 iDepth , Boolean iIsColor )
 // hierarchy to find a correct background
 
 pascal OSStatus wxMacSetupControlBackground( ControlRef iControl , SInt16 iMessage , SInt16 iDepth , Boolean iIsColor )


@@ -509,11 +610,10 @@ pascal OSStatus wxMacSetupControlBackground( ControlRef iControl , SInt16 iMessa
                     const wxBrush &brush = wx->MacGetBackgroundBrush() ;
                     if  ( brush.Ok() )
                     {
                     const wxBrush &brush = wx->MacGetBackgroundBrush() ;
                     if  ( brush.Ok() )
                     {

-                        

                         wxDC::MacSetupBackgroundForCurrentPort( brush ) ;
                         */
                         // this clipping is only needed for non HIView
                         wxDC::MacSetupBackgroundForCurrentPort( brush ) ;
                         */
                         // this clipping is only needed for non HIView

-                        
+

                         RgnHandle clip = NewRgn() ;
                         int x = 0 , y = 0;
 
                         RgnHandle clip = NewRgn() ;
                         int x = 0 , y = 0;
 


@@ -561,8 +661,8 @@ pascal void wxMacLiveScrollbarActionProc( ControlRef control , ControlPartCode p
 // ----------------------------------------------------------------------------
 
 wxWindowMac::wxWindowMac()
 // ----------------------------------------------------------------------------
 
 wxWindowMac::wxWindowMac()

-{ 
-    Init(); 
+{
+    Init();

 }
 
 wxWindowMac::wxWindowMac(wxWindowMac *parent,
 }
 
 wxWindowMac::wxWindowMac(wxWindowMac *parent,


@@ -592,9 +692,9 @@ void wxWindowMac::Init()
     m_macBackgroundBrush = wxNullBrush ;
 
     m_macIsUserPane = TRUE;
     m_macBackgroundBrush = wxNullBrush ;
 
     m_macIsUserPane = TRUE;

-    
+

     // make sure all proc ptrs are available
     // make sure all proc ptrs are available

-    
+

     if ( gControlUserPaneDrawUPP == NULL )
     {
         gControlUserPaneDrawUPP = NewControlUserPaneDrawUPP( wxMacControlUserPaneDrawProc ) ;
     if ( gControlUserPaneDrawUPP == NULL )
     {
         gControlUserPaneDrawUPP = NewControlUserPaneDrawUPP( wxMacControlUserPaneDrawProc ) ;


@@ -627,6 +727,39 @@ wxWindowMac::~wxWindowMac()
 
     m_isBeingDeleted = TRUE;
 
 
     m_isBeingDeleted = TRUE;
 

+    if ( m_peer )
+    {
+        // deleting a window while it is shown invalidates the region occupied by border or
+        // focus
+        int outerBorder = MacGetLeftBorderSize() ;
+        if ( m_peer->NeedsFocusRect() && m_peer->HasFocus() )
+            outerBorder += 4 ;
+
+        if ( IsShown() && ( outerBorder > 0 ) )
+        {
+            // as the borders are drawn on the parent we have to properly invalidate all these areas
+            RgnHandle updateInner = NewRgn() , updateOuter = NewRgn() , updateTotal = NewRgn() ;
+
+            Rect rect ;
+
+            m_peer->GetRect( &rect ) ;
+            RectRgn( updateInner , &rect ) ;
+            InsetRect( &rect , -outerBorder , -outerBorder ) ;
+            RectRgn( updateOuter , &rect ) ;
+            DiffRgn( updateOuter , updateInner ,updateOuter ) ;
+            wxPoint parent(0,0);
+            GetParent()->MacWindowToRootWindow( &parent.x , &parent.y ) ;
+            parent -= GetParent()->GetClientAreaOrigin() ;
+            OffsetRgn( updateOuter , -parent.x , -parent.y ) ;
+            CopyRgn( updateOuter , updateTotal ) ;
+
+            GetParent()->m_peer->SetNeedsDisplay( true , updateTotal ) ;
+            DisposeRgn(updateOuter) ;
+            DisposeRgn(updateInner) ;
+            DisposeRgn(updateTotal) ;
+        }
+    }
+

 #ifndef __WXUNIVERSAL__
     // VS: make sure there's no wxFrame with last focus set to us:
     for ( wxWindow *win = GetParent(); win; win = win->GetParent() )
 #ifndef __WXUNIVERSAL__
     // VS: make sure there's no wxFrame with last focus set to us:
     for ( wxWindow *win = GetParent(); win; win = win->GetParent() )


@@ -642,7 +775,10 @@ wxWindowMac::~wxWindowMac()
         }
     }
 #endif // __WXUNIVERSAL__
         }
     }
 #endif // __WXUNIVERSAL__

-    
+
+    // destroy children before destroying this window itself
+    DestroyChildren();
+

     // wxRemoveMacControlAssociation( this ) ;
     // If we delete an item, we should initialize the parent panel,
     // because it could now be invalid.
     // wxRemoveMacControlAssociation( this ) ;
     // If we delete an item, we should initialize the parent panel,
     // because it could now be invalid.


@@ -673,8 +809,6 @@ wxWindowMac::~wxWindowMac()
             frame->SetLastFocus( NULL ) ;
     }
 
             frame->SetLastFocus( NULL ) ;
     }
 

-    DestroyChildren();
-

     // delete our drop target if we've got one
 #if wxUSE_DRAG_AND_DROP
     if ( m_dropTarget != NULL )
     // delete our drop target if we've got one
 #if wxUSE_DRAG_AND_DROP
     if ( m_dropTarget != NULL )


@@ -686,9 +820,9 @@ wxWindowMac::~wxWindowMac()
     delete m_peer ;
 }
 
     delete m_peer ;
 }
 

-WXWidget wxWindowMac::GetHandle() const 
-{ 
-    return (WXWidget) m_peer->GetControlRef() ; 
+WXWidget wxWindowMac::GetHandle() const
+{
+    return (WXWidget) m_peer->GetControlRef() ;

 }
 
 
 }
 
 


@@ -696,7 +830,7 @@ void wxWindowMac::MacInstallEventHandler( WXWidget control )
 {
     wxAssociateControlWithMacControl( (ControlRef) control  , this ) ;
     InstallControlEventHandler( (ControlRef)  control , GetwxMacWindowEventHandlerUPP(),
 {
     wxAssociateControlWithMacControl( (ControlRef) control  , this ) ;
     InstallControlEventHandler( (ControlRef)  control , GetwxMacWindowEventHandlerUPP(),

-        GetEventTypeCount(eventList), eventList, this, 
+        GetEventTypeCount(eventList), eventList, this,

         (EventHandlerRef *)&m_macControlEventHandler);
 
 }
         (EventHandlerRef *)&m_macControlEventHandler);
 
 }


@@ -713,28 +847,26 @@ bool wxWindowMac::Create(wxWindowMac *parent, wxWindowID id,
     if ( !CreateBase(parent, id, pos, size, style, wxDefaultValidator, name) )
         return FALSE;
 
     if ( !CreateBase(parent, id, pos, size, style, wxDefaultValidator, name) )
         return FALSE;
 

-    parent->AddChild(this);
-

     m_windowVariant = parent->GetWindowVariant() ;
     m_windowVariant = parent->GetWindowVariant() ;

-        
+

     if ( m_macIsUserPane )
     {
         Rect bounds = wxMacGetBoundsForControl( this , pos , size ) ;
     if ( m_macIsUserPane )
     {
         Rect bounds = wxMacGetBoundsForControl( this , pos , size ) ;

-        
+

         UInt32 features = 0
         UInt32 features = 0

-                       | kControlSupportsEmbedding 
-//                     | kControlSupportsLiveFeedback 
-//                     | kControlHasSpecialBackground  
-//                     | kControlSupportsCalcBestRect 
-//                     | kControlHandlesTracking 
-                       | kControlSupportsFocus 
-//                     | kControlWantsActivate 
-//                     | kControlWantsIdle
-                       ; 
+            | kControlSupportsEmbedding
+//            | kControlSupportsLiveFeedback
+//            | kControlHasSpecialBackground
+//            | kControlSupportsCalcBestRect
+//            | kControlHandlesTracking
+            | kControlSupportsFocus
+//            | kControlWantsActivate
+//            | kControlWantsIdle
+            ;

 
         m_peer = new wxMacControl() ;
         ::CreateUserPaneControl( MAC_WXHWND(GetParent()->MacGetTopLevelWindowRef()) , &bounds, features , m_peer->GetControlRefAddr() );
 
         m_peer = new wxMacControl() ;
         ::CreateUserPaneControl( MAC_WXHWND(GetParent()->MacGetTopLevelWindowRef()) , &bounds, features , m_peer->GetControlRefAddr() );

-         
+

 
         MacPostControlCreate(pos,size) ;
 #if !TARGET_API_MAC_OSX
 
         MacPostControlCreate(pos,size) ;
 #if !TARGET_API_MAC_OSX


@@ -746,7 +878,7 @@ bool wxWindowMac::Create(wxWindowMac *parent, wxWindowID id,
         m_peer->SetData<ControlUserPaneActivateUPP>(kControlEntireControl,kControlUserPaneActivateProcTag,&gControlUserPaneActivateUPP) ;
         m_peer->SetData<ControlUserPaneFocusUPP>(kControlEntireControl,kControlUserPaneFocusProcTag,&gControlUserPaneFocusUPP) ;
         m_peer->SetData<ControlUserPaneBackgroundUPP>(kControlEntireControl,kControlUserPaneBackgroundProcTag,&gControlUserPaneBackgroundUPP) ;
         m_peer->SetData<ControlUserPaneActivateUPP>(kControlEntireControl,kControlUserPaneActivateProcTag,&gControlUserPaneActivateUPP) ;
         m_peer->SetData<ControlUserPaneFocusUPP>(kControlEntireControl,kControlUserPaneFocusProcTag,&gControlUserPaneFocusUPP) ;
         m_peer->SetData<ControlUserPaneBackgroundUPP>(kControlEntireControl,kControlUserPaneBackgroundProcTag,&gControlUserPaneBackgroundUPP) ;

-#endif        
+#endif

     }
 #ifndef __WXUNIVERSAL__
     // Don't give scrollbars to wxControls unless they ask for them
     }
 #ifndef __WXUNIVERSAL__
     // Don't give scrollbars to wxControls unless they ask for them


@@ -768,6 +900,7 @@ void wxWindowMac::MacPostControlCreate(const wxPoint& pos, const wxSize& size)
     wxASSERT_MSG( m_peer != NULL && m_peer->Ok() , wxT("No valid mac control") ) ;
 
     m_peer->SetReference( (long) this ) ;
     wxASSERT_MSG( m_peer != NULL && m_peer->Ok() , wxT("No valid mac control") ) ;
 
     m_peer->SetReference( (long) this ) ;

+    GetParent()->AddChild(this);

 
     MacInstallEventHandler( (WXWidget) m_peer->GetControlRef() );
 
 
     MacInstallEventHandler( (WXWidget) m_peer->GetControlRef() );
 


@@ -779,9 +912,9 @@ void wxWindowMac::MacPostControlCreate(const wxPoint& pos, const wxSize& size)
     DoSetWindowVariant( m_windowVariant ) ;
 
 #if !TARGET_API_MAC_OSX
     DoSetWindowVariant( m_windowVariant ) ;
 
 #if !TARGET_API_MAC_OSX

-    // eventually we can fix some clipping issues be reactivating this hook 
+    // eventually we can fix some clipping issues be reactivating this hook

     //if ( m_macIsUserPane )
     //if ( m_macIsUserPane )

-    // SetControlColorProc( *m_peer , wxMacSetupControlBackgroundUPP ) ;
+    // SetControlColorProc( m_peer->GetControlRef() , wxMacSetupControlBackgroundUPP ) ;

 #endif
     m_peer->SetTitle( wxStripMenuCodes(m_label) ) ;
 
 #endif
     m_peer->SetTitle( wxStripMenuCodes(m_label) ) ;
 


@@ -804,39 +937,39 @@ void wxWindowMac::DoSetWindowVariant( wxWindowVariant variant )
     if (m_peer == NULL || !m_peer->Ok())
         return;
 
     if (m_peer == NULL || !m_peer->Ok())
         return;
 

-       ControlSize size ;
+    ControlSize size ;

     ThemeFontID themeFont = kThemeSystemFont ;
 
     // we will get that from the settings later
     ThemeFontID themeFont = kThemeSystemFont ;
 
     // we will get that from the settings later

-    // and make this NORMAL later, but first 
+    // and make this NORMAL later, but first

     // we have a few calculations that we must fix
     // we have a few calculations that we must fix

-    
+

     switch ( variant )
     {
         case wxWINDOW_VARIANT_NORMAL :
     switch ( variant )
     {
         case wxWINDOW_VARIANT_NORMAL :

-            size = kControlSizeNormal; 
-               themeFont = kThemeSystemFont ;
+            size = kControlSizeNormal;
+            themeFont = kThemeSystemFont ;

             break ;
         case wxWINDOW_VARIANT_SMALL :
             break ;
         case wxWINDOW_VARIANT_SMALL :

-            size = kControlSizeSmall; 
-               themeFont = kThemeSmallSystemFont ;
+            size = kControlSizeSmall;
+            themeFont = kThemeSmallSystemFont ;

             break ;
         case wxWINDOW_VARIANT_MINI :
            if (UMAGetSystemVersion() >= 0x1030 )
             {
             break ;
         case wxWINDOW_VARIANT_MINI :
            if (UMAGetSystemVersion() >= 0x1030 )
             {

-                // not always defined in the headers 
-                size = 3 ; 
-                   themeFont = 109 ;
+                // not always defined in the headers
+                size = 3 ;
+                themeFont = 109 ;

             }
             else
             {
             }
             else
             {

-                size = kControlSizeSmall; 
-                   themeFont = kThemeSmallSystemFont ;
+                size = kControlSizeSmall;
+                themeFont = kThemeSmallSystemFont ;

             }
             break ;
         case wxWINDOW_VARIANT_LARGE :
             }
             break ;
         case wxWINDOW_VARIANT_LARGE :

-            size = kControlSizeLarge; 
-               themeFont = kThemeSystemFont ;
+            size = kControlSizeLarge;
+            themeFont = kThemeSystemFont ;

             break ;
         default:
             wxFAIL_MSG(_T("unexpected window variant"));
             break ;
         default:
             wxFAIL_MSG(_T("unexpected window variant"));


@@ -849,18 +982,18 @@ void wxWindowMac::DoSetWindowVariant( wxWindowVariant variant )
     SetFont( font ) ;
 }
 
     SetFont( font ) ;
 }
 

-void wxWindowMac::MacUpdateControlFont() 
+void wxWindowMac::MacUpdateControlFont()

 {
     m_peer->SetFont( GetFont() , GetForegroundColour() , GetWindowStyle() ) ;
 {
     m_peer->SetFont( GetFont() , GetForegroundColour() , GetWindowStyle() ) ;

-       Refresh() ;
+    Refresh() ;

 }
 
 bool wxWindowMac::SetFont(const wxFont& font)
 {
 }
 
 bool wxWindowMac::SetFont(const wxFont& font)
 {

-    bool retval = !wxWindowBase::SetFont( font ) ;
-    
+    bool retval = wxWindowBase::SetFont( font ) ;
+

     MacUpdateControlFont() ;
     MacUpdateControlFont() ;

-    
+

     return retval;
 }
 
     return retval;
 }
 


@@ -868,9 +1001,9 @@ bool wxWindowMac::SetForegroundColour(const wxColour& col )
 {
     if ( !wxWindowBase::SetForegroundColour(col) )
         return false ;
 {
     if ( !wxWindowBase::SetForegroundColour(col) )
         return false ;

-        
+

     MacUpdateControlFont() ;
     MacUpdateControlFont() ;

-    
+

     return true ;
 }
 
     return true ;
 }
 


@@ -887,19 +1020,24 @@ bool wxWindowMac::SetBackgroundColour(const wxColour& col )
     }
     else if (  newCol == wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE ) )
     {
     }
     else if (  newCol == wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE ) )
     {

-        brush.MacSetTheme( kThemeBrushDialogBackgroundActive ) ; 
-    } 
+        brush.MacSetTheme( kThemeBrushDialogBackgroundActive ) ;
+    }

     else
     {
         brush.SetColour( newCol ) ;
     }
     MacSetBackgroundBrush( brush ) ;
     else
     {
         brush.SetColour( newCol ) ;
     }
     MacSetBackgroundBrush( brush ) ;

-        
+

     MacUpdateControlFont() ;
     MacUpdateControlFont() ;

-    
+

     return true ;
 }
 
     return true ;
 }
 

+void wxWindowMac::MacSetBackgroundBrush( const wxBrush &brush )
+{
+    m_macBackgroundBrush = brush ;
+    m_peer->SetBackground( brush ) ;
+}

 
 bool wxWindowMac::MacCanFocus() const
 {
 
 bool wxWindowMac::MacCanFocus() const
 {


@@ -909,7 +1047,7 @@ bool wxWindowMac::MacCanFocus() const
     // in event handlers...
     UInt32 features = 0 ;
     m_peer->GetFeatures( & features ) ;
     // in event handlers...
     UInt32 features = 0 ;
     m_peer->GetFeatures( & features ) ;

-    return features & ( kControlSupportsFocus | kControlGetsFocusOnClick ) ; 
+    return features & ( kControlSupportsFocus | kControlGetsFocusOnClick ) ;

 }
 
 
 }
 
 


@@ -917,9 +1055,11 @@ void wxWindowMac::SetFocus()
 {
     if ( AcceptsFocus() )
     {
 {
     if ( AcceptsFocus() )
     {

-#if !TARGET_API_MAC_OSX
+

         wxWindow* former = FindFocus() ;
         wxWindow* former = FindFocus() ;

-#endif
+        if ( former == this )
+            return ;
+

         OSStatus err = m_peer->SetFocus( kControlFocusNextPart ) ;
         // as we cannot rely on the control features to find out whether we are in full keyboard mode, we can only
         // leave in case of an error
         OSStatus err = m_peer->SetFocus( kControlFocusNextPart ) ;
         // as we cannot rely on the control features to find out whether we are in full keyboard mode, we can only
         // leave in case of an error


@@ -937,7 +1077,7 @@ void wxWindowMac::SetFocus()
             wxMacCarbonEvent cEvent( evRef ) ;
             cEvent.SetParameter<ControlRef>( kEventParamDirectObject , (ControlRef) former->GetHandle() ) ;
             cEvent.SetParameter<ControlPartCode>(kEventParamControlPart , typeControlPartCode , kControlFocusNoPart ) ;
             wxMacCarbonEvent cEvent( evRef ) ;
             cEvent.SetParameter<ControlRef>( kEventParamDirectObject , (ControlRef) former->GetHandle() ) ;
             cEvent.SetParameter<ControlPartCode>(kEventParamControlPart , typeControlPartCode , kControlFocusNoPart ) ;

-            
+

             wxMacWindowEventHandler( NULL , evRef , former ) ;
             ReleaseEvent(evRef) ;
         }
             wxMacWindowEventHandler( NULL , evRef , former ) ;
             ReleaseEvent(evRef) ;
         }


@@ -950,7 +1090,7 @@ void wxWindowMac::SetFocus()
             wxMacCarbonEvent cEvent( evRef ) ;
             cEvent.SetParameter<ControlRef>( kEventParamDirectObject , (ControlRef) GetHandle() ) ;
             cEvent.SetParameter<ControlPartCode>(kEventParamControlPart , typeControlPartCode , kControlFocusNextPart ) ;
             wxMacCarbonEvent cEvent( evRef ) ;
             cEvent.SetParameter<ControlRef>( kEventParamDirectObject , (ControlRef) GetHandle() ) ;
             cEvent.SetParameter<ControlPartCode>(kEventParamControlPart , typeControlPartCode , kControlFocusNextPart ) ;

-            
+

             wxMacWindowEventHandler( NULL , evRef , this ) ;
             ReleaseEvent(evRef) ;
         }
             wxMacWindowEventHandler( NULL , evRef , this ) ;
             ReleaseEvent(evRef) ;
         }


@@ -997,35 +1137,31 @@ void wxWindowMac::DragAcceptFiles(bool accept)
     // TODO
 }
 
     // TODO
 }
 

+// Returns the size of the native control. In the case of the toplevel window
+// this is the content area root control
+

 void wxWindowMac::MacGetPositionAndSizeFromControl(int& x, int& y,
 void wxWindowMac::MacGetPositionAndSizeFromControl(int& x, int& y,

-                                           int& w, int& h) const 
+                                           int& w, int& h) const

 {
     Rect bounds ;
 {
     Rect bounds ;

-    m_peer->GetRect( &bounds ) ;   
+    m_peer->GetRect( &bounds ) ;

 
 
     x = bounds.left ;
     y = bounds.top ;
     w = bounds.right - bounds.left ;
     h = bounds.bottom - bounds.top ;
 
 
     x = bounds.left ;
     y = bounds.top ;
     w = bounds.right - bounds.left ;
     h = bounds.bottom - bounds.top ;

-
-    wxTopLevelWindow* tlw = wxDynamicCast( this , wxTopLevelWindow ) ;
-    if ( tlw )
-    {
-        Point tlworigin =  { 0 , 0  } ;
-        QDLocalToGlobalPoint( UMAGetWindowPort( (WindowRef) tlw->MacGetWindowRef() ) , &tlworigin ) ;
-        x = tlworigin.h ;
-        y = tlworigin.v ;    
-    }

 }
 
 }
 

+// From a wx position / size calculate the appropriate size of the native control
+

 bool wxWindowMac::MacGetBoundsForControl(const wxPoint& pos,
                                        const wxSize& size,
                                        int& x, int& y,
 bool wxWindowMac::MacGetBoundsForControl(const wxPoint& pos,
                                        const wxSize& size,
                                        int& x, int& y,

-                                       int& w, int& h , bool adjustOrigin ) const 
+                                       int& w, int& h , bool adjustOrigin ) const

 {
     // the desired size, minus the border pixels gives the correct size of the control
 {
     // the desired size, minus the border pixels gives the correct size of the control

-    
+

     x = (int)pos.x;
     y = (int)pos.y;
     // todo the default calls may be used as soon as PostCreateControl Is moved here
     x = (int)pos.x;
     y = (int)pos.y;
     // todo the default calls may be used as soon as PostCreateControl Is moved here


@@ -1039,45 +1175,61 @@ bool wxWindowMac::MacGetBoundsForControl(const wxPoint& pos,
     y += MacGetTopBorderSize() ;
     w -= MacGetLeftBorderSize() + MacGetRightBorderSize() ;
     h -= MacGetTopBorderSize() + MacGetBottomBorderSize() ;
     y += MacGetTopBorderSize() ;
     w -= MacGetLeftBorderSize() + MacGetRightBorderSize() ;
     h -= MacGetTopBorderSize() + MacGetBottomBorderSize() ;

-    
+

     if ( adjustOrigin )
         AdjustForParentClientOrigin( x , y ) ;
     if ( adjustOrigin )
         AdjustForParentClientOrigin( x , y ) ;

+#if TARGET_API_MAC_OSX
+    // this is in window relative coordinate, as this parent may have a border, its physical position is offset by this border
+    if ( ! GetParent()->IsTopLevel() )
+    {
+        x -= GetParent()->MacGetLeftBorderSize() ;
+        y -= GetParent()->MacGetTopBorderSize() ;
+    }
+#endif

     return true ;
 }
 
     return true ;
 }
 

-// Get total size
+// Get window size (not client size)

 void wxWindowMac::DoGetSize(int *x, int *y) const
 {
     // take the size of the control and add the borders that have to be drawn outside
 void wxWindowMac::DoGetSize(int *x, int *y) const
 {
     // take the size of the control and add the borders that have to be drawn outside

-    int x1 , y1 , w1 ,h1 ;
-#if TARGET_API_MAC_OSX
+    int x1 , y1 , w1 , h1 ;
+

     MacGetPositionAndSizeFromControl( x1 , y1, w1 ,h1 ) ;
     MacGetPositionAndSizeFromControl( x1 , y1, w1 ,h1 ) ;

-    
-#else
-    Rect bounds ;
-    m_peer->GetRect( &bounds ) ;   
-    w1 = bounds.right - bounds.left ;
-    h1 = bounds.bottom - bounds.top ;
-#endif
+

     w1 += MacGetLeftBorderSize() + MacGetRightBorderSize() ;
     h1 += MacGetTopBorderSize() + MacGetBottomBorderSize() ;
     w1 += MacGetLeftBorderSize() + MacGetRightBorderSize() ;
     h1 += MacGetTopBorderSize() + MacGetBottomBorderSize() ;

-    
+

     if(x)   *x = w1 ;
     if(y)   *y = h1 ;
 }
 
     if(x)   *x = w1 ;
     if(y)   *y = h1 ;
 }
 

+// get the position of the bounds of this window in client coordinates of its parent

 void wxWindowMac::DoGetPosition(int *x, int *y) const
 {
 void wxWindowMac::DoGetPosition(int *x, int *y) const
 {

- #if TARGET_API_MAC_OSX

     int x1 , y1 , w1 ,h1 ;
     MacGetPositionAndSizeFromControl( x1 , y1, w1 ,h1 ) ;
     x1 -= MacGetLeftBorderSize() ;
     y1 -= MacGetTopBorderSize() ;
     int x1 , y1 , w1 ,h1 ;
     MacGetPositionAndSizeFromControl( x1 , y1, w1 ,h1 ) ;
     x1 -= MacGetLeftBorderSize() ;
     y1 -= MacGetTopBorderSize() ;

+    // to non-client
+ #if !TARGET_API_MAC_OSX
+    if ( !GetParent()->IsTopLevel() )
+    {
+        Rect bounds ;
+        GetControlBounds( (ControlRef) GetParent()->GetHandle() , &bounds ) ;
+        x1 -= bounds.left ;
+        y1 -= bounds.top ;
+    }
+#endif

     if ( !IsTopLevel() )
     {
         wxWindow *parent = GetParent();
         if ( parent )
         {
     if ( !IsTopLevel() )
     {
         wxWindow *parent = GetParent();
         if ( parent )
         {

+            // we must first adjust it to be in window coordinates of the parent, as otherwise it gets lost by the clientareaorigin fix
+            x1 += parent->MacGetLeftBorderSize() ;
+            y1 += parent->MacGetTopBorderSize() ;
+            // and now to client coordinates

             wxPoint pt(parent->GetClientAreaOrigin());
             x1 -= pt.x ;
             y1 -= pt.y ;
             wxPoint pt(parent->GetClientAreaOrigin());
             x1 -= pt.x ;
             y1 -= pt.y ;


@@ -1085,52 +1237,27 @@ void wxWindowMac::DoGetPosition(int *x, int *y) const
     }
     if(x)   *x = x1 ;
     if(y)   *y = y1 ;
     }
     if(x)   *x = x1 ;
     if(y)   *y = y1 ;

- #else
-    Rect bounds ;
-    m_peer->GetRect( &bounds ) ;   
-    wxCHECK_RET( GetParent() , wxT("Missing Parent") ) ;
-    
-    int xx = bounds.left ;
-    int yy = bounds.top ;
-    xx -= MacGetLeftBorderSize() ;
-    yy -= MacGetTopBorderSize() ;
-    
-    if ( !GetParent()->IsTopLevel() )
-    {
-        GetControlBounds( (ControlRef) GetParent()->GetHandle() , &bounds ) ;
-    
-        xx -= bounds.left ;
-        yy -= bounds.top ;
-    }
-    
-    wxPoint pt(GetParent()->GetClientAreaOrigin());
-    xx -= pt.x;
-    yy -= pt.y;
-
-    if(x)   *x = xx;
-    if(y)   *y = yy;
-#endif

 }
 
 void wxWindowMac::DoScreenToClient(int *x, int *y) const
 {
     WindowRef window = (WindowRef) MacGetTopLevelWindowRef() ;
 }
 
 void wxWindowMac::DoScreenToClient(int *x, int *y) const
 {
     WindowRef window = (WindowRef) MacGetTopLevelWindowRef() ;

-    
+

     wxCHECK_RET( window , wxT("TopLevel Window Missing") ) ;
     wxCHECK_RET( window , wxT("TopLevel Window Missing") ) ;

-    
+

     {
         Point localwhere = {0,0} ;
 
         if(x) localwhere.h = * x ;
         if(y) localwhere.v = * y ;
     {
         Point localwhere = {0,0} ;
 
         if(x) localwhere.h = * x ;
         if(y) localwhere.v = * y ;

-        
+

         QDGlobalToLocalPoint( GetWindowPort( window ) , &localwhere ) ;
         if(x)   *x = localwhere.h ;
         if(y)   *y = localwhere.v ;
 
     }
     MacRootWindowToWindow( x , y ) ;
         QDGlobalToLocalPoint( GetWindowPort( window ) , &localwhere ) ;
         if(x)   *x = localwhere.h ;
         if(y)   *y = localwhere.v ;
 
     }
     MacRootWindowToWindow( x , y ) ;

-    
+

     wxPoint origin = GetClientAreaOrigin() ;
     if(x)   *x -= origin.x ;
     if(y)   *y -= origin.y ;
     wxPoint origin = GetClientAreaOrigin() ;
     if(x)   *x -= origin.x ;
     if(y)   *y -= origin.y ;


@@ -1192,16 +1319,16 @@ void wxWindowMac::MacWindowToRootWindow( int *x , int *y ) const
             wxMacControl::Convert( &pt , m_peer , top->m_peer ) ;
         }
     }
             wxMacControl::Convert( &pt , m_peer , top->m_peer ) ;
         }
     }

-    
+

     if ( x ) *x = (int) pt.x ;
     if ( y ) *y = (int) pt.y ;
  #else
     if ( !IsTopLevel() )
     {
         Rect bounds ;
     if ( x ) *x = (int) pt.x ;
     if ( y ) *y = (int) pt.y ;
  #else
     if ( !IsTopLevel() )
     {
         Rect bounds ;

-        m_peer->GetRect( &bounds ) ;   
-        if(x)   *x += bounds.left ;
-        if(y)   *y += bounds.top ;
+        m_peer->GetRect( &bounds ) ;
+        if(x)   *x += bounds.left - MacGetLeftBorderSize() ;
+        if(y)   *y += bounds.top - MacGetTopBorderSize() ;

     }
 #endif
 }
     }
 #endif
 }


@@ -1229,16 +1356,16 @@ void wxWindowMac::MacRootWindowToWindow( int *x , int *y ) const
         pt.x += MacGetLeftBorderSize() ;
         pt.y += MacGetTopBorderSize() ;
     }
         pt.x += MacGetLeftBorderSize() ;
         pt.y += MacGetTopBorderSize() ;
     }

-    
+

     if ( x ) *x = (int) pt.x ;
     if ( y ) *y = (int) pt.y ;
  #else
     if ( !IsTopLevel() )
     {
         Rect bounds ;
     if ( x ) *x = (int) pt.x ;
     if ( y ) *y = (int) pt.y ;
  #else
     if ( !IsTopLevel() )
     {
         Rect bounds ;

-        m_peer->GetRect( &bounds ) ;   
-        if(x)   *x -= bounds.left ;
-        if(y)   *y -= bounds.top ;
+        m_peer->GetRect( &bounds ) ;
+        if(x)   *x -= bounds.left + MacGetLeftBorderSize() ;
+        if(y)   *y -= bounds.top + MacGetTopBorderSize() ;

     }
 #endif
 }
     }
 #endif
 }


@@ -1268,7 +1395,7 @@ void wxWindowMac::MacGetContentAreaInset( int &left , int &top , int &right , in
     }
     Rect structure ;
     m_peer->GetRect( &structure ) ;
     }
     Rect structure ;
     m_peer->GetRect( &structure ) ;

-#if !TARGET_API_MAC_OSX    
+#if !TARGET_API_MAC_OSX

     OffsetRect( &content , -structure.left , -structure.top ) ;
 #endif
     left = content.left - structure.left ;
     OffsetRect( &content , -structure.left , -structure.top ) ;
 #endif
     left = content.left - structure.left ;


@@ -1284,7 +1411,7 @@ wxSize wxWindowMac::DoGetSizeFromClientSize( const wxSize & size )  const
     RgnHandle rgn = NewRgn() ;
 
     Rect content ;
     RgnHandle rgn = NewRgn() ;
 
     Rect content ;

-    
+

     if ( m_peer->GetRegion( kControlContentMetaPart , rgn ) == noErr )
     {
         GetRegionBounds( rgn , &content ) ;
     if ( m_peer->GetRegion( kControlContentMetaPart , rgn ) == noErr )
     {
         GetRegionBounds( rgn , &content ) ;


@@ -1296,12 +1423,12 @@ wxSize wxWindowMac::DoGetSizeFromClientSize( const wxSize & size )  const
     }
     Rect structure ;
     m_peer->GetRect( &structure ) ;
     }
     Rect structure ;
     m_peer->GetRect( &structure ) ;

-#if !TARGET_API_MAC_OSX    
+#if !TARGET_API_MAC_OSX

     OffsetRect( &content , -structure.left , -structure.top ) ;
 #endif
 
     sizeTotal.x += (structure.right - structure.left) - (content.right - content.left) ;
     OffsetRect( &content , -structure.left , -structure.top ) ;
 #endif
 
     sizeTotal.x += (structure.right - structure.left) - (content.right - content.left) ;

-    sizeTotal.y += (structure.bottom - structure.top) - (content.bottom - content.top ) ; 
+    sizeTotal.y += (structure.bottom - structure.top) - (content.bottom - content.top ) ;

 
     sizeTotal.x += MacGetLeftBorderSize(  ) + MacGetRightBorderSize( ) ;
     sizeTotal.y += MacGetTopBorderSize(  ) + MacGetBottomBorderSize( ) ;
 
     sizeTotal.x += MacGetLeftBorderSize(  ) + MacGetRightBorderSize( ) ;
     sizeTotal.y += MacGetTopBorderSize(  ) + MacGetBottomBorderSize( ) ;


@@ -1330,13 +1457,14 @@ void wxWindowMac::DoGetClientSize(int *x, int *y) const
     Rect structure ;
     m_peer->GetRect( &structure ) ;
     OffsetRect( &content , -structure.left , -structure.top ) ;
     Rect structure ;
     m_peer->GetRect( &structure ) ;
     OffsetRect( &content , -structure.left , -structure.top ) ;

-#endif 
+#endif

     ww = content.right - content.left ;
     hh = content.bottom - content.top ;
     ww = content.right - content.left ;
     hh = content.bottom - content.top ;

-    
+    /*

     ww -= MacGetLeftBorderSize(  )  + MacGetRightBorderSize(  ) ;
     hh -= MacGetTopBorderSize(  ) + MacGetBottomBorderSize( );
     ww -= MacGetLeftBorderSize(  )  + MacGetRightBorderSize(  ) ;
     hh -= MacGetTopBorderSize(  ) + MacGetBottomBorderSize( );

-
+    */
+    /*

     if ( (m_vScrollBar && m_vScrollBar->IsShown()) || (m_hScrollBar  && m_hScrollBar->IsShown()) )
     {
         int x1 = 0 ;
     if ( (m_vScrollBar && m_vScrollBar->IsShown()) || (m_hScrollBar  && m_hScrollBar->IsShown()) )
     {
         int x1 = 0 ;


@@ -1344,7 +1472,7 @@ void wxWindowMac::DoGetClientSize(int *x, int *y) const
         int w  ;
         int h  ;
         GetSize( &w , &h ) ;
         int w  ;
         int h  ;
         GetSize( &w , &h ) ;

-        
+

         MacClientToRootWindow( &x1 , &y1 ) ;
         MacClientToRootWindow( &w , &h ) ;
 
         MacClientToRootWindow( &x1 , &y1 ) ;
         MacClientToRootWindow( &w , &h ) ;
 


@@ -1364,7 +1492,7 @@ void wxWindowMac::DoGetClientSize(int *x, int *y) const
 
         if (m_hScrollBar  && m_hScrollBar->IsShown() )
         {
 
         if (m_hScrollBar  && m_hScrollBar->IsShown() )
         {

-            hh -= MAC_SCROLLBAR_SIZE;
+            hh -= m_hScrollBar->GetSize().y ; // MAC_SCROLLBAR_SIZE ;

             if ( h-y1 >= totH )
             {
                 hh += 1 ;
             if ( h-y1 >= totH )
             {
                 hh += 1 ;


@@ -1372,13 +1500,22 @@ void wxWindowMac::DoGetClientSize(int *x, int *y) const
         }
         if (m_vScrollBar  && m_vScrollBar->IsShown() )
         {
         }
         if (m_vScrollBar  && m_vScrollBar->IsShown() )
         {

-            ww -= MAC_SCROLLBAR_SIZE;
+            ww -= m_vScrollBar->GetSize().x ; // MAC_SCROLLBAR_SIZE;

             if ( w-x1 >= totW )
             {
                 ww += 1 ;
             }
         }
     }
             if ( w-x1 >= totW )
             {
                 ww += 1 ;
             }
         }
     }

+    */
+    if (m_hScrollBar  && m_hScrollBar->IsShown() )
+    {
+        hh -= m_hScrollBar->GetSize().y ; // MAC_SCROLLBAR_SIZE ;
+    }
+    if (m_vScrollBar  && m_vScrollBar->IsShown() )
+    {
+        ww -= m_vScrollBar->GetSize().x ; // MAC_SCROLLBAR_SIZE;
+    }

     if(x)   *x = ww;
     if(y)   *y = hh;
 
     if(x)   *x = ww;
     if(y)   *y = hh;
 


@@ -1402,17 +1539,17 @@ bool wxWindowMac::SetCursor(const wxCursor& cursor)
 
     wxASSERT_MSG( m_cursor.Ok(),
         wxT("cursor must be valid after call to the base version"));
 
     wxASSERT_MSG( m_cursor.Ok(),
         wxT("cursor must be valid after call to the base version"));

-    
-    
+
+

     wxWindowMac *mouseWin = 0 ;
     {
         WindowRef window = (WindowRef) MacGetTopLevelWindowRef() ;
         CGrafPtr savePort ;
         Boolean swapped = QDSwapPort( GetWindowPort( window ) , &savePort ) ;
     wxWindowMac *mouseWin = 0 ;
     {
         WindowRef window = (WindowRef) MacGetTopLevelWindowRef() ;
         CGrafPtr savePort ;
         Boolean swapped = QDSwapPort( GetWindowPort( window ) , &savePort ) ;

-        
+

         // TODO If we ever get a GetCurrentEvent.. replacement for the mouse
         // position, use it...
         // TODO If we ever get a GetCurrentEvent.. replacement for the mouse
         // position, use it...

-        
+

         Point pt ;
         GetMouse( &pt ) ;
         ControlPartCode part ;
         Point pt ;
         GetMouse( &pt ) ;
         ControlPartCode part ;


@@ -1420,7 +1557,7 @@ bool wxWindowMac::SetCursor(const wxCursor& cursor)
         control = wxMacFindControlUnderMouse( pt , window , &part ) ;
         if ( control )
             mouseWin = wxFindControlFromMacControl( control ) ;
         control = wxMacFindControlUnderMouse( pt , window , &part ) ;
         if ( control )
             mouseWin = wxFindControlFromMacControl( control ) ;

-        
+

         if ( swapped )
             QDSwapPort( savePort , NULL ) ;
     }
         if ( swapped )
             QDSwapPort( savePort , NULL ) ;
     }


@@ -1438,7 +1575,7 @@ bool wxWindowMac::DoPopupMenu(wxMenu *menu, int x, int y)
 {
     menu->SetInvokingWindow(this);
     menu->UpdateUI();
 {
     menu->SetInvokingWindow(this);
     menu->UpdateUI();

-    
+

     if ( x == -1 && y == -1 )
     {
         wxPoint mouse = wxGetMousePosition();
     if ( x == -1 && y == -1 )
     {
         wxPoint mouse = wxGetMousePosition();


@@ -1490,17 +1627,20 @@ void wxWindowMac::DoSetToolTip(wxToolTip *tooltip)
 
 void wxWindowMac::DoMoveWindow(int x, int y, int width, int height)
 {
 
 void wxWindowMac::DoMoveWindow(int x, int y, int width, int height)
 {

+    // this is never called for a toplevel window, so we know we have a parent

     int former_x , former_y , former_w, former_h ;
     int former_x , former_y , former_w, former_h ;

-#if !TARGET_API_MAC_OSX
+
+    // Get true coordinates of former position

     DoGetPosition( &former_x , &former_y ) ;
     DoGetSize( &former_w , &former_h ) ;
     DoGetPosition( &former_x , &former_y ) ;
     DoGetSize( &former_w , &former_h ) ;

-#else
-    MacGetPositionAndSizeFromControl( former_x , former_y , former_w , former_h ) ;
-    former_x -= MacGetLeftBorderSize() ;
-    former_y -= MacGetTopBorderSize() ;
-    former_w += MacGetLeftBorderSize() + MacGetRightBorderSize() ;
-    former_h += MacGetTopBorderSize() + MacGetBottomBorderSize() ;
-#endif
+
+    wxWindow *parent = GetParent();
+    if ( parent )
+    {
+        wxPoint pt(parent->GetClientAreaOrigin());
+        former_x += pt.x ;
+        former_y += pt.y ;
+    }

 
     int actualWidth = width;
     int actualHeight = height;
 
     int actualWidth = width;
     int actualHeight = height;


@@ -1534,10 +1674,48 @@ void wxWindowMac::DoMoveWindow(int x, int y, int width, int height)
         Rect r = wxMacGetBoundsForControl(this , wxPoint( actualX,actualY), wxSize( actualWidth, actualHeight ) , false ) ;
         bool vis = m_peer->IsVisible();
 
         Rect r = wxMacGetBoundsForControl(this , wxPoint( actualX,actualY), wxSize( actualWidth, actualHeight ) , false ) ;
         bool vis = m_peer->IsVisible();
 

+        int outerBorder = MacGetLeftBorderSize() ;
+        if ( m_peer->NeedsFocusRect() && m_peer->HasFocus() )
+            outerBorder += 4 ;
+
+        if ( vis && ( outerBorder > 0 ) )
+        {
+            // as the borders are drawn on the parent we have to properly invalidate all these areas
+            RgnHandle updateInner = NewRgn() , updateOuter = NewRgn() , updateTotal = NewRgn() ;
+
+            Rect rect ;
+
+            m_peer->GetRect( &rect ) ;
+            RectRgn( updateInner , &rect ) ;
+            InsetRect( &rect , -outerBorder , -outerBorder ) ;
+            RectRgn( updateOuter , &rect ) ;
+            DiffRgn( updateOuter , updateInner ,updateOuter ) ;
+            wxPoint parent(0,0);
+            GetParent()->MacWindowToRootWindow( &parent.x , &parent.y ) ;
+            parent -= GetParent()->GetClientAreaOrigin() ;
+            OffsetRgn( updateOuter , -parent.x , -parent.y ) ;
+            CopyRgn( updateOuter , updateTotal ) ;
+
+            rect = r ;
+            RectRgn( updateInner , &rect ) ;
+            InsetRect( &rect , -outerBorder , -outerBorder ) ;
+            RectRgn( updateOuter , &rect ) ;
+            DiffRgn( updateOuter , updateInner ,updateOuter ) ;
+
+            OffsetRgn( updateOuter , -parent.x , -parent.y ) ;
+            UnionRgn( updateOuter , updateTotal , updateTotal ) ;
+
+            GetParent()->m_peer->SetNeedsDisplay( true , updateTotal ) ;
+            DisposeRgn(updateOuter) ;
+            DisposeRgn(updateInner) ;
+            DisposeRgn(updateTotal) ;
+        }
+

         // the HIViewSetFrame call itself should invalidate the areas, but when testing with the UnicodeTextCtrl it does not !
         if ( vis )
             m_peer->SetVisibility( false , true ) ;
         // the HIViewSetFrame call itself should invalidate the areas, but when testing with the UnicodeTextCtrl it does not !
         if ( vis )
             m_peer->SetVisibility( false , true ) ;

-        m_peer->SetRect( &r ) ; 
+
+        m_peer->SetRect( &r ) ;

         if ( vis )
             m_peer->SetVisibility( true , true ) ;
 
         if ( vis )
             m_peer->SetVisibility( true , true ) ;
 


@@ -1565,7 +1743,7 @@ wxSize wxWindowMac::DoGetBestSize() const
 {
     if ( m_macIsUserPane || IsTopLevel() )
         return wxWindowBase::DoGetBestSize() ;
 {
     if ( m_macIsUserPane || IsTopLevel() )
         return wxWindowBase::DoGetBestSize() ;

-        
+

     Rect    bestsize = { 0 , 0 , 0 , 0 } ;
     int bestWidth, bestHeight ;
     m_peer->GetBestRect( &bestsize ) ;
     Rect    bestsize = { 0 , 0 , 0 , 0 } ;
     int bestWidth, bestHeight ;
     m_peer->GetBestRect( &bestsize ) ;


@@ -1579,13 +1757,15 @@ wxSize wxWindowMac::DoGetBestSize() const
         {
             bestsize.bottom = 16 ;
         }
         {
             bestsize.bottom = 16 ;
         }

+#if wxUSE_SPINBTN 

         else if ( IsKindOf( CLASSINFO( wxSpinButton ) ) )
         {
         else if ( IsKindOf( CLASSINFO( wxSpinButton ) ) )
         {

-            bestsize.bottom = 24 ; 
+            bestsize.bottom = 24 ;

         }
         }

+#endif // wxUSE_SPINBTN 

         else
         {
         else
         {

-            // return wxWindowBase::DoGetBestSize() ;  
+            // return wxWindowBase::DoGetBestSize() ;

         }
     }
 
         }
     }
 


@@ -1593,7 +1773,7 @@ wxSize wxWindowMac::DoGetBestSize() const
     bestHeight = bestsize.bottom - bestsize.top ;
     if ( bestHeight < 10 )
         bestHeight = 13 ;
     bestHeight = bestsize.bottom - bestsize.top ;
     if ( bestHeight < 10 )
         bestHeight = 13 ;

-        
+

     return wxSize(bestWidth, bestHeight);
 }
 
     return wxSize(bestWidth, bestHeight);
 }
 


@@ -1685,7 +1865,7 @@ wxPoint wxWindowMac::GetClientAreaOrigin() const
         m_peer->GetRect( &structure ) ;
         OffsetRect( &content , -structure.left , -structure.top ) ;
     }
         m_peer->GetRect( &structure ) ;
         OffsetRect( &content , -structure.left , -structure.top ) ;
     }

-#endif 
+#endif

 
     return wxPoint( content.left + MacGetLeftBorderSize(  ) , content.top + MacGetTopBorderSize(  ) );
 }
 
     return wxPoint( content.left + MacGetLeftBorderSize(  ) , content.top + MacGetTopBorderSize(  ) );
 }


@@ -1725,13 +1905,16 @@ bool wxWindowMac::Show(bool show)
 {
     if ( !wxWindowBase::Show(show) )
         return FALSE;
 {
     if ( !wxWindowBase::Show(show) )
         return FALSE;

-    
+

     // TODO use visibilityChanged Carbon Event for OSX
     // TODO use visibilityChanged Carbon Event for OSX

-    bool former = MacIsReallyShown() ;
-    
-    m_peer->SetVisibility( show , true ) ;
-    if ( former != MacIsReallyShown() )
-        MacPropagateVisibilityChanged() ;
+    if ( m_peer )
+    {
+        bool former = MacIsReallyShown() ;
+
+        m_peer->SetVisibility( show , true ) ;
+        if ( former != MacIsReallyShown() )
+            MacPropagateVisibilityChanged() ;
+    }

     return TRUE;
 }
 
     return TRUE;
 }
 


@@ -1749,7 +1932,7 @@ bool wxWindowMac::Enable(bool enable)
     return TRUE;
 }
 
     return TRUE;
 }
 

-//  
+//

 // status change propagations (will be not necessary for OSX later )
 //
 
 // status change propagations (will be not necessary for OSX later )
 //
 


@@ -1757,8 +1940,8 @@ void wxWindowMac::MacPropagateVisibilityChanged()
 {
 #if !TARGET_API_MAC_OSX
     MacVisibilityChanged() ;
 {
 #if !TARGET_API_MAC_OSX
     MacVisibilityChanged() ;

-    
-    wxWindowListNode *node = GetChildren().GetFirst();
+
+    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();

     while ( node )
     {
         wxWindowMac *child = node->GetData();
     while ( node )
     {
         wxWindowMac *child = node->GetData();


@@ -1773,8 +1956,8 @@ void wxWindowMac::MacPropagateEnabledStateChanged( )
 {
 #if !TARGET_API_MAC_OSX
     MacEnabledStateChanged() ;
 {
 #if !TARGET_API_MAC_OSX
     MacEnabledStateChanged() ;

-    
-    wxWindowListNode *node = GetChildren().GetFirst();
+
+    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();

     while ( node )
     {
         wxWindowMac *child = node->GetData();
     while ( node )
     {
         wxWindowMac *child = node->GetData();


@@ -1789,8 +1972,8 @@ void wxWindowMac::MacPropagateHiliteChanged( )
 {
 #if !TARGET_API_MAC_OSX
     MacHiliteChanged() ;
 {
 #if !TARGET_API_MAC_OSX
     MacHiliteChanged() ;

-    
-    wxWindowListNode *node = GetChildren().GetFirst();
+
+    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();

     while ( node )
     {
         wxWindowMac *child = node->GetData();
     while ( node )
     {
         wxWindowMac *child = node->GetData();


@@ -1803,17 +1986,17 @@ void wxWindowMac::MacPropagateHiliteChanged( )
 
 //
 // status change notifications
 
 //
 // status change notifications

-// 
+//

 
 

-void wxWindowMac::MacVisibilityChanged() 
+void wxWindowMac::MacVisibilityChanged()

 {
 }
 
 {
 }
 

-void wxWindowMac::MacHiliteChanged() 
+void wxWindowMac::MacHiliteChanged()

 {
 }
 
 {
 }
 

-void wxWindowMac::MacEnabledStateChanged() 
+void wxWindowMac::MacEnabledStateChanged()

 {
 }
 
 {
 }
 


@@ -1821,7 +2004,7 @@ void wxWindowMac::MacEnabledStateChanged()
 // status queries on the inherited window's state
 //
 
 // status queries on the inherited window's state
 //
 

-bool wxWindowMac::MacIsReallyShown() 
+bool wxWindowMac::MacIsReallyShown()

 {
     // only under OSX the visibility of the TLW is taken into account
 #if TARGET_API_MAC_OSX
 {
     // only under OSX the visibility of the TLW is taken into account
 #if TARGET_API_MAC_OSX


@@ -1833,26 +2016,26 @@ bool wxWindowMac::MacIsReallyShown()
     {
         if ( win->IsTopLevel() )
             return true ;
     {
         if ( win->IsTopLevel() )
             return true ;

-        
+

         win = win->GetParent() ;
         if ( win == NULL )
             return true ;
         win = win->GetParent() ;
         if ( win == NULL )
             return true ;

-            
+

     } ;
     return false ;
 }
 
     } ;
     return false ;
 }
 

-bool wxWindowMac::MacIsReallyEnabled() 
+bool wxWindowMac::MacIsReallyEnabled()

 {
     return m_peer->IsEnabled() ;
 }
 
 {
     return m_peer->IsEnabled() ;
 }
 

-bool wxWindowMac::MacIsReallyHilited() 
+bool wxWindowMac::MacIsReallyHilited()

 {
     return m_peer->IsActive();
 }
 
 {
     return m_peer->IsActive();
 }
 

-void wxWindowMac::MacFlashInvalidAreas() 
+void wxWindowMac::MacFlashInvalidAreas()

 {
 #if TARGET_API_MAC_OSX
     HIViewFlashDirtyArea( (WindowRef) MacGetTopLevelWindowRef() ) ;
 {
 #if TARGET_API_MAC_OSX
     HIViewFlashDirtyArea( (WindowRef) MacGetTopLevelWindowRef() ) ;


@@ -1902,17 +2085,24 @@ void wxWindowMac::GetTextExtent(const wxString& string, int *x, int *y,
 
 void wxWindowMac::Refresh(bool eraseBack, const wxRect *rect)
 {
 
 void wxWindowMac::Refresh(bool eraseBack, const wxRect *rect)
 {

+    if ( m_peer == NULL )
+        return ;
+

 #if TARGET_API_MAC_OSX
     if ( rect == NULL )
 #if TARGET_API_MAC_OSX
     if ( rect == NULL )

-        m_peer->SetNeedsDisplay( true ) ; 
+        m_peer->SetNeedsDisplay( true ) ;

     else
     {
         RgnHandle update = NewRgn() ;
         SetRectRgn( update , rect->x , rect->y , rect->x + rect->width , rect->y + rect->height ) ;
         SectRgn( (RgnHandle) MacGetVisibleRegion().GetWXHRGN() , update , update ) ;
         wxPoint origin = GetClientAreaOrigin() ;
     else
     {
         RgnHandle update = NewRgn() ;
         SetRectRgn( update , rect->x , rect->y , rect->x + rect->width , rect->y + rect->height ) ;
         SectRgn( (RgnHandle) MacGetVisibleRegion().GetWXHRGN() , update , update ) ;
         wxPoint origin = GetClientAreaOrigin() ;

-        OffsetRgn( update, origin.x , origin.y ) ;    
-        m_peer->SetNeedsDisplay( true , update) ;    
+        OffsetRgn( update, origin.x , origin.y ) ;
+        // right now this is wx' window coordinates, as our native peer does not have borders, this is
+        // inset
+        OffsetRgn( update , -MacGetLeftBorderSize() , -MacGetTopBorderSize() ) ;
+        m_peer->SetNeedsDisplay( true , update) ;
+        DisposeRgn( update ) ;

     }
 #else
 /*
     }
 #else
 /*


@@ -1924,7 +2114,7 @@ void wxWindowMac::Refresh(bool eraseBack, const wxRect *rect)
         else
         {
             SetRectRgn( updateRgn , rect->x , rect->y , rect->x + rect->width , rect->y + rect->height ) ;
         else
         {
             SetRectRgn( updateRgn , rect->x , rect->y , rect->x + rect->width , rect->y + rect->height ) ;

-            SectRgn( (RgnHandle) MacGetVisibleRegion().GetWXHRGN() , updateRgn , updateRgn ) ;        
+            SectRgn( (RgnHandle) MacGetVisibleRegion().GetWXHRGN() , updateRgn , updateRgn ) ;

         }
         InvalWindowRgn( (WindowRef) MacGetTopLevelWindowRef() , updateRgn ) ;
         DisposeRgn(updateRgn) ;
         }
         InvalWindowRgn( (WindowRef) MacGetTopLevelWindowRef() , updateRgn ) ;
         DisposeRgn(updateRgn) ;


@@ -1939,8 +2129,8 @@ void wxWindowMac::Refresh(bool eraseBack, const wxRect *rect)
         return ;
 
     if ( !m_peer->IsVisible())
         return ;
 
     if ( !m_peer->IsVisible())

-       return ;
- 
+        return ;
+

      wxPoint client = GetClientAreaOrigin();
     int x1 = -client.x;
     int y1 = -client.y;
      wxPoint client = GetClientAreaOrigin();
     int x1 = -client.x;
     int y1 = -client.y;


@@ -1982,7 +2172,8 @@ void wxWindowMac::Freeze()
 #if TARGET_API_MAC_OSX
     if ( !m_frozenness++ )
     {
 #if TARGET_API_MAC_OSX
     if ( !m_frozenness++ )
     {

-        m_peer->SetDrawingEnabled( false ) ;
+        if ( m_peer && m_peer->Ok() )
+            m_peer->SetDrawingEnabled( false ) ;

     }
 #endif
 }
     }
 #endif
 }


@@ -1995,8 +2186,11 @@ void wxWindowMac::Thaw()
 
     if ( !--m_frozenness )
     {
 
     if ( !--m_frozenness )
     {

-        m_peer->SetDrawingEnabled( true ) ;
-        m_peer->InvalidateWithChildren() ;
+        if ( m_peer && m_peer->Ok() )
+        {
+            m_peer->SetDrawingEnabled( true ) ;
+            m_peer->InvalidateWithChildren() ;
+        }

     }
 #endif
 }
     }
 #endif
 }


@@ -2018,7 +2212,7 @@ void wxWindowMac::MacRedrawControl()
     }
 */
 }
     }
 */
 }

- 
+

 /* TODO
 void wxWindowMac::OnPaint(wxPaintEvent& event)
 {
 /* TODO
 void wxWindowMac::OnPaint(wxPaintEvent& event)
 {


@@ -2040,20 +2234,21 @@ void wxWindowMac::WarpPointer (int x_pos, int y_pos)
 
 void wxWindowMac::OnEraseBackground(wxEraseEvent& event)
 {
 
 void wxWindowMac::OnEraseBackground(wxEraseEvent& event)
 {

+#if TARGET_API_MAC_OSX

     if ( m_macBackgroundBrush.Ok() == false || m_macBackgroundBrush.GetStyle() == wxTRANSPARENT )
     {
         event.Skip() ;
     }
     else
     if ( m_macBackgroundBrush.Ok() == false || m_macBackgroundBrush.GetStyle() == wxTRANSPARENT )
     {
         event.Skip() ;
     }
     else

+#endif
+    {

         event.GetDC()->Clear() ;
         event.GetDC()->Clear() ;

+    }

 }
 
 void wxWindowMac::OnNcPaint( wxNcPaintEvent& event )
 {
 }
 
 void wxWindowMac::OnNcPaint( wxNcPaintEvent& event )
 {

-    wxWindowDC dc(this) ;
-    wxMacPortSetter helper(&dc) ;
-
-    MacPaintBorders( dc.m_macLocalOrigin.x , dc.m_macLocalOrigin.y) ;
+    event.Skip() ;

 }
 
 int wxWindowMac::GetScrollPos(int orient) const
 }
 
 int wxWindowMac::GetScrollPos(int orient) const


@@ -2121,75 +2316,40 @@ void wxWindowMac::MacPaintBorders( int left , int top )
 {
     if( IsTopLevel() )
         return ;
 {
     if( IsTopLevel() )
         return ;

-        
-    int major,minor;
-    wxGetOsVersion( &major, &minor );
-
-    RGBColor darkShadow = { 0x0000, 0x0000 , 0x0000 } ;
-    RGBColor lightShadow = { 0x4444, 0x4444 , 0x4444 } ;
-    // OS X has lighter border edges than classic:
-    if (major >= 10) 
-    {
-        darkShadow.red                 = 0x8E8E;
-        darkShadow.green       = 0x8E8E;
-        darkShadow.blue        = 0x8E8E;
-        lightShadow.red        = 0xBDBD;
-        lightShadow.green      = 0xBDBD;
-        lightShadow.blue       = 0xBDBD;
-       }
-    
-    PenNormal() ;
-
-    int w , h ;
-    GetSize( &w , &h ) ;
-    Rect rect = { top , left , h + top , w + left } ;
+
+    Rect rect ;
+    m_peer->GetRect( &rect ) ;
+    InsetRect( &rect, -MacGetLeftBorderSize() , -MacGetTopBorderSize() ) ;
+
+    if ( !IsTopLevel() )
+    {
+        wxTopLevelWindowMac* top = MacGetTopLevelWindow();
+        if (top)
+        {
+            wxPoint pt(0,0) ;
+            wxMacControl::Convert( &pt , GetParent()->m_peer , top->m_peer ) ;
+            rect.left += pt.x ;
+            rect.right += pt.x ;
+            rect.top += pt.y ;
+            rect.bottom += pt.y ;
+        }
+    }
+

     if (HasFlag(wxRAISED_BORDER) || HasFlag( wxSUNKEN_BORDER) || HasFlag(wxDOUBLE_BORDER) )
     {
     if (HasFlag(wxRAISED_BORDER) || HasFlag( wxSUNKEN_BORDER) || HasFlag(wxDOUBLE_BORDER) )
     {

-#if wxMAC_USE_THEME_BORDER
+        Rect srect = rect ;

         SInt32 border = 0 ;
         GetThemeMetric( kThemeMetricEditTextFrameOutset , &border ) ;
         SInt32 border = 0 ;
         GetThemeMetric( kThemeMetricEditTextFrameOutset , &border ) ;

-        InsetRect( &rect , border , border );
-        DrawThemeEditTextFrame(&rect,IsEnabled() ? kThemeStateActive : kThemeStateInactive) ;
-#else
-        RGBColor white = { 0xFFFF, 0xFFFF , 0xFFFF } ;
-        RGBColor face = { 0xDDDD, 0xDDDD , 0xDDDD } ;
-    
-        bool sunken = HasFlag( wxSUNKEN_BORDER ) ;
-        RGBForeColor( &face );
-        MoveTo( left + 0 , top + h - 2 );
-        LineTo( left + 0 , top + 0 );
-        LineTo( left + w - 2 , top + 0 );
-
-        MoveTo( left + 2 , top + h - 3 );
-        LineTo( left + w - 3 , top + h - 3 );
-        LineTo( left + w - 3 , top + 2 );
-
-        RGBForeColor( sunken ? &face : &darkShadow );
-        MoveTo( left + 0 , top + h - 1 );
-        LineTo( left + w - 1 , top + h - 1 );
-        LineTo( left + w - 1 , top + 0 );
-
-        RGBForeColor( sunken ? &lightShadow : &white );
-        MoveTo( left + 1 , top + h - 3 );
-        LineTo( left + 1, top + 1 );
-        LineTo( left + w - 3 , top + 1 );
-
-        RGBForeColor( sunken ? &white : &lightShadow );
-        MoveTo( left + 1 , top + h - 2 );
-        LineTo( left + w - 2 , top + h - 2 );
-        LineTo( left + w - 2 , top + 1 );
-
-        RGBForeColor( sunken ? &darkShadow : &face );
-        MoveTo( left + 2 , top + h - 4 );
-        LineTo( left + 2 , top + 2 );
-        LineTo( left + w - 4 , top + 2 );
-#endif
+        InsetRect( &srect , border , border );
+        DrawThemeEditTextFrame(&srect,IsEnabled() ? kThemeStateActive : kThemeStateInactive) ;

     }
     else if (HasFlag(wxSIMPLE_BORDER))
     {
     }
     else if (HasFlag(wxSIMPLE_BORDER))
     {

-        Rect rect = { top , left , h + top , w + left } ;
-        RGBForeColor( &darkShadow ) ;
-        FrameRect( &rect ) ;
+        Rect srect = rect ;
+        SInt32 border = 0 ;
+        GetThemeMetric( kThemeMetricListBoxFrameOutset , &border ) ;
+        InsetRect( &srect , border , border );
+        DrawThemeListBoxFrame(&rect,IsEnabled() ? kThemeStateActive : kThemeStateInactive) ;

     }
 }
 
     }
 }
 


@@ -2249,7 +2409,7 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
 {
     if( dx == 0 && dy ==0 )
         return ;
 {
     if( dx == 0 && dy ==0 )
         return ;

-        
+

 
     {
 
 
     {
 


@@ -2257,10 +2417,10 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
         GetClientSize( &width , &height ) ;
 #if TARGET_API_MAC_OSX
         // note there currently is a bug in OSX which makes inefficient refreshes in case an entire control
         GetClientSize( &width , &height ) ;
 #if TARGET_API_MAC_OSX
         // note there currently is a bug in OSX which makes inefficient refreshes in case an entire control

-        // area is scrolled, this does not occur if width and height are 2 pixels less, 
+        // area is scrolled, this does not occur if width and height are 2 pixels less,

         // TODO write optimal workaround
         // TODO write optimal workaround

-        wxRect scrollrect( MacGetLeftBorderSize() , MacGetTopBorderSize()  , MacGetLeftBorderSize() + width , MacGetTopBorderSize() + height ) ;
-        if ( rect ) 
+        wxRect scrollrect( MacGetLeftBorderSize() , MacGetTopBorderSize()  , width , height ) ;
+        if ( rect )

         {
             scrollrect.Intersect( *rect ) ;
         }
         {
             scrollrect.Intersect( *rect ) ;
         }


@@ -2272,18 +2432,20 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
             // is the better overall solution, as it does not slow down scrolling
             m_peer->SetNeedsDisplay( true ) ;
 #else
             // is the better overall solution, as it does not slow down scrolling
             m_peer->SetNeedsDisplay( true ) ;
 #else

-            // this would be the preferred version for fast drawing controls       
+            // this would be the preferred version for fast drawing controls

             if( UMAGetSystemVersion() < 0x1030 )
                 Update() ;
             else
             if( UMAGetSystemVersion() < 0x1030 )
                 Update() ;
             else

-                HIViewRender(*m_peer) ;
+                HIViewRender(m_peer->GetControlRef()) ;

 #endif
         }
 #endif
         }

+        // as the native control might be not a 0/0 wx window coordinates, we have to offset
+        scrollrect.Offset( -MacGetLeftBorderSize() , -MacGetTopBorderSize() ) ;

         m_peer->ScrollRect( scrollrect , dx , dy ) ;
 #else
 
         wxPoint pos;
         m_peer->ScrollRect( scrollrect , dx , dy ) ;
 #else
 
         wxPoint pos;

-        pos.x = pos.y = 0; 
+        pos.x = pos.y = 0;

 
         Rect scrollrect;
         RgnHandle updateRgn = NewRgn() ;
 
         Rect scrollrect;
         RgnHandle updateRgn = NewRgn() ;


@@ -2291,13 +2453,13 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
        {
             wxClientDC dc(this) ;
             wxMacPortSetter helper(&dc) ;
        {
             wxClientDC dc(this) ;
             wxMacPortSetter helper(&dc) ;

-        
+

             m_peer->GetRect( &scrollrect ) ;
             scrollrect.top += MacGetTopBorderSize() ;
             scrollrect.left += MacGetLeftBorderSize() ;
             scrollrect.bottom = scrollrect.top + height ;
             scrollrect.right = scrollrect.left + width ;
             m_peer->GetRect( &scrollrect ) ;
             scrollrect.top += MacGetTopBorderSize() ;
             scrollrect.left += MacGetLeftBorderSize() ;
             scrollrect.bottom = scrollrect.top + height ;
             scrollrect.right = scrollrect.left + width ;

-            
+

             if ( rect )
             {
                 Rect r = { dc.YLOG2DEVMAC(rect->y) , dc.XLOG2DEVMAC(rect->x) , dc.YLOG2DEVMAC(rect->y + rect->height) ,
             if ( rect )
             {
                 Rect r = { dc.YLOG2DEVMAC(rect->y) , dc.XLOG2DEVMAC(rect->x) , dc.YLOG2DEVMAC(rect->y + rect->height) ,


@@ -2310,7 +2472,7 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
 #endif
     }
 
 #endif
     }
 

-    for (wxWindowListNode *node = GetChildren().GetFirst(); node; node = node->GetNext())
+    for (wxWindowList::compatibility_iterator node = GetChildren().GetFirst(); node; node = node->GetNext())

     {
         wxWindowMac *child = node->GetData();
         if (child == m_vScrollBar) continue;
     {
         wxWindowMac *child = node->GetData();
         if (child == m_vScrollBar) continue;


@@ -2329,8 +2491,8 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
         }
         else
         {
         }
         else
         {

-            child->SetSize( x+dx, y+dy, w, h );                
-        }        
+            child->SetSize( x+dx, y+dy, w, h );
+        }

     }
 }
 
     }
 }
 


@@ -2365,7 +2527,7 @@ void wxWindowMac::MacOnScroll(wxScrollEvent &event )
 }
 
 // Get the window with the focus
 }
 
 // Get the window with the focus

-wxWindowMac *wxWindowBase::FindFocus()
+wxWindowMac *wxWindowBase::DoFindFocus()

 {
     ControlRef control ;
     GetKeyboardFocus( GetUserFocusWindow() , &control ) ;
 {
     ControlRef control ;
     GetKeyboardFocus( GetUserFocusWindow() , &control ) ;


@@ -2388,8 +2550,6 @@ void wxWindowMac::OnSetFocus(wxFocusEvent& event)
     if ( MacGetTopLevelWindow() && m_peer->NeedsFocusRect() )
     {
         wxMacWindowStateSaver sv( this ) ;
     if ( MacGetTopLevelWindow() && m_peer->NeedsFocusRect() )
     {
         wxMacWindowStateSaver sv( this ) ;

-//        wxWindowDC dc(this) ;
-//        wxMacPortSetter helper(&dc) ;

 
         int w , h ;
         int x , y ;
 
         int w , h ;
         int x , y ;


@@ -2401,7 +2561,25 @@ void wxWindowMac::OnSetFocus(wxFocusEvent& event)
         if ( event.GetEventType() == wxEVT_SET_FOCUS )
             DrawThemeFocusRect( &rect , true ) ;
         else
         if ( event.GetEventType() == wxEVT_SET_FOCUS )
             DrawThemeFocusRect( &rect , true ) ;
         else

+        {

             DrawThemeFocusRect( &rect , false ) ;
             DrawThemeFocusRect( &rect , false ) ;

+
+            // as this erases part of the frame we have to redraw borders
+            // and because our z-ordering is not always correct (staticboxes)
+            // we have to invalidate things, we cannot simple redraw
+            RgnHandle updateInner = NewRgn() , updateOuter = NewRgn() ;
+            RectRgn( updateInner , &rect ) ;
+            InsetRect( &rect , -4 , -4 ) ;
+            RectRgn( updateOuter , &rect ) ;
+            DiffRgn( updateOuter , updateInner ,updateOuter ) ;
+            wxPoint parent(0,0);
+            GetParent()->MacWindowToRootWindow( &parent.x , &parent.y ) ;
+            parent -= GetParent()->GetClientAreaOrigin() ;
+            OffsetRgn( updateOuter , -parent.x , -parent.y ) ;
+            GetParent()->m_peer->SetNeedsDisplay( true , updateOuter ) ;
+            DisposeRgn(updateOuter) ;
+            DisposeRgn(updateInner) ;
+        }

     }
 
     event.Skip();
     }
 
     event.Skip();


@@ -2484,13 +2662,15 @@ wxString wxWindowMac::MacGetToolTipString( wxPoint &pt )
 void wxWindowMac::Update()
 {
 #if TARGET_API_MAC_OSX
 void wxWindowMac::Update()
 {
 #if TARGET_API_MAC_OSX

-    WindowRef window = (WindowRef)MacGetTopLevelWindowRef() ;
+

 #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_3
 #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_3

+    WindowRef window = (WindowRef)MacGetTopLevelWindowRef() ;
+

     // for composited windows this also triggers a redraw of all
     // invalid views in the window
     if( UMAGetSystemVersion() >= 0x1030 )
     // for composited windows this also triggers a redraw of all
     // invalid views in the window
     if( UMAGetSystemVersion() >= 0x1030 )

-        HIWindowFlush(window) ;       
-    else                   
+        HIWindowFlush(window) ;
+    else

 #endif
     {
         // the only way to trigger the redrawing on earlier systems is to call
 #endif
     {
         // the only way to trigger the redrawing on earlier systems is to call


@@ -2503,7 +2683,7 @@ void wxWindowMac::Update()
         {
             currentEventClass = ::GetEventClass( currentEvent ) ;
             currentEventKind = ::GetEventKind( currentEvent ) ;
         {
             currentEventClass = ::GetEventClass( currentEvent ) ;
             currentEventKind = ::GetEventKind( currentEvent ) ;

-        }       
+        }

         if ( currentEventClass != kEventClassMenu )
         {
             // when tracking a menu, strange redraw errors occur if we flush now, so leave..
         if ( currentEventClass != kEventClassMenu )
         {
             // when tracking a menu, strange redraw errors occur if we flush now, so leave..


@@ -2532,6 +2712,10 @@ wxTopLevelWindowMac* wxWindowMac::MacGetTopLevelWindow() const
 }
 wxRegion wxWindowMac::MacGetVisibleRegion( bool includeOuterStructures )
 {
 }
 wxRegion wxWindowMac::MacGetVisibleRegion( bool includeOuterStructures )
 {

+    // includeOuterStructures is true if we try to draw somthing like a focus ring etc.
+    // also a window dc uses this, in this case we only clip in the hierarchy for hard
+    // borders like a scrollwindow, splitter etc otherwise we end up in a paranoia having
+    // to add focus borders everywhere

 
     Rect r ;
     RgnHandle visRgn = NewRgn() ;
 
     Rect r ;
     RgnHandle visRgn = NewRgn() ;


@@ -2543,7 +2727,7 @@ wxRegion wxWindowMac::MacGetVisibleRegion( bool includeOuterStructures )
         r.top -= MacGetTopBorderSize() ;
         r.bottom += MacGetBottomBorderSize() ;
         r.right += MacGetRightBorderSize() ;
         r.top -= MacGetTopBorderSize() ;
         r.bottom += MacGetBottomBorderSize() ;
         r.right += MacGetRightBorderSize() ;

-        
+

         if (! MacGetTopLevelWindow()->MacUsesCompositing() )
         {
             MacRootWindowToWindow( &r.left , & r.top ) ;
         if (! MacGetTopLevelWindow()->MacUsesCompositing() )
         {
             MacRootWindowToWindow( &r.left , & r.top ) ;


@@ -2557,8 +2741,9 @@ wxRegion wxWindowMac::MacGetVisibleRegion( bool includeOuterStructures )
             r.top = 0 ;
         }
         if ( includeOuterStructures )
             r.top = 0 ;
         }
         if ( includeOuterStructures )

-            InsetRect( &r , -3 , -3 ) ;
+            InsetRect( &r , -4 , -4 ) ;

         RectRgn( visRgn , &r ) ;
         RectRgn( visRgn , &r ) ;

+

         if ( !IsTopLevel() )
         {
             wxWindow* child = this ;
         if ( !IsTopLevel() )
         {
             wxWindow* child = this ;


@@ -2584,12 +2769,18 @@ wxRegion wxWindowMac::MacGetVisibleRegion( bool includeOuterStructures )
                 parent->MacWindowToRootWindow( &x, &y ) ;
                 MacRootWindowToWindow( &x , &y ) ;
 
                 parent->MacWindowToRootWindow( &x, &y ) ;
                 MacRootWindowToWindow( &x , &y ) ;
 

-                SetRectRgn( tempRgn ,
-                    x + parent->MacGetLeftBorderSize() , y + parent->MacGetTopBorderSize() ,
-                    x + size.x - parent->MacGetRightBorderSize(),
-                    y + size.y - parent->MacGetBottomBorderSize()) ;
+                if ( !includeOuterStructures || (
+                    parent->MacClipChildren() ||
+                    ( parent->GetParent() && parent->GetParent()->MacClipGrandChildren() )
+                    ) )
+                {
+                    SetRectRgn( tempRgn ,
+                        x + parent->MacGetLeftBorderSize() , y + parent->MacGetTopBorderSize() ,
+                        x + size.x - parent->MacGetRightBorderSize(),
+                        y + size.y - parent->MacGetBottomBorderSize()) ;

 
 

-                SectRgn( visRgn , tempRgn , visRgn ) ;
+                    SectRgn( visRgn , tempRgn , visRgn ) ;
+                }

                 if ( parent->IsTopLevel() )
                     break ;
                 child = parent ;
                 if ( parent->IsTopLevel() )
                     break ;
                 child = parent ;


@@ -2607,45 +2798,100 @@ wxRegion wxWindowMac::MacGetVisibleRegion( bool includeOuterStructures )
 /*
     This function must not change the updatergn !
  */
 /*
     This function must not change the updatergn !
  */

-bool wxWindowMac::MacDoRedraw( WXHRGN updatergnr , long time ) 
+bool wxWindowMac::MacDoRedraw( WXHRGN updatergnr , long time )

 {
     RgnHandle updatergn = (RgnHandle) updatergnr ;
     bool handled = false ;
 {
     RgnHandle updatergn = (RgnHandle) updatergnr ;
     bool handled = false ;

-    
-    // calculate a client-origin version of the update rgn and set m_updateRegion to that
+    Rect updatebounds ;
+    GetRegionBounds( updatergn , &updatebounds ) ;
+//    wxLogDebug("update for %s bounds %d , %d , %d , %d",typeid(*this).name() , updatebounds.left , updatebounds.top , updatebounds.right , updatebounds.bottom ) ;
+    if ( !EmptyRgn(updatergn) )

     {
         RgnHandle newupdate = NewRgn() ;
         wxSize point = GetClientSize() ;
         wxPoint origin = GetClientAreaOrigin() ;
         SetRectRgn( newupdate , origin.x , origin.y , origin.x + point.x , origin.y+point.y ) ;
         SectRgn( newupdate , updatergn , newupdate ) ;
     {
         RgnHandle newupdate = NewRgn() ;
         wxSize point = GetClientSize() ;
         wxPoint origin = GetClientAreaOrigin() ;
         SetRectRgn( newupdate , origin.x , origin.y , origin.x + point.x , origin.y+point.y ) ;
         SectRgn( newupdate , updatergn , newupdate ) ;

+
+        // first send an erase event to the entire update area
+        {
+            wxWindowDC dc(this);
+            dc.SetClippingRegion(wxRegion(updatergn));
+            wxEraseEvent eevent( GetId(), &dc );
+            eevent.SetEventObject( this );
+            GetEventHandler()->ProcessEvent( eevent );
+        }
+
+        // calculate a client-origin version of the update rgn and set m_updateRegion to that

         OffsetRgn( newupdate , -origin.x , -origin.y ) ;
         m_updateRegion = newupdate ;
         OffsetRgn( newupdate , -origin.x , -origin.y ) ;
         m_updateRegion = newupdate ;

-        DisposeRgn( newupdate ) ; 
-    }
+        DisposeRgn( newupdate ) ;

 
 

-    if ( !EmptyRgn(updatergn) )
-    {
-        wxWindowDC dc(this);
-        if (!EmptyRgn(updatergn))
-            dc.SetClippingRegion(wxRegion(updatergn));
-        
-        wxEraseEvent eevent( GetId(), &dc );
-        eevent.SetEventObject( this );
-        GetEventHandler()->ProcessEvent( eevent );
- 

         if ( !m_updateRegion.Empty() )
         {
             // paint the window itself
             wxPaintEvent event;
             event.m_timeStamp = time ;
             event.SetEventObject(this);
         if ( !m_updateRegion.Empty() )
         {
             // paint the window itself
             wxPaintEvent event;
             event.m_timeStamp = time ;
             event.SetEventObject(this);

-            handled = GetEventHandler()->ProcessEvent(event); 
+            handled = GetEventHandler()->ProcessEvent(event);
+
+            // we have to call the default built-in handler, as otherwise our frames will be drawn and immediately erased afterwards
+            if ( !handled )
+            {
+                if ( wxTheApp->MacGetCurrentEvent() != NULL && wxTheApp->MacGetCurrentEventHandlerCallRef() != NULL )
+                {
+                    CallNextEventHandler((EventHandlerCallRef)wxTheApp->MacGetCurrentEventHandlerCallRef() , (EventRef) wxTheApp->MacGetCurrentEvent() ) ;
+                    handled = true ;
+                }
+            }
+
+        }
+
+        // now we cannot rely on having its borders drawn by a window itself, as it does not
+        // get the updateRgn wide enough to always do so, so we do it from the parent
+        // this would also be the place to draw any custom backgrounds for native controls
+        // in Composited windowing
+        wxPoint clientOrigin = GetClientAreaOrigin() ;

 
 

-            // paint custom borders
-            wxNcPaintEvent eventNc( GetId() );
-            eventNc.SetEventObject( this );
-            GetEventHandler()->ProcessEvent( eventNc );
+        for (wxWindowList::compatibility_iterator node = GetChildren().GetFirst(); node; node = node->GetNext())
+        {
+            wxWindowMac *child = node->GetData();
+            if (child == m_vScrollBar) continue;
+            if (child == m_hScrollBar) continue;
+            if (child->IsTopLevel()) continue;
+            if (!child->IsShown()) continue;
+
+            int x,y;
+            child->GetPosition( &x, &y );
+            int w,h;
+            child->GetSize( &w, &h );
+            Rect childRect = { y , x , y + h , x + w } ;
+            OffsetRect( &childRect , clientOrigin.x , clientOrigin.y ) ;
+            if ( child->MacGetTopBorderSize() )
+            {
+                if ( RectInRgn( &childRect , updatergn ) )
+                {
+                    // paint custom borders
+                    wxNcPaintEvent eventNc( child->GetId() );
+                    eventNc.SetEventObject( child );
+                    if ( !child->GetEventHandler()->ProcessEvent( eventNc ) )
+                    {
+                        wxWindowDC dc(this) ;
+                        dc.SetClippingRegion(wxRegion(updatergn));
+                        wxMacPortSetter helper(&dc) ;
+                        child->MacPaintBorders( dc.m_macLocalOrigin.x + childRect.left , dc.m_macLocalOrigin.y + childRect.top)  ;
+                    }
+                }
+            }
+            if ( child->m_peer->NeedsFocusRect() && child->m_peer->HasFocus() )
+            {
+                wxWindowDC dc(this) ;
+                dc.SetClippingRegion(wxRegion(updatergn));
+                wxMacPortSetter helper(&dc) ;
+                Rect r = childRect ;
+                OffsetRect( &r , dc.m_macLocalOrigin.x , dc.m_macLocalOrigin.y ) ;
+                DrawThemeFocusRect( &r , true ) ;
+            }

         }
     }
     return handled ;
         }
     }
     return handled ;


@@ -2665,20 +2911,20 @@ void wxWindowMac::MacRedraw( WXHRGN updatergnr , long time, bool erase)
     CopyRgn( updatergn , ownUpdateRgn ) ;
 
     if ( MacGetTopLevelWindow()->MacUsesCompositing() == false )
     CopyRgn( updatergn , ownUpdateRgn ) ;
 
     if ( MacGetTopLevelWindow()->MacUsesCompositing() == false )

-    { 
+    {

         Rect bounds;
         m_peer->GetRectInWindowCoords( &bounds );
         RgnHandle controlRgn = NewRgn();
         RectRgn( controlRgn, &bounds );
         //KO: This sets the ownUpdateRgn to the area of this control that is inside
         // the window update region
         Rect bounds;
         m_peer->GetRectInWindowCoords( &bounds );
         RgnHandle controlRgn = NewRgn();
         RectRgn( controlRgn, &bounds );
         //KO: This sets the ownUpdateRgn to the area of this control that is inside
         // the window update region

-        SectRgn( ownUpdateRgn, controlRgn, ownUpdateRgn ); 
+        SectRgn( ownUpdateRgn, controlRgn, ownUpdateRgn );

         DisposeRgn( controlRgn );
         DisposeRgn( controlRgn );

-    
+

         //KO: convert ownUpdateRgn to local coordinates
         //KO: convert ownUpdateRgn to local coordinates

-        OffsetRgn( ownUpdateRgn, -bounds.left, -bounds.top ); 
+        OffsetRgn( ownUpdateRgn, -bounds.left, -bounds.top );

     }
     }

-        
+

     MacDoRedraw( ownUpdateRgn , time ) ;
     DisposeRgn( ownUpdateRgn ) ;
 
     MacDoRedraw( ownUpdateRgn , time ) ;
     DisposeRgn( ownUpdateRgn ) ;
 


@@ -2703,36 +2949,40 @@ void wxWindowMac::MacCreateScrollBars( long style )
 {
     wxASSERT_MSG( m_vScrollBar == NULL && m_hScrollBar == NULL , wxT("attempt to create window twice") ) ;
 
 {
     wxASSERT_MSG( m_vScrollBar == NULL && m_hScrollBar == NULL , wxT("attempt to create window twice") ) ;
 

-    bool hasBoth = ( style & wxVSCROLL ) && ( style & wxHSCROLL ) ;
-    int adjust = hasBoth ? MAC_SCROLLBAR_SIZE - 1: 0 ;
-    int width, height ;
-    GetClientSize( &width , &height ) ;
+    if ( style & ( wxVSCROLL | wxHSCROLL ) )
+    {
+        bool hasBoth = ( style & wxVSCROLL ) && ( style & wxHSCROLL ) ;
+        int scrlsize = MAC_SCROLLBAR_SIZE ;
+        wxWindowVariant variant = wxWINDOW_VARIANT_NORMAL ;
+        if ( GetWindowVariant() == wxWINDOW_VARIANT_SMALL || GetWindowVariant() == wxWINDOW_VARIANT_MINI )
+        {
+            scrlsize = MAC_SMALL_SCROLLBAR_SIZE ;
+            variant = wxWINDOW_VARIANT_SMALL ;
+        }

 
 

-    wxPoint vPoint(width-MAC_SCROLLBAR_SIZE, 0) ;
-    wxSize vSize(MAC_SCROLLBAR_SIZE, height - adjust) ;
-    wxPoint hPoint(0 , height-MAC_SCROLLBAR_SIZE ) ;
-    wxSize hSize( width - adjust, MAC_SCROLLBAR_SIZE) ;
+        int adjust = hasBoth ? scrlsize - 1: 0 ;
+        int width, height ;
+        GetClientSize( &width , &height ) ;

 
 

-    m_vScrollBar = new wxScrollBar(this, wxWINDOW_VSCROLL, vPoint,
-        vSize , wxVERTICAL);
+        wxPoint vPoint(width-scrlsize, 0) ;
+        wxSize vSize(scrlsize, height - adjust) ;
+        wxPoint hPoint(0 , height-scrlsize ) ;
+        wxSize hSize( width - adjust, scrlsize) ;

 
 

-    if ( style & wxVSCROLL )
-    {

 
 

+        if ( style & wxVSCROLL )
+        {
+            m_vScrollBar = new wxScrollBar(this, wxWINDOW_VSCROLL, vPoint,
+                vSize , wxVERTICAL);
+        }
+
+        if ( style  & wxHSCROLL )
+        {
+            m_hScrollBar = new wxScrollBar(this, wxWINDOW_HSCROLL, hPoint,
+                hSize , wxHORIZONTAL);
+        }

     }
     }

-    else
-    {
-        m_vScrollBar->Show(false) ;
-    }
-    m_hScrollBar = new wxScrollBar(this, wxWINDOW_HSCROLL, hPoint,
-        hSize , wxHORIZONTAL);
-    if ( style  & wxHSCROLL )
-    {
-    }
-    else
-    {
-        m_hScrollBar->Show(false) ;
-    }
+

 
     // because the create does not take into account the client area origin
     MacRepositionScrollBars() ; // we might have a real position shift
 
     // because the create does not take into account the client area origin
     MacRepositionScrollBars() ; // we might have a real position shift


@@ -2740,8 +2990,12 @@ void wxWindowMac::MacCreateScrollBars( long style )
 
 void wxWindowMac::MacRepositionScrollBars()
 {
 
 void wxWindowMac::MacRepositionScrollBars()
 {

+    if ( !m_hScrollBar && !m_vScrollBar )
+        return ;
+

     bool hasBoth = ( m_hScrollBar && m_hScrollBar->IsShown()) && ( m_vScrollBar && m_vScrollBar->IsShown()) ;
     bool hasBoth = ( m_hScrollBar && m_hScrollBar->IsShown()) && ( m_vScrollBar && m_vScrollBar->IsShown()) ;

-    int adjust = hasBoth ? MAC_SCROLLBAR_SIZE - 1 : 0 ;
+    int scrlsize = m_hScrollBar ? m_hScrollBar->GetSize().y : ( m_vScrollBar ? m_vScrollBar->GetSize().x : MAC_SCROLLBAR_SIZE ) ;
+    int adjust = hasBoth ? scrlsize - 1 : 0 ;

 
     // get real client area
 
 
     // get real client area
 


@@ -2756,7 +3010,7 @@ void wxWindowMac::MacRepositionScrollBars()
     wxSize vSize(MAC_SCROLLBAR_SIZE, height - adjust) ;
     wxPoint hPoint(0 , height-MAC_SCROLLBAR_SIZE ) ;
     wxSize hSize( width - adjust, MAC_SCROLLBAR_SIZE) ;
     wxSize vSize(MAC_SCROLLBAR_SIZE, height - adjust) ;
     wxPoint hPoint(0 , height-MAC_SCROLLBAR_SIZE ) ;
     wxSize hSize( width - adjust, MAC_SCROLLBAR_SIZE) ;

-
+/*

     int x = 0 ;
     int y = 0 ;
     int w ;
     int x = 0 ;
     int y = 0 ;
     int w ;


@@ -2802,7 +3056,7 @@ void wxWindowMac::MacRepositionScrollBars()
         vSize.y += 1 ;
         hPoint.y += 1 ;
     }
         vSize.y += 1 ;
         hPoint.y += 1 ;
     }

-
+*/

     if ( m_vScrollBar )
     {
         m_vScrollBar->SetSize( vPoint.x , vPoint.y, vSize.x, vSize.y , wxSIZE_ALLOW_MINUS_ONE);
     if ( m_vScrollBar )
     {
         m_vScrollBar->SetSize( vPoint.x , vPoint.y, vSize.x, vSize.y , wxSIZE_ALLOW_MINUS_ONE);


@@ -2822,7 +3076,7 @@ void wxWindowMac::MacSuperChangedPosition()
 {
     // only window-absolute structures have to be moved i.e. controls
 
 {
     // only window-absolute structures have to be moved i.e. controls
 

-    wxWindowListNode *node = GetChildren().GetFirst();
+    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();

     while ( node )
     {
         wxWindowMac *child = node->GetData();
     while ( node )
     {
         wxWindowMac *child = node->GetData();


@@ -2835,7 +3089,7 @@ void wxWindowMac::MacTopLevelWindowChangedPosition()
 {
     // only screen-absolute structures have to be moved i.e. glcanvas
 
 {
     // only screen-absolute structures have to be moved i.e. glcanvas
 

-    wxWindowListNode *node = GetChildren().GetFirst();
+    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();

     while ( node )
     {
         wxWindowMac *child = node->GetData();
     while ( node )
     {
         wxWindowMac *child = node->GetData();


@@ -2852,17 +3106,11 @@ long wxWindowMac::MacGetLeftBorderSize( ) const
     if (m_windowStyle & wxRAISED_BORDER || m_windowStyle & wxSUNKEN_BORDER )
     {
         SInt32 border = 3 ;
     if (m_windowStyle & wxRAISED_BORDER || m_windowStyle & wxSUNKEN_BORDER )
     {
         SInt32 border = 3 ;

-#if 0 // wxMAC_USE_THEME_BORDER
-          GetThemeMetric( kThemeMetricListBoxFrameOutset , &border ) ;
-#endif

           return border ;
     }
     else if (  m_windowStyle &wxDOUBLE_BORDER)
     {
           SInt32 border = 3 ;
           return border ;
     }
     else if (  m_windowStyle &wxDOUBLE_BORDER)
     {
           SInt32 border = 3 ;

-#if 0 // wxMAC_USE_THEME_BORDER
-          GetThemeMetric( kThemeMetricEditTextFrameOutset , &border ) ;
-#endif

           return border ;
     }
     else if (m_windowStyle &wxSIMPLE_BORDER)
           return border ;
     }
     else if (m_windowStyle &wxSIMPLE_BORDER)


@@ -2892,7 +3140,7 @@ long wxWindowMac::MacGetBottomBorderSize( ) const
 
 long wxWindowMac::MacRemoveBordersFromStyle( long style )
 {
 
 long wxWindowMac::MacRemoveBordersFromStyle( long style )
 {

-    return style & ~( wxDOUBLE_BORDER | wxSUNKEN_BORDER | wxRAISED_BORDER | wxBORDER | wxSTATIC_BORDER ) ;
+    return style & ~wxBORDER_MASK ;

 }
 
 // Find the wxWindowMac at the current mouse position, returning the mouse
 }
 
 // Find the wxWindowMac at the current mouse position, returning the mouse


@@ -2914,9 +3162,9 @@ wxPoint wxGetMousePosition()
 
 void wxWindowMac::OnMouseEvent( wxMouseEvent &event )
 {
 
 void wxWindowMac::OnMouseEvent( wxMouseEvent &event )
 {

-       if ( event.GetEventType() == wxEVT_RIGHT_DOWN )
-       {
-               // copied from wxGTK : CS
+    if ( event.GetEventType() == wxEVT_RIGHT_DOWN )
+    {
+        // copied from wxGTK : CS

         // generate a "context menu" event: this is similar to wxEVT_RIGHT_DOWN
         // except that:
         //
         // generate a "context menu" event: this is similar to wxEVT_RIGHT_DOWN
         // except that:
         //


@@ -2928,27 +3176,27 @@ void wxWindowMac::OnMouseEvent( wxMouseEvent &event )
                                   this->ClientToScreen(event.GetPosition()));
         if ( ! GetEventHandler()->ProcessEvent(evtCtx) )
             event.Skip() ;
                                   this->ClientToScreen(event.GetPosition()));
         if ( ! GetEventHandler()->ProcessEvent(evtCtx) )
             event.Skip() ;

-       }
+    }

     else
     {
     else
     {

-       event.Skip() ;
+        event.Skip() ;

     }
 }
 
     }
 }
 

-void wxWindowMac::MacHandleControlClick( WXWidget control , wxInt16 controlpart , bool WXUNUSED( mouseStillDown ) ) 
+void wxWindowMac::MacHandleControlClick( WXWidget control , wxInt16 controlpart , bool WXUNUSED( mouseStillDown ) )

 {
 }
 
 {
 }
 

-Rect wxMacGetBoundsForControl( wxWindow* window , const wxPoint& pos , const wxSize &size , bool adjustForOrigin ) 
+Rect wxMacGetBoundsForControl( wxWindow* window , const wxPoint& pos , const wxSize &size , bool adjustForOrigin )

 {
     int x ,y , w ,h ;
 {
     int x ,y , w ,h ;

-    
+

     window->MacGetBoundsForControl( pos , size , x , y, w, h , adjustForOrigin) ;
     Rect bounds =  { y , x , y+h , x+w  };
     return bounds ;
 }
 
     window->MacGetBoundsForControl( pos , size , x , y, w, h , adjustForOrigin) ;
     Rect bounds =  { y , x , y+h , x+w  };
     return bounds ;
 }
 

-wxInt32 wxWindowMac::MacControlHit(WXEVENTHANDLERREF WXUNUSED(handler) , WXEVENTREF WXUNUSED(event) ) 
+wxInt32 wxWindowMac::MacControlHit(WXEVENTHANDLERREF WXUNUSED(handler) , WXEVENTREF WXUNUSED(event) )

 {
     return eventNotHandledErr ;
 }
 {
     return eventNotHandledErr ;
 }