use WX_FORWARD_STD_METHODS_TO_SUBWINDOWS

[wxWidgets.git] / src / xml / xml.cpp

diff --git a/src/xml/xml.cpp b/src/xml/xml.cpp
index ab40593bede751e0241b07634062c65743a82d35..f55ad6f7a1ead4267637837e5c6d404e57556588 100644 (file)
--- a/src/xml/xml.cpp
+++ b/src/xml/xml.cpp
@@ -156,8 +156,8 @@ wxString wxXmlNode::GetPropVal(const wxString& propName, const wxString& default
     wxString tmp;
     if (GetPropVal(propName, &tmp))
         return tmp;
     wxString tmp;
     if (GetPropVal(propName, &tmp))
         return tmp;

-    else
-        return defaultVal;
+
+    return defaultVal;

 }
 
 void wxXmlNode::AddChild(wxXmlNode *child)
 }
 
 void wxXmlNode::AddChild(wxXmlNode *child)


@@ -370,7 +370,7 @@ inline static wxString CharToString(wxMBConv *conv,
         return str;
     }
     else
         return str;
     }
     else

-        return wxString(s, len);
+        return wxString(s, len != wxSTRING_MAXLEN ? len : strlen(s));

 #endif
 }
 
 #endif
 }
 


@@ -482,7 +482,8 @@ static int UnknownEncodingHnd(void * WXUNUSED(encodingHandlerData),
     // We must build conversion table for expat. The easiest way to do so
     // is to let wxCSConv convert as string containing all characters to
     // wide character representation:
     // We must build conversion table for expat. The easiest way to do so
     // is to let wxCSConv convert as string containing all characters to
     // wide character representation:

-    wxCSConv conv(wxString(name, wxConvLibc));
+    wxString str(name, wxConvLibc);
+    wxCSConv conv(str);

     char mbBuf[2];
     wchar_t wcBuf[10];
     size_t i;
     char mbBuf[2];
     wchar_t wcBuf[10];
     size_t i;


@@ -499,7 +500,7 @@ static int UnknownEncodingHnd(void * WXUNUSED(encodingHandlerData),
         }
         info->map[i+1] = (int)wcBuf[0];
     }
         }
         info->map[i+1] = (int)wcBuf[0];
     }

-    
+

     info->data = NULL;
     info->convert = NULL;
     info->release = NULL;
     info->data = NULL;
     info->convert = NULL;
     info->release = NULL;


@@ -584,7 +585,12 @@ bool wxXmlDocument::Load(wxInputStream& stream, const wxString& encoding)
 
 // write string to output:
 inline static void OutputString(wxOutputStream& stream, const wxString& str,
 
 // write string to output:
 inline static void OutputString(wxOutputStream& stream, const wxString& str,

-                                wxMBConv *convMem, wxMBConv *convFile)
+#if wxUSE_UNICODE
+    wxMBConv * WXUNUSED(convMem),
+#else
+    wxMBConv *convMem,
+#endif
+    wxMBConv *convFile)

 {
     if (str.IsEmpty()) return;
 #if wxUSE_UNICODE
 {
     if (str.IsEmpty()) return;
 #if wxUSE_UNICODE


@@ -604,7 +610,8 @@ inline static void OutputString(wxOutputStream& stream, const wxString& str,
 // Same as above, but create entities first.
 // Translates '<' to "&lt;", '>' to "&gt;" and '&' to "&amp;"
 static void OutputStringEnt(wxOutputStream& stream, const wxString& str,
 // Same as above, but create entities first.
 // Translates '<' to "&lt;", '>' to "&gt;" and '&' to "&amp;"
 static void OutputStringEnt(wxOutputStream& stream, const wxString& str,

-                            wxMBConv *convMem, wxMBConv *convFile)
+                            wxMBConv *convMem, wxMBConv *convFile,
+                            bool escapeQuotes = false)

 {
     wxString buf;
     size_t i, last, len;
 {
     wxString buf;
     size_t i, last, len;


@@ -616,7 +623,8 @@ static void OutputStringEnt(wxOutputStream& stream, const wxString& str,
     {
         c = str.GetChar(i);
         if (c == wxT('<') || c == wxT('>') ||
     {
         c = str.GetChar(i);
         if (c == wxT('<') || c == wxT('>') ||

-            (c == wxT('&') && str.Mid(i+1, 4) != wxT("amp;")))
+            (c == wxT('&') && str.Mid(i+1, 4) != wxT("amp;")) ||
+            (escapeQuotes && c == wxT('"')))

         {
             OutputString(stream, str.Mid(last, i - last), convMem, convFile);
             switch (c)
         {
             OutputString(stream, str.Mid(last, i - last), convMem, convFile);
             switch (c)


@@ -630,6 +638,9 @@ static void OutputStringEnt(wxOutputStream& stream, const wxString& str,
                 case wxT('&'):
                     OutputString(stream, wxT("&amp;"), NULL, NULL);
                     break;
                 case wxT('&'):
                     OutputString(stream, wxT("&amp;"), NULL, NULL);
                     break;

+                case wxT('"'):
+                    OutputString(stream, wxT("&quot;"), NULL, NULL);
+                    break;

                 default: break;
             }
             last = i + 1;
                 default: break;
             }
             last = i + 1;


@@ -665,10 +676,11 @@ static void OutputNode(wxOutputStream& stream, wxXmlNode *node, int indent,
             prop = node->GetProperties();
             while (prop)
             {
             prop = node->GetProperties();
             while (prop)
             {

-                OutputString(stream, wxT(" ") + prop->GetName() +
-                             wxT("=\"") + prop->GetValue() + wxT("\""),
+                OutputString(stream, wxT(" ") + prop->GetName() +  wxT("=\""),

                              NULL, NULL);
                              NULL, NULL);

-                // FIXME - what if prop contains '"'?
+                OutputStringEnt(stream, prop->GetValue(), NULL, NULL,
+                                true/*escapeQuotes*/);
+                OutputString(stream, wxT("\""), NULL, NULL);

                 prop = prop->GetNext();
             }
 
                 prop = prop->GetNext();
             }