deleted unused variable

[wxWidgets.git] / src / mac / carbon / listbox.cpp

diff --git a/src/mac/carbon/listbox.cpp b/src/mac/carbon/listbox.cpp
index 8c2e856246e326725ba43e0fdb1165036ac581f7..9daaf275e82b77581269dbbd28b1698d24d3a1b7 100644 (file)
--- a/src/mac/carbon/listbox.cpp
+++ b/src/mac/carbon/listbox.cpp
@@ -1,11 +1,11 @@
 ///////////////////////////////////////////////////////////////////////////////
 // Name:        listbox.cpp
 // Purpose:     wxListBox
 ///////////////////////////////////////////////////////////////////////////////
 // Name:        listbox.cpp
 // Purpose:     wxListBox

-// Author:      AUTHOR
+// Author:      Stefan Csomor

 // Modified by:
 // Modified by:

-// Created:     ??/??/98
+// Created:     1998-01-01

 // RCS-ID:      $Id$
 // RCS-ID:      $Id$

-// Copyright:   (c) AUTHOR
+// Copyright:   (c) Stefan Csomor

 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 


@@ -24,11 +24,11 @@
 #include "wx/utils.h"
 
 #if !USE_SHARED_LIBRARY
 #include "wx/utils.h"
 
 #if !USE_SHARED_LIBRARY

-  IMPLEMENT_DYNAMIC_CLASS(wxListBox, wxControl)
+IMPLEMENT_DYNAMIC_CLASS(wxListBox, wxControl)

 
 BEGIN_EVENT_TABLE(wxListBox, wxControl)
 
 BEGIN_EVENT_TABLE(wxListBox, wxControl)

-       EVT_SIZE( wxListBox::OnSize )
-       EVT_CHAR( wxListBox::OnChar )
+    EVT_SIZE( wxListBox::OnSize )
+    EVT_CHAR( wxListBox::OnChar )

 END_EVENT_TABLE()
 #endif
 
 END_EVENT_TABLE()
 #endif
 


@@ -43,8 +43,8 @@ END_EVENT_TABLE()
 #endif
 
 typedef struct {
 #endif
 
 typedef struct {

- unsigned short instruction;
- void (*function)();
+    unsigned short instruction;
+    void (*function)();

 } ldefRec, *ldefPtr, **ldefHandle;
 
 #if PRAGMA_STRUCT_ALIGN
 } ldefRec, *ldefPtr, **ldefHandle;
 
 #if PRAGMA_STRUCT_ALIGN


@@ -77,96 +77,108 @@ static pascal void wxMacListDefinition( short message, Boolean isSelected, Rect
     RgnHandle savedClipRegion;
     SInt32 savedPenMode;
     wxListBox*          list;
     RgnHandle savedClipRegion;
     SInt32 savedPenMode;
     wxListBox*          list;

-  GetPort(&savePort);
-  SetPort((**listHandle).port);
-  grafPtr = (**listHandle).port ;
+    GetPort(&savePort);
+    SetPort((**listHandle).port);
+    grafPtr = (**listHandle).port ;

     // typecast our refCon
     list = (wxListBox*) GetControlReference( (ControlHandle) GetListRefCon(listHandle) );
     // typecast our refCon
     list = (wxListBox*) GetControlReference( (ControlHandle) GetListRefCon(listHandle) );

-
+    

     //  Calculate the cell rect.
     //  Calculate the cell rect.

-
+    

     switch( message ) {
     switch( message ) {

-        case lInitMsg:
-            break;
-
-        case lCloseMsg:
-            break;
-
-        case lDrawMsg:
+    case lInitMsg:
+        break;
+        
+    case lCloseMsg:
+        break;
+        
+    case lDrawMsg:

         {
         {

-            const wxString text = list->m_stringArray[cell.v] ;
-
+            const wxString linetext = list->m_stringArray[cell.v] ;
+            

             //  Save the current clip region, and set the clip region to the area we are about
             //  to draw.
             //  Save the current clip region, and set the clip region to the area we are about
             //  to draw.

-
+            

             savedClipRegion = NewRgn();
             GetClip( savedClipRegion );
             savedClipRegion = NewRgn();
             GetClip( savedClipRegion );

-
+            

             ClipRect( drawRect );
             EraseRect( drawRect );
             ClipRect( drawRect );
             EraseRect( drawRect );

-
+            
+            wxFontRefData * font = (wxFontRefData*) list->GetFont().GetRefData() ;
+            
+            if ( font )
+            {
+                ::TextFont( font->m_macFontNum ) ;
+                ::TextSize( short(font->m_macFontSize) ) ;
+                ::TextFace( font->m_macFontStyle ) ;
+            }
+            else
+            {
+                ::TextFont( kFontIDMonaco ) ;
+                ::TextSize( 9  );
+                ::TextFace( 0 ) ;
+            }
+            

 #if TARGET_CARBON
 #if TARGET_CARBON

-               bool useDrawThemeText = ( DrawThemeTextBox != (void*) kUnresolvedCFragSymbolAddress ) ;
-
-               if ( useDrawThemeText )
-               {
-                   Rect frame = { drawRect->top, drawRect->left + 4,
-                                  drawRect->top + kwxMacListItemHeight, drawRect->right} ;
-                CFStringRef mString = CFStringCreateWithBytes( NULL , (UInt8*) text.c_str(), text.Length(), CFStringGetSystemEncoding(), false ) ;
-                       ::DrawThemeTextBox( mString,
-                                                               kThemeViewsFont,
-                                                               kThemeStateActive,
-                                                               false,
-                                                               &frame,
-                                                               teJustLeft,
-                                                               nil );
-                   CFRelease( mString ) ;
+                       {
+                               Rect frame = { drawRect->top, drawRect->left + 4,
+                                   drawRect->top + kwxMacListItemHeight, drawRect->right + 10000 } ;
+                               CFMutableStringRef mString = CFStringCreateMutableCopy( NULL , 0 , wxMacCFStringHolder(linetext) ) ;
+                               ::TruncateThemeText( mString , kThemeCurrentPortFont, kThemeStateActive, drawRect->right - drawRect->left , truncEnd , NULL ) ;
+                               ::DrawThemeTextBox( mString,
+                                   kThemeCurrentPortFont,
+                                   kThemeStateActive,
+                                   false,
+                                   &frame,
+                                   teJustLeft,
+                                   nil );
+                               CFRelease( mString ) ;
+                       }
+#else
+            {  
+               wxCharBuffer text = wxMacStringToCString( linetext ) ;
+                MoveTo(drawRect->left + 4 , drawRect->top + 10 );
+                DrawText(text, 0 , strlen(text) );

             }
             }

-                   else
-#endif
-                   {
-                       MoveTo(drawRect->left + 4 , drawRect->top + 10 );
-                       ::TextFont( kFontIDMonaco ) ;
-                       ::TextSize( 9  );
-                       ::TextFace( 0 ) ;
-                       DrawText(text, 0 , text.Length());
-                   }
-
+#endif            

             //  If the cell is hilited, do the hilite now. Paint the cell contents with the
             //  appropriate QuickDraw transform mode.
             //  If the cell is hilited, do the hilite now. Paint the cell contents with the
             //  appropriate QuickDraw transform mode.

-
+            

             if( isSelected ) {
                 savedPenMode = GetPortPenMode( (CGrafPtr) grafPtr );
                 SetPortPenMode( (CGrafPtr)grafPtr, hilitetransfermode );
                 PaintRect( drawRect );
                 SetPortPenMode( (CGrafPtr)grafPtr, savedPenMode );
             }
             if( isSelected ) {
                 savedPenMode = GetPortPenMode( (CGrafPtr) grafPtr );
                 SetPortPenMode( (CGrafPtr)grafPtr, hilitetransfermode );
                 PaintRect( drawRect );
                 SetPortPenMode( (CGrafPtr)grafPtr, savedPenMode );
             }

-
+            

             //  Restore the saved clip region.
             //  Restore the saved clip region.

-
+            

             SetClip( savedClipRegion );
             DisposeRgn( savedClipRegion );
             SetClip( savedClipRegion );
             DisposeRgn( savedClipRegion );

-            }
-            break;
-        case lHiliteMsg:
-
-            //  Hilite or unhilite the cell. Paint the cell contents with the
-            //  appropriate QuickDraw transform mode.
-
-            GetPort( &grafPtr );
-            savedPenMode = GetPortPenMode( (CGrafPtr)grafPtr );
-            SetPortPenMode( (CGrafPtr)grafPtr, hilitetransfermode );
-            PaintRect( drawRect );
-            SetPortPenMode( (CGrafPtr)grafPtr, savedPenMode );
-            break;
-        default :
-          break ;
+        }
+        break;
+    case lHiliteMsg:
+        
+        //  Hilite or unhilite the cell. Paint the cell contents with the
+        //  appropriate QuickDraw transform mode.
+        
+        GetPort( &grafPtr );
+        savedPenMode = GetPortPenMode( (CGrafPtr)grafPtr );
+        SetPortPenMode( (CGrafPtr)grafPtr, hilitetransfermode );
+        PaintRect( drawRect );
+        SetPortPenMode( (CGrafPtr)grafPtr, savedPenMode );
+        break;
+    default :
+        break ;

     }
     SetPort(savePort);
 }
 
 extern "C" void MacDrawStringCell(Rect *cellRect, Cell lCell, ListHandle theList, long refCon) ;
     }
     SetPort(savePort);
 }
 
 extern "C" void MacDrawStringCell(Rect *cellRect, Cell lCell, ListHandle theList, long refCon) ;

+// resources ldef ids

 const short kwxMacListWithVerticalScrollbar = 128 ;
 const short kwxMacListWithVerticalScrollbar = 128 ;

+const short kwxMacListWithVerticalAndHorizontalScrollbar = 129 ;

 
 // ============================================================================
 // list box control implementation
 
 // ============================================================================
 // list box control implementation


@@ -195,22 +207,33 @@ bool wxListBox::Create(wxWindow *parent, wxWindowID id,
 
     Rect bounds ;
     Str255 title ;
 
     Rect bounds ;
     Str255 title ;

-
-    MacPreControlCreate( parent , id ,  "" , pos , size ,style, validator , name , &bounds , title ) ;
-
+    
+    MacPreControlCreate( parent , id ,  wxEmptyString , pos , size ,style, validator , name , &bounds , title ) ;
+    

     ListDefSpec listDef;
     listDef.defType = kListDefUserProcType;
     if ( macListDefUPP == NULL )
     {
     ListDefSpec listDef;
     listDef.defType = kListDefUserProcType;
     if ( macListDefUPP == NULL )
     {

-      macListDefUPP = NewListDefUPP( wxMacListDefinition );
+        macListDefUPP = NewListDefUPP( wxMacListDefinition );

     }
     }

-        listDef.u.userProc = macListDefUPP ;
-
+    listDef.u.userProc = macListDefUPP ;
+    
+    Str255 fontName ;
+    SInt16 fontSize ;
+    Style fontStyle ;
+#if TARGET_CARBON
+    GetThemeFont(kThemeViewsFont , GetApplicationScript() , fontName , &fontSize , &fontStyle ) ;
+#else
+    GetFontName( kFontIDMonaco , fontName ) ;
+    fontSize = 9 ;
+    fontStyle = normal ;
+#endif 
+    SetFont( wxFont (fontSize, wxSWISS, wxNORMAL, wxNORMAL , false , wxMacMakeStringFromPascal( fontName ) ) ) ;

 #if TARGET_CARBON
     Size asize;
 
 
 #if TARGET_CARBON
     Size asize;
 
 

-    CreateListBoxControl( MAC_WXHWND(parent->MacGetRootWindow()), &bounds, false, 0, 1, false, true,
+    CreateListBoxControl( MAC_WXHWND(parent->MacGetRootWindow()), &bounds, false, 0, 1, (style & wxLB_HSCROLL), true,

                           kwxMacListItemHeight, kwxMacListItemHeight, false, &listDef, (ControlRef *)&m_macControl );
 
     GetControlData( (ControlHandle) m_macControl, kControlNoPart, kControlListBoxListHandleTag,
                           kwxMacListItemHeight, kwxMacListItemHeight, false, &listDef, (ControlRef *)&m_macControl );
 
     GetControlData( (ControlHandle) m_macControl, kControlNoPart, kControlListBoxListHandleTag,


@@ -224,8 +247,8 @@ bool wxListBox::Create(wxWindow *parent, wxWindowID id,
     long    result ;
     wxStAppResource resload ;
     m_macControl = ::NewControl( MAC_WXHWND(parent->MacGetRootWindow()) , &bounds , title , false ,
     long    result ;
     wxStAppResource resload ;
     m_macControl = ::NewControl( MAC_WXHWND(parent->MacGetRootWindow()) , &bounds , title , false ,

-                  kwxMacListWithVerticalScrollbar , 0 , 0,
-                  kControlListBoxProc , (long) this ) ;
+                  (style & wxLB_HSCROLL) ? kwxMacListWithVerticalAndHorizontalScrollbar : kwxMacListWithVerticalScrollbar , 
+                  0 , 0, kControlListBoxProc , (long) this ) ;

     ::GetControlData( (ControlHandle) m_macControl , kControlNoPart , kControlListBoxListHandleTag ,
                sizeof( ListHandle ) , (char*) &m_macList  , &result ) ;
 
     ::GetControlData( (ControlHandle) m_macControl , kControlNoPart , kControlListBoxListHandleTag ,
                sizeof( ListHandle ) , (char*) &m_macList  , &result ) ;
 


@@ -255,17 +278,17 @@ bool wxListBox::Create(wxWindow *parent, wxWindowID id,
     }
     else
     {
     }
     else
     {

-        options = lOnlyOne ;
+        options = (OptionBits) lOnlyOne ;

     }
     SetListSelectionFlags((ListHandle)m_macList, options);
 
     }
     SetListSelectionFlags((ListHandle)m_macList, options);
 

-    MacPostControlCreate() ;
-

     for ( int i = 0 ; i < n ; i++ )
     {
         Append( choices[i] ) ;
     }
 
     for ( int i = 0 ; i < n ; i++ )
     {
         Append( choices[i] ) ;
     }
 

+    MacPostControlCreate() ;
+

     LSetDrawingMode( true , (ListHandle)m_macList ) ;
 
     return TRUE;
     LSetDrawingMode( true , (ListHandle)m_macList ) ;
 
     return TRUE;


@@ -277,8 +300,8 @@ wxListBox::~wxListBox()
     if ( m_macList )
     {
 #if !TARGET_CARBON
     if ( m_macList )
     {
 #if !TARGET_CARBON

-      DisposeHandle( (**(ListHandle)m_macList).listDefProc ) ;
-      (**(ListHandle)m_macList).listDefProc = NULL ;
+        DisposeHandle( (**(ListHandle)m_macList).listDefProc ) ;
+        (**(ListHandle)m_macList).listDefProc = NULL ;

 #endif
         m_macList = NULL ;
     }
 #endif
         m_macList = NULL ;
     }


@@ -358,15 +381,8 @@ void wxListBox::Delete(int N)
 int wxListBox::DoAppend(const wxString& item)
 {
     int index = m_noItems ;
 int wxListBox::DoAppend(const wxString& item)
 {
     int index = m_noItems ;

-    if( wxApp::s_macDefaultEncodingIsPC )
-    {
-        m_stringArray.Add( wxMacMakeMacStringFromPC( item ) ) ;
-        m_dataArray.Add( NULL );
-    }
-    else {
-        m_stringArray.Add( item ) ;
-        m_dataArray.Add( NULL );
-    }
+    m_stringArray.Add( item ) ;
+    m_dataArray.Add( NULL );

     m_noItems ++;
     DoSetItemClientData( index , NULL ) ;
     MacAppend( item ) ;
     m_noItems ++;
     DoSetItemClientData( index , NULL ) ;
     MacAppend( item ) ;


@@ -376,25 +392,25 @@ int wxListBox::DoAppend(const wxString& item)
 
 void wxListBox::DoSetItems(const wxArrayString& choices, void** clientData)
 {
 
 void wxListBox::DoSetItems(const wxArrayString& choices, void** clientData)
 {

-  MacSetRedraw( false ) ;
-  Clear() ;
-  int n = choices.GetCount();
-
-  for( int i = 0 ; i < n ; ++i )
-  {
-    if ( clientData )
+    MacSetRedraw( false ) ;
+    Clear() ;
+    int n = choices.GetCount();
+    
+    for( int i = 0 ; i < n ; ++i )

     {
     {

+        if ( clientData )
+        {

 #if wxUSE_OWNER_DRAWN
             wxASSERT_MSG(clientData[i] == NULL,
 #if wxUSE_OWNER_DRAWN
             wxASSERT_MSG(clientData[i] == NULL,

-                         wxT("Can't use client data with owner-drawn listboxes"));
+                wxT("Can't use client data with owner-drawn listboxes"));

 #else // !wxUSE_OWNER_DRAWN
 #else // !wxUSE_OWNER_DRAWN

-        Append( choices[i] , clientData[i] ) ;
- #endif
+            Append( choices[i] , clientData[i] ) ;
+#endif
+        }
+        else
+            Append( choices[i] ) ;

     }
     }

-    else
-        Append( choices[i] ) ;
-  }
-
+    

 #if wxUSE_OWNER_DRAWN
     if ( m_windowStyle & wxLB_OWNERDRAW ) {
         // first delete old items
 #if wxUSE_OWNER_DRAWN
     if ( m_windowStyle & wxLB_OWNERDRAW ) {
         // first delete old items


@@ -404,7 +420,7 @@ void wxListBox::DoSetItems(const wxArrayString& choices, void** clientData)
             m_aItems[ui] = NULL;
         }
         m_aItems.Empty();
             m_aItems[ui] = NULL;
         }
         m_aItems.Empty();

-
+        

         // then create new ones
         for ( ui = 0; ui < (size_t)m_noItems; ui++ ) {
             wxOwnerDrawn *pNewItem = CreateItem(ui);
         // then create new ones
         for ( ui = 0; ui < (size_t)m_noItems; ui++ ) {
             wxOwnerDrawn *pNewItem = CreateItem(ui);


@@ -413,7 +429,7 @@ void wxListBox::DoSetItems(const wxArrayString& choices, void** clientData)
         }
     }
 #endif // wxUSE_OWNER_DRAWN
         }
     }
 #endif // wxUSE_OWNER_DRAWN

-  MacSetRedraw( true ) ;
+    MacSetRedraw( true ) ;

 }
 
 bool wxListBox::HasMultipleSelection() const
 }
 
 bool wxListBox::HasMultipleSelection() const


@@ -421,108 +437,82 @@ bool wxListBox::HasMultipleSelection() const
     return (m_windowStyle & wxLB_MULTIPLE) || (m_windowStyle & wxLB_EXTENDED);
 }
 
     return (m_windowStyle & wxLB_MULTIPLE) || (m_windowStyle & wxLB_EXTENDED);
 }
 

-int wxListBox::FindString(const wxString& st) const
+int wxListBox::FindString(const wxString& s) const

 {
 {

-    wxString s ;
-    if( wxApp::s_macDefaultEncodingIsPC )
-    {
-        s = wxMacMakeMacStringFromPC( st ) ;
-    }
-    else
-        s = st ;
-
-    if ( s.Right(1) == "*" )
+    
+    if ( s.Right(1) == wxT("*") )

     {
         wxString search = s.Left( s.Length() - 1 ) ;
         int len = search.Length() ;
         Str255 s1 , s2 ;
     {
         wxString search = s.Left( s.Length() - 1 ) ;
         int len = search.Length() ;
         Str255 s1 , s2 ;

-
-#if TARGET_CARBON
-        c2pstrcpy( (StringPtr) s2 , search.c_str() ) ;
-#else
-        strcpy( (char *) s2 , search.c_str() ) ;
-        c2pstr( (char *) s2 ) ;
-#endif
-
+        wxMacStringToPascal( search , s2 ) ;
+        

         for ( int i = 0 ; i < m_noItems ; ++ i )
         {
         for ( int i = 0 ; i < m_noItems ; ++ i )
         {

-#if TARGET_CARBON
-            c2pstrcpy( (StringPtr) s1 , m_stringArray[i].Left( len ).c_str() ) ;
-#else
-            strcpy( (char *) s1 , m_stringArray[i].Left( len ).c_str() ) ;
-            c2pstr( (char *) s1 ) ;
-#endif
+               wxMacStringToPascal( m_stringArray[i].Left( len ) , s1 ) ;
+

             if ( EqualString( s1 , s2 , false , false ) )
                 return i ;
         }
             if ( EqualString( s1 , s2 , false , false ) )
                 return i ;
         }

-        if ( s.Left(1) == "*" && s.Length() > 1 )
+        if ( s.Left(1) == wxT("*") && s.Length() > 1 )

         {
         {

-            s = st ;
-            s.MakeLower() ;
+            wxString st = s ;
+            st.MakeLower() ;

             for ( int i = 0 ; i < m_noItems ; ++i )
             {
             for ( int i = 0 ; i < m_noItems ; ++i )
             {

-                if ( GetString(i).Lower().Matches(s) )
+                if ( GetString(i).Lower().Matches(st) )

                     return i ;
             }
         }
                     return i ;
             }
         }

-
+        

     }
     else
     {
         Str255 s1 , s2 ;
     }
     else
     {
         Str255 s1 , s2 ;

-
-#if TARGET_CARBON
-        c2pstrcpy( (StringPtr) s2 , s.c_str() ) ;
-#else
-        strcpy( (char *) s2 , s.c_str() ) ;
-        c2pstr( (char *) s2 ) ;
-#endif
-
+        
+        wxMacStringToPascal( s , s2 ) ;
+        

         for ( int i = 0 ; i < m_noItems ; ++ i )
         {
         for ( int i = 0 ; i < m_noItems ; ++ i )
         {

-#if TARGET_CARBON
-            c2pstrcpy( (StringPtr) s1 , m_stringArray[i].c_str() ) ;
-#else
-            strcpy( (char *) s1 , m_stringArray[i].c_str() ) ;
-            c2pstr( (char *) s1 ) ;
-#endif
+               wxMacStringToPascal( m_stringArray[i] , s1 ) ;
+

             if ( EqualString( s1 , s2 , false , false ) )
                 return i ;
         }
             if ( EqualString( s1 , s2 , false , false ) )
                 return i ;
         }

-   }
-   return -1;
+    }
+    return -1;

 }
 
 void wxListBox::Clear()
 {
 }
 
 void wxListBox::Clear()
 {

-  FreeData();
-  m_noItems = 0;
-  m_stringArray.Empty() ;
-  m_dataArray.Empty() ;
-  MacClear() ;
+    FreeData();
+    m_noItems = 0;
+    m_stringArray.Empty() ;
+    m_dataArray.Empty() ;
+    MacClear() ;

 }
 
 void wxListBox::SetSelection(int N, bool select)
 {
     wxCHECK_RET( N >= 0 && N < m_noItems,
 }
 
 void wxListBox::SetSelection(int N, bool select)
 {
     wxCHECK_RET( N >= 0 && N < m_noItems,

-                 "invalid index in wxListBox::SetSelection" );
-      MacSetSelection( N , select ) ;
-      GetSelections( m_selectionPreImage ) ;
+        wxT("invalid index in wxListBox::SetSelection") );
+    MacSetSelection( N , select ) ;
+    GetSelections( m_selectionPreImage ) ;

 }
 
 bool wxListBox::IsSelected(int N) const
 {
     wxCHECK_MSG( N >= 0 && N < m_noItems, FALSE,
 }
 
 bool wxListBox::IsSelected(int N) const
 {
     wxCHECK_MSG( N >= 0 && N < m_noItems, FALSE,

-                 "invalid index in wxListBox::Selected" );
-
-      return MacIsSelected( N ) ;
+        wxT("invalid index in wxListBox::Selected") );
+    
+    return MacIsSelected( N ) ;

 }
 
 void *wxListBox::DoGetItemClientData(int N) const
 {
     wxCHECK_MSG( N >= 0 && N < m_noItems, NULL,
 }
 
 void *wxListBox::DoGetItemClientData(int N) const
 {
     wxCHECK_MSG( N >= 0 && N < m_noItems, NULL,

-                 wxT("invalid index in wxListBox::GetClientData"));
-
+        wxT("invalid index in wxListBox::GetClientData"));
+    

     return (void *)m_dataArray[N];
 }
 
     return (void *)m_dataArray[N];
 }
 


@@ -534,8 +524,8 @@ wxClientData *wxListBox::DoGetItemClientObject(int N) const
 void wxListBox::DoSetItemClientData(int N, void *Client_data)
 {
     wxCHECK_RET( N >= 0 && N < m_noItems,
 void wxListBox::DoSetItemClientData(int N, void *Client_data)
 {
     wxCHECK_RET( N >= 0 && N < m_noItems,

-                 "invalid index in wxListBox::SetClientData" );
-
+        wxT("invalid index in wxListBox::SetClientData") );
+    

 #if wxUSE_OWNER_DRAWN
     if ( m_windowStyle & wxLB_OWNERDRAW )
     {
 #if wxUSE_OWNER_DRAWN
     if ( m_windowStyle & wxLB_OWNERDRAW )
     {


@@ -544,8 +534,8 @@ void wxListBox::DoSetItemClientData(int N, void *Client_data)
         wxFAIL_MSG(wxT("Can't use client data with owner-drawn listboxes"));
     }
 #endif // wxUSE_OWNER_DRAWN
         wxFAIL_MSG(wxT("Can't use client data with owner-drawn listboxes"));
     }
 #endif // wxUSE_OWNER_DRAWN

-    wxASSERT_MSG( m_dataArray.GetCount() >= (size_t) N , "invalid client_data array" ) ;
-
+    wxASSERT_MSG( m_dataArray.GetCount() >= (size_t) N , wxT("invalid client_data array") ) ;
+    

     if ( m_dataArray.GetCount() > (size_t) N )
     {
         m_dataArray[N] = (char*) Client_data ;
     if ( m_dataArray.GetCount() > (size_t) N )
     {
         m_dataArray[N] = (char*) Client_data ;


@@ -576,47 +566,89 @@ int wxListBox::GetSelection() const
 // Find string for position
 wxString wxListBox::GetString(int N) const
 {
 // Find string for position
 wxString wxListBox::GetString(int N) const
 {

-    if( wxApp::s_macDefaultEncodingIsPC )
-    {
-        return      wxMacMakePCStringFromMac( m_stringArray[N] ) ;
-    }
-    else
-        return m_stringArray[N]  ;
+       return m_stringArray[N]  ;

 }
 
 void wxListBox::DoInsertItems(const wxArrayString& items, int pos)
 {
     wxCHECK_RET( pos >= 0 && pos <= m_noItems,
 }
 
 void wxListBox::DoInsertItems(const wxArrayString& items, int pos)
 {
     wxCHECK_RET( pos >= 0 && pos <= m_noItems,

-                 wxT("invalid index in wxListBox::InsertItems") );
-
+        wxT("invalid index in wxListBox::InsertItems") );
+    

     int nItems = items.GetCount();
     int nItems = items.GetCount();

-
+    

     for ( int i = 0 ; i < nItems ; i++ )
     {
         m_stringArray.Insert( items[i] , pos + i ) ;
         m_dataArray.Insert( NULL , pos + i ) ;
         MacInsert( pos + i , items[i] ) ;
     }
     for ( int i = 0 ; i < nItems ; i++ )
     {
         m_stringArray.Insert( items[i] , pos + i ) ;
         m_dataArray.Insert( NULL , pos + i ) ;
         MacInsert( pos + i , items[i] ) ;
     }

-
+    

     m_noItems += nItems;
 }
 
 void wxListBox::SetString(int N, const wxString& s)
 {
     m_noItems += nItems;
 }
 
 void wxListBox::SetString(int N, const wxString& s)
 {

-    wxString str ;
-    if( wxApp::s_macDefaultEncodingIsPC )
-    {
-        str = wxMacMakeMacStringFromPC( s )  ;
-    }
-    else
-        str = s ;
-    m_stringArray[N] = str ;
+    m_stringArray[N] = s ;

     MacSet( N , s ) ;
 }
 
 wxSize wxListBox::DoGetBestSize() const
 {
     MacSet( N , s ) ;
 }
 
 wxSize wxListBox::DoGetBestSize() const
 {

-    return wxSize(100, 100);
+    int lbWidth = 100;  // some defaults
+    int lbHeight = 110;
+    int wLine;
+    
+    {
+        wxMacPortStateHelper st( UMAGetWindowPort( (WindowRef) MacGetRootWindow() ) ) ; 
+        
+        wxFontRefData * font = (wxFontRefData*) m_font.GetRefData() ;
+        
+        if ( font )
+        {
+            ::TextFont( font->m_macFontNum ) ;
+            ::TextSize( short(font->m_macFontSize) ) ;
+            ::TextFace( font->m_macFontStyle ) ;
+        }
+        else
+        {
+            ::TextFont( kFontIDMonaco ) ;
+            ::TextSize( 9  );
+            ::TextFace( 0 ) ;
+        }
+        
+        // Find the widest line
+        for(int i = 0; i < GetCount(); i++) {
+            wxString str(GetString(i));
+        #if wxUSE_UNICODE
+            Point bounds={0,0} ;
+            SInt16 baseline ;
+            ::GetThemeTextDimensions( wxMacCFStringHolder( str ) ,
+                kThemeCurrentPortFont,
+                kThemeStateActive,
+                false,
+                &bounds,
+                &baseline );
+            wLine = bounds.h ;
+        #else
+            wxCharBuffer text = wxMacStringToCString( str ) ;
+            wLine = ::TextWidth( text , 0 , strlen(text) ) ;
+        #endif
+            lbWidth = wxMax(lbWidth, wLine);
+        }
+        
+        // Add room for the scrollbar
+        lbWidth += wxSystemSettings::GetMetric(wxSYS_VSCROLL_X);
+        
+        // And just a bit more
+        int cy = 12 ;
+        int cx = ::TextWidth( "X" , 0 , 1 ) ;
+        lbWidth += cx ;
+        
+        // don't make the listbox too tall (limit height to around 10 items) but don't
+        // make it too small neither
+        lbHeight = (cy+4) * wxMin(wxMax(GetCount(), 3), 10);
+    }
+    return wxSize(lbWidth, lbHeight);

 }
 
 int wxListBox::GetCount() const
 }
 
 int wxListBox::GetCount() const


@@ -633,7 +665,7 @@ void wxListBox::SetupColours()
 void wxListBox::Refresh(bool eraseBack, const wxRect *rect)
 {
     wxControl::Refresh( eraseBack , rect ) ;
 void wxListBox::Refresh(bool eraseBack, const wxRect *rect)
 {
     wxControl::Refresh( eraseBack , rect ) ;

-//    MacRedrawControl() ;
+    //    MacRedrawControl() ;

 }
 
 #if wxUSE_OWNER_DRAWN
 }
 
 #if wxUSE_OWNER_DRAWN


@@ -661,42 +693,43 @@ wxOwnerDrawn *wxListBox::CreateItem(size_t n)
 // list box control implementation
 // ============================================================================
 
 // list box control implementation
 // ============================================================================
 

+/*

 void MacDrawStringCell(Rect *cellRect, Cell lCell, ListHandle theList, long refCon)
 {
 void MacDrawStringCell(Rect *cellRect, Cell lCell, ListHandle theList, long refCon)
 {

-    wxListBox*          list;
-    // typecast our refCon
-    list = (wxListBox*)refCon;
-
-    MoveTo(cellRect->left + 4 , cellRect->top + 10 );
-    const wxString text = list->m_stringArray[lCell.v] ;
-    ::TextFont( kFontIDMonaco ) ;
-    ::TextSize( 9  );
-    ::TextFace( 0 ) ;
-    DrawText(text, 0 , text.Length());
-
-}
+wxListBox*          list;
+// typecast our refCon
+list = (wxListBox*)refCon;

 
 

+  MoveTo(cellRect->left + 4 , cellRect->top + 10 );
+  const wxString text = list->m_stringArray[lCell.v] ;
+  ::TextFont( kFontIDMonaco ) ;
+  ::TextSize( 9  );
+  ::TextFace( 0 ) ;
+  DrawText(text, 0 , text.Length());
+  
+    }
+*/

 void wxListBox::MacDelete( int N )
 {
     LDelRow( 1 , N , (ListHandle)m_macList) ;
     Refresh();
 }
 
 void wxListBox::MacDelete( int N )
 {
     LDelRow( 1 , N , (ListHandle)m_macList) ;
     Refresh();
 }
 

-void wxListBox::MacInsert( int n , const char * text)
+void wxListBox::MacInsert( int n , const wxString& text)

 {
     Cell cell = { 0 , 0 } ;
     cell.v = n ;
     LAddRow( 1 , cell.v , (ListHandle)m_macList ) ;
 {
     Cell cell = { 0 , 0 } ;
     cell.v = n ;
     LAddRow( 1 , cell.v , (ListHandle)m_macList ) ;

-//    LSetCell(text, strlen(text), cell, m_macList);
+    //    LSetCell(text, strlen(text), cell, m_macList);

     Refresh();
 }
 
     Refresh();
 }
 

-void wxListBox::MacAppend( const char * text)
+void wxListBox::MacAppend( const wxString& text)

 {
     Cell cell = { 0 , 0 } ;
     cell.v = (**(ListHandle)m_macList).dataBounds.bottom ;
     LAddRow( 1 , cell.v , (ListHandle)m_macList ) ;
 {
     Cell cell = { 0 , 0 } ;
     cell.v = (**(ListHandle)m_macList).dataBounds.bottom ;
     LAddRow( 1 , cell.v , (ListHandle)m_macList ) ;

- //   LSetCell(text, strlen(text), cell, m_macList);
+    //   LSetCell(text, strlen(text), cell, m_macList);

     Refresh();
 }
 
     Refresh();
 }
 


@@ -716,7 +749,7 @@ void wxListBox::MacSetSelection( int n , bool select )
             LSetSelect( false , cell , (ListHandle)m_macList ) ;
         }
     }
             LSetSelect( false , cell , (ListHandle)m_macList ) ;
         }
     }

-
+    

     cell.v = n ;
     LSetSelect( select , cell , (ListHandle)m_macList ) ;
     LAutoScroll( (ListHandle)m_macList ) ;
     cell.v = n ;
     LSetSelect( select , cell , (ListHandle)m_macList ) ;
     LAutoScroll( (ListHandle)m_macList ) ;


@@ -732,7 +765,7 @@ bool wxListBox::MacIsSelected( int n ) const
 
 void wxListBox::MacDestroy()
 {
 
 void wxListBox::MacDestroy()
 {

-//    DisposeExtLDEFInfo( m_macList ) ;
+    //    DisposeExtLDEFInfo( m_macList ) ;

 }
 
 int wxListBox::MacGetSelection() const
 }
 
 int wxListBox::MacGetSelection() const


@@ -747,12 +780,12 @@ int wxListBox::MacGetSelection() const
 int wxListBox::MacGetSelections( wxArrayInt& aSelections ) const
 {
     int no_sel = 0 ;
 int wxListBox::MacGetSelections( wxArrayInt& aSelections ) const
 {
     int no_sel = 0 ;

-
+    

     aSelections.Empty();
     aSelections.Empty();

-
+    

     Cell cell = { 0 , 0 } ;
     cell.v = 0 ;
     Cell cell = { 0 , 0 } ;
     cell.v = 0 ;

-
+    

     while ( LGetSelect( true , &cell ,(ListHandle) m_macList ) )
     {
         aSelections.Add( cell.v ) ;
     while ( LGetSelect( true , &cell ,(ListHandle) m_macList ) )
     {
         aSelections.Add( cell.v ) ;


@@ -762,13 +795,13 @@ int wxListBox::MacGetSelections( wxArrayInt& aSelections ) const
     return no_sel ;
 }
 
     return no_sel ;
 }
 

-void wxListBox::MacSet( int n , const char * text )
+void wxListBox::MacSet( int n , const wxString& text )

 {
     // our implementation does not store anything in the list
     // so we just have to redraw
     Cell cell = { 0 , 0 } ;
     cell.v = n ;
 {
     // our implementation does not store anything in the list
     // so we just have to redraw
     Cell cell = { 0 , 0 } ;
     cell.v = n ;

-//  LSetCell(text, strlen(text), cell, m_macList);
+    //  LSetCell(text, strlen(text), cell, m_macList);

     Refresh();
 }
 
     Refresh();
 }
 


@@ -780,7 +813,7 @@ void wxListBox::MacScrollTo( int n )
 void wxListBox::OnSize( const wxSizeEvent &event)
 {
     Point pt;
 void wxListBox::OnSize( const wxSizeEvent &event)
 {
     Point pt;

-
+    

 #if TARGET_CARBON
     GetListCellSize((ListHandle)m_macList, &pt);
 #else
 #if TARGET_CARBON
     GetListCellSize((ListHandle)m_macList, &pt);
 #else


@@ -790,11 +823,11 @@ void wxListBox::OnSize( const wxSizeEvent &event)
     LCellSize( pt , (ListHandle)m_macList ) ;
 }
 
     LCellSize( pt , (ListHandle)m_macList ) ;
 }
 

-void wxListBox::MacHandleControlClick( WXWidget control , wxInt16 controlpart )
+void wxListBox::MacHandleControlClick( WXWidget control , wxInt16 controlpart , bool WXUNUSED(mouseStillDown))

 {
     Boolean wasDoubleClick = false ;
     long    result ;
 {
     Boolean wasDoubleClick = false ;
     long    result ;

-
+    

     ::GetControlData( (ControlHandle) m_macControl , kControlNoPart , kControlListBoxDoubleClickTag , sizeof( wasDoubleClick ) , (char*) &wasDoubleClick  , &result ) ;
     if ( !wasDoubleClick )
     {
     ::GetControlData( (ControlHandle) m_macControl , kControlNoPart , kControlListBoxDoubleClickTag , sizeof( wasDoubleClick ) , (char*) &wasDoubleClick  , &result ) ;
     if ( !wasDoubleClick )
     {


@@ -809,7 +842,7 @@ void wxListBox::MacHandleControlClick( WXWidget control , wxInt16 controlpart )
 void wxListBox::MacSetRedraw( bool doDraw )
 {
     LSetDrawingMode( doDraw , (ListHandle)m_macList ) ;
 void wxListBox::MacSetRedraw( bool doDraw )
 {
     LSetDrawingMode( doDraw , (ListHandle)m_macList ) ;

-
+    

 }
 
 void wxListBox::MacDoClick()
 }
 
 void wxListBox::MacDoClick()


@@ -817,7 +850,7 @@ void wxListBox::MacDoClick()
     wxArrayInt aSelections;
     int n ;
     size_t count = GetSelections(aSelections);
     wxArrayInt aSelections;
     int n ;
     size_t count = GetSelections(aSelections);

-
+    

     if ( count == m_selectionPreImage.GetCount() )
     {
         bool hasChanged = false ;
     if ( count == m_selectionPreImage.GetCount() )
     {
         bool hasChanged = false ;


@@ -834,12 +867,12 @@ void wxListBox::MacDoClick()
             return ;
         }
     }
             return ;
         }
     }

-
+    

     m_selectionPreImage = aSelections;
     m_selectionPreImage = aSelections;

-
+    

     wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
     event.SetEventObject( this );
     wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
     event.SetEventObject( this );

-
+    

     if ( count > 0 )
     {
         n = aSelections[0];
     if ( count > 0 )
     {
         n = aSelections[0];


@@ -851,11 +884,11 @@ void wxListBox::MacDoClick()
     }
     else
     {
     }
     else
     {

-         n = -1;
+        n = -1;

     }
     }

-
+    

     event.m_commandInt = n;
     event.m_commandInt = n;

-
+    

     GetEventHandler()->ProcessEvent(event);
 }
 
     GetEventHandler()->ProcessEvent(event);
 }
 


@@ -863,40 +896,44 @@ void wxListBox::MacDoDoubleClick()
 {
     wxCommandEvent event(wxEVT_COMMAND_LISTBOX_DOUBLECLICKED, m_windowId);
     event.SetEventObject( this );
 {
     wxCommandEvent event(wxEVT_COMMAND_LISTBOX_DOUBLECLICKED, m_windowId);
     event.SetEventObject( this );

-       GetEventHandler()->ProcessEvent(event) ;
+    GetEventHandler()->ProcessEvent(event) ;

 }
 
 void wxListBox::OnChar(wxKeyEvent& event)
 {
 }
 
 void wxListBox::OnChar(wxKeyEvent& event)
 {

-    if ( event.KeyCode() == WXK_RETURN || event.KeyCode() == WXK_NUMPAD_ENTER)
+    if ( event.GetKeyCode() == WXK_RETURN || event.GetKeyCode() == WXK_NUMPAD_ENTER)

     {
     {

-       wxWindow* parent = GetParent() ;
-       while( parent  && !parent->IsTopLevel() && parent->GetDefaultItem() == NULL )
-               parent = parent->GetParent() ;
-
-       if ( parent && parent->GetDefaultItem() )
-       {
-               wxButton *def = wxDynamicCast(parent->GetDefaultItem(),
-                                               wxButton);
-               if ( def && def->IsEnabled() )
-               {
-                    wxCommandEvent event(wxEVT_COMMAND_BUTTON_CLICKED, def->GetId() );
-                    event.SetEventObject(def);
-                    def->Command(event);
-                    return ;
-               }
-           }
-           event.Skip() ;
+        wxWindow* parent = GetParent() ;
+        while( parent  && !parent->IsTopLevel() && parent->GetDefaultItem() == NULL )
+            parent = parent->GetParent() ;
+        
+        if ( parent && parent->GetDefaultItem() )
+        {
+            wxButton *def = wxDynamicCast(parent->GetDefaultItem(),
+                wxButton);
+            if ( def && def->IsEnabled() )
+            {
+                wxCommandEvent event(wxEVT_COMMAND_BUTTON_CLICKED, def->GetId() );
+                event.SetEventObject(def);
+                def->Command(event);
+                return ;
+            }
+        }
+        event.Skip() ;

     }
     /* generate wxID_CANCEL if command-. or <esc> has been pressed (typically in dialogs) */
     }
     /* generate wxID_CANCEL if command-. or <esc> has been pressed (typically in dialogs) */

-    else if (event.KeyCode() == WXK_ESCAPE || (event.KeyCode() == '.' && event.MetaDown() ) )
+    else if (event.GetKeyCode() == WXK_ESCAPE || (event.GetKeyCode() == '.' && event.MetaDown() ) )

     {
     {

-       wxWindow* win = GetParent()->FindWindow( wxID_CANCEL ) ;
-        wxCommandEvent new_event(wxEVT_COMMAND_BUTTON_CLICKED,wxID_CANCEL);
-        new_event.SetEventObject( win );
-        win->GetEventHandler()->ProcessEvent( new_event );
+       // FIXME: look in ancestors, not just parent.
+        wxWindow* win = GetParent()->FindWindow( wxID_CANCEL ) ;
+        if (win)
+        {
+               wxCommandEvent new_event(wxEVT_COMMAND_BUTTON_CLICKED,wxID_CANCEL);
+               new_event.SetEventObject( win );
+               win->GetEventHandler()->ProcessEvent( new_event );
+       }

     }
     }

-    else if ( event.KeyCode() == WXK_TAB )
+    else if ( event.GetKeyCode() == WXK_TAB )

     {
         wxNavigationKeyEvent new_event;
         new_event.SetEventObject( this );
     {
         wxNavigationKeyEvent new_event;
         new_event.SetEventObject( this );


@@ -905,64 +942,64 @@ void wxListBox::OnChar(wxKeyEvent& event)
         new_event.SetWindowChange( event.ControlDown() );
         new_event.SetCurrentFocus( this );
         if ( !GetEventHandler()->ProcessEvent( new_event ) )
         new_event.SetWindowChange( event.ControlDown() );
         new_event.SetCurrentFocus( this );
         if ( !GetEventHandler()->ProcessEvent( new_event ) )

-               event.Skip() ;
+            event.Skip() ;

     }
     }

-       else if ( event.KeyCode() == WXK_DOWN || event.KeyCode() == WXK_UP )
-       {
-               // perform the default key handling first
-               wxControl::OnKeyDown( event ) ;
-
+    else if ( event.GetKeyCode() == WXK_DOWN || event.GetKeyCode() == WXK_UP )
+    {
+        // perform the default key handling first
+        wxControl::OnKeyDown( event ) ;
+        

         wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
         event.SetEventObject( this );
         wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
         event.SetEventObject( this );

-
+        

         wxArrayInt aSelections;
         int n, count = GetSelections(aSelections);
         if ( count > 0 )
         {
         wxArrayInt aSelections;
         int n, count = GetSelections(aSelections);
         if ( count > 0 )
         {

-               n = aSelections[0];
-               if ( HasClientObjectData() )
-                  event.SetClientObject( GetClientObject(n) );
-              else if ( HasClientUntypedData() )
-                  event.SetClientData( GetClientData(n) );
-              event.SetString( GetString(n) );
+            n = aSelections[0];
+            if ( HasClientObjectData() )
+                event.SetClientObject( GetClientObject(n) );
+            else if ( HasClientUntypedData() )
+                event.SetClientData( GetClientData(n) );
+            event.SetString( GetString(n) );

         }
         else
         {
         }
         else
         {

-             n = -1;
+            n = -1;

         }
         }

-
+        

         event.m_commandInt = n;
         event.m_commandInt = n;

-
+        

         GetEventHandler()->ProcessEvent(event);
         GetEventHandler()->ProcessEvent(event);

-       }
-       else
-       {
-         if ( event.GetTimestamp() > m_lastTypeIn + 60 )
-         {
-           m_typeIn = "" ;
-         }
-         m_lastTypeIn = event.GetTimestamp() ;
-         m_typeIn += (char) event.KeyCode() ;
-         int line = FindString("*"+m_typeIn+"*") ;
-         if ( line >= 0 )
-         {
-               if ( GetSelection() != line )
-               {
-               SetSelection(line) ;
-               wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
-               event.SetEventObject( this );
-
-            if ( HasClientObjectData() )
-              event.SetClientObject( GetClientObject( line ) );
-               else if ( HasClientUntypedData() )
-              event.SetClientData( GetClientData(line) );
-               event.SetString( GetString(line) );
-
-               event.m_commandInt = line ;
-
-               GetEventHandler()->ProcessEvent(event);
-           }
-         }
-       }
+    }
+    else
+    {
+        if ( event.GetTimestamp() > m_lastTypeIn + 60 )
+        {
+            m_typeIn = wxEmptyString ;
+        }
+        m_lastTypeIn = event.GetTimestamp() ;
+        m_typeIn += (char) event.GetKeyCode() ;
+        int line = FindString(wxT("*")+m_typeIn+wxT("*")) ;
+        if ( line >= 0 )
+        {
+            if ( GetSelection() != line )
+            {
+                SetSelection(line) ;
+                wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, m_windowId);
+                event.SetEventObject( this );
+                
+                if ( HasClientObjectData() )
+                    event.SetClientObject( GetClientObject( line ) );
+                else if ( HasClientUntypedData() )
+                    event.SetClientData( GetClientData(line) );
+                event.SetString( GetString(line) );
+                
+                event.m_commandInt = line ;
+                
+                GetEventHandler()->ProcessEvent(event);
+            }
+        }
+    }

 }
 
 }