Fix for #11647: text from WriteText not scrolled to be visible in wxRichTextCtrl

[wxWidgets.git] / src / os2 / toolbar.cpp

diff --git a/src/os2/toolbar.cpp b/src/os2/toolbar.cpp
index ea8d5f8480b4421105eab0ffdb2daac8db377319..9a802aa7106a16d9e58323b186ce1865647194c6 100644 (file)
--- a/src/os2/toolbar.cpp
+++ b/src/os2/toolbar.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        toolbar.cpp
+// Name:        src/os2/toolbar.cpp

 // Purpose:     wxToolBar
 // Author:      David Webster
 // Modified by:
 // Purpose:     wxToolBar
 // Author:      David Webster
 // Modified by:


@@ -14,6 +14,8 @@
 
 #if wxUSE_TOOLBAR && wxUSE_TOOLBAR_NATIVE
 
 
 #if wxUSE_TOOLBAR && wxUSE_TOOLBAR_NATIVE
 

+#include "wx/toolbar.h"
+

 #ifndef WX_PRECOMP
     #include "wx/settings.h"
     #include "wx/window.h"
 #ifndef WX_PRECOMP
     #include "wx/settings.h"
     #include "wx/window.h"


@@ -24,9 +26,9 @@
 #endif
 
 #include "wx/tooltip.h"
 #endif
 
 #include "wx/tooltip.h"

-#include "wx/toolbar.h"
+#include "wx/os2/dcclient.h"

 
 

-bool                                wxToolBar::m_bInitialized = FALSE;
+bool wxToolBar::m_bInitialized = false;

 
 // ----------------------------------------------------------------------------
 // private classes
 
 // ----------------------------------------------------------------------------
 // private classes


@@ -59,8 +61,10 @@ public:
 
     inline wxToolBarTool( wxToolBar* pTbar
                          ,wxControl* pControl
 
     inline wxToolBarTool( wxToolBar* pTbar
                          ,wxControl* pControl

+                         ,const wxString& label

                         ) : wxToolBarToolBase( pTbar
                                               ,pControl
                         ) : wxToolBarToolBase( pTbar
                                               ,pControl

+                                              ,label

                                              )
     {
     }
                                              )
     {
     }


@@ -127,10 +131,12 @@ wxToolBarToolBase* wxToolBar::CreateTool(
 
 wxToolBarToolBase *wxToolBar::CreateTool(
   wxControl*                        pControl
 
 wxToolBarToolBase *wxToolBar::CreateTool(
   wxControl*                        pControl

+, const wxString&                   label

 )
 {
     return new wxToolBarTool( this
                              ,pControl
 )
 {
     return new wxToolBarTool( this
                              ,pControl

+                             ,label

                             );
 } // end of wxToolBarSimple::CreateTool
 
                             );
 } // end of wxToolBarSimple::CreateTool
 


@@ -275,12 +281,10 @@ wxToolBarToolBase* wxToolBar::InsertTool(
     return pTool;
 } // end of wxToolBar::InsertTool
 
     return pTool;
 } // end of wxToolBar::InsertTool
 

-bool wxToolBar::DoInsertTool(
-  size_t                            WXUNUSED(nPos)
-, wxToolBarToolBase*                pToolBase
-)
+bool wxToolBar::DoInsertTool( size_t WXUNUSED(nPos),
+                              wxToolBarToolBase* pToolBase )

 {
 {

-    wxToolBarTool*                  pTool = (wxToolBarTool *)pToolBase;
+    wxToolBarTool* pTool = (wxToolBarTool *)pToolBase;

 
     pTool->m_vX = m_vXPos;
     if (pTool->m_vX == -1)
 
     pTool->m_vX = m_vXPos;
     if (pTool->m_vX == -1)


@@ -303,27 +307,23 @@ bool wxToolBar::DoInsertTool(
         if ((pTool->m_vY + pTool->GetNormalBitmap().GetHeight() + m_yMargin) > m_vMaxHeight)
             m_vMaxHeight = (wxCoord)((pTool->m_vY + pTool->GetHeight() + m_yMargin));
     }
         if ((pTool->m_vY + pTool->GetNormalBitmap().GetHeight() + m_yMargin) > m_vMaxHeight)
             m_vMaxHeight = (wxCoord)((pTool->m_vY + pTool->GetHeight() + m_yMargin));
     }

-    return TRUE;
+    return true;

 } // end of wxToolBar::DoInsertTool
 
 } // end of wxToolBar::DoInsertTool
 

-bool wxToolBar::DoDeleteTool(
-  size_t                            WXUNUSED(nPos)
-, wxToolBarToolBase*                pTool
-)
+bool wxToolBar::DoDeleteTool( size_t WXUNUSED(nPos),
+                              wxToolBarToolBase* pTool )

 {
     pTool->Detach();
     Refresh();
 {
     pTool->Detach();
     Refresh();

-    return TRUE;
+    return true;

 } // end of wxToolBar::DoDeleteTool
 
 } // end of wxToolBar::DoDeleteTool
 

-bool wxToolBar::Create(
-  wxWindow*                         pParent
-, wxWindowID                        vId
-, const wxPoint&                    rPos
-, const wxSize&                     rSize
-, long                              lStyle
-, const wxString&                   rsName
-)
+bool wxToolBar::Create( wxWindow* pParent,
+                        wxWindowID vId,
+                        const wxPoint& rPos,
+                        const wxSize& rSize,
+                        long lStyle,
+                        const wxString& rsName )

 {
     if ( !wxWindow::Create( pParent
                            ,vId
 {
     if ( !wxWindow::Create( pParent
                            ,vId


@@ -332,13 +332,13 @@ bool wxToolBar::Create(
                            ,lStyle
                            ,rsName
                           ))
                            ,lStyle
                            ,rsName
                           ))

-        return FALSE;
+        return false;

 
     // Set it to grey (or other 3D face colour)
     SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_MENUBAR));
     SetFont(*wxSMALL_FONT);
 
 
     // Set it to grey (or other 3D face colour)
     SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_MENUBAR));
     SetFont(*wxSMALL_FONT);
 

-    if (GetWindowStyleFlag() & wxTB_VERTICAL)
+    if (GetWindowStyleFlag() & (wxTB_LEFT | wxTB_RIGHT))

     {
         m_vLastX = 7;
         m_vLastY = 3;
     {
         m_vLastX = 7;
         m_vLastY = 3;


@@ -380,7 +380,7 @@ bool wxToolBar::Create(
     int                             nWidth  = rSize.x;
     int                             nHeight = rSize.y;
 
     int                             nWidth  = rSize.x;
     int                             nHeight = rSize.y;
 

-    if (lStyle & wxTB_HORIZONTAL)
+    if (lStyle & (wxTB_TOP | wxTB_BOTTOM))

     {
         if (nWidth <= 0)
         {
     {
         if (nWidth <= 0)
         {


@@ -418,16 +418,12 @@ bool wxToolBar::Create(
             ,nWidth
             ,nHeight
            );
             ,nWidth
             ,nHeight
            );

-    return TRUE;
+    return true;

 } // end of wxToolBar::Create
 
 wxToolBar::~wxToolBar()
 {
 } // end of wxToolBar::Create
 
 wxToolBar::~wxToolBar()
 {

-    if (m_pToolTip)
-    {
-        delete m_pToolTip;
-        m_pToolTip = NULL;
-    }
+    wxDELETE(m_pToolTip);

 } // end of wxToolBar::~wxToolBar
 
 bool wxToolBar::Realize()
 } // end of wxToolBar::~wxToolBar
 
 bool wxToolBar::Realize()


@@ -504,7 +500,7 @@ bool wxToolBar::Realize()
 
         if (pTool->IsSeparator())
         {
 
         if (pTool->IsSeparator())
         {

-            if (GetWindowStyleFlag() & wxTB_HORIZONTAL)
+            if (GetWindowStyleFlag() & (wxTB_TOP | wxTB_BOTTOM))

             {
                 pTool->m_vX = m_vLastX + nSeparatorSize;
                 pTool->m_vHeight = m_defaultHeight + m_vTextY;
             {
                 pTool->m_vX = m_vLastX + nSeparatorSize;
                 pTool->m_vHeight = m_defaultHeight + m_vTextY;


@@ -525,7 +521,7 @@ bool wxToolBar::Realize()
         }
         else if (pTool->IsButton())
         {
         }
         else if (pTool->IsButton())
         {

-            if (GetWindowStyleFlag() & wxTB_HORIZONTAL)
+            if (GetWindowStyleFlag() & (wxTB_TOP | wxTB_BOTTOM))

             {
                 if (m_nCurrentRowsOrColumns >= m_maxCols)
                 {
             {
                 if (m_nCurrentRowsOrColumns >= m_maxCols)
                 {


@@ -549,7 +545,7 @@ bool wxToolBar::Realize()
                     m_vLastY                = m_yMargin;
                 }
                 pTool->m_vX = m_vLastX + pTool->GetWidth();
                     m_vLastY                = m_yMargin;
                 }
                 pTool->m_vX = m_vLastX + pTool->GetWidth();

-                if (HasFlag(wxTB_TEXT) && !pTool->GetLabel().IsNull())
+                if ( HasFlag(wxTB_TEXT) && !pTool->GetLabel().empty() )

                     pTool->m_vY = m_vLastY + (nMaxToolHeight - m_vTextY) + m_toolPacking;
                 else
                     pTool->m_vY = m_vLastY + (nMaxToolHeight - (int)(pTool->GetHeight()/2));
                     pTool->m_vY = m_vLastY + (nMaxToolHeight - m_vTextY) + m_toolPacking;
                 else
                     pTool->m_vY = m_vLastY + (nMaxToolHeight - (int)(pTool->GetHeight()/2));


@@ -570,15 +566,15 @@ bool wxToolBar::Realize()
         node = node->GetNext();
     }
 
         node = node->GetNext();
     }
 

-    if ( GetWindowStyleFlag() & wxTB_HORIZONTAL )
+    if (GetWindowStyleFlag() & (wxTB_TOP | wxTB_BOTTOM))

         m_maxWidth += nMaxToolWidth;
     else
         m_maxHeight += nMaxToolHeight;
 
     m_maxWidth += m_xMargin;
     m_maxHeight += m_yMargin;
         m_maxWidth += nMaxToolWidth;
     else
         m_maxHeight += nMaxToolHeight;
 
     m_maxWidth += m_xMargin;
     m_maxHeight += m_yMargin;

-    m_bInitialized = TRUE;
-    return TRUE;
+    m_bInitialized = true;
+    return true;

 } // end of wxToolBar::Realize
 
 // ----------------------------------------------------------------------------
 } // end of wxToolBar::Realize
 
 // ----------------------------------------------------------------------------


@@ -602,7 +598,8 @@ void wxToolBar::OnPaint (
         return;
     nCount++;
 
         return;
     nCount++;
 

-    ::WinFillRect(vDc.GetHPS(), &vDc.m_vRclPaint, GetBackgroundColour().GetPixel());
+    wxPMDCImpl *impl = (wxPMDCImpl*) vDc.GetImpl();
+    ::WinFillRect(impl->GetHPS(), &impl->m_vRclPaint, GetBackgroundColour().GetPixel());

     for ( wxToolBarToolsList::compatibility_iterator node = m_tools.GetFirst();
           node;
           node = node->GetNext() )
     for ( wxToolBarToolsList::compatibility_iterator node = m_tools.GetFirst();
           node;
           node = node->GetNext() )


@@ -623,7 +620,7 @@ void wxToolBar::OnPaint (
             vDc.SetPen(vDarkGreyPen);
             if (HasFlag(wxTB_TEXT))
             {
             vDc.SetPen(vDarkGreyPen);
             if (HasFlag(wxTB_TEXT))
             {

-                if (HasFlag(wxTB_HORIZONTAL))
+                if (HasFlag(wxTB_TOP) || HasFlag(wxTB_BOTTOM))

                 {
                     nX = pTool->m_vX;
                     nY = pTool->m_vY - (m_vTextY - 6);
                 {
                     nX = pTool->m_vX;
                     nY = pTool->m_vY - (m_vTextY - 6);


@@ -640,7 +637,7 @@ void wxToolBar::OnPaint (
             {
                 nX = pTool->m_vX;
                 nY = pTool->m_vY;
             {
                 nX = pTool->m_vX;
                 nY = pTool->m_vY;

-                if (HasFlag(wxTB_HORIZONTAL))
+                if (HasFlag(wxTB_TOP) || HasFlag(wxTB_BOTTOM))

                     nHeight = pTool->GetHeight() - 2;
                 else
                 {
                     nHeight = pTool->GetHeight() - 2;
                 else
                 {


@@ -716,9 +713,7 @@ void wxToolBar::OnMouseEvent(
             pTool = (wxToolBarTool *)FindById(m_nCurrentTool);
             if (pTool && !pTool->IsToggled())
             {
             pTool = (wxToolBarTool *)FindById(m_nCurrentTool);
             if (pTool && !pTool->IsToggled())
             {

-                RaiseTool( pTool
-                          ,FALSE
-                         );
+                RaiseTool( pTool, FALSE );

             }
             m_nCurrentTool = -1;
             OnMouseEnter(-1);
             }
             m_nCurrentTool = -1;
             OnMouseEnter(-1);


@@ -745,9 +740,7 @@ void wxToolBar::OnMouseEvent(
             wxToolBarTool*          pOldTool = (wxToolBarTool*)FindById(m_nCurrentTool);
 
             if (pOldTool && !pTool->IsToggled())
             wxToolBarTool*          pOldTool = (wxToolBarTool*)FindById(m_nCurrentTool);
 
             if (pOldTool && !pTool->IsToggled())

-                RaiseTool( pOldTool
-                          ,FALSE
-                         );
+                RaiseTool( pOldTool, FALSE );

             m_nCurrentTool = pTool->GetId();
             OnMouseEnter(m_nCurrentTool);
             if (!pTool->GetShortHelp().empty())
             m_nCurrentTool = pTool->GetId();
             OnMouseEnter(m_nCurrentTool);
             if (!pTool->GetShortHelp().empty())


@@ -810,27 +803,20 @@ void wxToolBar::OnMouseEvent(
 // drawing
 // ----------------------------------------------------------------------------
 
 // drawing
 // ----------------------------------------------------------------------------
 

-void wxToolBar::DrawTool(
-  wxToolBarToolBase*                pTool
-)
+void wxToolBar::DrawTool( wxToolBarToolBase* pTool )

 {
 {

-    wxClientDC                      vDc(this);
+    wxClientDC vDc(this);

 
 

-    DrawTool( vDc
-             ,pTool
-            );
+    DrawTool( vDc, pTool );

 } // end of wxToolBar::DrawTool
 
 } // end of wxToolBar::DrawTool
 

-void wxToolBar::DrawTool(
-  wxDC&                             rDc
-, wxToolBarToolBase*                pToolBase
-)
+void wxToolBar::DrawTool( wxDC& rDc, wxToolBarToolBase* pToolBase )

 {
     wxToolBarTool* pTool = (wxToolBarTool *)pToolBase;
     wxColour gray85( 85,85,85 );
     wxPen vDarkGreyPen( gray85, 1, wxSOLID );
     wxBitmap vBitmap = pTool->GetNormalBitmap();
 {
     wxToolBarTool* pTool = (wxToolBarTool *)pToolBase;
     wxColour gray85( 85,85,85 );
     wxPen vDarkGreyPen( gray85, 1, wxSOLID );
     wxBitmap vBitmap = pTool->GetNormalBitmap();

-    bool bUseMask = FALSE;
+    bool bUseMask = false;

     wxMask* pMask = NULL;
 
     PrepareDC(rDc);
     wxMask* pMask = NULL;
 
     PrepareDC(rDc);


@@ -839,7 +825,7 @@ void wxToolBar::DrawTool(
         return;
     if ((pMask = vBitmap.GetMask()) != NULL)
         if (pMask->GetMaskBitmap() != NULLHANDLE)
         return;
     if ((pMask = vBitmap.GetMask()) != NULL)
         if (pMask->GetMaskBitmap() != NULLHANDLE)

-            bUseMask = TRUE;
+            bUseMask = true;

 
     if (!pTool->IsToggled())
     {
 
     if (!pTool->IsToggled())
     {


@@ -872,7 +858,7 @@ void wxToolBar::DrawTool(
         {
             RaiseTool(pTool);
         }
         {
             RaiseTool(pTool);
         }

-        if (HasFlag(wxTB_TEXT) && !pTool->GetLabel().IsNull())
+        if ( HasFlag(wxTB_TEXT) && !pTool->GetLabel().empty() )

         {
             wxCoord                 vX;
             wxCoord                 vY;
         {
             wxCoord                 vX;
             wxCoord                 vY;


@@ -889,7 +875,7 @@ void wxToolBar::DrawTool(
                 GetSize(&vX, &vY);
                 rDc.DrawText( pTool->GetLabel()
                              ,vLeft
                 GetSize(&vX, &vY);
                 rDc.DrawText( pTool->GetLabel()
                              ,vLeft

-                             ,vY - (m_vTextY - 2)
+                             ,vY - m_vTextY - 1

                             );
             }
             else  // normal tools
                             );
             }
             else  // normal tools


@@ -897,7 +883,7 @@ void wxToolBar::DrawTool(
                 vLeft += (wxCoord)((m_vTextX - vX)/2);
                 rDc.DrawText( pTool->GetLabel()
                              ,vLeft
                 vLeft += (wxCoord)((m_vTextX - vX)/2);
                 rDc.DrawText( pTool->GetLabel()
                              ,vLeft

-                             ,pTool->m_vY + m_vTextY + 4 // a bit of margin
+                             ,pTool->m_vY + m_vTextY - 1 // a bit of margin

                             );
             }
         }
                             );
             }
         }


@@ -917,7 +903,7 @@ void wxToolBar::DrawTool(
                        ,pTool->m_vY
                        ,bUseMask
                       );
                        ,pTool->m_vY
                        ,bUseMask
                       );

-        if (HasFlag(wxTB_TEXT) && !pTool->GetLabel().IsNull())
+        if ( HasFlag(wxTB_TEXT) && !pTool->GetLabel().empty() )

         {
             wxCoord                 vX;
             wxCoord                 vY;
         {
             wxCoord                 vX;
             wxCoord                 vY;


@@ -931,7 +917,7 @@ void wxToolBar::DrawTool(
             vLeft += (wxCoord)((m_vTextX - vX)/2);
             rDc.DrawText( pTool->GetLabel()
                          ,vLeft
             vLeft += (wxCoord)((m_vTextX - vX)/2);
             rDc.DrawText( pTool->GetLabel()
                          ,vLeft

-                         ,pTool->m_vY + m_vTextY + 4 // a bit of margin
+                         ,pTool->m_vY + m_vTextY - 1 // a bit of margin

                         );
         }
     }
                         );
         }
     }


@@ -945,7 +931,7 @@ void wxToolBar::SetRows(
   int                               nRows
 )
 {
   int                               nRows
 )
 {

-    wxCHECK_RET( nRows != 0, _T("max number of rows must be > 0") );
+    wxCHECK_RET( nRows != 0, wxT("max number of rows must be > 0") );

 
     m_maxCols = (GetToolsCount() + nRows - 1) / nRows;
     Refresh();
 
     m_maxCols = (GetToolsCount() + nRows - 1) / nRows;
     Refresh();


@@ -967,7 +953,7 @@ wxToolBarToolBase* wxToolBar::FindToolForPosition(
     {
         wxToolBarTool*              pTool = (wxToolBarTool *)node->GetData();
 
     {
         wxToolBarTool*              pTool = (wxToolBarTool *)node->GetData();
 

-        if (HasFlag(wxTB_TEXT) && !pTool->GetLabel().IsNull())
+        if ( HasFlag(wxTB_TEXT) && !pTool->GetLabel().empty() )

         {
             if ((vX >= (pTool->m_vX - ((wxCoord)(pTool->GetWidth()/2) - 2))) &&
                 (vY >= (pTool->m_vY - 2)) &&
         {
             if ((vX >= (pTool->m_vX - ((wxCoord)(pTool->GetWidth()/2) - 2))) &&
                 (vY >= (pTool->m_vY - 2)) &&


@@ -989,7 +975,7 @@ wxToolBarToolBase* wxToolBar::FindToolForPosition(
         }
         node = node->GetNext();
     }
         }
         node = node->GetNext();
     }

-    return (wxToolBarToolBase *)NULL;
+    return NULL;

 } // end of wxToolBar::FindToolForPosition
 
 // ----------------------------------------------------------------------------
 } // end of wxToolBar::FindToolForPosition
 
 // ----------------------------------------------------------------------------


@@ -1179,21 +1165,17 @@ void wxToolBar::RaiseTool ( wxToolBarToolBase* pToolBase,
     }
 } // end of wxToolBar::RaiseTool
 
     }
 } // end of wxToolBar::RaiseTool
 

-void wxToolBar::OnTimer (
-  wxTimerEvent&                     rEvent
-)
+void wxToolBar::OnTimer ( wxTimerEvent& rEvent )

 {
 {

-    if (rEvent.GetId() == m_vToolTimer.GetTimerId())
+    if (rEvent.GetId() == m_vToolTimer.GetId())

     {
     {

-        wxPoint                     vPos( m_vXMouse
-                                         ,m_vYMouse
-                                        );
+        wxPoint vPos( m_vXMouse, m_vYMouse );

 
         m_pToolTip->DisplayToolTipWindow(vPos);
         m_vToolTimer.Stop();
         m_vToolExpTimer.Start(4000L, TRUE);
     }
 
         m_pToolTip->DisplayToolTipWindow(vPos);
         m_vToolTimer.Stop();
         m_vToolExpTimer.Start(4000L, TRUE);
     }

-    else if (rEvent.GetId() == m_vToolExpTimer.GetTimerId())
+    else if (rEvent.GetId() == m_vToolExpTimer.GetId())

     {
         m_pToolTip->HideToolTipWindow();
         GetParent()->Refresh();
     {
         m_pToolTip->HideToolTipWindow();
         GetParent()->Refresh();