// Name: msw/timer.cpp
// Purpose: wxTimer implementation
// Author: Julian Smart
-// Modified by:
+// Modified by: Vadim Zeitlin (use hash map instead of list, global rewrite)
// Created: 04/01/98
// RCS-ID: $Id$
// Copyright: (c) Julian Smart
#include "wx/msw/private.h"
-// from utils.cpp
-extern "C" WXDLLIMPEXP_BASE HWND
-wxCreateHiddenWindow(LPCTSTR *pclassname, LPCTSTR classname, WNDPROC wndproc);
-
// ----------------------------------------------------------------------------
// private globals
// ----------------------------------------------------------------------------
WX_DECLARE_HASH_MAP(unsigned long, wxTimer *, wxIntegerHash, wxIntegerEqual,
wxTimerMap);
-static wxTimerMap g_timerMap;
+// instead of using a global here, wrap it in a static function as otherwise it
+// could have been used before being initialized if a timer object were created
+// globally
+static wxTimerMap& TimerMap()
+{
+ static wxTimerMap s_timerMap;
+
+ return s_timerMap;
+}
// ----------------------------------------------------------------------------
// private functions
// ----------------------------------------------------------------------------
-void WINAPI wxTimerProc(HWND hwnd, WORD, int idTimer, DWORD);
+// timer callback used for all timers
+void WINAPI wxTimerProc(HWND hwnd, UINT msg, UINT idTimer, DWORD dwTime);
// ----------------------------------------------------------------------------
// macros
{
(void)wxTimerBase::Start(milliseconds, oneShot);
- wxCHECK_MSG( m_milli > 0, false, wxT("invalid value for timer timeour") );
+ wxCHECK_MSG( m_milli > 0, false, wxT("invalid value for timer timeout") );
m_id = ::SetTimer
(
NULL, // don't use window
1, // id ignored with NULL hwnd anyhow
(UINT)m_milli, // delay
- (TIMERPROC)wxTimerProc // timer proc to call
+ wxTimerProc // timer proc to call
);
if ( !m_id )
// check that SetTimer() didn't reuse an existing id: according to the MSDN
// this can happen and this would be catastrophic to us as we rely on ids
// uniquely identifying the timers because we use them as keys in the hash
- if ( g_timerMap.find(m_id) != g_timerMap.end() )
+ if ( TimerMap().find(m_id) != TimerMap().end() )
{
wxLogError(_("Timer creation failed."));
return false;
}
- g_timerMap[m_id] = this;
+ TimerMap()[m_id] = this;
return true;
}
{
::KillTimer(NULL, m_id);
- g_timerMap.erase(m_id);
+ TimerMap().erase(m_id);
}
m_id = 0;
timer.Notify();
}
-void WINAPI wxTimerProc(HWND WXUNUSED(hwnd), WORD, int idTimer, DWORD)
+void WINAPI
+wxTimerProc(HWND WXUNUSED(hwnd),
+ UINT WXUNUSED(msg),
+ UINT idTimer,
+ DWORD WXUNUSED(dwTime))
{
- wxTimerMap::iterator node = g_timerMap.find(idTimer);
+ wxTimerMap::iterator node = TimerMap().find((unsigned long)idTimer);
- wxCHECK_RET( node != g_timerMap.end(), wxT("bogus timer id in wxTimerProc") );
+ wxCHECK_RET( node != TimerMap().end(), wxT("bogus timer id in wxTimerProc") );
wxProcessTimer(*(node->second));
}