don't crash if one of GetAllCommands() parameters is NULL (coverity checker CID 11)

[wxWidgets.git] / src / common / fs_inet.cpp

diff --git a/src/common/fs_inet.cpp b/src/common/fs_inet.cpp
index af90f422350048cb63bd6cccdd9a5dabf7d9e64d..f32d068f1271193ba2a9acf670bb72647046b2a5 100644 (file)
--- a/src/common/fs_inet.cpp
+++ b/src/common/fs_inet.cpp
@@ -3,29 +3,12 @@
 // Purpose:     HTTP and FTP file system
 // Author:      Vaclav Slavik
 // Copyright:   (c) 1999 Vaclav Slavik
 // Purpose:     HTTP and FTP file system
 // Author:      Vaclav Slavik
 // Copyright:   (c) 1999 Vaclav Slavik

-// Licence:     wxWindows Licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-/*
-
-REMARKS :
-
-This FS creates local cache (in /tmp directory). The cache is freed
-on program exit.
-
-Size of cache is limited to cca 1000 items (due to GetTempFileName
-limitation)
-
-
-*/
-
-#ifdef __GNUG__
-#pragma implementation
-#endif
-

 #include "wx/wxprec.h"
 
 #include "wx/wxprec.h"
 

-#ifdef __BORDLANDC__
+#ifdef __BORLANDC__

 #pragma hdrstop
 #endif
 
 #pragma hdrstop
 #endif
 


@@ -34,10 +17,9 @@ limitation)
     #define wxUSE_FS_INET 0
 #endif
 
     #define wxUSE_FS_INET 0
 #endif
 

-#if wxUSE_FS_INET
+#if wxUSE_FILESYSTEM && wxUSE_FS_INET

 
 #ifndef WXPRECOMP
 
 #ifndef WXPRECOMP

-#include "wx/wx.h"

 #endif
 
 #include "wx/wfstream.h"
 #endif
 
 #include "wx/wfstream.h"


@@ -46,35 +28,46 @@ limitation)
 #include "wx/fs_inet.h"
 #include "wx/module.h"
 
 #include "wx/fs_inet.h"
 #include "wx/module.h"
 

-class wxInetCacheNode : public wxObject
-{
-    private:
-        wxString m_Temp;
-        wxString m_Mime;
-
-    public:
-        wxInetCacheNode(const wxString& l, const wxString& m) : wxObject() {m_Temp = l; m_Mime = m;}
-        const wxString& GetTemp() const {return m_Temp;}
-        const wxString& GetMime() const {return m_Mime;}
-};
+// ----------------------------------------------------------------------------
+// Helper classes
+// ----------------------------------------------------------------------------

 
 

+// This stream deletes the file when destroyed
+class wxTemporaryFileInputStream : public wxFileInputStream
+{
+public:
+    wxTemporaryFileInputStream(const wxString& filename) :
+        wxFileInputStream(filename), m_filename(filename) {}

 
 

+    ~wxTemporaryFileInputStream()
+    {
+        // NB: copied from wxFileInputStream dtor, we need to do it before
+        //     wxRemoveFile
+        if (m_file_destroy)
+        {
+            delete m_file;
+            m_file_destroy = false;
+        }
+        wxRemoveFile(m_filename);
+    }

 
 

+protected:
+    wxString m_filename;
+};

 
 
 
 

-//--------------------------------------------------------------------------------
+// ----------------------------------------------------------------------------

 // wxInternetFSHandler
 // wxInternetFSHandler

-//--------------------------------------------------------------------------------
-
+// ----------------------------------------------------------------------------

 
 static wxString StripProtocolAnchor(const wxString& location)
 {
     wxString myloc(location.BeforeLast(wxT('#')));
 
 static wxString StripProtocolAnchor(const wxString& location)
 {
     wxString myloc(location.BeforeLast(wxT('#')));

-    if (myloc.IsEmpty()) myloc = location.AfterFirst(wxT(':'));
+    if (myloc.empty()) myloc = location.AfterFirst(wxT(':'));

     else myloc = myloc.AfterFirst(wxT(':'));
 
     // fix malformed url:
     else myloc = myloc.AfterFirst(wxT(':'));
 
     // fix malformed url:

-    if (myloc.Left(2) != wxT("//")) 
+    if (!myloc.Left(2).IsSameAs(wxT("//")))

     {
         if (myloc.GetChar(0) != wxT('/')) myloc = wxT("//") + myloc;
         else myloc = wxT("/") + myloc;
     {
         if (myloc.GetChar(0) != wxT('/')) myloc = wxT("//") + myloc;
         else myloc = wxT("/") + myloc;


@@ -85,88 +78,62 @@ static wxString StripProtocolAnchor(const wxString& location)
 }
 
 
 }
 
 

-

 bool wxInternetFSHandler::CanOpen(const wxString& location)
 {
 bool wxInternetFSHandler::CanOpen(const wxString& location)
 {

+#if wxUSE_URL

     wxString p = GetProtocol(location);
     wxString p = GetProtocol(location);

-    if ((p == wxT("http")) || (p == wxT("ftp"))) 
+    if ((p == wxT("http")) || (p == wxT("ftp")))

     {
         wxURL url(p + wxT(":") + StripProtocolAnchor(location));
         return (url.GetError() == wxURL_NOERR);
     }
     {
         wxURL url(p + wxT(":") + StripProtocolAnchor(location));
         return (url.GetError() == wxURL_NOERR);
     }

-    else 
-        return FALSE;
+#endif
+    return false;

 }
 
 
 }
 
 

-wxFSFile* wxInternetFSHandler::OpenFile(wxFileSystem& WXUNUSED(fs), const wxString& location)
+wxFSFile* wxInternetFSHandler::OpenFile(wxFileSystem& WXUNUSED(fs),
+                                        const wxString& location)

 {
 {

-    wxString right = GetProtocol(location) + wxT(":") + StripProtocolAnchor(location);
-    wxInputStream *s;
-    wxString content;
-    wxInetCacheNode *info;
-
-    info = (wxInetCacheNode*) m_Cache.Get(right);
-
-    // Add item into cache:
-    if (info == NULL)
+#if !wxUSE_URL
+    return NULL;
+#else
+    wxString right =
+        GetProtocol(location) + wxT(":") + StripProtocolAnchor(location);
+
+    wxURL url(right);
+    if (url.GetError() == wxURL_NOERR)

     {
     {

-        wxURL url(right);
-        if (url.GetError() == wxURL_NOERR) 
+        wxInputStream *s = url.GetInputStream();
+        wxString content = url.GetProtocol().GetContentType();
+        if (content == wxEmptyString) content = GetMimeTypeFromExt(location);
+        if (s)

         {
         {

-            s = url.GetInputStream();
-            content = url.GetProtocol().GetContentType();
-            if (content == wxEmptyString) content = GetMimeTypeFromExt(location);
-            if (s)
-            {
-                wxChar buf[256];
-
-                wxGetTempFileName( wxT("wxhtml"), buf);
-                info = new wxInetCacheNode(buf, content);
-                m_Cache.Put(right, info);
-
-                {   // ok, now copy it:
-                    wxFileOutputStream sout((wxString)buf);
-                    s -> Read(sout); // copy the stream
-                }
-                delete s;
+            wxString tmpfile =
+                wxFileName::CreateTempFileName(wxT("wxhtml"));
+
+            {   // now copy streams content to temporary file:
+                wxFileOutputStream sout(tmpfile);
+                s->Read(sout);

             }
             }

-            else
-                return (wxFSFile*) NULL; // we can't open the URL
+            delete s;
+
+            return new wxFSFile(new wxTemporaryFileInputStream(tmpfile),
+                                right,
+                                content,
+                                GetAnchor(location)
+#if wxUSE_DATETIME
+                                , wxDateTime::Now()
+#endif // wxUSE_DATETIME
+                        );

         }
         }

-        else
-            return (wxFSFile*) NULL; // incorrect URL

     }
 
     }
 

-    // Load item from cache:
-    s = new wxFileInputStream(info->GetTemp());
-    if (s)
-    {
-        return new wxFSFile(s,
-                            right,
-                            info->GetMime(),
-                            GetAnchor(location),
-                            wxDateTime::Now());
-    }
-    else return (wxFSFile*) NULL;
+    return (wxFSFile*) NULL; // incorrect URL
+#endif

 }
 
 
 }
 
 

-
-wxInternetFSHandler::~wxInternetFSHandler()
-{
-    wxNode *n;
-    wxInetCacheNode *n2;
-
-    m_Cache.BeginFind();
-    while ((n = m_Cache.Next()) != NULL)
-    {
-        n2 = (wxInetCacheNode*) n->GetData();
-        wxRemoveFile(n2->GetTemp());
-        delete n2;
-    }
-}
-

 class wxFileSystemInternetModule : public wxModule
 {
     DECLARE_DYNAMIC_CLASS(wxFileSystemInternetModule)
 class wxFileSystemInternetModule : public wxModule
 {
     DECLARE_DYNAMIC_CLASS(wxFileSystemInternetModule)


@@ -175,11 +142,11 @@ class wxFileSystemInternetModule : public wxModule
         virtual bool OnInit()
         {
             wxFileSystem::AddHandler(new wxInternetFSHandler);
         virtual bool OnInit()
         {
             wxFileSystem::AddHandler(new wxInternetFSHandler);

-            return TRUE;
+            return true;

         }
         virtual void OnExit() {}
 };
 
 IMPLEMENT_DYNAMIC_CLASS(wxFileSystemInternetModule, wxModule)
 
         }
         virtual void OnExit() {}
 };
 
 IMPLEMENT_DYNAMIC_CLASS(wxFileSystemInternetModule, wxModule)
 

-#endif // wxUSE_FS_INET
+#endif // wxUSE_FILESYSTEM && wxUSE_FS_INET