wxTLW: don't assert when setting null icons initially (#10138)

[wxWidgets.git] / src / msw / font.cpp

diff --git a/src/msw/font.cpp b/src/msw/font.cpp
index 5fcc96ffc8c6b82c7a739617a6bae6d1c16233a8..f2ff677d8a5549ceb1bb0df591115c79328be2fd 100644 (file)
--- a/src/msw/font.cpp
+++ b/src/msw/font.cpp
@@ -39,6 +39,10 @@
 #include "wx/fontutil.h"
 #include "wx/fontmap.h"
 
 #include "wx/fontutil.h"
 #include "wx/fontmap.h"
 

+#ifndef __WXWINCE__
+    #include "wx/sysopt.h"
+#endif
+

 #include "wx/tokenzr.h"
 
 #if wxUSE_EXTENDED_RTTI
 #include "wx/tokenzr.h"
 
 #if wxUSE_EXTENDED_RTTI


@@ -145,7 +149,7 @@ public:
     virtual ~wxFontRefData();
 
     // operations
     virtual ~wxFontRefData();
 
     // operations

-    bool Alloc(wxFont *font);
+    bool Alloc(const wxFont *font);

 
     void Free();
 
 
     void Free();
 


@@ -207,11 +211,26 @@ public:
                                   : m_encoding;
     }
 
                                   : m_encoding;
     }
 

-    WXHFONT GetHFONT() const { return m_hFont; }
+    WXHFONT GetHFONT(const wxFont *font) const
+    {
+        if ( !m_hFont )
+            wx_const_cast(wxFontRefData *, this)->Alloc(font);
+
+        return (WXHFONT)m_hFont;
+    }

 
 

-    // ... and setters
+    bool HasHFONT() const
+    {
+        return m_hFont != 0;
+    }
+
+    // ... and setters: notice that all of them invalidate the currently
+    // allocated HFONT, if any, so that the next call to GetHFONT() recreates a
+    // new one

     void SetPointSize(int pointSize)
     {
     void SetPointSize(int pointSize)
     {

+        Free();
+

         if ( m_nativeFontInfoOk )
         {
             m_nativeFontInfo.SetPointSize(pointSize);
         if ( m_nativeFontInfoOk )
         {
             m_nativeFontInfo.SetPointSize(pointSize);


@@ -225,6 +244,8 @@ public:
 
     void SetPixelSize(const wxSize& pixelSize)
     {
 
     void SetPixelSize(const wxSize& pixelSize)
     {

+        Free();
+

         if ( m_nativeFontInfoOk )
         {
             m_nativeFontInfo.SetPixelSize(pixelSize);
         if ( m_nativeFontInfoOk )
         {
             m_nativeFontInfo.SetPixelSize(pixelSize);


@@ -238,11 +259,15 @@ public:
 
     void SetFamily(int family)
     {
 
     void SetFamily(int family)
     {

+        Free();
+

         m_family = family;
     }
 
     void SetStyle(int style)
     {
         m_family = family;
     }
 
     void SetStyle(int style)
     {

+        Free();
+

         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetStyle((wxFontStyle)style);
         else
         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetStyle((wxFontStyle)style);
         else


@@ -251,6 +276,8 @@ public:
 
     void SetWeight(int weight)
     {
 
     void SetWeight(int weight)
     {

+        Free();
+

         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetWeight((wxFontWeight)weight);
         else
         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetWeight((wxFontWeight)weight);
         else


@@ -259,15 +286,19 @@ public:
 
     bool SetFaceName(const wxString& faceName)
     {
 
     bool SetFaceName(const wxString& faceName)
     {

+        Free();
+

         if ( m_nativeFontInfoOk )
             return m_nativeFontInfo.SetFaceName(faceName);
 
         if ( m_nativeFontInfoOk )
             return m_nativeFontInfo.SetFaceName(faceName);
 

-            m_faceName = faceName;
+        m_faceName = faceName;

         return true;
     }
 
     void SetUnderlined(bool underlined)
     {
         return true;
     }
 
     void SetUnderlined(bool underlined)
     {

+        Free();
+

         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetUnderlined(underlined);
         else
         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetUnderlined(underlined);
         else


@@ -276,18 +307,28 @@ public:
 
     void SetEncoding(wxFontEncoding encoding)
     {
 
     void SetEncoding(wxFontEncoding encoding)
     {

+        Free();
+

         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetEncoding(encoding);
         else
             m_encoding = encoding;
     }
 
         if ( m_nativeFontInfoOk )
             m_nativeFontInfo.SetEncoding(encoding);
         else
             m_encoding = encoding;
     }
 

-    // native font info tests
+    // native font info

     bool HasNativeFontInfo() const { return m_nativeFontInfoOk; }
 
     const wxNativeFontInfo& GetNativeFontInfo() const
         { return m_nativeFontInfo; }
 
     bool HasNativeFontInfo() const { return m_nativeFontInfoOk; }
 
     const wxNativeFontInfo& GetNativeFontInfo() const
         { return m_nativeFontInfo; }
 

+    void SetNativeFontInfo(const wxNativeFontInfo& nativeFontInfo)
+    {
+        Free();
+
+        m_nativeFontInfo = nativeFontInfo;
+        m_nativeFontInfoOk = true;
+    }
+

 protected:
     // common part of all ctors
     void Init(int size,
 protected:
     // common part of all ctors
     void Init(int size,


@@ -302,7 +343,7 @@ protected:
 
     void Init(const wxNativeFontInfo& info, WXHFONT hFont = 0);
 
 
     void Init(const wxNativeFontInfo& info, WXHFONT hFont = 0);
 

-    // font characterstics
+    // font characteristics

     int           m_pointSize;
     wxSize        m_pixelSize;
     bool          m_sizeUsingPixels;
     int           m_pointSize;
     wxSize        m_pixelSize;
     bool          m_sizeUsingPixels;


@@ -313,14 +354,16 @@ protected:
     wxString      m_faceName;
     wxFontEncoding m_encoding;
 
     wxString      m_faceName;
     wxFontEncoding m_encoding;
 

-    // Windows font handle
-    WXHFONT       m_hFont;
+    // Windows font handle, created on demand in GetHFONT()
+    HFONT         m_hFont;

 
     // Native font info
     wxNativeFontInfo m_nativeFontInfo;
     bool             m_nativeFontInfoOk;
 };
 
 
     // Native font info
     wxNativeFontInfo m_nativeFontInfo;
     bool             m_nativeFontInfoOk;
 };
 

+#define M_FONTDATA ((wxFontRefData*)m_refData)
+

 // ============================================================================
 // implementation
 // ============================================================================
 // ============================================================================
 // implementation
 // ============================================================================


@@ -361,7 +404,7 @@ void wxFontRefData::Init(const wxNativeFontInfo& info, WXHFONT hFont)
     // use the exact font created in the underlying system
     // (for example where we can't guarantee conversion from HFONT
     // to LOGFONT back to HFONT)
     // use the exact font created in the underlying system
     // (for example where we can't guarantee conversion from HFONT
     // to LOGFONT back to HFONT)

-    m_hFont = hFont;
+    m_hFont = (HFONT)hFont;

 
     m_nativeFontInfoOk = true;
     m_nativeFontInfo = info;
 
     m_nativeFontInfoOk = true;
     m_nativeFontInfo = info;


@@ -375,7 +418,7 @@ wxFontRefData::~wxFontRefData()
     Free();
 }
 
     Free();
 }
 

-bool wxFontRefData::Alloc(wxFont *font)
+bool wxFontRefData::Alloc(const wxFont *font)

 {
     if ( !m_nativeFontInfoOk )
     {
 {
     if ( !m_nativeFontInfoOk )
     {


@@ -383,14 +426,13 @@ bool wxFontRefData::Alloc(wxFont *font)
         m_nativeFontInfoOk = true;
     }
 
         m_nativeFontInfoOk = true;
     }
 

-    HFONT hfont = ::CreateFontIndirect(&m_nativeFontInfo.lf);
-    if ( !hfont )
+    m_hFont = ::CreateFontIndirect(&m_nativeFontInfo.lf);
+    if ( !m_hFont )

     {
         wxLogLastError(wxT("CreateFont"));
         return false;
     }
 
     {
         wxLogLastError(wxT("CreateFont"));
         return false;
     }
 

-    m_hFont = (WXHFONT)hfont;

     return true;
 }
 
     return true;
 }
 


@@ -398,7 +440,7 @@ void wxFontRefData::Free()
 {
     if ( m_hFont )
     {
 {
     if ( m_hFont )
     {

-        if ( !::DeleteObject((HFONT) m_hFont) )
+        if ( !::DeleteObject(m_hFont) )

         {
             wxLogLastError(wxT("DeleteObject(font)"));
         }
         {
             wxLogLastError(wxT("DeleteObject(font)"));
         }


@@ -414,6 +456,18 @@ void wxFontRefData::Free()
 void wxNativeFontInfo::Init()
 {
     wxZeroMemory(lf);
 void wxNativeFontInfo::Init()
 {
     wxZeroMemory(lf);

+
+    // we get better font quality if we use PROOF_QUALITY instead of
+    // DEFAULT_QUALITY but some fonts (e.g. "Terminal 6pt") are not available
+    // then so we allow to set a global option to choose between quality and
+    // wider font selection
+#ifdef __WXWINCE__
+    lf.lfQuality = CLEARTYPE_QUALITY;
+#else
+    lf.lfQuality = wxSystemOptions::GetOptionInt(_T("msw.font.no-proof-quality"))
+                    ? DEFAULT_QUALITY
+                    : PROOF_QUALITY;
+#endif

 }
 
 int wxNativeFontInfo::GetPointSize() const
 }
 
 int wxNativeFontInfo::GetPointSize() const


@@ -422,13 +476,14 @@ int wxNativeFontInfo::GetPointSize() const
     //        for printing!
     const int ppInch = ::GetDeviceCaps(ScreenHDC(), LOGPIXELSY);
 
     //        for printing!
     const int ppInch = ::GetDeviceCaps(ScreenHDC(), LOGPIXELSY);
 

-    return (int) (((72.0*(double)abs(lf.lfHeight)) / (double) ppInch) + 0.5);
+    // BC++ 2007 doesn't provide abs(long) overload, hence the cast
+    return (int) (((72.0*abs((int)lf.lfHeight)) / (double) ppInch) + 0.5);

 }
 
 wxSize wxNativeFontInfo::GetPixelSize() const
 {
     wxSize ret;
 }
 
 wxSize wxNativeFontInfo::GetPixelSize() const
 {
     wxSize ret;

-    ret.SetHeight(lf.lfHeight);
+    ret.SetHeight(abs((int)lf.lfHeight));

     ret.SetWidth(lf.lfWidth);
     return ret;
 }
     ret.SetWidth(lf.lfWidth);
     return ret;
 }


@@ -630,7 +685,7 @@ void wxNativeFontInfo::SetFamily(wxFontFamily family)
             // is returned as default GUI font for compatibility
             int verMaj;
             ff_family = FF_SWISS;
             // is returned as default GUI font for compatibility
             int verMaj;
             ff_family = FF_SWISS;

-            if(wxGetOsVersion(&verMaj) == wxWINDOWS_NT && verMaj >= 5)
+            if(wxGetOsVersion(&verMaj) == wxOS_WINDOWS_NT && verMaj >= 5)

                 facename.Add(_T("MS Shell Dlg 2"));
             else
                 facename.Add(_T("MS Shell Dlg"));
                 facename.Add(_T("MS Shell Dlg 2"));
             else
                 facename.Add(_T("MS Shell Dlg"));


@@ -781,7 +836,7 @@ wxString wxNativeFontInfo::ToString() const
              lf.lfClipPrecision,
              lf.lfQuality,
              lf.lfPitchAndFamily,
              lf.lfClipPrecision,
              lf.lfQuality,
              lf.lfPitchAndFamily,

-             lf.lfFaceName);
+             (const wxChar*)lf.lfFaceName);

 
     return s;
 }
 
     return s;
 }


@@ -796,9 +851,7 @@ bool wxFont::Create(const wxNativeFontInfo& info, WXHFONT hFont)
 
     m_refData = new wxFontRefData(info, hFont);
 
 
     m_refData = new wxFontRefData(info, hFont);
 

-    RealizeResource();
-
-    return true;
+    return RealizeResource();

 }
 
 wxFont::wxFont(const wxString& fontdesc)
 }
 
 wxFont::wxFont(const wxString& fontdesc)


@@ -808,9 +861,6 @@ wxFont::wxFont(const wxString& fontdesc)
         (void)Create(info);
 }
 
         (void)Create(info);
 }
 

-/* Constructor for a font. Note that the real construction is done
- * in wxDC::SetFont, when information is available about scaling etc.
- */

 bool wxFont::DoCreate(int pointSize,
                       const wxSize& pixelSize,
                       bool sizeUsingPixels,
 bool wxFont::DoCreate(int pointSize,
                       const wxSize& pixelSize,
                       bool sizeUsingPixels,


@@ -834,9 +884,7 @@ bool wxFont::DoCreate(int pointSize,
                                   family, style, weight,
                                   underlined, faceName, encoding);
 
                                   family, style, weight,
                                   underlined, faceName, encoding);
 

-    RealizeResource();
-
-    return true;
+    return RealizeResource();

 }
 
 wxFont::~wxFont()
 }
 
 wxFont::~wxFont()


@@ -847,28 +895,33 @@ wxFont::~wxFont()
 // real implementation
 // ----------------------------------------------------------------------------
 
 // real implementation
 // ----------------------------------------------------------------------------
 

+wxGDIRefData *wxFont::CreateGDIRefData() const
+{
+    return new wxFontRefData();
+}
+
+wxGDIRefData *wxFont::CloneGDIRefData(const wxGDIRefData *data) const
+{
+    return new wxFontRefData(*wx_static_cast(const wxFontRefData *, data));
+}
+

 bool wxFont::RealizeResource()
 {
 bool wxFont::RealizeResource()
 {

-    if ( GetResourceHandle() )
-    {
-        // VZ: the old code returned false in this case, but it doesn't seem
-        //     to make sense because the font _was_ created
+    // don't do anything if we already have a valid font
+    if ( GetHFONT() )

         return true;
         return true;

-    }

 
     return M_FONTDATA->Alloc(this);
 }
 
 bool wxFont::FreeResource(bool WXUNUSED(force))
 {
 
     return M_FONTDATA->Alloc(this);
 }
 
 bool wxFont::FreeResource(bool WXUNUSED(force))
 {

-    if ( GetResourceHandle() )
-    {
-        M_FONTDATA->Free();
+    if ( !GetHFONT() )
+        return false;

 
 

-        return true;
-    }
+    M_FONTDATA->Free();

 
 

-    return false;
+    return true;

 }
 
 WXHANDLE wxFont::GetResourceHandle() const
 }
 
 WXHANDLE wxFont::GetResourceHandle() const


@@ -878,27 +931,12 @@ WXHANDLE wxFont::GetResourceHandle() const
 
 WXHFONT wxFont::GetHFONT() const
 {
 
 WXHFONT wxFont::GetHFONT() const
 {

-    return M_FONTDATA ? M_FONTDATA->GetHFONT() : 0;
+    return M_FONTDATA ? M_FONTDATA->GetHFONT(this) : 0;

 }
 
 bool wxFont::IsFree() const
 {
 }
 
 bool wxFont::IsFree() const
 {

-    return M_FONTDATA && (M_FONTDATA->GetHFONT() == 0);
-}
-
-void wxFont::Unshare()
-{
-    // Don't change shared data
-    if ( !m_refData )
-    {
-        m_refData = new wxFontRefData();
-    }
-    else
-    {
-        wxFontRefData* ref = new wxFontRefData(*M_FONTDATA);
-        UnRef();
-        m_refData = ref;
-    }
+    return M_FONTDATA && !M_FONTDATA->HasHFONT();

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -907,56 +945,46 @@ void wxFont::Unshare()
 
 void wxFont::SetPointSize(int pointSize)
 {
 
 void wxFont::SetPointSize(int pointSize)
 {

-    Unshare();
+    AllocExclusive();

 
 

+    M_FONTDATA->Free();

     M_FONTDATA->SetPointSize(pointSize);
     M_FONTDATA->SetPointSize(pointSize);

-
-    RealizeResource();

 }
 
 void wxFont::SetPixelSize(const wxSize& pixelSize)
 {
 }
 
 void wxFont::SetPixelSize(const wxSize& pixelSize)
 {

-    Unshare();
+    AllocExclusive();

 
     M_FONTDATA->SetPixelSize(pixelSize);
 
     M_FONTDATA->SetPixelSize(pixelSize);

-
-    RealizeResource();

 }
 
 void wxFont::SetFamily(int family)
 {
 }
 
 void wxFont::SetFamily(int family)
 {

-    Unshare();
+    AllocExclusive();

 
     M_FONTDATA->SetFamily(family);
 
     M_FONTDATA->SetFamily(family);

-
-    RealizeResource();

 }
 
 void wxFont::SetStyle(int style)
 {
 }
 
 void wxFont::SetStyle(int style)
 {

-    Unshare();
+    AllocExclusive();

 
     M_FONTDATA->SetStyle(style);
 
     M_FONTDATA->SetStyle(style);

-
-    RealizeResource();

 }
 
 void wxFont::SetWeight(int weight)
 {
 }
 
 void wxFont::SetWeight(int weight)
 {

-    Unshare();
+    AllocExclusive();

 
     M_FONTDATA->SetWeight(weight);
 
     M_FONTDATA->SetWeight(weight);

-
-    RealizeResource();

 }
 
 bool wxFont::SetFaceName(const wxString& faceName)
 {
 }
 
 bool wxFont::SetFaceName(const wxString& faceName)
 {

-    Unshare();
-
-    bool refdataok = M_FONTDATA->SetFaceName(faceName);
+    AllocExclusive();

 
 

-    RealizeResource();
+    if ( !M_FONTDATA->SetFaceName(faceName) )
+        return false;

 
     // NB: using win32's GetObject() API on M_FONTDATA->GetHFONT()
     //     to retrieve a LOGFONT and then compare lf.lfFaceName
 
     // NB: using win32's GetObject() API on M_FONTDATA->GetHFONT()
     //     to retrieve a LOGFONT and then compare lf.lfFaceName


@@ -965,36 +993,28 @@ bool wxFont::SetFaceName(const wxString& faceName)
     //     without any validity check.
     //     Thus we use wxFontBase::SetFaceName to check if facename
     //     is valid...
     //     without any validity check.
     //     Thus we use wxFontBase::SetFaceName to check if facename
     //     is valid...

-    return refdataok && wxFontBase::SetFaceName(faceName);
+    return wxFontBase::SetFaceName(faceName);

 }
 
 void wxFont::SetUnderlined(bool underlined)
 {
 }
 
 void wxFont::SetUnderlined(bool underlined)
 {

-    Unshare();
+    AllocExclusive();

 
     M_FONTDATA->SetUnderlined(underlined);
 
     M_FONTDATA->SetUnderlined(underlined);

-
-    RealizeResource();

 }
 
 void wxFont::SetEncoding(wxFontEncoding encoding)
 {
 }
 
 void wxFont::SetEncoding(wxFontEncoding encoding)
 {

-    Unshare();
+    AllocExclusive();

 
     M_FONTDATA->SetEncoding(encoding);
 
     M_FONTDATA->SetEncoding(encoding);

-
-    RealizeResource();

 }
 
 void wxFont::DoSetNativeFontInfo(const wxNativeFontInfo& info)
 {
 }
 
 void wxFont::DoSetNativeFontInfo(const wxNativeFontInfo& info)
 {

-    Unshare();
-
-    FreeResource();
+    AllocExclusive();

 
 

-    *M_FONTDATA = wxFontRefData(info);
-
-    RealizeResource();
+    M_FONTDATA->SetNativeFontInfo(info);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1010,6 +1030,8 @@ int wxFont::GetPointSize() const
 
 wxSize wxFont::GetPixelSize() const
 {
 
 wxSize wxFont::GetPixelSize() const
 {

+    wxCHECK_MSG( Ok(), wxDefaultSize, wxT("invalid font") );
+

     return M_FONTDATA->GetPixelSize();
 }
 
     return M_FONTDATA->GetPixelSize();
 }
 


@@ -1064,12 +1086,14 @@ wxFontEncoding wxFont::GetEncoding() const
 
 const wxNativeFontInfo *wxFont::GetNativeFontInfo() const
 {
 
 const wxNativeFontInfo *wxFont::GetNativeFontInfo() const
 {

-    return M_FONTDATA->HasNativeFontInfo() ? &(M_FONTDATA->GetNativeFontInfo())
+    return Ok() && M_FONTDATA->HasNativeFontInfo() ? &(M_FONTDATA->GetNativeFontInfo())

                                            : NULL;
 }
 
 wxString wxFont::GetNativeFontInfoDesc() const
 {
                                            : NULL;
 }
 
 wxString wxFont::GetNativeFontInfoDesc() const
 {

+    wxCHECK_MSG( Ok(), wxEmptyString, wxT("invalid font") );
+

     // be sure we have an HFONT associated...
     wxConstCast(this, wxFont)->RealizeResource();
     return wxFontBase::GetNativeFontInfoDesc();
     // be sure we have an HFONT associated...
     wxConstCast(this, wxFont)->RealizeResource();
     return wxFontBase::GetNativeFontInfoDesc();


@@ -1077,6 +1101,8 @@ wxString wxFont::GetNativeFontInfoDesc() const
 
 wxString wxFont::GetNativeFontInfoUserDesc() const
 {
 
 wxString wxFont::GetNativeFontInfoUserDesc() const
 {

+    wxCHECK_MSG( Ok(), wxEmptyString, wxT("invalid font") );
+

     // be sure we have an HFONT associated...
     wxConstCast(this, wxFont)->RealizeResource();
     return wxFontBase::GetNativeFontInfoUserDesc();
     // be sure we have an HFONT associated...
     wxConstCast(this, wxFont)->RealizeResource();
     return wxFontBase::GetNativeFontInfoUserDesc();