Make the margin between wxSpinCtrlGeneric sub-windows compatible with MSW.

[wxWidgets.git] / src / gtk / statbox.cpp

diff --git a/src/gtk/statbox.cpp b/src/gtk/statbox.cpp
index 4d3feeb72b0fa7675a13af950b2bfe45c6140b27..b7df8b6f58cb2c2f4a983ed8024016d229fa5cd1 100644 (file)
--- a/src/gtk/statbox.cpp
+++ b/src/gtk/statbox.cpp
@@ -13,10 +13,36 @@
 #if wxUSE_STATBOX
 
 #include "wx/statbox.h"
 #if wxUSE_STATBOX
 
 #include "wx/statbox.h"

-#include "wx/gtk/private.h"
+#include "wx/gtk/private/win_gtk.h"     // for wxPizza

 
 

-#include "gdk/gdk.h"
-#include "gtk/gtk.h"
+#include <gtk/gtk.h>
+
+// constants taken from GTK sources
+#define LABEL_PAD 1
+#define LABEL_SIDE_PAD 2
+
+//-----------------------------------------------------------------------------
+// "size_allocate" from m_widget
+//-----------------------------------------------------------------------------
+
+extern "C" {
+static void size_allocate(GtkWidget* widget, GtkAllocation* alloc, void*)
+{
+    // clip label as GTK >= 2.12 does
+    GtkWidget* label_widget = gtk_frame_get_label_widget(GTK_FRAME(widget));
+    int w = alloc->width -
+        2 * widget->style->xthickness - 2 * LABEL_PAD - 2 * LABEL_SIDE_PAD;
+    if (w < 0)
+        w = 0;
+
+    if (label_widget->allocation.width > w)
+    {
+        GtkAllocation alloc2 = label_widget->allocation;
+        alloc2.width = w;
+        gtk_widget_size_allocate(label_widget, &alloc2);
+    }
+}
+}

 
 //-----------------------------------------------------------------------------
 // wxStaticBox
 
 //-----------------------------------------------------------------------------
 // wxStaticBox


@@ -47,16 +73,17 @@ bool wxStaticBox::Create( wxWindow *parent,
                           long style,
                           const wxString& name )
 {
                           long style,
                           const wxString& name )
 {

-    m_needParent = TRUE;
-

     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, wxDefaultValidator, name ))
     {
         wxFAIL_MSG( wxT("wxStaticBox creation failed") );
     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, wxDefaultValidator, name ))
     {
         wxFAIL_MSG( wxT("wxStaticBox creation failed") );

-        return FALSE;
+        return false;

     }
 
     m_widget = GTKCreateFrame(label);
     }
 
     m_widget = GTKCreateFrame(label);

+    g_object_ref(m_widget);
+
+    // only base SetLabel needs to be called after GTKCreateFrame

     wxControl::SetLabel(label);
 
     m_parent->DoAddChild( this );
     wxControl::SetLabel(label);
 
     m_parent->DoAddChild( this );


@@ -64,18 +91,35 @@ bool wxStaticBox::Create( wxWindow *parent,
     PostCreation(size);
 
     // need to set non default alignment?
     PostCreation(size);
 
     // need to set non default alignment?

-    gfloat xalign;
+    gfloat xalign = 0;

     if ( style & wxALIGN_CENTER )
         xalign = 0.5;
     else if ( style & wxALIGN_RIGHT )
         xalign = 1.0;
     if ( style & wxALIGN_CENTER )
         xalign = 0.5;
     else if ( style & wxALIGN_RIGHT )
         xalign = 1.0;

-    else // wxALIGN_LEFT
-        xalign = 0.0;

 
 

-    if ( style & (wxALIGN_RIGHT | wxALIGN_CENTER) ) // left alignment is default
-        gtk_frame_set_label_align(GTK_FRAME( m_widget ), xalign, 0.5);
+    gtk_frame_set_label_align(GTK_FRAME(m_widget), xalign, 0.5);

 
 

-    return TRUE;
+    if (gtk_check_version(2, 12, 0))
+    {
+        // we connect this signal to perform label-clipping as GTK >= 2.12 does
+        g_signal_connect(m_widget, "size_allocate", G_CALLBACK(size_allocate), NULL);
+    }
+
+    return true;
+}
+
+void wxStaticBox::AddChild( wxWindowBase *child )
+{
+    if (!m_wxwindow)
+    {
+        // make this window a container of other wxWindows by instancing a wxPizza
+        // and packing it into the GtkFrame:
+        m_wxwindow = wxPizza::New();
+        gtk_widget_show( m_wxwindow );
+        gtk_container_add( GTK_CONTAINER (m_widget), m_wxwindow );
+    }
+
+    wxWindow::AddChild( child );

 }
 
 void wxStaticBox::SetLabel( const wxString& label )
 }
 
 void wxStaticBox::SetLabel( const wxString& label )


@@ -107,4 +151,13 @@ wxStaticBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
     return GetDefaultAttributesFromGTKWidget(gtk_frame_new);
 }
 
     return GetDefaultAttributesFromGTKWidget(gtk_frame_new);
 }
 

+
+void wxStaticBox::GetBordersForSizer(int *borderTop, int *borderOther) const
+{
+    const int BORDER = 5; // FIXME: hardcoded value
+
+    *borderTop = GetLabel().empty() ? 2*BORDER : GetCharHeight();
+    *borderOther = BORDER;
+}
+

 #endif // wxUSE_STATBOX
 #endif // wxUSE_STATBOX