just added a comment

[wxWidgets.git] / src / cocoa / toolbar.mm

diff --git a/src/cocoa/toolbar.mm b/src/cocoa/toolbar.mm
index 0f7e02c01dd37cb9ab8287c8eb34a8c8c5e7dc47..bf0d2a4d5a3d370d1e44989b5b5a75c0bf094399 100644 (file)
--- a/src/cocoa/toolbar.mm
+++ b/src/cocoa/toolbar.mm
@@ -6,7 +6,7 @@
 // Created:     2003/08/17
 // RCS-ID:      $Id$
 // Copyright:   (c) 2003 David Elliott
 // Created:     2003/08/17
 // RCS-ID:      $Id$
 // Copyright:   (c) 2003 David Elliott

-// Licence:    wxWindows licence
+// Licence:    wxWidgets licence

 /////////////////////////////////////////////////////////////////////////////
 
 // ============================================================================
 /////////////////////////////////////////////////////////////////////////////
 
 // ============================================================================


@@ -41,54 +41,10 @@
 
 #include <math.h>
 
 
 #include <math.h>
 

-DECLARE_WXCOCOA_OBJC_CLASS(NSActionCell);
-
-// ========================================================================
-// wxCocoaNSActionCell
-// ========================================================================
-WX_DECLARE_OBJC_HASHMAP(NSActionCell);
-
-class wxCocoaNSActionCell
-{
-    WX_DECLARE_OBJC_INTERFACE(NSActionCell)
-public:
-    virtual void CocoaTarget_wxNSActionCellAction() {}
-protected:
-    static struct objc_object *sm_cocoaTarget;
-};
-
-// ============================================================================
-// @class wxNSActionCellTarget
-// ============================================================================
-@interface wxNSActionCellTarget : NSObject
-{
-}
-
-- (void)wxNSActionCellAction: (id)sender;
-@end //interface wxNSActionCellTarget
-
-@implementation wxNSActionCellTarget : NSObject
-
-- (void)wxNSActionCellAction: (id)sender
-{
-    wxLogDebug(wxT("wxNSActionCellAction"));
-    wxCocoaNSActionCell *wxcontrol = wxCocoaNSActionCell::GetFromCocoa(sender);
-    wxCHECK_RET(wxcontrol,wxT("wxNSActionCellAction received but no wxCocoaNSActionCell exists!"));
-    wxcontrol->CocoaTarget_wxNSActionCellAction();
-}
-
-@end //implementation wxNSActionCellTarget
-
-// ========================================================================
-// wxCocoaNSActionCell
-// ========================================================================
-struct objc_object *wxCocoaNSActionCell::sm_cocoaTarget = [[wxNSActionCellTarget alloc] init];
-WX_IMPLEMENT_OBJC_INTERFACE(NSActionCell)
-

 // ========================================================================
 // wxToolBarTool
 // ========================================================================
 // ========================================================================
 // wxToolBarTool
 // ========================================================================

-class wxToolBarTool : public wxToolBarToolBase, protected wxCocoaNSActionCell
+class wxToolBarTool : public wxToolBarToolBase

 {
 public:
     wxToolBarTool(wxToolBar *tbar, int toolid, const wxString& label,
 {
 public:
     wxToolBarTool(wxToolBar *tbar, int toolid, const wxString& label,


@@ -139,9 +95,16 @@ void wxToolBarTool::Init()
     m_frameRect = NSZeroRect;
 }
 
     m_frameRect = NSZeroRect;
 }
 

+void wxToolBar::CocoaToolClickEnded()
+{
+    wxASSERT(m_mouseDownTool);
+    wxCommandEvent event(wxEVT_COMMAND_MENU_SELECTED, m_mouseDownTool->GetId());
+    InitCommandEvent(event);
+    Command(event);
+}
+

 wxToolBarTool::~wxToolBarTool()
 {
 wxToolBarTool::~wxToolBarTool()
 {

-    DisassociateNSActionCell(m_cocoaNSButtonCell);

     [m_cocoaNSButtonCell release];
 }
 
     [m_cocoaNSButtonCell release];
 }
 


@@ -186,7 +149,6 @@ bool wxToolBarTool::CreateButtonCell()
     [m_cocoaNSButtonCell setBordered:NO];
 //    [m_cocoaNSButtonCell setHighlightsBy:NSContentsCellMask|NSPushInCellMask];
 //    [m_cocoaNSButtonCell setShowsStateBy:NSContentsCellMask|NSPushInCellMask];
     [m_cocoaNSButtonCell setBordered:NO];
 //    [m_cocoaNSButtonCell setHighlightsBy:NSContentsCellMask|NSPushInCellMask];
 //    [m_cocoaNSButtonCell setShowsStateBy:NSContentsCellMask|NSPushInCellMask];

-    AssociateNSActionCell(m_cocoaNSButtonCell);

     return true;
 }
 
     return true;
 }
 


@@ -259,6 +221,11 @@ bool wxToolBar::DoDeleteTool(size_t WXUNUSED(pos), wxToolBarToolBase *toolBase)
     return true;
 }
 
     return true;
 }
 

+bool wxToolBar::Cocoa_acceptsFirstMouse(bool &acceptsFirstMouse, WX_NSEvent theEvent)
+{
+    acceptsFirstMouse = true; return true;
+}
+

 bool wxToolBar::Cocoa_drawRect(const NSRect &rect)
 {
     wxToolBarToolsList::compatibility_iterator node;
 bool wxToolBar::Cocoa_drawRect(const NSRect &rect)
 {
     wxToolBarToolsList::compatibility_iterator node;


@@ -291,15 +258,18 @@ bool wxToolBar::Cocoa_mouseDragged(WX_NSEvent theEvent)
         NSButtonCell *buttonCell = m_mouseDownTool->GetNSButtonCell();
         if(buttonCell)
         {
         NSButtonCell *buttonCell = m_mouseDownTool->GetNSButtonCell();
         if(buttonCell)
         {

+            [buttonCell retain];

             [buttonCell setHighlighted: YES];
             if([buttonCell trackMouse: theEvent
                 inRect:AddToolPadding(m_mouseDownTool->GetFrameRect()) ofView:m_cocoaNSView
                 untilMouseUp:NO])
             {
             [buttonCell setHighlighted: YES];
             if([buttonCell trackMouse: theEvent
                 inRect:AddToolPadding(m_mouseDownTool->GetFrameRect()) ofView:m_cocoaNSView
                 untilMouseUp:NO])
             {

+                CocoaToolClickEnded();

                 m_mouseDownTool = NULL;
                 m_mouseDownTool = NULL;

-                wxLogDebug(wxT("Button was clicked after drag!"));
+                wxLogTrace(wxTRACE_COCOA,wxT("Button was clicked after drag!"));

             }
             [buttonCell setHighlighted: NO];
             }
             [buttonCell setHighlighted: NO];

+            [buttonCell release];

         }
     }
     return wxToolBarBase::Cocoa_mouseDragged(theEvent);
         }
     }
     return wxToolBarBase::Cocoa_mouseDragged(theEvent);


@@ -313,16 +283,19 @@ bool wxToolBar::Cocoa_mouseDown(WX_NSEvent theEvent)
         NSButtonCell *buttonCell = tool->GetNSButtonCell();
         if(buttonCell)
         {
         NSButtonCell *buttonCell = tool->GetNSButtonCell();
         if(buttonCell)
         {

+            [buttonCell retain];

             m_mouseDownTool = tool;
             [buttonCell setHighlighted: YES];
             if([buttonCell trackMouse: theEvent
                 inRect:AddToolPadding(tool->GetFrameRect()) ofView:m_cocoaNSView
                 untilMouseUp:NO])
             {
             m_mouseDownTool = tool;
             [buttonCell setHighlighted: YES];
             if([buttonCell trackMouse: theEvent
                 inRect:AddToolPadding(tool->GetFrameRect()) ofView:m_cocoaNSView
                 untilMouseUp:NO])
             {

+                CocoaToolClickEnded();

                 m_mouseDownTool = NULL;
                 m_mouseDownTool = NULL;

-                wxLogDebug(wxT("Button was clicked!"));
+                wxLogTrace(wxTRACE_COCOA,wxT("Button was clicked!"));

             }
             [buttonCell setHighlighted: NO];
             }
             [buttonCell setHighlighted: NO];

+            [buttonCell release];

         }
     }
     return wxToolBarBase::Cocoa_mouseDown(theEvent);
         }
     }
     return wxToolBarBase::Cocoa_mouseDown(theEvent);