A little clarification

[wxWidgets.git] / src / gtk / notebook.cpp

diff --git a/src/gtk/notebook.cpp b/src/gtk/notebook.cpp
index 0621f9fe5b7cdce914d021e96ac2c54671dc213f..76baec9d8ea386ce8c9464a2b505bbff5c4d015b 100644 (file)
--- a/src/gtk/notebook.cpp
+++ b/src/gtk/notebook.cpp
@@ -7,10 +7,13 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "notebook.h"
 #endif
 
 #pragma implementation "notebook.h"
 #endif
 

+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+

 #include "wx/notebook.h"
 
 #if wxUSE_NOTEBOOK
 #include "wx/notebook.h"
 
 #if wxUSE_NOTEBOOK


@@ -189,6 +192,8 @@ static gint gtk_notebook_key_press_callback( GtkWidget *widget, GdkEventKey *gdk
     if ((gdk_event->keyval == GDK_Tab) || (gdk_event->keyval == GDK_ISO_Left_Tab))
     {
         int sel = win->GetSelection();
     if ((gdk_event->keyval == GDK_Tab) || (gdk_event->keyval == GDK_ISO_Left_Tab))
     {
         int sel = win->GetSelection();

+        if (sel == -1)
+            return TRUE;

         wxGtkNotebookPage *nb_page = win->GetNotebookPage(sel);
         wxCHECK_MSG( nb_page, FALSE, _T("invalid selection in wxNotebook") );
 
         wxGtkNotebookPage *nb_page = win->GetNotebookPage(sel);
         wxCHECK_MSG( nb_page, FALSE, _T("invalid selection in wxNotebook") );
 


@@ -238,7 +243,6 @@ void wxNotebook::Init()
     m_inSwitchPage = FALSE;
 
     m_imageList = (wxImageList *) NULL;
     m_inSwitchPage = FALSE;
 
     m_imageList = (wxImageList *) NULL;

-    m_pagesData.DeleteContents( TRUE );

     m_selection = -1;
     m_themeEnabled = TRUE;
 }
     m_selection = -1;
     m_themeEnabled = TRUE;
 }


@@ -258,10 +262,6 @@ wxNotebook::wxNotebook( wxWindow *parent, wxWindowID id,
 
 wxNotebook::~wxNotebook()
 {
 
 wxNotebook::~wxNotebook()
 {

-    /* don't generate change page events any more */
-    gtk_signal_disconnect_by_func( GTK_OBJECT(m_widget),
-      GTK_SIGNAL_FUNC(gtk_notebook_page_change_callback), (gpointer) this );
-

     DeleteAllPages();
 }
 
     DeleteAllPages();
 }
 


@@ -336,7 +336,7 @@ int wxNotebook::GetSelection() const
     return m_selection;
 }
 
     return m_selection;
 }
 

-wxString wxNotebook::GetPageText( int page ) const
+wxString wxNotebook::GetPageText( size_t page ) const

 {
     wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid notebook") );
 
 {
     wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid notebook") );
 


@@ -347,7 +347,7 @@ wxString wxNotebook::GetPageText( int page ) const
         return wxT("");
 }
 
         return wxT("");
 }
 

-int wxNotebook::GetPageImage( int page ) const
+int wxNotebook::GetPageImage( size_t page ) const

 {
     wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid notebook") );
 
 {
     wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid notebook") );
 


@@ -367,11 +367,11 @@ wxGtkNotebookPage* wxNotebook::GetNotebookPage( int page ) const
     return m_pagesData.Item(page)->GetData();
 }
 
     return m_pagesData.Item(page)->GetData();
 }
 

-int wxNotebook::SetSelection( int page )
+int wxNotebook::SetSelection( size_t page )

 {
     wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid notebook") );
 
 {
     wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid notebook") );
 

-    wxCHECK_MSG( page < (int)m_pagesData.GetCount(), -1, wxT("invalid notebook index") );
+    wxCHECK_MSG( page < m_pagesData.GetCount(), -1, wxT("invalid notebook index") );

 
     int selOld = GetSelection();
 
 
     int selOld = GetSelection();
 


@@ -386,7 +386,7 @@ int wxNotebook::SetSelection( int page )
     return selOld;
 }
 
     return selOld;
 }
 

-bool wxNotebook::SetPageText( int page, const wxString &text )
+bool wxNotebook::SetPageText( size_t page, const wxString &text )

 {
     wxCHECK_MSG( m_widget != NULL, FALSE, wxT("invalid notebook") );
 
 {
     wxCHECK_MSG( m_widget != NULL, FALSE, wxT("invalid notebook") );
 


@@ -401,7 +401,7 @@ bool wxNotebook::SetPageText( int page, const wxString &text )
     return TRUE;
 }
 
     return TRUE;
 }
 

-bool wxNotebook::SetPageImage( int page, int image )
+bool wxNotebook::SetPageImage( size_t page, int image )

 {
     /* HvdH 28-12-98: now it works, but it's a bit of a kludge */
 
 {
     /* HvdH 28-12-98: now it works, but it's a bit of a kludge */
 


@@ -535,25 +535,19 @@ bool wxNotebook::DeleteAllPages()
     return wxNotebookBase::DeleteAllPages();
 }
 
     return wxNotebookBase::DeleteAllPages();
 }
 

-bool wxNotebook::DeletePage( int page )
+bool wxNotebook::DeletePage( size_t page )

 {
 {

-    // GTK sets GtkNotebook.cur_page to NULL before sending the switch page
-    // event so we have to store the selection internally
-    if ( m_selection == -1 )
+    if ( m_selection == (int)m_pagesData.GetCount() - 1 )

     {
     {

-        m_selection = GetSelection();
-        if ( m_selection == (int)m_pagesData.GetCount() - 1 )
-        {
-            // the index will become invalid after the page is deleted
-            m_selection = -1;
-        }
+        // the index will become invalid after the page is deleted
+        m_selection = -1;

     }
 
     // it will call our DoRemovePage() to do the real work
     return wxNotebookBase::DeletePage(page);
 }
 
     }
 
     // it will call our DoRemovePage() to do the real work
     return wxNotebookBase::DeletePage(page);
 }
 

-wxNotebookPage *wxNotebook::DoRemovePage( int page )
+wxNotebookPage *wxNotebook::DoRemovePage( size_t page )

 {
     wxNotebookPage *client = wxNotebookBase::DoRemovePage(page);
     if ( !client )
 {
     wxNotebookPage *client = wxNotebookBase::DoRemovePage(page);
     if ( !client )


@@ -563,14 +557,25 @@ wxNotebookPage *wxNotebook::DoRemovePage( int page )
     gtk_widget_unrealize( client->m_widget );
     gtk_widget_unparent( client->m_widget );
 
     gtk_widget_unrealize( client->m_widget );
     gtk_widget_unparent( client->m_widget );
 

+    // gtk_notebook_remove_page() sends "switch_page" signal with some strange
+    // new page index (when deleting selected page 0, new page is 1 although,
+    // clearly, the selection should stay 0), so suppress this
+    gtk_signal_disconnect_by_func( GTK_OBJECT(m_widget),
+      GTK_SIGNAL_FUNC(gtk_notebook_page_change_callback), (gpointer) this );
+

     gtk_notebook_remove_page( GTK_NOTEBOOK(m_widget), page );
 
     gtk_notebook_remove_page( GTK_NOTEBOOK(m_widget), page );
 

-    m_pagesData.DeleteObject(GetNotebookPage(page));
+    gtk_signal_connect( GTK_OBJECT(m_widget), "switch_page",
+      GTK_SIGNAL_FUNC(gtk_notebook_page_change_callback), (gpointer)this );
+
+    wxGtkNotebookPage* p = GetNotebookPage(page);
+    m_pagesData.DeleteObject(p);
+    delete p;

 
     return client;
 }
 
 
     return client;
 }
 

-bool wxNotebook::InsertPage( int position,
+bool wxNotebook::InsertPage( size_t position,

                              wxNotebookPage* win,
                              const wxString& text,
                              bool select,
                              wxNotebookPage* win,
                              const wxString& text,
                              bool select,


@@ -581,7 +586,7 @@ bool wxNotebook::InsertPage( int position,
     wxCHECK_MSG( win->GetParent() == this, FALSE,
                wxT("Can't add a page whose parent is not the notebook!") );
 
     wxCHECK_MSG( win->GetParent() == this, FALSE,
                wxT("Can't add a page whose parent is not the notebook!") );
 

-    wxCHECK_MSG( position >= 0 && position <= GetPageCount(), FALSE,
+    wxCHECK_MSG( position <= GetPageCount(), FALSE,

                  _T("invalid page index in wxNotebookPage::InsertPage()") );
 
     /* don't receive switch page during addition */
                  _T("invalid page index in wxNotebookPage::InsertPage()") );
 
     /* don't receive switch page during addition */


@@ -608,10 +613,13 @@ bool wxNotebook::InsertPage( int position,
     gtk_signal_connect( GTK_OBJECT(win->m_widget), "size_allocate",
       GTK_SIGNAL_FUNC(gtk_page_size_callback), (gpointer)win );
 
     gtk_signal_connect( GTK_OBJECT(win->m_widget), "size_allocate",
       GTK_SIGNAL_FUNC(gtk_page_size_callback), (gpointer)win );
 

-    if (position < 0)
+#ifndef __VMS
+   // On VMS position is unsigned and thus always positive
+   if (position < 0)

         gtk_notebook_append_page( notebook, win->m_widget, nb_page->m_box );
     else
         gtk_notebook_append_page( notebook, win->m_widget, nb_page->m_box );
     else

-        gtk_notebook_insert_page( notebook, win->m_widget, nb_page->m_box, position );
+#endif
+     gtk_notebook_insert_page( notebook, win->m_widget, nb_page->m_box, position );

 
     nb_page->m_page = (GtkNotebookPage*) g_list_last(notebook->children)->data;
 
 
     nb_page->m_page = (GtkNotebookPage*) g_list_last(notebook->children)->data;
 


@@ -641,17 +649,20 @@ bool wxNotebook::InsertPage( int position,
     nb_page->m_text = text;
     if (nb_page->m_text.IsEmpty()) nb_page->m_text = wxT("");
   
     nb_page->m_text = text;
     if (nb_page->m_text.IsEmpty()) nb_page->m_text = wxT("");
   

-    nb_page->m_label = GTK_LABEL( gtk_label_new(nb_page->m_text.mbc_str()) );
+    nb_page->m_label = GTK_LABEL( gtk_label_new(wxGTK_CONV(nb_page->m_text)) );

     gtk_box_pack_end( GTK_BOX(nb_page->m_box), GTK_WIDGET(nb_page->m_label), FALSE, FALSE, m_padding );
   
     /* show the label */
     gtk_widget_show( GTK_WIDGET(nb_page->m_label) );
     if (select && (m_pagesData.GetCount() > 1))
     {
     gtk_box_pack_end( GTK_BOX(nb_page->m_box), GTK_WIDGET(nb_page->m_label), FALSE, FALSE, m_padding );
   
     /* show the label */
     gtk_widget_show( GTK_WIDGET(nb_page->m_label) );
     if (select && (m_pagesData.GetCount() > 1))
     {

+#ifndef __VMS
+   // On VMS position is unsigned and thus always positive

         if (position < 0)
             SetSelection( GetPageCount()-1 );
         else
         if (position < 0)
             SetSelection( GetPageCount()-1 );
         else

-            SetSelection( position );
+#endif
+           SetSelection( position );

     }
 
     gtk_signal_connect( GTK_OBJECT(m_widget), "switch_page",
     }
 
     gtk_signal_connect( GTK_OBJECT(m_widget), "switch_page",