Fix for unsafe use of a global pointer for focus window: now checks at destruct

[wxWidgets.git] / src / gtk1 / timer.cpp

diff --git a/src/gtk1/timer.cpp b/src/gtk1/timer.cpp
index 4e36a67f1447dc978ce61c33a361ef179d54811b..ab9e36893186bdcc635daa4600362efe117ef3be 100644 (file)
--- a/src/gtk1/timer.cpp
+++ b/src/gtk1/timer.cpp
@@ -1,11 +1,10 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        timer.cpp
+// Name:        gtk/timer.cpp
 // Purpose:
 // Author:      Robert Roebling
-// Created:     01/02/97
-// Id:
-// Copyright:   (c) 1998 Robert Roebling, Julian Smart and Markus Holzem
-// Licence:    wxWindows licence
+// Id:          $Id$
+// Copyright:   (c) 1998 Robert Roebling
+// Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 
@@ -15,54 +14,60 @@
 
 #include "wx/timer.h"
 
+#include "gtk/gtk.h"
+
 //-----------------------------------------------------------------------------
 // wxTimer
 //-----------------------------------------------------------------------------
 
 IMPLEMENT_ABSTRACT_CLASS(wxTimer,wxObject)
 
-gint timeout_callback( gpointer data )
+static gint timeout_callback( gpointer data )
 {
-  wxTimer *timer = (wxTimer*)data;
-  timer->Notify();
+    wxTimer *timer = (wxTimer*)data;
+
+    /* when getting called from GDK's timer handler we
+       are no longer within GDK's grab on the GUI
+       thread so we must lock it here ourselves */
+    gdk_threads_enter();
+
+    timer->Notify();
+
+    /* release lock again */
+    gdk_threads_leave();
 
-  if ( timer->OneShot() )
-    timer->Stop();
+    if ( timer->IsOneShot() )
+        return FALSE;
 
-  return TRUE;
+    return TRUE;
 }
 
-wxTimer::wxTimer()
+void wxTimer::Init()
 {
-  m_tag = -1;
-  m_time = 1000;
-  m_oneShot = FALSE;
+    m_tag = -1;
+    m_milli = 1000;
 }
 
 wxTimer::~wxTimer()
 {
-  Stop();
+    wxTimer::Stop();
 }
 
 bool wxTimer::Start( int millisecs, bool oneShot )
 {
-  if ( millisecs != -1 )
-    m_time = millisecs;
-
-  m_oneShot = oneShot;
+    (void)wxTimerBase::Start(millisecs, oneShot);
 
-  m_tag = gtk_timeout_add( millisecs, timeout_callback, this );
+    m_tag = gtk_timeout_add( m_milli, timeout_callback, this );
 
-  return TRUE;
+    return TRUE;
 }
 
 void wxTimer::Stop()
 {
-  if ( m_tag != -1 )
-  {
-    gtk_timeout_remove( m_tag );
-
-    m_tag = -1;
-  }
+    if (m_tag != -1)
+    {
+        gtk_timeout_remove( m_tag );
+        m_tag = -1;
+    }
 }