don't crash in wx(Flex)GridSizer with division by 0, assert instead; also factored...

[wxWidgets.git] / src / common / timercmn.cpp

diff --git a/src/common/timercmn.cpp b/src/common/timercmn.cpp
index 3d8db4c93692b5d1572985db5ddaeba7ae67425e..3bf88317e8987647871ae8d9ffc2477f467dc9fb 100644 (file)
--- a/src/common/timercmn.cpp
+++ b/src/common/timercmn.cpp
@@ -19,7 +19,7 @@
 // ============================================================================
 
 // ----------------------------------------------------------------------------
 // ============================================================================
 
 // ----------------------------------------------------------------------------

-// headers
+// wxWin headers

 // ----------------------------------------------------------------------------
 
 #ifdef __GNUG__
 // ----------------------------------------------------------------------------
 
 #ifdef __GNUG__


@@ -41,10 +41,30 @@
 #include "wx/timer.h"
 #include "wx/longlong.h"
 
 #include "wx/timer.h"
 #include "wx/longlong.h"
 

+// ----------------------------------------------------------------------------
+// System headers
+// ----------------------------------------------------------------------------
+

 #if defined(__WIN32__)
     #include <windows.h>
 #endif
 
 #if defined(__WIN32__)
     #include <windows.h>
 #endif
 

+#if defined(__WIN32__) && !defined(HAVE_FTIME) && !defined(__MWERKS__)
+    #define HAVE_FTIME
+#endif
+
+#if defined(__VISAGECPP__) && !defined(HAVE_FTIME)
+    #define HAVE_FTIME
+#  if __IBMCPP__ >= 400
+    #  define ftime(x) _ftime(x)
+#  endif
+#endif
+
+#if defined(__MWERKS__) && defined(__WXMSW__)
+#   undef HAVE_FTIME
+#   undef HAVE_GETTIMEOFDAY
+#endif
+

 #include <time.h>
 #ifndef __WXMAC__
     #include <sys/types.h>      // for time_t
 #include <time.h>
 #ifndef __WXMAC__
     #include <sys/types.h>      // for time_t


@@ -57,11 +77,17 @@
     #include <sys/timeb.h>
 #endif
 
     #include <sys/timeb.h>
 #endif
 

+#ifdef __WXMAC__
+    #include <Timer.h>
+    #include <DriverServices.h>
+#endif

 // ----------------------------------------------------------------------------
 // wxWin macros
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 // wxWin macros
 // ----------------------------------------------------------------------------
 

-IMPLEMENT_DYNAMIC_CLASS(wxTimerEvent, wxEvent)
+#if wxUSE_GUI && wxUSE_TIMER
+    IMPLEMENT_DYNAMIC_CLASS(wxTimerEvent, wxEvent)
+#endif // wxUSE_GUI

 
 // ----------------------------------------------------------------------------
 // macros
 
 // ----------------------------------------------------------------------------
 // macros


@@ -78,12 +104,6 @@ IMPLEMENT_DYNAMIC_CLASS(wxTimerEvent, wxEvent)
     #endif
 #endif // HAVE_GETTIMEOFDAY
 
     #endif
 #endif // HAVE_GETTIMEOFDAY
 

-// ----------------------------------------------------------------------------
-// prototypes
-// ----------------------------------------------------------------------------
-
-wxLongLong wxGetLocalTimeMillis();
-

 // ============================================================================
 // implementation
 // ============================================================================
 // ============================================================================
 // implementation
 // ============================================================================


@@ -92,6 +112,13 @@ wxLongLong wxGetLocalTimeMillis();
 // wxTimerBase
 // ----------------------------------------------------------------------------
 
 // wxTimerBase
 // ----------------------------------------------------------------------------
 

+#if wxUSE_GUI && wxUSE_TIMER
+
+wxTimerBase::~wxTimerBase()
+{
+    // this destructor is required for Darwin
+}
+

 void wxTimerBase::Notify()
 {
     // the base class version generates an event if it has owner - which it
 void wxTimerBase::Notify()
 {
     // the base class version generates an event if it has owner - which it


@@ -102,10 +129,34 @@ void wxTimerBase::Notify()
     (void)m_owner->ProcessEvent(event);
 }
 
     (void)m_owner->ProcessEvent(event);
 }
 

+bool wxTimerBase::Start(int milliseconds, bool oneShot)
+{
+    if ( IsRunning() )
+    {
+        // not stopping the already running timer might work for some
+        // platforms (no problems under MSW) but leads to mysterious crashes
+        // on the others (GTK), so to be on the safe side do it here
+        Stop();
+    }
+
+    if ( milliseconds != -1 )
+    {
+        m_milli = milliseconds;
+    }
+
+    m_oneShot = oneShot;
+
+    return TRUE;
+}
+
+#endif // wxUSE_GUI
+

 // ----------------------------------------------------------------------------
 // wxStopWatch
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 // wxStopWatch
 // ----------------------------------------------------------------------------
 

+#if wxUSE_LONGLONG
+

 void wxStopWatch::Start(long t)
 {
     m_t0 = wxGetLocalTimeMillis() - t;
 void wxStopWatch::Start(long t)
 {
     m_t0 = wxGetLocalTimeMillis() - t;


@@ -114,18 +165,22 @@ void wxStopWatch::Start(long t)
 
 long wxStopWatch::GetElapsedTime() const
 {
 
 long wxStopWatch::GetElapsedTime() const
 {

-  return (wxGetLocalTimeMillis() - m_t0).GetLo();
+    return (wxGetLocalTimeMillis() - m_t0).GetLo();

 }
 
 long wxStopWatch::Time() const
 {
 }
 
 long wxStopWatch::Time() const
 {

-    return (m_pause ? m_pause : GetElapsedTime());
+    return m_pauseCount ? m_pause : GetElapsedTime();

 }
 
 }
 

+#endif // wxUSE_LONGLONG
+

 // ----------------------------------------------------------------------------
 // old timer functions superceded by wxStopWatch
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 // old timer functions superceded by wxStopWatch
 // ----------------------------------------------------------------------------
 

+#if wxUSE_LONGLONG
+

 static wxLongLong wxStartTime = 0l;
 
 // starts the global timer
 static wxLongLong wxStartTime = 0l;
 
 // starts the global timer


@@ -146,6 +201,7 @@ long wxGetElapsedTime(bool resetTimer)
     return (newTime - oldTime).GetLo();
 }
 
     return (newTime - oldTime).GetLo();
 }
 

+#endif // wxUSE_LONGLONG

 
 // ----------------------------------------------------------------------------
 // the functions to get the current time and timezone info
 
 // ----------------------------------------------------------------------------
 // the functions to get the current time and timezone info


@@ -185,7 +241,8 @@ long wxGetLocalTime()
 // Get UTC time as seconds since 00:00:00, Jan 1st 1970
 long wxGetUTCTime()
 {
 // Get UTC time as seconds since 00:00:00, Jan 1st 1970
 long wxGetUTCTime()
 {

-    struct tm tm, *ptm;
+    struct tm tm;
+    struct tm *ptm;

     time_t t0, t1;
 
     // This cannot be made static because mktime can overwrite it
     time_t t0, t1;
 
     // This cannot be made static because mktime can overwrite it


@@ -218,56 +275,121 @@ long wxGetUTCTime()
 
             if (t0 != (time_t)-1 )
                 return (long)difftime(t1, t0) + (60 * 60 * 24 * 4);
 
             if (t0 != (time_t)-1 )
                 return (long)difftime(t1, t0) + (60 * 60 * 24 * 4);

-            wxLogSysError(_("Failed 2nd mktime"));
+            wxLogSysError(_("mktime() failed"));
+        }
+        else
+        {
+            wxLogSysError(_("gmtime() failed"));

         }
         }

-        wxLogSysError(_("Failed gmtime"));

     }
     }

-    wxLogSysError(_("Failed to get the UTC system time"));
+
+    wxLogError(_("Failed to get the UTC system time."));
+

     return -1;
 }
 
     return -1;
 }
 

+#if wxUSE_LONGLONG

 
 // Get local time as milliseconds since 00:00:00, Jan 1st 1970
 wxLongLong wxGetLocalTimeMillis()
 {
     wxLongLong val = 1000l;
 
 
 // Get local time as milliseconds since 00:00:00, Jan 1st 1970
 wxLongLong wxGetLocalTimeMillis()
 {
     wxLongLong val = 1000l;
 

-#if defined(HAVE_GETTIMEOFDAY)
+    // If possible, use a function which avoids conversions from
+    // broken-up time structures to milliseconds
+
+#if defined(__WXMSW__) && defined(__MWERKS__)
+    // This should probably be the way all WXMSW compilers should do it
+    // Go direct to the OS for time
+
+    SYSTEMTIME thenst = { 1970, 1, 4, 1, 0, 0, 0, 0 };  // 00:00:00 Jan 1st 1970
+    FILETIME thenft;
+    SystemTimeToFileTime( &thenst, &thenft );
+    wxLongLong then( thenft.dwHighDateTime, thenft.dwLowDateTime );   // time in 100 nanoseconds
+
+    SYSTEMTIME nowst;
+    GetLocalTime( &nowst );
+    FILETIME nowft;
+    SystemTimeToFileTime( &nowst, &nowft );
+    wxLongLong now( nowft.dwHighDateTime, nowft.dwLowDateTime );   // time in 100 nanoseconds
+
+    return ( now - then ) / 10000.0;  // time from 00:00:00 Jan 1st 1970 to now in milliseconds
+    
+#elif defined(HAVE_GETTIMEOFDAY)

     struct timeval tp;
     if ( wxGetTimeOfDay(&tp, (struct timezone *)NULL) != -1 )
     {
         val *= tp.tv_sec;
         return (val + (tp.tv_usec / 1000));
     }
     struct timeval tp;
     if ( wxGetTimeOfDay(&tp, (struct timezone *)NULL) != -1 )
     {
         val *= tp.tv_sec;
         return (val + (tp.tv_usec / 1000));
     }

-#else
+    else
+    {
+        wxLogError(_("wxGetTimeOfDay failed."));
+        return 0;
+    }
+#elif defined(HAVE_FTIME)
+    struct timeb tp;

 
 

+    // ftime() is void and not int in some mingw32 headers, so don't
+    // test the return code (well, it shouldn't fail anyhow...)
+    (void)ftime(&tp);
+    val *= tp.time;
+    return (val + tp.millitm);
+#elif defined(__WXMAC__)
+    
+    UInt64 gMilliAtStart = 0 ;
+    Nanoseconds upTime = AbsoluteToNanoseconds( UpTime() ) ;
+    if ( gMilliAtStart == 0 )
+    {
+        time_t start = time(NULL) ;
+        gMilliAtStart = ((UInt64) start) * 1000L ;
+        gMilliAtStart -= upTime.lo / 1000 ;
+        gMilliAtStart -= ( ( (UInt64) upTime.hi ) << 32 ) / 1000 ;
+    }
+    UInt64 millival = gMilliAtStart ;
+    millival += upTime.lo / 1000 ;
+    millival += ( ( (UInt64) upTime.hi ) << 32 ) / 1000 ;
+    val = millival ;
+    return val ;
+#else // no gettimeofday() nor ftime()

     // We use wxGetLocalTime() to get the seconds since
     // 00:00:00 Jan 1st 1970 and then whatever is available
     // to get millisecond resolution.
     // We use wxGetLocalTime() to get the seconds since
     // 00:00:00 Jan 1st 1970 and then whatever is available
     // to get millisecond resolution.

-    // THIS LEADS TO A BUG SINCE REFERENCE TIME ARE DIFFERENT
+    //
+    // NOTE that this might lead to a problem if the clocks
+    // use different sources, so this approach should be
+    // avoided where possible.
+

     val *= wxGetLocalTime();
 
     val *= wxGetLocalTime();
 

-    // If we got here, do not fail even if we can't get
-    // millisecond resolution.
-    //
-#if defined(__WIN32__)
+// GRG: This will go soon as all WIN32 seem to have ftime
+#if defined (__WIN32__)
+    // If your platform/compiler needs to use two different functions
+    // to get ms resolution, please do NOT just shut off these warnings,
+    // drop me a line instead at <guille@iies.es>
+    #warning "Possible clock skew bug in wxGetLocalTimeMillis()!"
+

     SYSTEMTIME st;
     ::GetLocalTime(&st);
     SYSTEMTIME st;
     ::GetLocalTime(&st);

-    return (val + st.wMilliseconds);
-#elif defined(__VISAGECPP__)
-    DATETIME    dt;
-    ::DosGetDateTime(&dt);
-    return (val + dt.hundredths*10);
-#elif defined(HAVE_FTIME)
-    struct timeb tp;
-    if ( ftime(&tp) == 0 )
-    {
-        return (val + tp.millitm);
-    }
-#elif !defined(__BORLANDC__) && !(defined(__VISUALC__) && defined(__WIN16__))
-    #warning "wxStopWatch will be up to second resolution!"
-#endif
+    val += st.wMilliseconds;
+#else // !Win32
+    // If your platform/compiler does not support ms resolution please
+    // do NOT just shut off these warnings, drop me a line instead at
+    // <guille@iies.es>
+
+    #if defined(__VISUALC__) || defined (__WATCOMC__)
+        #pragma message("wxStopWatch will be up to second resolution!")
+    #elif defined(__BORLANDC__)
+        #pragma message "wxStopWatch will be up to second resolution!"
+    #else
+        #warning "wxStopWatch will be up to second resolution!"
+    #endif // compiler

 #endif
 
     return val;
 #endif
 
     return val;

+
+#endif // time functions

 }
 }

+
+#endif // wxUSE_LONGLONG
+