From: Jay Freeman (saurik) <saurik@saurik.com>
Date: Fri, 3 Dec 2010 11:58:13 +0000 (+0000)
Subject: gcc -Wall -Werror
X-Git-Tag: v1.1.0~1
X-Git-Url: https://git.saurik.com/uikittools.git/commitdiff_plain/743eb46fb998aa6deaaa2569b9ff84726ed286fe

gcc -Wall -Werror
---

diff --git a/makefile b/makefile
index 54fe85b..a9807b6 100644
--- a/makefile
+++ b/makefile
@@ -8,11 +8,11 @@ clean:
 .PHONY: all clean package
 
 %: %.mm
-	$${PKG_TARG}-g++ -o $@ $< -framework CoreFoundation -framework Foundation -framework UIKit -framework GraphicsServices -F"$${PKG_ROOT}"/System/Library/PrivateFrameworks -lobjc -framework SpringBoardServices
+	$${PKG_TARG}-g++ -Wall -Werror -o $@ $< -framework CoreFoundation -framework Foundation -framework UIKit -framework GraphicsServices -F"$${PKG_ROOT}"/System/Library/PrivateFrameworks -lobjc -framework SpringBoardServices
 	ldid -S $@
 
 %: %.c
-	$${PKG_TARG}-gcc -o $@ $< -framework CoreFoundation
+	$${PKG_TARG}-gcc -Wall -Werror -o $@ $< -framework CoreFoundation
 	ldid -S $@
 
 package: all
diff --git a/uicache.mm b/uicache.mm
index 8397703..41a8839 100644
--- a/uicache.mm
+++ b/uicache.mm
@@ -64,7 +64,7 @@ int main(int argc, const char *argv[]) {
                     NSString *plist = [path stringByAppendingPathComponent:@"Info.plist"];
 
                     if (NSMutableDictionary *info = [NSMutableDictionary dictionaryWithContentsOfFile:plist]) {
-                        if (NSString *bundle = [info objectForKey:@"CFBundleIdentifier"]) {
+                        if ([info objectForKey:@"CFBundleIdentifier"] != nil) {
                             [bundles addObject:path];
                             [info setObject:path forKey:@"Path"];
                             [info setObject:@"System" forKey:@"ApplicationType"];