From 512f682340eb74aaedc525e834a943427999508c Mon Sep 17 00:00:00 2001 From: antirez Date: Sun, 25 Mar 2012 10:57:34 +0200 Subject: [PATCH] convert-zipmap-hash-on-load false positive fixed. Apparently because the sample RDB file was not copied before every test Redis had a chance to replace it with a newly written one, so that the next test could fail. --- tests/integration/convert-zipmap-hash-on-load.tcl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/integration/convert-zipmap-hash-on-load.tcl b/tests/integration/convert-zipmap-hash-on-load.tcl index 75a65d3e..cf3577f2 100644 --- a/tests/integration/convert-zipmap-hash-on-load.tcl +++ b/tests/integration/convert-zipmap-hash-on-load.tcl @@ -1,8 +1,7 @@ -set server_path [tmpdir "server.convert-zipmap-hash-on-load"] - # Copy RDB with zipmap encoded hash to server path -exec cp tests/assets/hash-zipmap.rdb $server_path +set server_path [tmpdir "server.convert-zipmap-hash-on-load"] +exec cp -f tests/assets/hash-zipmap.rdb $server_path start_server [list overrides [list "dir" $server_path "dbfilename" "hash-zipmap.rdb"]] { test "RDB load zipmap hash: converts to ziplist" { r select 0 @@ -13,6 +12,7 @@ start_server [list overrides [list "dir" $server_path "dbfilename" "hash-zipmap. } } +exec cp -f tests/assets/hash-zipmap.rdb $server_path start_server [list overrides [list "dir" $server_path "dbfilename" "hash-zipmap.rdb" "hash-max-ziplist-entries" 1]] { test "RDB load zipmap hash: converts to hash table when hash-max-ziplist-entries is exceeded" { r select 0 @@ -23,6 +23,7 @@ start_server [list overrides [list "dir" $server_path "dbfilename" "hash-zipmap. } } +exec cp -f tests/assets/hash-zipmap.rdb $server_path start_server [list overrides [list "dir" $server_path "dbfilename" "hash-zipmap.rdb" "hash-max-ziplist-value" 1]] { test "RDB load zipmap hash: converts to hash table when hash-max-ziplist-value is exceeded" { r select 0 -- 2.47.2