From: Pieter Noordhuis <pcnoordhuis@gmail.com>
Date: Fri, 3 Sep 2010 14:44:31 +0000 (+0200)
Subject: Merge branch 'master' into networking-perf
X-Git-Url: https://git.saurik.com/redis.git/commitdiff_plain/9e83ac06ef1c978c65fefc1fbf5af1e95f31fe15

Merge branch 'master' into networking-perf

Resolved conflict in src/db.c and changed adding an error to the reply
in blockingPopGenericCommand to use the new API.
---

9e83ac06ef1c978c65fefc1fbf5af1e95f31fe15
diff --cc src/db.c
index 4f1572a6,f380bf6e..fc059510
--- a/src/db.c
+++ b/src/db.c
@@@ -221,11 -221,14 +221,12 @@@ void keysCommand(redisClient *c) 
      dictIterator *di;
      dictEntry *de;
      sds pattern = c->argv[1]->ptr;
-     int plen = sdslen(pattern);
+     int plen = sdslen(pattern), allkeys;
      unsigned long numkeys = 0;
 -    robj *lenobj = createObject(REDIS_STRING,NULL);
 +    void *replylen = addDeferredMultiBulkLength(c);
  
      di = dictGetIterator(c->db->dict);
 -    addReply(c,lenobj);
 -    decrRefCount(lenobj);
+     allkeys = (pattern[0] == '*' && pattern[1] == '\0');
      while((de = dictNext(di)) != NULL) {
          sds key = dictGetEntryKey(de);
          robj *keyobj;
diff --cc src/t_list.c
index 4d948294,add1bee1..41d651f6
--- a/src/t_list.c
+++ b/src/t_list.c
@@@ -785,6 -786,16 +786,16 @@@ void blockingPopGenericCommand(redisCli
      time_t timeout;
      int j;
  
+     /* Make sure timeout is an integer value */
+     if (getLongLongFromObjectOrReply(c,c->argv[c->argc-1],&lltimeout,
+             "timeout is not an integer") != REDIS_OK) return;
+ 
+     /* Make sure the timeout is not negative */
+     if (lltimeout < 0) {
 -        addReplySds(c,sdsnew("-ERR timeout is negative\r\n"));
++        addReplyError(c,"timeout is negative");
+         return;
+     }
+ 
      for (j = 1; j < c->argc-1; j++) {
          o = lookupKeyWrite(c->db,c->argv[j]);
          if (o != NULL) {