From: antirez <antirez@gmail.com>
Date: Thu, 22 Jul 2010 21:31:40 +0000 (+0200)
Subject: don't open/close log file if log level is not matched
X-Git-Url: https://git.saurik.com/redis.git/commitdiff_plain/230729617dc6714858902da5520b4e2c1ecc711e?ds=inline

don't open/close log file if log level is not matched
---

diff --git a/src/redis.c b/src/redis.c
index 433eae37..9978eab5 100644
--- a/src/redis.c
+++ b/src/redis.c
@@ -186,23 +186,22 @@ struct redisCommand readonlyCommandTable[] = {
 void redisLog(int level, const char *fmt, ...) {
     va_list ap;
     FILE *fp;
+    char *c = ".-*#";
+    char buf[64];
+    time_t now;
+
+    if (level < server.verbosity) return;
 
     fp = (server.logfile == NULL) ? stdout : fopen(server.logfile,"a");
     if (!fp) return;
 
     va_start(ap, fmt);
-    if (level >= server.verbosity) {
-        char *c = ".-*#";
-        char buf[64];
-        time_t now;
-
-        now = time(NULL);
-        strftime(buf,64,"%d %b %H:%M:%S",localtime(&now));
-        fprintf(fp,"[%d] %s %c ",(int)getpid(),buf,c[level]);
-        vfprintf(fp, fmt, ap);
-        fprintf(fp,"\n");
-        fflush(fp);
-    }
+    now = time(NULL);
+    strftime(buf,64,"%d %b %H:%M:%S",localtime(&now));
+    fprintf(fp,"[%d] %s %c ",(int)getpid(),buf,c[level]);
+    vfprintf(fp, fmt, ap);
+    fprintf(fp,"\n");
+    fflush(fp);
     va_end(ap);
 
     if (server.logfile) fclose(fp);