From: Pieter Noordhuis <pcnoordhuis@gmail.com>
Date: Thu, 16 Sep 2010 12:32:30 +0000 (+0200)
Subject: Merge branch 'zset-mem' into zrevrangebyscore
X-Git-Url: https://git.saurik.com/redis.git/commitdiff_plain/192fc3376a0712e69e638b087c82c7e34f698f4d?hp=--cc

Merge branch 'zset-mem' into zrevrangebyscore
---

192fc3376a0712e69e638b087c82c7e34f698f4d
diff --cc src/t_zset.c
index d944e923,3d9f612a..93ade5aa
--- a/src/t_zset.c
+++ b/src/t_zset.c
@@@ -339,24 -318,17 +318,16 @@@ void zaddGenericCommand(redisClient *c
      }
      zs = zsetobj->ptr;
  
-     /* Ok now since we implement both ZADD and ZINCRBY here the code
-      * needs to handle the two different conditions. It's all about setting
-      * '*score', that is, the new score to set, to the right value. */
-     score = zmalloc(sizeof(double));
-     if (doincrement) {
-         dictEntry *de;
- 
+     /* Since both ZADD and ZINCRBY are implemented here, we need to increment
+      * the score first by the current score if ZINCRBY is called. */
+     if (incr) {
          /* Read the old score. If the element was not present starts from 0 */
-         de = dictFind(zs->dict,ele);
-         if (de) {
-             double *oldscore = dictGetEntryVal(de);
-             *score = *oldscore + scoreval;
-         } else {
-             *score = scoreval;
-         }
-         if (isnan(*score)) {
+         dictEntry *de = dictFind(zs->dict,ele);
+         if (de != NULL)
+             score += *(double*)dictGetEntryVal(de);
+ 
+         if (isnan(score)) {
 -            addReplySds(c,
 -                sdsnew("-ERR resulting score is not a number (NaN)\r\n"));
 +            addReplyError(c,"resulting score is not a number (NaN)");
-             zfree(score);
              /* Note that we don't need to check if the zset may be empty and
               * should be removed here, as we can only obtain Nan as score if
               * there was already an element in the sorted set. */