From: antirez <antirez@gmail.com>
Date: Thu, 26 Jul 2012 10:09:40 +0000 (+0200)
Subject: Sentinel: don't start a failover as leader if there is no good slave.
X-Git-Url: https://git.saurik.com/redis.git/commitdiff_plain/0d0975f2b6c12210cc9c1ab523b6bf09415415a8

Sentinel: don't start a failover as leader if there is no good slave.
---

diff --git a/src/sentinel.c b/src/sentinel.c
index 227fb693..24bf993f 100644
--- a/src/sentinel.c
+++ b/src/sentinel.c
@@ -294,6 +294,7 @@ void sentinelKillLink(sentinelRedisInstance *ri, redisAsyncContext *c);
 const char *sentinelRedisInstanceTypeStr(sentinelRedisInstance *ri);
 void sentinelAbortFailover(sentinelRedisInstance *ri);
 void sentinelEvent(int level, char *type, sentinelRedisInstance *ri, const char *fmt, ...);
+sentinelRedisInstance *sentinelSelectSlave(sentinelRedisInstance *master);
 
 /* ========================= Dictionary types =============================== */
 
@@ -2061,7 +2062,11 @@ void sentinelStartFailover(sentinelRedisInstance *master) {
                 SRI_RECONF_SENT);
         }
     } else {
-        /* Brand new failover as SRI_FAILOVER_IN_PROGRESS was not set. */
+        /* Brand new failover as SRI_FAILOVER_IN_PROGRESS was not set.
+         *
+         * Do we have a slave to promote? Otherwise don't start a failover
+         * at all. */
+        if (sentinelSelectSlave(master) == NULL) return;
         master->failover_state = SENTINEL_FAILOVER_STATE_WAIT_START;
     }