From: antirez <antirez@gmail.com>
Date: Mon, 25 May 2009 19:30:20 +0000 (+0200)
Subject: minor fix to RubyRedis about bulk commands sent without arguments
X-Git-Url: https://git.saurik.com/redis.git/commitdiff_plain/0b420168b485d0a9c4b66d0a6c341597fb155947

minor fix to RubyRedis about bulk commands sent without arguments
---

diff --git a/Changelog b/Changelog
index 2298f008..6e4d93a1 100644
--- a/Changelog
+++ b/Changelog
@@ -1,3 +1,8 @@
+2009-05-24 Warns if using the default config
+2009-05-24 Issue with redis-client used in scripts solved, now to check if the latest argument must come from standard input we do not check that stdin is or not a tty but the command arity
+2009-05-23 RubyRedis: now sets are returned as arrays again, and not as Set objects
+2009-05-23 SLAVEOF command documented
+2009-05-23 SLAVEOF command implemented for replication remote control
 2009-05-22 Fix: no connection timeout for the master!
 2009-05-22 replication slave timeout when receiving the initial bulk data set to 3600 seconds, now that replication is non-blocking the server must save the db before to start the async replication and this can take a lot of time with huge datasets
 2009-05-22 README tutorial now reflects the new proto
diff --git a/TODO b/TODO
index d762277d..7bcb3828 100644
--- a/TODO
+++ b/TODO
@@ -6,8 +6,7 @@ BEFORE REDIS 1.0.0-rc1
  * maxclients support
  * Resize the expires and Sets hash tables if needed as well? For Sets the right moment to check for this is probably in SREM
  * What happens if the saving child gets killed or segfaults instead of ending normally? Handle this.
- * Make sinterstore / unionstore / sdiffstore returning the cardinality of the resulting set.
- * check 'server.dirty' everywere
+ * check 'server.dirty' everywere. Make it proprotional to the number of objects modified.
  * Shutdown must kill other background savings before to start saving. Otherwise the DB can get replaced by the child that rename(2) after the parent for some reason. Child should trap the signal and remove the temp file name.
  * Objects sharing configuration, add the directive `objectsharingpool <size>`
  * Make sure to convert all the fstat() calls to 64bit versions.
diff --git a/client-libraries/ruby_2/rubyredis.rb b/client-libraries/ruby_2/rubyredis.rb
index 23d7b017..e668fcd5 100644
--- a/client-libraries/ruby_2/rubyredis.rb
+++ b/client-libraries/ruby_2/rubyredis.rb
@@ -152,7 +152,7 @@ class RedisClient
         bulk = nil
         argv[0] = argv[0].to_s.downcase
         argv[0] = Aliases[argv[0]] if Aliases[argv[0]]
-        if BulkCommands[argv[0]]
+        if BulkCommands[argv[0]] and argv.length > 1
             bulk = argv[-1].to_s
             argv[-1] = bulk.length
         end