From: antirez Date: Mon, 23 Mar 2009 13:50:09 +0000 (+0100) Subject: another missing free->zfree replacement fixed. Thanks to Ludo X-Git-Url: https://git.saurik.com/redis.git/commitdiff_plain/092dac2a64f912fe67be2e924c58979b200aa64b?ds=sidebyside;hp=-c another missing free->zfree replacement fixed. Thanks to Ludo --- 092dac2a64f912fe67be2e924c58979b200aa64b diff --git a/Makefile b/Makefile index bf9760f0..e45899e9 100644 --- a/Makefile +++ b/Makefile @@ -23,7 +23,7 @@ anet.o: anet.c anet.h benchmark.o: benchmark.c ae.h anet.h sds.h adlist.h dict.o: dict.c dict.h redis-cli.o: redis-cli.c anet.h sds.h adlist.h -redis.o: redis.c ae.h sds.h anet.h dict.h adlist.h +redis.o: redis.c ae.h sds.h anet.h dict.h adlist.h zmalloc.c zmalloc.h sds.o: sds.c sds.h sha1.o: sha1.c sha1.h zmalloc.o: zmalloc.c diff --git a/TODO b/TODO index 02595425..7d91a103 100644 --- a/TODO +++ b/TODO @@ -15,3 +15,22 @@ BETA 8 TODO $ - Make Redis aware of the memory it is using thanks to getrusage() and report this info with the INFO command. - INFO command: clients, slave/master, requests/second in the last N seconds, memory usage, uptime, dirty, lastsave + +FUTURE + +ROLLBACK command: + + ROLLBACK UNSET x + SET x 10 + EXPIRE x 3600 + COMMIT + + (multiple rollbacks are allowed) + + or alternatively + + TRANSACTION SET x 1000 + TRANSACTION EXPIRE x 1000 + COMMIT + + but this sucks since there is no way to check the error message. diff --git a/redis.c b/redis.c index 04504eec..e6606f18 100644 --- a/redis.c +++ b/redis.c @@ -2619,7 +2619,7 @@ static void sortCommand(redisClient *c) { /* Create a list of operations to perform for every sorted element. * Operations can be GET/DEL/INCR/DECR */ operations = listCreate(); - listSetFreeMethod(operations,free); + listSetFreeMethod(operations,zfree); j = 2; /* Now we need to protect sortval incrementing its count, in the future diff --git a/zmalloc.h b/zmalloc.h index aaddb9ba..9e70e877 100644 --- a/zmalloc.h +++ b/zmalloc.h @@ -33,7 +33,7 @@ void *zmalloc(size_t size); void *zrealloc(void *ptr, size_t size); -void *zfree(void *ptr); +void zfree(void *ptr); char *zstrdup(const char *s); size_t zmalloc_used_memory(void);