From 5b625a2ec894f476ab8f7daae0e7471b1076aa80 Mon Sep 17 00:00:00 2001 From: "Jay Freeman (saurik)" Date: Sat, 25 Feb 2012 13:57:56 -0800 Subject: [PATCH] Do not add nil tags to the Package::tag_ array. --- MobileCydia.mm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/MobileCydia.mm b/MobileCydia.mm index cdce7c5b..2212e096 100644 --- a/MobileCydia.mm +++ b/MobileCydia.mm @@ -2321,9 +2321,14 @@ struct PackageNameOrdering : pkgCache::TagIterator tag(iterator.TagList()); if (!tag.end()) { tags_ = [NSMutableArray arrayWithCapacity:8]; - do { + + goto tag; for (; !tag.end(); ++tag) tag: { const char *name(tag.Name()); - [tags_ addObject:[(NSString *)CYStringCreate(name) autorelease]]; + NSString *string((NSString *) CYStringCreate(name)); + if (string == nil) + continue; + + [tags_ addObject:[string autorelease]]; if (role_ == 0 && strncmp(name, "role::", 6) == 0 /*&& strcmp(name, "role::leaper") != 0*/) { if (strcmp(name + 6, "enduser") == 0) @@ -2344,9 +2349,7 @@ struct PackageNameOrdering : else if (strcmp(name + 7, "obsolete") == 0) obsolete_ = true; } - - ++tag; - } while (!tag.end()); + } } _end -- 2.45.2