From 2e018aa45473ef882d7fb78eaeb6182723399da8 Mon Sep 17 00:00:00 2001
From: "Jay Freeman (saurik)" <saurik@saurk.com>
Date: Tue, 30 Dec 2008 01:14:28 +0000
Subject: [PATCH] Reworked how ratings integrate.

---
 Cydia.app/menes/menes.js |  10 ----
 Cydia.app/package.html   | 118 +++++++++++++++++++++++++--------------
 Cydia.app/package.js     |  63 +++++++++++----------
 Cydia.app/star.png       | Bin 0 -> 3487 bytes
 Cydia.mm                 |   2 +-
 5 files changed, 110 insertions(+), 83 deletions(-)
 create mode 100644 Cydia.app/star.png

diff --git a/Cydia.app/menes/menes.js b/Cydia.app/menes/menes.js
index b5f457b1..098f377f 100644
--- a/Cydia.app/menes/menes.js
+++ b/Cydia.app/menes/menes.js
@@ -287,15 +287,6 @@ $.inject({
         }
     },
 
-    display: {
-        get: function (node) {
-            return node.style.display;
-        },
-        set: function (node, value) {
-            node.style.display = value;
-        }
-    },
-
     html: {
         get: function (node) {
             return node.innerHTML;
@@ -466,7 +457,6 @@ $.xhr = function (url, method, headers, data, events) {
         events = {};
 
     xhr.onreadystatechange = function () {
-        console.log(xhr.readyState);
         if (xhr.readyState == 4) {
             var status = xhr.status;
             var text = xhr.responseText;
diff --git a/Cydia.app/package.html b/Cydia.app/package.html
index ae602b7d..3e634752 100644
--- a/Cydia.app/package.html
+++ b/Cydia.app/package.html
@@ -14,13 +14,11 @@
             if (count++ != 0)
                 return;
             $("#depiction-load").remove();
-            $.each($("#depiction-src"), function (node) {
-                node.style.display = "block";
-            });
+            $("#depiction-src").css("display" "block");
         }
 
         var remove = function() {
-            $(".description").display("block");
+            $(".description").css("display", "block");
             $(".depiction").remove();
         }
     </script>
@@ -74,15 +72,18 @@
 
         #boundry {
             float: left;
-            width: 60px;
+            width: 64px;
         }
 
         #icon {
-            height: 59px;
-            max-width: 60px;
-            width: auto;
+            background-position: center center;
+            background-repeat: no-repeat;
+            -webkit-border-radius: 9px;
+            height: 64px;
+            width: 64px;
         }
 
+        /* XXX: this style is out of date */
         #reflection {
             height: 59px;
             max-width: 60px;
@@ -92,7 +93,7 @@
             width: auto;
         }
 
-        #id {
+        #id, #author, #maintainer, #sponsor {
             white-space: nowrap;
         }
 
@@ -103,23 +104,26 @@
 
         #header > div {
             padding: 0;
-            margin-left: 2px;
         }
 
         #content {
-            margin: auto 0;
+            padding: 5px;
             position: absolute;
-            left: 72px;
-            width: 237px;
+            left: 77px;
+            width: 232px;
         }
 
         #lower {
-            margin: 10px 5px;
+            margin: 0px 5px;
         }
 
         #name {
-            margin: 7px 5px;
+            margin-bottom: 10px;
             font-weight: bold;
+            font-size: 17px;
+            overflow: hidden;
+            text-overflow: ellipsis;
+            white-space: nowrap;
         }
 
         #latest {
@@ -127,19 +131,55 @@
             float: left;
         }
 
-        #rating {
+        a[href].rating {
+            background: 105px 7px no-repeat url(menes/chevron.png);
+        }
+
+        .rating {
+            /*border: 1px solid #999999;*/
+            -webkit-border-radius: 6px;
+            padding: 7px 7px;
+            margin: -7px 0px;
             float: right;
-            margin-top: -7px;
-            width: 130px;
+            width: 124px;
         }
 
-        #description {
-            background-color: #c7ced5;
-            border-bottom: 1px solid #999999;
-            border-top: 1px solid #999999;
-            font-size: 16px;
-            margin: 9px 10px;
-            padding: 10px;
+        .rating .back,
+        .rating .fore,
+        .rating .star {
+            background: url(star.png);
+            height: 16px;
+        }
+
+        .rating .back,
+        .rating .fore {
+            width: 80px;
+        }
+
+        .rating .star {
+            display: inline-block;
+            width: 16px;
+        }
+
+        .rating .back {
+            opacity: 0.2;
+        }
+
+        .rating .fore {
+            /*border-right: 1px solid #999999;*/
+            position: absolute;
+        }
+    
+        .rating .text {
+            display: inline-block;
+            color: #4d4d70;
+            margin: 0 6px;
+            vertical-align: top;
+        }
+
+        #rating-none,
+        #rating-done {
+            display: none;
         }
     </style>
 </head><body class="pinstripe">
@@ -148,26 +188,22 @@
 <fieldset id="header">
     <div class="clearfix">
         <div id="boundry">
-            <img id="icon"/>
+            <div id="icon"></div>
             <!--img id="reflection"/-->
         </div>
 
         <div id="content">
             <div id="name"></div>
-
-            <div id="lower">
-                <div id="latest"></div>
-
-                <iframe
-                    onload="rating_()"
-                    class="rating"
-                    id="rating"
-                    frameborder="0"
-                    height="0"
-                    target="_top"
-                    src="loading.html"
-                ></iframe>
-            </div>
+            <div id="latest"></div>
+
+            <a class="rating" id="rating-href">
+                <div id="rating-none">
+                    <div class="star"></div><div class="text">Not Rated</div>
+                </div><div id="rating-done">
+                    <div class="fore" id="rating-value"></div>
+                    <div class="back"></div>
+                </div>
+            </a>
         </div>
     </div>
 </fieldset>
@@ -232,7 +268,7 @@
 
 <!--hr id="lower-bar" class="depiction"/-->
 
-<div id="description" class="description"></div>
+<block class="description"><p id="description"></p></block>
 
 <fieldset class="description homepage">
     <a class="homepage" id="homepage-href">
diff --git a/Cydia.app/package.js b/Cydia.app/package.js
index 679d1832..71ac849b 100644
--- a/Cydia.app/package.js
+++ b/Cydia.app/package.js
@@ -29,22 +29,47 @@ function space(selector, html, max) {
     var width = node.width();
     if (width > max) {
         var spacing = (max - node.width()) / (html.length - 1) + "px";
-        console.log(width + " " + max + " " + spacing);
         node.css("letter-spacing", spacing);
     }
 }
 
-var rated = 0;
+$(function () {
+    var id = package.id;
+    var idc = encodeURIComponent(id);
+    var name = package.name;
+    var regarding = encodeURIComponent("Cydia/APT: " + name);
+    var icon = 'cydia://package-icon/' + idc;
+    var icon = 'http://cydia.saurik.com/thumb/net.ispazio.deeptheme.png';
+
+    $("#icon").css("background-image", 'url("' + icon + '")');
+    $("#reflection").src("cydia://package-icon/" + idc);
+
+    $("#name").html(name);
+    space("#latest", package.latest, 96);
 
-var rating = function () {
     var rating = package.rating;
     if (rating == null)
         $(".rating").remove();
     else {
-        rating = 'fail.html';
-        $.xhr('_' + rating, 'GET', {}, null, {
+        $.xhr(rating, 'GET', {}, null, {
             success: function (value) {
-                document.getElementById("rating").contentWindow.document.write(value);
+                value = eval(value);
+
+                $("#rating-load").remove();
+                $("#rating-href").href(value.reviews);
+
+                var none = $("#rating-none");
+                var done = $("#rating-done");
+
+                if (value.rating == null) {
+                    done.remove();
+                    none.css("display", "block");
+                } else {
+                    none.remove();
+                    done.css("display", "block");
+
+                    $("#rating-value").css('width', 16 * value.rating);
+                }
             },
 
             failure: function (status) {
@@ -52,30 +77,6 @@ var rating = function () {
             }
         });
     }
-};
-
-var rating_ = function() {
-    if (rated == 0)
-        rated = 1;
-    else if (rated == 1) {
-        rating();
-        rated = -1;
-    }
-};
-
-$(function () {
-    var id = package.id;
-    var idc = encodeURIComponent(id);
-    var name = package.name;
-    var regarding = encodeURIComponent("Cydia/APT: " + name);
-
-    $("#icon").src("cydia://package-icon/" + idc);
-    $("#reflection").src("cydia://package-icon/" + idc);
-
-    $("#name").html(name);
-    space("#latest", package.latest, 93);
-
-    rating_();
 
     $("#settings").href("cydia://package-settings/" + idc);
 
@@ -147,7 +148,7 @@ $(function () {
     if (depiction == null)
         $(".depiction").remove();
     else {
-        $(".description").display("none");
+        $(".description").css("display", "none");
         $("#depiction-src").src(depiction);
     }
 
diff --git a/Cydia.app/star.png b/Cydia.app/star.png
new file mode 100644
index 0000000000000000000000000000000000000000..b67a56c88cf004219b3fee1e57f62f278d66fca2
GIT binary patch
literal 3487
zcmV;Q4Pf$#P)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV00009a7bBm000XU
z000XU0RWnu7ytkYPiaF#P*7-ZbZ>KLZ*U+<Lqi~Na&Km7Y-Iodc-oy)XH-+^7Crag
z^g>IBfRsybQWXdwQbLP>6p<z>Aqfylh#{fb6;Z(vMMVS~$e@S=j*ftg6;Uh<iVD~V
z<RPMtgQJLw%KPDaqifc@_vX$1wbwr9tn;0-&j-K=43<bUQ8j=JsX`tR;Dg7+#^K~H
zK!FM*Z~zbpvt%K2{UZSY_<lS*D<Z%Lz5oGu(+dayz)hRLFdT>f59&ghTmgWD0l;*T
zI7<kC6aYYajzXpYKt=(8otP$50H6c_V9R4-;{Z@C0AMG7=F<Rxo%or10RUT+Ar%3j
zkpLhQWr#!oXgdI`&sK^>09Y^p6lP1rIRMx#05C~cW=H_Aw*bJ-5DT&Z2n+x)QHX^p
z00esgV8|mQcmRZ%02D^@S3L16t`O%c004NIvOKvYIYoh62rY33S640`D9%Y2D-<?i
z0%4j!F2Z@488U%158(66005wo6%pWr^Zj_v4zAA5HjcIqUoGmt2LB>rV&neh&#Q1i
z007~1e$oCcFS8neI|hJl{-P!B1ZZ9hpmq0)X0i`JwE&>$+E?>%_<lS*MWK+n+1cgf
z<k(8YLR(?VSAG6x!e78w{cQPuJpA|d;J)G{fihizM+Erb!p!tcr5w+a34~(Y=8s4G
zw+sLL9n&JjNn*KJDiq^U5^;`1nvC-@r6P$!k}1U{(*I=Q-z@tBKHoI}uxdU5dyy@u
zU1J0GOD7Ombim^G008p4Z^6_k2m^p<gW=D2|L;HjN1!DDfM!XOaR2~bL?kX$%CkSm
z2mk;?pn)o|K^yeJ7%adB9Ki+L!3+FgHiSYX#KJ-lLJDMn9CBbOtb#%)hRv`YDqt_v
zKpix|QD}yfa1JiQRk#j4a1Z)n2%f<xynzV>LC6RbVIkUx0b+_+BaR3cnT7Zv!AJxW
zizFb)h!jyGOOZ85F;a?DAXP{m@;!0_Ifq<Ex{*7`05XF7hP+2Hl!3BQJ=6@fL%FCo
z8iYoo3(#bAF`ADSpqtQgv>H8(HlgRxt7s3}k3K`kFu>>-2Q$QMFfPW!La{h336o>X
zu_CMttHv6zR;&ZNiS=X8v3CR#fknUxHUxJ<AYmRsNLWl*PS{AOARHt#5!wki2?K;t
z!Y3k=s7tgax)J%r7-BLphge7~Bi0g+6E6^Zh(p9TBoc{3GAFr^0!gu?RMHaCM$&Fl
zBk3%un>0uoBa_M6WNWeqIg~6QE69c9o#eyhGvpiOA@W-aonk<7r1(?fC{oI5N*U!4
z<uv66WtcKSRim0x-Ke2d5jBrmLam{;Qm;{ms1r1GnmNsb7D-E`t)i9F8fX`2_i3-_
zbh;7Ul^#x)&{xvS=|||7=mYe33=M`AgU5(xC>fg=2N-7=cNnjjOr{yriy6mMFgG#l
znCF=fnQv8CDz++o6_Lscl}eQ+l^ZHARH>?_s@|##Rr6KLRFA1%Q+=*RRWnoLsR`7U
zt5vF<Q0r40Q)j6=sE4X&sBct1q<&fbi3VB2Ov6t@q*0);U*o*SAPZv|vv@2aYYnT0
zb%8a+Cb7-ge0D0knEf5Qi#@8Tp*ce{N;6lpQuCB%KL_KOarm5cP6_8Ir<e17iry6O
zDdH&`rZh~sF=bq9s+O0QSgS~@QL9Jmy*94xr=6y~MY~!1fet~(N+(<=M`w@D1)b+p
z*;C!83a1uLJv#NSE~;y#8=<>IcfW3@?wFpwUVxrVZ>QdQz32KIeJ}k~{cZZE^+ya?
z2D1z#2HOnI7(B%_ac?{wFUQ;QQA1tBKtrWrm0_3Rgps+?Jfqb{jYbcQX~taRB;#$y
zZN{S}1|}gUOHJxc?wV3fxuz+mJ4`!F$IZ;mqRrNsHJd##*D~ju=bP7?-?v~|cv>vB
zsJ6IeNwVZxrdjT`yl#bBIa#GxRa#xMMy;K#CDyyGyQdMSxlWT#tDe?p!?5wT$+oGt
z8L;Kp2HUQ-ZMJ=3XJQv;x5ci*?vuTfeY$;({XGW_huIFR9a<fJbF^|4I#xQ~n$Dc=
zKYhjYmgz5NSkDm8*fZm{6U!;YX`NG>(?@3)XSs8O^N5RyOM=TTmp(3=8^+zpz2r)C
z^>JO{deZfso3oq3?Wo(Y?l$ge?uXo;%ru`Vo>?<<(8I_>;8Eq#KMS9gFl*neeosSB
zfoHYnBQIkwkyowPu(zdms`p{<7e4kra-ZWq<2*OsGTvEV%s0Td$hXT+!*8Bnh2KMe
zBmZRodjHV?r+_5^X9J0WL4jKW`}lf%A-|44I@@LTvf1rHjG(ze6+w@Jt%Bvjts!X0
z?2xS?_ve_-k<Mujg;0Lz*3buG=3$G&ehepthlN*$KaOySSQ^nWmo<0M+(UEUMEXRQ
zMBbZcF;6+KElM>iKB_KiJlZ$9G`c^=E@oNG)mWWaNo-3TIW8)$Hg0Ub-~8?KhvJ>$
z3*&nim@mj(aCxE5!t{lw7O5^0EIO7zOo&c6l<+|iDySBWCGrz@C5{St!X3hAA}`T4
z(TLbXTq+(;@<=L8dXnssyft|w#WSTW<++3>sgS%(4NTpeI-VAqb|7ssJvzNHgOZVu
zaYCvgO_R1~>SyL=cFU|~g|hy|Zi}}s9+d~lYqOB71z9Z$wnC=pR9Yz4DhIM>Wmjgu
z&56o6maCpC&F##y%G;1PobR9i?GnNg;gYtchD%p19a!eQtZF&3JaKv33gZ<8D~47E
ztUS1iwkmDaPpj=$m#%)jCVEY4fnLGNg2A-`YwHVD3gv};>)hAvT~AmqS>Lr``i7kw
zJ{5_It`yrBmlc25DBO7E8;5VoznR>Ww5hAaxn$2~(q`%A-YuS64wkBy=9dm`4cXeX
z4c}I@?e+FW+b@^RDBHV(wnMq2zdX3SWv9u`%{xC-q*U}&`cyXV(%rRT*Z6MH?i+i&
z_B8C(+grT%{XWUQ+f@NoP1R=AW&26{v-dx)iK^-Nmiuj8txj!m?Z*Ss1N{dh4z}01
z)YTo*JycSU)+_5r4#yw9{+;i4Ee$peRgIj+;v;ZGdF1K$3E%e~4LaI(jC-u%2h$&R
z9cLXcYC@Xwnns&bn)_Q~Te?roKGD|d-g^8;+aC{{G(1^(O7m37Y1-+6)01cN&y1aw
zoqc{T`P^XJqPBbIW6s}d4{z_f5Om?vMgNQEJG?v2T=KYd^0M3I6IZxbny)%vZR&LD
zJpPl@Psh8QyPB@KTx+@RdcC!KX7}kEo;S|j^u2lU7XQ}Oo;f|;z4Ll+_r>@1-xl3|
zawq-H%e&ckC+@AhPrP6BK<z=<L*0kfKU@CX*zeqbYQT4(^U>T#_XdT7&;F71j}Joy
zkC~6lh7E@6o;W@^IpRNZ{ptLtL(gQ-CY~4mqW;US7Zxvm_|@yz&e53Bp_lTPlfP|z
zrTyx_>lv@x#=^!PzR7qqF<$gm`|ZJZ+;<)Cqu&ot<a{81DF0~rvGr5Xr~8u`lav1h
z1DNytV>2z=00004XF*Lt006O$eEU(80000WV@Og>004R=004l4008;_004mL004C`
z008P>0026e000+nl3&F}0008INkl<Zc-oAQTWDNW6o$WjE;)0Y#4>FrGbRmHk~Gaj
z5^5D~1k0cg!QQYmrGjmRmcEFk=|!+U*=qVAeNjOSsi2lp)CVCn+MAWozD!A*ibMw$
zZBtDqnaO1C*K?K+Lo}@h{9&=zUhDt={cm;QR5SJdAdl|~^B_KbGjKFMTP*Ys&cDBS
ze(6*vKCj74>`ye7z$@#OT`JbSn96!KA9!9Z$wNf`v(~TDc4Q)lWM*u??0MSgU5dA)
z^HXacKI{#)<8OVEmQ}t(|2x4ueRgB$QT^55M_v$_85Eg5Es-yKor4>!mrrap0}t}m
z-gV~omVl?zs?{4U+i1{r)!NhQZSU&q)2Ru9n2?Y2<K>a^t)HTiyHmMeD7dj~B0o8q
zDUYi+p7RVp+qq&>@9q#-7E~&rS)kW}GC*_?1!&c?kcW7bug_gzY&!Xc-t4bTh9j9o
zhneaLJhl>Cpi+QR67unC<zkSHLuwZ0X88VEST5e3I;ni+Pn3wTv0K@0j<??4*3iE$
zwA#SX00l_Z&=IIOkSTF9e5W{kZ}y~F$H1|VrL05*fX!=_M+%&HH{?CivB3|zUKNW}
z4U}SXBJRHaP4akKI|IkhNSW%#su;c{g|et`0f^=x??T3bWTo1dgkr*Rev7K_7R2`%
z0JJSvYXF#cAX|bzQt)d6=8KRi(qwDqLoO|gHOAsgW35`<k#oVYh>oQhx{-<5w$gWZ
z>%RI%8(S$>dTC#*`8&aT`;@1-M(Zk8OwNub(z`CDKMU*b&U-=UrH`WNbLYoXIVYj$
z_Nui<w<zOZ3B*L3vfSJKKWFDA=9~{3nz;P=btwT1>{FvxXS2Ome$e*E$}$nq|9M#Z
z;57w+Zct*G`&CW7bNZPl7+nwp92=6nKgd;Yvpe)itBkDh;VkU_8UVveUJkrnEk*zU
N002ovPDHLkV1j-Mk}CiJ

literal 0
HcmV?d00001

diff --git a/Cydia.mm b/Cydia.mm
index d07e85f4..6f80b37c 100644
--- a/Cydia.mm
+++ b/Cydia.mm
@@ -1840,7 +1840,7 @@ class Progress :
 
 - (NSString *) rating {
     if (NSString *rating = [Indices_ objectForKey:@"Rating"])
-        return [rating stringByReplacingOccurrencesOfString:@"@P" withString:[id_ stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
+        return [rating stringByReplacingOccurrencesOfString:@"@" withString:[id_ stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
     else
         return nil;
 }
-- 
2.45.2