From: Jay Freeman (saurik) <saurik@saurik.com>
Date: Sun, 20 Feb 2011 12:40:52 +0000 (-0800)
Subject: Refactor _detachNewThreadData as _detachNewThreadInvocation.
X-Git-Tag: v1.1.0%b1~274
X-Git-Url: https://git.saurik.com/cydia.git/commitdiff_plain/ed637e66d7f4af4b8f81fc897f89a0775cb957f6?ds=inline

Refactor _detachNewThreadData as _detachNewThreadInvocation.
---

diff --git a/MobileCydia.mm b/MobileCydia.mm
index 48163b06..c7c9ab49 100644
--- a/MobileCydia.mm
+++ b/MobileCydia.mm
@@ -4811,7 +4811,6 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
 - (id) initWithDatabase:(Database *)database delegate:(id)delegate;
 
 - (void) _retachThread;
-- (void) _detachNewThreadData:(ProgressData *)data;
 - (void) detachNewThreadSelector:(SEL)selector toTarget:(id)target withObject:(id)object title:(NSString *)title;
 
 - (BOOL) isRunning;
@@ -5036,8 +5035,8 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
     [delegate_ setStatusBarShowsProgress:NO];
 }
 
-- (void) _detachNewThreadData:(ProgressData *)data { _pooled
-    [[data target] performSelector:[data selector] withObject:[data object]];
+- (void) _detachNewThreadInvocation:(NSInvocation *)invocation { _pooled
+    [invocation invoke];
     [self performSelectorOnMainThread:@selector(_retachThread) withObject:nil waitUntilDone:YES];
 }
 
@@ -5088,15 +5087,12 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
         }
     }
 
-    [NSThread
-        detachNewThreadSelector:@selector(_detachNewThreadData:)
-        toTarget:self
-        withObject:[[[ProgressData alloc]
-            initWithSelector:selector
-            target:target
-            object:object
-        ] autorelease]
-    ];
+    NSInvocation *invocation([NSInvocation invocationWithMethodSignature:[target methodSignatureForSelector:selector]]);
+    [invocation setTarget:target];
+    [invocation setSelector:selector];
+    _assert(object == nil);
+
+    [NSThread detachNewThreadSelector:@selector(_detachNewThreadInvocation:) toTarget:self withObject:invocation];
 }
 
 - (void) repairWithSelector:(SEL)selector {