From: Jay Freeman (saurik) <saurik@saurik.com>
Date: Sat, 13 Nov 2010 22:07:29 +0000 (-0800)
Subject: Use lowercase identifiers always, even internally.
X-Git-Url: https://git.saurik.com/cydia.git/commitdiff_plain/c400e87fb23d0d6353c2831b3e6a59ba47a0728c

Use lowercase identifiers always, even internally.
---

diff --git a/MobileCydia.mm b/MobileCydia.mm
index 1be5d281..6f8737f1 100644
--- a/MobileCydia.mm
+++ b/MobileCydia.mm
@@ -2153,6 +2153,13 @@ struct PackageNameOrdering :
             name_.set(pool, iterator_.Display());
         _end
 
+        _profile(Package$lowercaseString)
+            char *data(id_.data());
+            for (size_t i(0), e(id_.size()); i != e; ++i)
+                // XXX: do not use tolower() as this is not locale-specific? :(
+                data[i] |= 0x20;
+        _end
+
         if (!file_.end()) {
             _profile(Package$initWithVersion$Source)
                 source_ = [database_ getSource:file_.File()];
@@ -2183,10 +2190,9 @@ struct PackageNameOrdering :
         _end
 
         bool changed(false);
-        NSString *key([static_cast<id>(id_) lowercaseString]);
 
         _profile(Package$initWithVersion$Metadata)
-            metadata_ = [Packages_ objectForKey:key];
+            metadata_ = [Packages_ objectForKey:id_];
 
             if (metadata_ == nil) {
                 firstSeen_ = now_;
@@ -2226,7 +2232,7 @@ struct PackageNameOrdering :
             metadata_ = [metadata_ retain];
 
             if (changed) {
-                [Packages_ setObject:metadata_ forKey:key];
+                [Packages_ setObject:metadata_ forKey:id_];
                 Changed_ = true;
             }
         _end