From: Jay Freeman (saurik) <saurik@saurik.com>
Date: Sun, 13 Mar 2011 22:48:54 +0000 (-0700)
Subject: Source warnings added null sources.
X-Git-Tag: v1.1.0%b7~21
X-Git-Url: https://git.saurik.com/cydia.git/commitdiff_plain/708cf61e40da2ed0f63f8b212a2c3c9f7bab3e4f

Source warnings added null sources.
---

diff --git a/MobileCydia.mm b/MobileCydia.mm
index 43217de9..255bf87c 100644
--- a/MobileCydia.mm
+++ b/MobileCydia.mm
@@ -8276,12 +8276,8 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
         [delegate_ removeProgressHUD:hud_];
         hud_ = nil;
 
-        bool defer(false);
-
         if (cydia_) {
             if (NSString *warning = [self yieldToSelector:@selector(getWarning)]) {
-                defer = true;
-
                 UIAlertView *alert = [[[UIAlertView alloc]
                     initWithTitle:UCLocalize("SOURCE_WARNING")
                     message:warning
@@ -8295,8 +8291,13 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
                 [alert setContext:@"warning"];
                 [alert setNumberOfRows:1];
                 [alert show];
-            } else
-                [self complete];
+
+                // XXX: there used to be this great mechanism called yieldToPopup... who deleted it?
+                error_ = nil;
+                return;
+            }
+
+            [self complete];
         } else if (error_ != nil) {
             UIAlertView *alert = [[[UIAlertView alloc]
                 initWithTitle:UCLocalize("VERIFICATION_ERROR")