From: Jay Freeman (saurik) <saurik@saurik.com>
Date: Sun, 20 Feb 2011 00:28:01 +0000 (-0800)
Subject: Add explanatory threading comment to -[ChangesController _reloadPackages:].
X-Git-Tag: v1.1.0%b1~281
X-Git-Url: https://git.saurik.com/cydia.git/commitdiff_plain/6c0ea9c39cd316b4c15ad75bad35ccb8e3f17f22

Add explanatory threading comment to -[ChangesController _reloadPackages:].
---

diff --git a/MobileCydia.mm b/MobileCydia.mm
index 17b08bd4..bda674d8 100644
--- a/MobileCydia.mm
+++ b/MobileCydia.mm
@@ -7349,6 +7349,8 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) {
     } return self;
 }
 
+// this mostly works because reloadData (below) is @synchronized (database_)
+// XXX: that said, I've been running into problems with NSRangeExceptions :(
 - (void) _reloadPackages:(NSArray *)packages {
     CFRelease(packages_);
     packages_ = CFArrayCreateMutable(kCFAllocatorDefault, [packages count], NULL);