From: Jay Freeman (saurik) <saurik@saurik.com>
Date: Sat, 31 Mar 2012 20:03:47 +0000 (-0700)
Subject: Fix the bug Optimo reported with CFBundleIconFile.
X-Git-Tag: v1.1.6~2
X-Git-Url: https://git.saurik.com/cydia.git/commitdiff_plain/5e17a7344aeaea01178fa53bd69fab5baef75f73?ds=inline

Fix the bug Optimo reported with CFBundleIconFile.
---

diff --git a/MobileCydia.mm b/MobileCydia.mm
index fc38970f..bd18af14 100644
--- a/MobileCydia.mm
+++ b/MobileCydia.mm
@@ -2885,7 +2885,8 @@ struct PackageNameOrdering :
 
                 NSString *bundle([file stringByDeletingLastPathComponent]);
                 NSString *icon([info objectForKey:@"CFBundleIconFile"]);
-                if (icon == nil || [icon length] == 0)
+                // XXX: maybe this should check if this is really a string, not just for length
+                if (icon == nil || ![icon respondsToSelector:@selector(length)] || [icon length] == 0)
                     icon = @"icon.png";
                 NSURL *url([NSURL fileURLWithPath:[bundle stringByAppendingPathComponent:icon]]);