X-Git-Url: https://git.saurik.com/cydia.git/blobdiff_plain/d11754e58a653af9ef4721fb3dafc0fe9e998816..3736ff65d8e3dbe7398a30b8cadf489f7fefde5f:/MobileCydia.mm diff --git a/MobileCydia.mm b/MobileCydia.mm index 8b0ae707..d6adebab 100644 --- a/MobileCydia.mm +++ b/MobileCydia.mm @@ -118,7 +118,7 @@ extern "C" { #include #include -#include +#include #include "UICaboodle/BrowserView.h" @@ -204,6 +204,15 @@ void PrintTimes() { while (false); \ [_pool release]; +// Hash Functions/Structures {{{ +extern "C" uint32_t hashlittle(const void *key, size_t length, uint32_t initval = 0); + +union SplitHash { + uint32_t u32; + uint16_t u16[2]; +}; +// }}} + static const NSUInteger UIViewAutoresizingFlexibleBoth(UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight); void NSLogPoint(const char *fix, const CGPoint &point) { @@ -695,6 +704,16 @@ NSUInteger DOMNodeList$countByEnumeratingWithState$objects$count$(DOMNodeList *s /* }}} */ /* C++ NSString Wrapper Cache {{{ */ +static _finline CFStringRef CYStringCreate(const char *data, size_t size) { + return size == 0 ? NULL : + CFStringCreateWithBytesNoCopy(kCFAllocatorDefault, reinterpret_cast(data), size, kCFStringEncodingUTF8, NO, kCFAllocatorNull) ?: + CFStringCreateWithBytesNoCopy(kCFAllocatorDefault, reinterpret_cast(data), size, kCFStringEncodingISOLatin1, NO, kCFAllocatorNull); +} + +static _finline CFStringRef CYStringCreate(const char *data) { + return CYStringCreate(data, strlen(data)); +} + class CYString { private: char *data_; @@ -747,17 +766,24 @@ class CYString { cache_ = reinterpret_cast(CFRetain(rhs.cache_)); } + void copy(apr_pool_t *pool) { + char *temp(reinterpret_cast(apr_palloc(pool, size_ + 1))); + memcpy(temp, data_, size_); + temp[size_] = '\0'; + data_ = temp; + } + void set(apr_pool_t *pool, const char *data, size_t size) { if (size == 0) clear(); else { clear_(); - char *temp(reinterpret_cast(apr_palloc(pool, size + 1))); - memcpy(temp, data, size); - temp[size] = '\0'; - data_ = temp; + data_ = const_cast(data); size_ = size; + + if (pool != NULL) + copy(pool); } } @@ -773,19 +799,19 @@ class CYString { return size_ == rhs.size_ && memcmp(data_, rhs.data_, size_) == 0; } - operator CFStringRef() { - if (cache_ == NULL) { - if (size_ == 0) - return nil; - cache_ = CFStringCreateWithBytesNoCopy(kCFAllocatorDefault, reinterpret_cast(data_), size_, kCFStringEncodingUTF8, NO, kCFAllocatorNull); - if (cache_ == NULL) - cache_ = CFStringCreateWithBytesNoCopy(kCFAllocatorDefault, reinterpret_cast(data_), size_, kCFStringEncodingISOLatin1, NO, kCFAllocatorNull); - } return cache_; + _finline operator CFStringRef() { + if (cache_ == NULL) + cache_ = CYStringCreate(data_, size_); + return cache_; } _finline operator id() { return (NSString *) static_cast(*this); } + + _finline operator const char *() { + return reinterpret_cast(data_); + } }; /* }}} */ /* C++ NSString Algorithm Adapters {{{ */ @@ -947,6 +973,11 @@ class CYColor { private: CGColorRef color_; + static CGColorRef Create_(CGColorSpaceRef space, float red, float green, float blue, float alpha) { + CGFloat color[] = {red, green, blue, alpha}; + return CGColorCreate(space, color); + } + public: CYColor() : color_(NULL) @@ -954,7 +985,7 @@ class CYColor { } CYColor(CGColorSpaceRef space, float red, float green, float blue, float alpha) : - color_(NULL) + color_(Create_(space, red, green, blue, alpha)) { Set(space, red, green, blue, alpha); } @@ -970,8 +1001,7 @@ class CYColor { void Set(CGColorSpaceRef space, float red, float green, float blue, float alpha) { Clear(); - float color[] = {red, green, blue, alpha}; - color_ = CGColorCreate(space, (CGFloat *) color); + color_ = Create_(space, red, green, blue, alpha); } operator CGColorRef() { @@ -1042,7 +1072,7 @@ static _transient NSMutableDictionary *Packages_; static _transient NSMutableDictionary *Sections_; static _transient NSMutableDictionary *Sources_; static bool Changed_; -static NSDate *now_; +static time_t now_; static bool IsWildcat_; /* }}} */ @@ -1069,24 +1099,9 @@ NSString *SizeString(double size) { return [NSString stringWithFormat:@"%s%.1f %s", (negative ? "-" : ""), size, powers_[power]]; } -static _finline CFStringRef CFCString(const char *value) { - return CFStringCreateWithBytesNoCopy(kCFAllocatorDefault, reinterpret_cast(value), strlen(value), kCFStringEncodingUTF8, NO, kCFAllocatorNull); -} - -const char *StripVersion_(const char *version) { - const char *colon(strchr(version, ':')); - if (colon != NULL) - version = colon + 1; - return version; -} - -CFStringRef StripVersion(const char *version) { +static _finline const char *StripVersion_(const char *version) { const char *colon(strchr(version, ':')); - if (colon != NULL) - version = colon + 1; - return CFStringCreateWithBytes(kCFAllocatorDefault, reinterpret_cast(version), strlen(version), kCFStringEncodingUTF8, NO); - // XXX: performance - return CFCString(version); + return colon == NULL ? version : colon + 1; } NSString *LocalizeSection(NSString *section) { @@ -1183,6 +1198,7 @@ bool isSectionVisible(NSString *section) { - (void) syncData; - (void) showSettings; - (UIProgressHUD *) addProgressHUD; +- (BOOL) hudIsShowing; - (void) removeProgressHUD:(UIProgressHUD *)hud; - (CYViewController *) pageForPackage:(NSString *)name; - (PackageController *) packageController; @@ -1368,8 +1384,6 @@ typedef std::map< unsigned long, _H > SourceMap; - (bool) upgrade; - (void) update; -- (void) setVisible; - - (void) updateWithStatus:(Status &)status; - (void) setDelegate:(id)delegate; @@ -1412,6 +1426,101 @@ typedef std::map< unsigned long, _H > SourceMap; @end /* }}} */ +// Cytore Definitions {{{ +struct PackageValue : + Cytore::Block +{ + Cytore::Offset next_; + + uint32_t index_ : 23; + uint32_t subscribed_ : 1; + uint32_t : 8; + + int32_t first_; + int32_t last_; + + uint16_t vhash_; + uint16_t nhash_; + + char version_[8]; + char name_[]; +}; + +struct MetaValue : + Cytore::Block +{ + Cytore::Offset packages_[1 << 16]; +}; + +static Cytore::File MetaFile_; +// }}} +// Cytore Helper Functions {{{ +static PackageValue *PackageFind(const char *name, size_t length) { + SplitHash nhash = { hashlittle(name, length) }; + + PackageValue *metadata; + + Cytore::Offset *offset(&MetaFile_->packages_[nhash.u16[0]]); + offset: if (offset->IsNull()) { + *offset = MetaFile_.New(length + 1); + metadata = &MetaFile_.Get(*offset); + + memcpy(metadata->name_, name, length + 1); + metadata->nhash_ = nhash.u16[1]; + } else { + metadata = &MetaFile_.Get(*offset); + + if (metadata->nhash_ != nhash.u16[1] || strncmp(metadata->name_, name, length + 1) != 0) { + offset = &metadata->next_; + goto offset; + } + } + + return metadata; +} + +static void PackageImport(const void *key, const void *value, void *context) { + char buffer[1024]; + if (!CFStringGetCString((CFStringRef) key, buffer, sizeof(buffer), kCFStringEncodingUTF8)) { + NSLog(@"failed to import package %@", key); + return; + } + + PackageValue *metadata(PackageFind(buffer, strlen(buffer))); + NSDictionary *package((NSDictionary *) value); + + if (NSNumber *subscribed = [package objectForKey:@"IsSubscribed"]) + if ([subscribed boolValue]) + metadata->subscribed_ = true; + + if (NSDate *date = [package objectForKey:@"FirstSeen"]) { + time_t time([date timeIntervalSince1970]); + if (metadata->first_ > time || metadata->first_ == 0) + metadata->first_ = time; + } + + if (NSDate *date = [package objectForKey:@"LastSeen"]) { + time_t time([date timeIntervalSince1970]); + if (metadata->last_ < time || metadata->last_ == 0) { + metadata->last_ = time; + goto last; + } + } else if (metadata->last_ == 0) last: { + NSString *version([package objectForKey:@"LastVersion"]); + if (CFStringGetCString((CFStringRef) version, buffer, sizeof(buffer), kCFStringEncodingUTF8)) { + size_t length(strlen(buffer)); + uint16_t vhash(hashlittle(buffer, length)); + + size_t capped(std::min(8, length)); + char *latest(buffer + length - capped); + + strncpy(metadata->version_, latest, sizeof(metadata->version_)); + metadata->vhash_ = vhash; + } + } +} +// }}} + /* Source Class {{{ */ @interface Source : NSObject { CYString depiction_; @@ -1492,6 +1601,7 @@ typedef std::map< unsigned long, _H > SourceMap; } - (void) dealloc { + // XXX: this is a very inefficient way to call these deconstructors [self _clear]; [super dealloc]; } @@ -1698,53 +1808,51 @@ typedef std::map< unsigned long, _H > SourceMap; @end /* }}} */ /* Package Class {{{ */ +struct ParsedPackage { + CYString tagline_; + + CYString icon_; + + CYString depiction_; + CYString homepage_; + + CYString sponsor_; + CYString author_; + + CYString bugs_; + CYString support_; +}; + @interface Package : NSObject { - unsigned era_; + uint32_t era_ : 29; + uint32_t essential_ : 1; + uint32_t obsolete_ : 1; + uint32_t ignored_ : 1; + apr_pool_t *pool_; + _transient Database *database_; + pkgCache::VerIterator version_; pkgCache::PkgIterator iterator_; - _transient Database *database_; pkgCache::VerFileIterator file_; - Source *source_; - bool cached_; - bool parsed_; - - CYString section_; - NSString *section$_; - bool essential_; - bool required_; - bool visible_; - bool obsolete_; + CYString id_; + CYString name_; - NSString *latest_; + CYString latest_; CYString installed_; - CYString id_; - CYString name_; - CYString tagline_; - CYString icon_; - CYString depiction_; - CYString homepage_; + CYString section_; + _transient NSString *section$_; - CYString sponsor_; - Address *sponsor$_; + Source *source_; - CYString author_; - Address *author$_; + PackageValue *metadata_; + ParsedPackage *parsed_; - CYString bugs_; - CYString support_; NSMutableArray *tags_; NSString *role_; - - NSArray *relationships_; - - NSMutableDictionary *metadata_; - _transient NSDate *firstSeen_; - _transient NSDate *lastSeen_; - bool subscribed_; } - (Package *) initWithVersion:(pkgCache::VerIterator)version withZone:(NSZone *)zone inPool:(apr_pool_t *)pool database:(Database *)database; @@ -1767,9 +1875,12 @@ typedef std::map< unsigned long, _H > SourceMap; - (NSString *) shortDescription; - (unichar) index; -- (NSMutableDictionary *) metadata; -- (NSDate *) seen; -- (BOOL) subscribed; +- (PackageValue *) metadata; +- (time_t) seen; + +- (bool) subscribed; +- (bool) setSubscribed:(bool)subscribed; + - (BOOL) ignored; - (NSString *) latest; @@ -1789,8 +1900,6 @@ typedef std::map< unsigned long, _H > SourceMap; - (BOOL) hasMode; - (NSString *) mode; -- (void) setVisible; - - (NSString *) id; - (NSString *) name; - (UIImage *) icon; @@ -1801,7 +1910,6 @@ typedef std::map< unsigned long, _H > SourceMap; - (NSString *) support; - (NSArray *) files; -- (NSArray *) relationships; - (NSArray *) warnings; - (NSArray *) applications; @@ -1816,18 +1924,18 @@ typedef std::map< unsigned long, _H > SourceMap; - (NSArray *) purposes; - (bool) isCommercial; +- (void) setIndex:(size_t)index; + - (CYString &) cyname; - (uint32_t) compareBySection:(NSArray *)sections; -- (uint32_t) compareForChanges; - - (void) install; - (void) remove; - (bool) isUnfilteredAndSearchedForBy:(NSString *)search; - (bool) isUnfilteredAndSelectedForBy:(NSString *)search; -- (bool) isInstalledAndVisible:(NSNumber *)number; +- (bool) isInstalledAndUnfiltered:(NSNumber *)number; - (bool) isVisibleInSection:(NSString *)section; - (bool) isVisibleInSource:(Source *)source; @@ -1852,7 +1960,7 @@ uint32_t PackageChangesRadix(Package *self, void *) { value.bits.ignored = [self ignored] ? 0 : 1; value.bits.upgradable = 1; } else { - value.bits.timestamp = static_cast([[self seen] timeIntervalSince1970]) >> 2; + value.bits.timestamp = [self seen] >> 2; value.bits.ignored = 0; value.bits.upgradable = 0; } @@ -1970,28 +2078,17 @@ struct PackageNameOrdering : } - (void) dealloc { + if (parsed_ != NULL) + delete parsed_; + if (source_ != nil) [source_ release]; - if (section$_ != nil) - [section$_ release]; - if (latest_ != nil) - [latest_ release]; - - if (sponsor$_ != nil) - [sponsor$_ release]; - if (author$_ != nil) - [author$_ release]; if (tags_ != nil) [tags_ release]; if (role_ != nil) [role_ release]; - if (relationships_ != nil) - [relationships_ release]; - if (metadata_ != nil) - [metadata_ release]; - [super dealloc]; } @@ -2019,12 +2116,15 @@ struct PackageNameOrdering : } - (void) parse { - if (parsed_) + if (parsed_ != NULL) return; - parsed_ = true; - if (file_.end()) +@synchronized (database_) { + if ([database_ era] != era_ || file_.end()) return; + ParsedPackage *parsed(new ParsedPackage); + parsed_ = parsed; + _profile(Package$parse) pkgRecords::Parser *parser; @@ -2039,14 +2139,14 @@ struct PackageNameOrdering : const char *name_; CYString *value_; } names[] = { - {"icon", &icon_}, - {"depiction", &depiction_}, - {"homepage", &homepage_}, + {"icon", &parsed->icon_}, + {"depiction", &parsed->depiction_}, + {"homepage", &parsed->homepage_}, {"website", &website}, - {"bugs", &bugs_}, - {"support", &support_}, - {"sponsor", &sponsor_}, - {"author", &author_}, + {"bugs", &parsed->bugs_}, + {"support", &parsed->support_}, + {"sponsor", &parsed->sponsor_}, + {"author", &parsed->author_}, }; for (size_t i(0); i != sizeof(names) / sizeof(names[0]); ++i) { @@ -2069,43 +2169,33 @@ struct PackageNameOrdering : stop = end; while (stop != start && stop[-1] == '\r') --stop; - tagline_.set(pool_, start, stop - start); + parsed->tagline_.set(pool_, start, stop - start); } _end _profile(Package$parse$Retain) - if (homepage_.empty()) - homepage_ = website; - if (homepage_ == depiction_) - homepage_.clear(); + if (parsed->homepage_.empty()) + parsed->homepage_ = website; + if (parsed->homepage_ == parsed->depiction_) + parsed->homepage_.clear(); _end _end -} - -- (void) setVisible { - visible_ = required_ && [self unfiltered]; -} +} } - (Package *) initWithVersion:(pkgCache::VerIterator)version withZone:(NSZone *)zone inPool:(apr_pool_t *)pool database:(Database *)database { if ((self = [super init]) != nil) { _profile(Package$initWithVersion) - era_ = [database era]; pool_ = pool; - version_ = version; - iterator_ = version.ParentPkg(); database_ = database; + era_ = [database era]; - _profile(Package$initWithVersion$Latest) - latest_ = (NSString *) StripVersion(version_.VerStr()); - _end + version_ = version; - pkgCache::VerIterator current; - _profile(Package$initWithVersion$Versions) - current = iterator_.CurrentVer(); - if (!current.end()) - installed_.set(pool_, StripVersion_(current.VerStr())); + pkgCache::PkgIterator iterator(version.ParentPkg()); + iterator_ = iterator; + _profile(Package$initWithVersion$Version) if (!version_.end()) file_ = version_.FileList(); else { @@ -2114,102 +2204,84 @@ struct PackageNameOrdering : } _end - _profile(Package$initWithVersion$Name) - id_.set(pool_, iterator_.Name()); - name_.set(pool, iterator_.Display()); + _profile(Package$initWithVersion$Cache) + id_.set(NULL, iterator.Name()); + name_.set(NULL, iterator.Display()); + + latest_.set(NULL, StripVersion_(version_.VerStr())); + + pkgCache::VerIterator current(iterator.CurrentVer()); + if (!current.end()) + installed_.set(NULL, StripVersion_(current.VerStr())); _end - _profile(Package$lowercaseString) + _profile(Package$initWithVersion$Lower) + // XXX: do not use tolower() as this is not locale-specific? :( char *data(id_.data()); for (size_t i(0), e(id_.size()); i != e; ++i) - // XXX: do not use tolower() as this is not locale-specific? :( - data[i] |= 0x20; + if ((data[i] & 0x20) == 0) { + id_.copy(pool); + data = id_.data(); + for (; i != e; ++i) + data[i] |= 0x20; + break; + } _end - if (!file_.end()) { - _profile(Package$initWithVersion$Source) - source_ = [database_ getSource:file_.File()]; - if (source_ != nil) - [source_ retain]; - cached_ = true; - _end - } - - required_ = true; - _profile(Package$initWithVersion$Tags) - pkgCache::TagIterator tag(iterator_.TagList()); + pkgCache::TagIterator tag(iterator.TagList()); if (!tag.end()) { tags_ = [[NSMutableArray alloc] initWithCapacity:8]; do { const char *name(tag.Name()); - [tags_ addObject:(NSString *)CFCString(name)]; + [tags_ addObject:[(NSString *)CYStringCreate(name) autorelease]]; + if (role_ == nil && strncmp(name, "role::", 6) == 0 /*&& strcmp(name, "role::leaper") != 0*/) - role_ = (NSString *) CFCString(name + 6); - if (required_ && strncmp(name, "require::", 9) == 0 && ( - true - )) - required_ = false; + role_ = (NSString *) CYStringCreate(name + 6); + + if (strncmp(name, "cydia::", 7) == 0) { + if (strcmp(name + 7, "essential") == 0) + essential_ = true; + else if (strcmp(name + 7, "obsolete") == 0) + obsolete_ = true; + } + ++tag; } while (!tag.end()); } _end - bool changed(false); - _profile(Package$initWithVersion$Metadata) - metadata_ = [Packages_ objectForKey:id_]; - - if (metadata_ == nil) { - firstSeen_ = now_; - - metadata_ = [[NSMutableDictionary dictionaryWithObjectsAndKeys: - firstSeen_, @"FirstSeen", - latest_, @"LastVersion", - nil] mutableCopy]; - - changed = true; - } else { - firstSeen_ = [metadata_ objectForKey:@"FirstSeen"]; - lastSeen_ = [metadata_ objectForKey:@"LastSeen"]; + PackageValue *metadata(PackageFind(id_.data(), id_.size())); + metadata_ = metadata; - if (NSNumber *subscribed = [metadata_ objectForKey:@"IsSubscribed"]) - subscribed_ = [subscribed boolValue]; + const char *latest(version_.VerStr()); + size_t length(strlen(latest)); - NSString *version([metadata_ objectForKey:@"LastVersion"]); + uint16_t vhash(hashlittle(latest, length)); - if (firstSeen_ == nil) { - firstSeen_ = lastSeen_ == nil ? now_ : lastSeen_; - [metadata_ setObject:firstSeen_ forKey:@"FirstSeen"]; - changed = true; - } - - if (version == nil) { - [metadata_ setObject:latest_ forKey:@"LastVersion"]; - changed = true; - } else if (![version isEqualToString:latest_]) { - [metadata_ setObject:latest_ forKey:@"LastVersion"]; - lastSeen_ = now_; - [metadata_ setObject:lastSeen_ forKey:@"LastSeen"]; - changed = true; - } - } + size_t capped(std::min(8, length)); + latest = latest + length - capped; - metadata_ = [metadata_ retain]; + if (metadata->first_ == 0) + metadata->first_ = now_; - if (changed) { - [Packages_ setObject:metadata_ forKey:id_]; - Changed_ = true; - } + if (metadata->vhash_ != vhash || strncmp(metadata->version_, latest, sizeof(metadata->version_)) != 0) { + metadata->last_ = now_; + strncpy(metadata->version_, latest, sizeof(metadata->version_)); + metadata->vhash_ = vhash; + } else if (metadata->last_ == 0) + metadata->last_ = metadata->first_; _end _profile(Package$initWithVersion$Section) - section_.set(pool_, iterator_.Section()); + section_.set(NULL, iterator.Section()); _end - obsolete_ = [self hasTag:@"cydia::obsolete"]; - essential_ = ((iterator_->Flags & pkgCache::Flag::Essential) == 0 ? NO : YES) || [self hasTag:@"cydia::essential"]; - [self setVisible]; + _profile(Package$initWithVersion$Flags) + essential_ |= ((iterator->Flags & pkgCache::Flag::Essential) == 0 ? NO : YES); + ignored_ = iterator->SelectedState == pkgCache::State::Hold; + _end _end } return self; } @@ -2223,12 +2295,26 @@ struct PackageNameOrdering : if (version.end()) return nil; - return [[[Package alloc] - initWithVersion:version - withZone:zone - inPool:pool - database:database - ] autorelease]; + Package *package; + + _profile(Package$packageWithIterator$Allocate) + package = [Package allocWithZone:zone]; + _end + + _profile(Package$packageWithIterator$Initialize) + package = [package + initWithVersion:version + withZone:zone + inPool:pool + database:database + ]; + _end + + _profile(Package$packageWithIterator$Autorelease) + package = [package autorelease]; + _end + + return package; } - (pkgCache::PkgIterator) iterator { @@ -2240,17 +2326,11 @@ struct PackageNameOrdering : if (section_.empty()) return nil; - std::replace(section_.data(), section_.data() + section_.size(), ' ', '_'); - NSString *name(section_); - - lookup: - if (NSDictionary *value = [SectionMap_ objectForKey:name]) - if (NSString *rename = [value objectForKey:@"Rename"]) { - name = rename; - goto lookup; - } - - section$_ = [[name stringByReplacingCharacter:'_' withCharacter:' '] retain]; + _profile(Package$section) + std::replace(section_.data(), section_.data() + section_.size(), '_', ' '); + NSString *name(section_); + section$_ = [SectionMap_ objectForKey:name] ?: name; + _end } return section$_; } @@ -2283,16 +2363,22 @@ struct PackageNameOrdering : } - (Address *) maintainer { - if (file_.end()) +@synchronized (database_) { + if ([database_ era] != era_ || file_.end()) return nil; + pkgRecords::Parser *parser = &[database_ records]->Lookup(file_); const std::string &maintainer(parser->Maintainer()); return maintainer.empty() ? nil : [Address addressWithString:[NSString stringWithUTF8String:maintainer.c_str()]]; -} +} } - (size_t) size { - return version_.end() ? 0 : version_->InstalledSize; -} +@synchronized (database_) { + if ([database_ era] != era_ || version_.end()) + return 0; + + return version_->InstalledSize; +} } - (NSString *) longDescription { @synchronized (database_) { @@ -2317,7 +2403,7 @@ struct PackageNameOrdering : } } - (NSString *) shortDescription { - return tagline_; + return parsed_ == NULL ? nil : static_cast(parsed_->tagline_); } - (unichar) index { @@ -2332,26 +2418,29 @@ struct PackageNameOrdering : _end } -- (NSMutableDictionary *) metadata { +- (PackageValue *) metadata { return metadata_; } -- (NSDate *) seen { - if (subscribed_ && lastSeen_ != nil) - return lastSeen_; - return firstSeen_; +- (time_t) seen { + PackageValue *metadata([self metadata]); + return metadata->subscribed_ ? metadata->last_ : metadata->first_; } -- (BOOL) subscribed { - return subscribed_; +- (bool) subscribed { + return [self metadata]->subscribed_; } -- (BOOL) ignored { - NSDictionary *metadata([self metadata]); - if (NSNumber *ignored = [metadata objectForKey:@"IsIgnored"]) - return [ignored boolValue]; - else +- (bool) setSubscribed:(bool)subscribed { + PackageValue *metadata([self metadata]); + if (metadata->subscribed_ == subscribed) return false; + metadata->subscribed_ = subscribed; + return true; +} + +- (BOOL) ignored { + return ignored_; } - (NSString *) latest { @@ -2374,9 +2463,9 @@ struct PackageNameOrdering : _profile(Package$upgradableAndEssential) pkgCache::VerIterator current(iterator_.CurrentVer()); if (current.end()) - return essential && essential_ && visible_; + return essential && essential_; else - return !version_.end() && version_ != current;// && (!essential || ![database_ cache][iterator_].Keep()); + return !version_.end() && version_ != current; _end } @@ -2389,12 +2478,31 @@ struct PackageNameOrdering : } - (BOOL) unfiltered { - NSString *section([self section]); - return !obsolete_ && [self hasSupportingRole] && (section == nil || isSectionVisible(section)); + _profile(Package$unfiltered$obsolete) + if (obsolete_) + return false; + _end + + _profile(Package$unfiltered$hasSupportingRole) + if (![self hasSupportingRole]) + return false; + _end + + return true; } - (BOOL) visible { - return visible_; + if (![self unfiltered]) + return false; + + NSString *section([self section]); + + _profile(Package$visible$isSectionVisible) + if (section != nil && !isSectionVisible(section)) + return false; + _end + + return true; } - (BOOL) half { @@ -2461,13 +2569,14 @@ struct PackageNameOrdering : NSString *section = [self simpleSection]; UIImage *icon(nil); - if (!icon_.empty()) - if ([static_cast(icon_) hasPrefix:@"file:///"]) - // XXX: correct escaping - icon = [UIImage imageAtPath:[static_cast(icon_) substringFromIndex:7]]; + if (parsed_ != NULL) + if (NSString *href = parsed_->icon_) + if ([href hasPrefix:@"file:///"]) + // XXX: correct escaping + icon = [UIImage imageAtPath:[href substringFromIndex:7]]; if (icon == nil) if (section != nil) icon = [UIImage imageAtPath:[NSString stringWithFormat:@"%@/Sections/%@.png", App_, section]]; - if (icon == nil) if (source_ != nil) if (NSString *dicon = [source_ defaultIcon]) + if (icon == nil) if (Source *source = [self source]) if (NSString *dicon = [source defaultIcon]) if ([dicon hasPrefix:@"file:///"]) // XXX: correct escaping icon = [UIImage imageAtPath:[dicon substringFromIndex:7]]; @@ -2477,31 +2586,23 @@ struct PackageNameOrdering : } - (NSString *) homepage { - return homepage_; + return parsed_ == NULL ? nil : static_cast(parsed_->homepage_); } - (NSString *) depiction { - return !depiction_.empty() ? depiction_ : [[self source] depictionForPackage:id_]; + return parsed_ != NULL && !parsed_->depiction_.empty() ? parsed_->depiction_ : [[self source] depictionForPackage:id_]; } - (Address *) sponsor { - if (sponsor$_ == nil) { - if (sponsor_.empty()) - return nil; - sponsor$_ = [[Address addressWithString:sponsor_] retain]; - } return sponsor$_; + return parsed_ == NULL || parsed_->sponsor_.empty() ? nil : [Address addressWithString:parsed_->sponsor_]; } - (Address *) author { - if (author$_ == nil) { - if (author_.empty()) - return nil; - author$_ = [[Address addressWithString:author_] retain]; - } return author$_; + return parsed_ == NULL || parsed_->author_.empty() ? nil : [Address addressWithString:parsed_->author_]; } - (NSString *) support { - return !bugs_.empty() ? bugs_ : [[self source] supportForPackage:id_]; + return parsed_ != NULL && !parsed_->bugs_.empty() ? parsed_->bugs_ : [[self source] supportForPackage:id_]; } - (NSArray *) files { @@ -2520,10 +2621,6 @@ struct PackageNameOrdering : return files; } -- (NSArray *) relationships { - return relationships_; -} - - (NSArray *) warnings { NSMutableArray *warnings([NSMutableArray arrayWithCapacity:4]); const char *name(iterator_.Name()); @@ -2609,21 +2706,16 @@ struct PackageNameOrdering : } - (Source *) source { - if (!cached_) { + if (source_ == nil) { @synchronized (database_) { if ([database_ era] != era_ || file_.end()) - source_ = nil; - else { - source_ = [database_ getSource:file_.File()]; - if (source_ != nil) - [source_ retain]; - } - - cached_ = true; + source_ = (Source *) [NSNull null]; + else + source_ = [([database_ getSource:file_.File()] ?: (Source *) [NSNull null]) retain]; } } - return source_; + return source_ == (Source *) [NSNull null] ? nil : source_; } - (NSString *) role { @@ -2692,6 +2784,11 @@ struct PackageNameOrdering : return [self hasTag:@"cydia::commercial"]; } +- (void) setIndex:(size_t)index { + if (metadata_->index_ != index) + metadata_->index_ = index; +} + - (CYString &) cyname { return name_.empty() ? id_ : name_; } @@ -2706,57 +2803,42 @@ struct PackageNameOrdering : return _not(uint32_t); } -- (uint32_t) compareForChanges { - union { - uint32_t key; - - struct { - uint32_t timestamp : 30; - uint32_t ignored : 1; - uint32_t upgradable : 1; - } bits; - } value; - - bool upgradable([self upgradableAndEssential:YES]); - value.bits.upgradable = upgradable ? 1 : 0; - - if (upgradable) { - value.bits.timestamp = 0; - value.bits.ignored = [self ignored] ? 0 : 1; - value.bits.upgradable = 1; - } else { - value.bits.timestamp = static_cast([[self seen] timeIntervalSince1970]) >> 2; - value.bits.ignored = 0; - value.bits.upgradable = 0; - } - - return _not(uint32_t) - value.key; -} - - (void) clear { +@synchronized (database_) { pkgProblemResolver *resolver = [database_ resolver]; resolver->Clear(iterator_); - resolver->Protect(iterator_); -} + + pkgCacheFile &cache([database_ cache]); + cache->SetReInstall(iterator_, false); + cache->MarkKeep(iterator_, false); +} } - (void) install { +@synchronized (database_) { pkgProblemResolver *resolver = [database_ resolver]; resolver->Clear(iterator_); resolver->Protect(iterator_); + pkgCacheFile &cache([database_ cache]); + cache->SetReInstall(iterator_, false); cache->MarkInstall(iterator_, false); + pkgDepCache::StateCache &state((*cache)[iterator_]); if (!state.Install()) cache->SetReInstall(iterator_, true); -} +} } - (void) remove { +@synchronized (database_) { pkgProblemResolver *resolver = [database_ resolver]; resolver->Clear(iterator_); - resolver->Protect(iterator_); resolver->Remove(iterator_); - [database_ cache]->MarkDelete(iterator_, true); -} + resolver->Protect(iterator_); + + pkgCacheFile &cache([database_ cache]); + cache->SetReInstall(iterator_, false); + cache->MarkDelete(iterator_, true); +} } - (bool) isUnfilteredAndSearchedForBy:(NSString *)search { _profile(Package$isUnfilteredAndSearchedForBy) @@ -2793,19 +2875,18 @@ struct PackageNameOrdering : _end } -- (bool) isInstalledAndVisible:(NSNumber *)number { - return (![number boolValue] || [self visible]) && ![self uninstalled]; +- (bool) isInstalledAndUnfiltered:(NSNumber *)number { + return ![self uninstalled] && (![number boolValue] && ![role_ isEqualToString:@"cydia"] || [self unfiltered]); } - (bool) isVisibleInSection:(NSString *)name { - NSString *section = [self section]; + NSString *section([self section]); - return - [self visible] && ( - name == nil || - section == nil && [name length] == 0 || - [name isEqualToString:section] - ); + return ( + name == nil || + section == nil && [name length] == 0 || + [name isEqualToString:section] + ) && [self visible]; } - (bool) isVisibleInSource:(Source *)source { @@ -2934,6 +3015,7 @@ struct PackageNameOrdering : /* }}} */ static NSString *Colon_; +static NSString *Elision_; static NSString *Error_; static NSString *Warning_; @@ -2951,11 +3033,17 @@ static NSString *Warning_; return era_; } +- (void) releasePackages { + CFArrayApplyFunction(packages_, CFRangeMake(0, CFArrayGetCount(packages_)), reinterpret_cast(&CFRelease), NULL); + CFArrayRemoveAllValues(packages_); +} + - (void) dealloc { + // XXX: actually implement this thing _assert(false); - NSRecycleZone(zone_); - // XXX: malloc_destroy_zone(zone_); + [self releasePackages]; apr_pool_destroy(pool_); + NSRecycleZone(zone_); [super dealloc]; } @@ -3076,7 +3164,7 @@ static NSString *Warning_; [NSThread detachNewThreadSelector:@selector(_readCydia:) toTarget:self - withObject:[[NSNumber numberWithInt:fds[0]] retain] + withObject:[NSNumber numberWithInt:fds[0]] ]; _assert(pipe(fds) != -1); @@ -3085,7 +3173,7 @@ static NSString *Warning_; [NSThread detachNewThreadSelector:@selector(_readStatus:) toTarget:self - withObject:[[NSNumber numberWithInt:fds[0]] retain] + withObject:[NSNumber numberWithInt:fds[0]] ]; _assert(pipe(fds) != -1); @@ -3101,7 +3189,7 @@ static NSString *Warning_; [NSThread detachNewThreadSelector:@selector(_readOutput:) toTarget:self - withObject:[[NSNumber numberWithInt:fds[0]] retain] + withObject:[NSNumber numberWithInt:fds[0]] ]; } return self; } @@ -3243,9 +3331,7 @@ static NSString *Warning_; @synchronized (self) { ++era_; - CFArrayApplyFunction(packages_, CFRangeMake(0, CFArrayGetCount(packages_)), reinterpret_cast(&CFRelease), NULL); - CFArrayRemoveAllValues(packages_); - + [self releasePackages]; sources_.clear(); _error->Discard(); @@ -3264,11 +3350,6 @@ static NSString *Warning_; delete policy_; policy_ = NULL; - if (now_ != nil) { - [now_ release]; - now_ = nil; - } - cache_.Close(); apr_pool_clear(pool_); @@ -3305,7 +3386,7 @@ static NSString *Warning_; unlink("/tmp/cydia.chk"); - now_ = [[NSDate date] retain]; + now_ = [[NSDate date] timeIntervalSince1970]; policy_ = new pkgDepCache::Policy(); records_ = new pkgRecords(cache_); @@ -3391,9 +3472,28 @@ static NSString *Warning_; //[packages_ sortUsingFunction:reinterpret_cast(&PackageNameCompare) context:NULL]; _trace(); + + size_t count(CFArrayGetCount(packages_)); + for (size_t index(0); index != count; ++index) + [(Package *) CFArrayGetValueAtIndex(packages_, index) setIndex:index]; + + _trace(); } } } CYPoolEnd() _trace(); } +- (void) clear { +@synchronized (self) { + delete resolver_; + resolver_ = new pkgProblemResolver(cache_); + + for (pkgCache::PkgIterator iterator(cache_->PkgBegin()); !iterator.end(); ++iterator) { + if (!cache_[iterator].Keep()) { + cache_->MarkKeep(iterator, false); + cache_->SetReInstall(iterator, false); + } + } +} } + - (void) configure { NSString *dpkg = [NSString stringWithFormat:@"dpkg --configure -a --status-fd %u", statusfd_]; system([dpkg UTF8String]); @@ -3537,11 +3637,6 @@ static NSString *Warning_; [self updateWithStatus:status_]; } -- (void) setVisible { - for (Package *package in [self packages]) - [package setVisible]; -} - - (void) updateWithStatus:(Status &)status { _transient NSObject *delegate(status.getDelegate()); NSString *title(UCLocalize("REFRESHING_DATA")); @@ -3597,7 +3692,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { /* Web Scripting {{{ */ @interface CydiaObject : NSObject { id indirect_; - id delegate_; + _transient id delegate_; } - (id) initWithDelegate:(IndirectDelegate *)indirect; @@ -3703,7 +3798,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { - (NSArray *) getInstalledPackages { NSArray *packages([[Database sharedInstance] packages]); - NSMutableArray *installed([NSMutableArray arrayWithCapacity:[packages count]]); + NSMutableArray *installed([NSMutableArray arrayWithCapacity:1024]); for (Package *package in packages) if ([package installed] != nil) [installed addObject:package]; @@ -4080,32 +4175,30 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { [self loadURL:[NSURL fileURLWithPath:[[NSBundle mainBundle] pathForResource:@"confirm" ofType:@"html"]]]; - UIBarButtonItem *leftItem = [[UIBarButtonItem alloc] + [[self navigationItem] setLeftBarButtonItem:[[[UIBarButtonItem alloc] initWithTitle:UCLocalize("CANCEL") // OLD: [NSString stringWithFormat:UCLocalize("SLASH_DELIMITED"), UCLocalize("CANCEL"), UCLocalize("QUEUE")] style:UIBarButtonItemStylePlain target:self action:@selector(cancelButtonClicked) - ]; - [[self navigationItem] setLeftBarButtonItem:leftItem]; - [leftItem release]; + ] autorelease]]; } return self; } - (void) applyRightButton { - UIBarButtonItem *rightItem = [[UIBarButtonItem alloc] - initWithTitle:UCLocalize("CONFIRM") - style:UIBarButtonItemStylePlain - target:self - action:@selector(confirmButtonClicked) - ]; #if !AlwaysReload && !IgnoreInstall - if (issues_ == nil && ![self isLoading]) [[self navigationItem] setRightBarButtonItem:rightItem]; - else [super applyRightButton]; + if (issues_ == nil && ![self isLoading]) + [[self navigationItem] setRightBarButtonItem:[[[UIBarButtonItem alloc] + initWithTitle:UCLocalize("CONFIRM") + style:UIBarButtonItemStylePlain + target:self + action:@selector(confirmButtonClicked) + ] autorelease]]; + else + [super applyRightButton]; #else [[self navigationItem] setRightBarButtonItem:nil]; #endif - [rightItem release]; } - (void) cancelButtonClicked { @@ -4134,8 +4227,9 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { /* Progress Data {{{ */ @interface ProgressData : NSObject { SEL selector_; - id target_; - id object_; + // XXX: should these really both be _transient? + _transient id target_; + _transient id object_; } - (ProgressData *) initWithSelector:(SEL)selector target:(id)target object:(id)object; @@ -4265,8 +4359,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { bounds.size.height - prgsize.height - 20 }, prgsize}; - float closewidth = bounds.size.width - 20; - if (closewidth > 300) closewidth = 300; + float closewidth = std::min(bounds.size.width - 20, 300.0f); [progress_ setFrame:prgrect]; [status_ setFrame:CGRectMake( @@ -4306,8 +4399,10 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { if ([context isEqualToString:@"conffile"]) { FILE *input = [database_ input]; - if (button == [alert cancelButtonIndex]) fprintf(input, "N\n"); - else if (button == [alert firstOtherButtonIndex]) fprintf(input, "Y\n"); + if (button == [alert cancelButtonIndex]) + fprintf(input, "N\n"); + else if (button == [alert firstOtherButtonIndex]) + fprintf(input, "Y\n"); fflush(input); } } @@ -4397,8 +4492,6 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { - (void) _detachNewThreadData:(ProgressData *)data { _pooled [[data target] performSelector:[data selector] withObject:[data object]]; - [data release]; - [self performSelectorOnMainThread:@selector(_retachThread) withObject:nil waitUntilDone:YES]; } @@ -4452,11 +4545,11 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { [NSThread detachNewThreadSelector:@selector(_detachNewThreadData:) toTarget:self - withObject:[[ProgressData alloc] + withObject:[[[ProgressData alloc] initWithSelector:selector target:target object:object - ] + ] autorelease] ]; } @@ -4586,9 +4679,9 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { @end @implementation ContentView + - (id) initWithFrame:(CGRect)frame { if ((self = [super initWithFrame:frame]) != nil) { - /* Fix landscape stretching. */ [self setNeedsDisplayOnBoundsChange:YES]; } return self; } @@ -4601,10 +4694,47 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { [super drawRect:rect]; [delegate_ drawContentRect:rect]; } + +@end +/* }}} */ +/* Cydia TableView Cell {{{ */ +@interface CYTableViewCell : UITableViewCell { + ContentView *content_; + bool highlighted_; +} + +@end + +@implementation CYTableViewCell + +- (void) dealloc { + [content_ release]; + [super dealloc]; +} + +- (void) _updateHighlightColorsForView:(id)view highlighted:(BOOL)highlighted { + //NSLog(@"_updateHighlightColorsForView:%@ highlighted:%s [content_=%@]", view, highlighted ? "YES" : "NO", content_); + + if (view == content_) { + //NSLog(@"_updateHighlightColorsForView:content_ highlighted:%s", highlighted ? "YES" : "NO", content_); + highlighted_ = highlighted; + } + + [super _updateHighlightColorsForView:view highlighted:highlighted]; +} + +- (void) setSelected:(BOOL)selected animated:(BOOL)animated { + //NSLog(@"setSelected:%s animated:%s", selected ? "YES" : "NO", animated ? "YES" : "NO"); + highlighted_ = selected; + + [super setSelected:selected animated:animated]; + [content_ setNeedsDisplay]; +} + @end /* }}} */ /* Package Cell {{{ */ -@interface PackageCell : UITableViewCell < +@interface PackageCell : CYTableViewCell < ContentDelegate > { UIImage *icon_; @@ -4614,10 +4744,6 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { NSString *source_; UIImage *badge_; Package *package_; - UIColor *color_; - ContentView *content_; - BOOL faded_; - float fade_; UIImage *placard_; } @@ -4668,15 +4794,9 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { - (void) dealloc { [self clearPackage]; - [content_ release]; - [color_ release]; [super dealloc]; } -- (float) fade { - return faded_ ? [self selectionPercent] : fade_; -} - - (PackageCell *) init { CGRect frame(CGRectMake(0, 0, 320, 74)); if ((self = [super initWithFrame:frame reuseIdentifier:@"Package"]) != nil) { @@ -4689,8 +4809,6 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { [content_ setDelegate:self]; [content_ setOpaque:YES]; - if ([self respondsToSelector:@selector(selectionPercent)]) - faded_ = YES; } return self; } @@ -4761,7 +4879,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { } - (void) drawContentRect:(CGRect)rect { - bool selected([self isSelected]); + bool highlighted(highlighted_); float width([self bounds].size.width); #if 0 @@ -4792,15 +4910,15 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { )]; } - if (selected) + if (highlighted) UISetColor(White_); - if (!selected) + if (!highlighted) UISetColor(commercial_ ? Purple_ : Black_); [name_ drawAtPoint:CGPointMake(48, 8) forWidth:(width - (placard_ == nil ? 80 : 106)) withFont:Font18Bold_ lineBreakMode:UILineBreakModeTailTruncation]; [source_ drawAtPoint:CGPointMake(58, 29) forWidth:(width - 95) withFont:Font12_ lineBreakMode:UILineBreakModeTailTruncation]; - if (!selected) + if (!highlighted) UISetColor(commercial_ ? Purplish_ : Gray_); [description_ drawAtPoint:CGPointMake(12, 46) forWidth:(width - 46) withFont:Font14_ lineBreakMode:UILineBreakModeTailTruncation]; @@ -4808,12 +4926,6 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { [placard_ drawAtPoint:CGPointMake(width - 52, 9)]; } -- (void) setSelected:(BOOL)selected animated:(BOOL)fade { - //[self _setBackgroundColor]; - [super setSelected:selected animated:fade]; - [content_ setNeedsDisplay]; -} - + (int) heightForPackage:(Package *)package { return 73; } @@ -4821,7 +4933,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { @end /* }}} */ /* Section Cell {{{ */ -@interface SectionCell : UITableViewCell < +@interface SectionCell : CYTableViewCell < ContentDelegate > { NSString *basic_; @@ -4829,8 +4941,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { NSString *name_; NSString *count_; UIImage *icon_; - ContentView *content_; - id switch_; + UISwitch *switch_; BOOL editing_; } @@ -4866,15 +4977,13 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { [self clearSection]; [icon_ release]; [switch_ release]; - [content_ release]; - [super dealloc]; } - (id) initWithFrame:(CGRect)frame reuseIdentifier:(NSString *)reuseIdentifier { if ((self = [super initWithFrame:frame reuseIdentifier:reuseIdentifier]) != nil) { icon_ = [[UIImage applicationImageNamed:@"folder.png"] retain]; - switch_ = [[objc_getClass("UISwitch") alloc] initWithFrame:CGRectMake(218, 9, 60, 25)]; + switch_ = [[UISwitch alloc] initWithFrame:CGRectMake(218, 9, 60, 25)]; [switch_ addTarget:self action:@selector(onSwitch:) forEvents:UIControlEventValueChanged]; UIView *content([self contentView]); @@ -4890,14 +4999,14 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { } - (void) onSwitch:(id)sender { - NSMutableDictionary *metadata = [Sections_ objectForKey:basic_]; + NSMutableDictionary *metadata([Sections_ objectForKey:basic_]); if (metadata == nil) { metadata = [NSMutableDictionary dictionaryWithCapacity:2]; [Sections_ setObject:metadata forKey:basic_]; } - Changed_ = true; [metadata setObject:[NSNumber numberWithBool:([switch_ isOn] == NO)] forKey:@"Hidden"]; + Changed_ = true; } - (void) setSection:(Section *)section editing:(BOOL)editing { @@ -4944,20 +5053,19 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { } - (void) drawContentRect:(CGRect)rect { - BOOL selected = [self isSelected]; + bool highlighted(highlighted_); [icon_ drawInRect:CGRectMake(8, 7, 32, 32)]; - if (selected) + if (highlighted) UISetColor(White_); - if (!selected) - UISetColor(Black_); - float width(rect.size.width); if (editing_) width -= 87; + if (!highlighted) + UISetColor(Black_); [name_ drawAtPoint:CGPointMake(48, 9) forWidth:(width - 70) withFont:Font22Bold_ lineBreakMode:UILineBreakModeTailTruncation]; CGSize size = [count_ sizeWithFont:Font14_]; @@ -5276,6 +5384,8 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { target:self action:@selector(customButtonClicked) ]; + + [self reloadURL]; } - (bool) isLoading { @@ -5299,9 +5409,11 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { UITableView *list_; NSMutableArray *index_; NSMutableDictionary *indices_; - id target_; + // XXX: this target_ seems to be delegate_. :( + _transient id target_; SEL action_; - id delegate_; + // XXX: why do we even have this delegate_? + _transient id delegate_; } - (id) initWithFrame:(CGRect)frame database:(Database *)database target:(id)target action:(SEL)action; @@ -5630,14 +5742,13 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { @end /* }}} */ /* Source Cell {{{ */ -@interface SourceCell : UITableViewCell < +@interface SourceCell : CYTableViewCell < ContentDelegate > { UIImage *icon_; NSString *origin_; NSString *description_; NSString *label_; - ContentView *content_; } - (void) setSource:(Source *)source; @@ -5676,7 +5787,6 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { - (void) dealloc { [self clearSource]; - [content_ release]; [super dealloc]; } @@ -5695,30 +5805,25 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { } return self; } -- (void) setSelected:(BOOL)selected animated:(BOOL)animated { - [super setSelected:selected animated:animated]; - [content_ setNeedsDisplay]; -} - - (void) drawContentRect:(CGRect)rect { - bool selected([self isSelected]); + bool highlighted(highlighted_); float width(rect.size.width); if (icon_ != nil) [icon_ drawInRect:CGRectMake(10, 10, 30, 30)]; - if (selected) + if (highlighted) UISetColor(White_); - if (!selected) + if (!highlighted) UISetColor(Black_); [origin_ drawAtPoint:CGPointMake(48, 8) forWidth:(width - 80) withFont:Font18Bold_ lineBreakMode:UILineBreakModeTailTruncation]; - if (!selected) + if (!highlighted) UISetColor(Blue_); [label_ drawAtPoint:CGPointMake(58, 29) forWidth:(width - 95) withFont:Font12_ lineBreakMode:UILineBreakModeTailTruncation]; - if (!selected) + if (!highlighted) UISetColor(Gray_); [description_ drawAtPoint:CGPointMake(12, 46) forWidth:(width - 40) withFont:Font14_ lineBreakMode:UILineBreakModeTailTruncation]; } @@ -5756,7 +5861,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { @implementation SourceTable -- (void) _deallocConnection:(NSURLConnection *)connection { +- (void) _releaseConnection:(NSURLConnection *)connection { if (connection != nil) { [connection cancel]; //[connection setDelegate:nil]; @@ -5772,11 +5877,11 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { if (error_ != nil) [error_ release]; - //[self _deallocConnection:installer_]; - [self _deallocConnection:trivial_]; - [self _deallocConnection:trivial_gz_]; - [self _deallocConnection:trivial_bz2_]; - //[self _deallocConnection:automatic_]; + //[self _releaseConnection:installer_]; + [self _releaseConnection:trivial_]; + [self _releaseConnection:trivial_gz_]; + [self _releaseConnection:trivial_bz2_]; + //[self _releaseConnection:automatic_]; [sources_ release]; [list_ release]; @@ -5897,6 +6002,8 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { } - (void) _endConnection:(NSURLConnection *)connection { + // XXX: the memory management in this method is horribly awkward + NSURLConnection **field = NULL; if (connection == trivial_) field = &trivial_; @@ -6036,6 +6143,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { cydia_ = false; + // XXX: this is stupid hud_ = [[delegate_ addProgressHUD] retain]; [hud_ setText:UCLocalize("VERIFYING_URL")]; } break; @@ -6100,11 +6208,12 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { [sources_ sortUsingSelector:@selector(compareByNameAndType:)]; _trace(); - int count([sources_ count]); + int count([sources_ count]); offset_ = 0; for (int i = 0; i != count; i++) { - if ([[sources_ objectAtIndex:i] record] == nil) break; - else offset_++; + if ([[sources_ objectAtIndex:i] record] == nil) + break; + offset_++; } [list_ setEditing:NO]; @@ -6143,34 +6252,27 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { } - (void) updateButtonsForEditingStatus:(BOOL)editing animated:(BOOL)animated { - UIBarButtonItem *leftItem = [[UIBarButtonItem alloc] + [[self navigationItem] setLeftBarButtonItem:(editing ? [[[UIBarButtonItem alloc] initWithTitle:UCLocalize("ADD") style:UIBarButtonItemStylePlain target:self action:@selector(addButtonClicked) - ]; - [[self navigationItem] setLeftBarButtonItem:editing ? leftItem : [[self navigationItem] backBarButtonItem] animated:animated]; - [leftItem release]; + ] autorelease] : [[self navigationItem] backBarButtonItem]) animated:animated]; - UIBarButtonItem *rightItem = [[UIBarButtonItem alloc] - initWithTitle:editing ? UCLocalize("DONE") : UCLocalize("EDIT") - style:editing ? UIBarButtonItemStyleDone : UIBarButtonItemStylePlain + [[self navigationItem] setRightBarButtonItem:[[[UIBarButtonItem alloc] + initWithTitle:(editing ? UCLocalize("DONE") : UCLocalize("EDIT")) + style:(editing ? UIBarButtonItemStyleDone : UIBarButtonItemStylePlain) target:self action:@selector(editButtonClicked) - ]; - [[self navigationItem] setRightBarButtonItem:rightItem animated:animated]; - [rightItem release]; + ] autorelease] animated:animated]; - if (IsWildcat_ && !editing) { - UIBarButtonItem *settingsItem = [[UIBarButtonItem alloc] + if (IsWildcat_ && !editing) + [[self navigationItem] setLeftBarButtonItem:[[[UIBarButtonItem alloc] initWithTitle:UCLocalize("SETTINGS") style:UIBarButtonItemStylePlain target:self action:@selector(settingsButtonClicked) - ]; - [[self navigationItem] setLeftBarButtonItem:settingsItem]; - [settingsItem release]; - } + ] autorelease]]; } - (void) settingsButtonClicked { @@ -6207,7 +6309,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { - (NSString *) title { return UCLocalize("INSTALLED"); } - (id) initWithDatabase:(Database *)database { - if ((self = [super initWithDatabase:database title:UCLocalize("INSTALLED") filter:@selector(isInstalledAndVisible:) with:[NSNumber numberWithBool:YES]]) != nil) { + if ((self = [super initWithDatabase:database title:UCLocalize("INSTALLED") filter:@selector(isInstalledAndUnfiltered:) with:[NSNumber numberWithBool:YES]]) != nil) { [self updateRoleButton]; [self queueStatusDidChange]; } return self; @@ -6222,15 +6324,16 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { - (void) queueStatusDidChange { #if !AlwaysReload if (IsWildcat_) { - UIBarButtonItem *queueItem = [[UIBarButtonItem alloc] - initWithTitle:UCLocalize("QUEUE") - style:UIBarButtonItemStyleDone - target:self - action:@selector(queueButtonClicked) - ]; - if (Queuing_) [[self navigationItem] setLeftBarButtonItem:queueItem]; - else [[self navigationItem] setLeftBarButtonItem:nil]; - [queueItem release]; + if (Queuing_) { + [[self navigationItem] setLeftBarButtonItem:[[[UIBarButtonItem alloc] + initWithTitle:UCLocalize("QUEUE") + style:UIBarButtonItemStyleDone + target:self + action:@selector(queueButtonClicked) + ] autorelease]]; + } else { + [[self navigationItem] setLeftBarButtonItem:nil]; + } } #endif } @@ -6240,14 +6343,13 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { } - (void) updateRoleButton { - UIBarButtonItem *rightItem = [[UIBarButtonItem alloc] - initWithTitle:expert_ ? UCLocalize("EXPERT") : UCLocalize("SIMPLE") - style:expert_ ? UIBarButtonItemStyleDone : UIBarButtonItemStylePlain - target:self - action:@selector(roleButtonClicked) - ]; - if (Role_ != nil && ![Role_ isEqualToString:@"Developer"]) [[self navigationItem] setRightBarButtonItem:rightItem]; - [rightItem release]; + if (Role_ != nil && ![Role_ isEqualToString:@"Developer"]) + [[self navigationItem] setRightBarButtonItem:[[[UIBarButtonItem alloc] + initWithTitle:(expert_ ? UCLocalize("EXPERT") : UCLocalize("SIMPLE")) + style:(expert_ ? UIBarButtonItemStyleDone : UIBarButtonItemStylePlain) + target:self + action:@selector(roleButtonClicked) + ] autorelease]]; } - (void) roleButtonClicked { @@ -6338,14 +6440,12 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { if ((self = [super init]) != nil) { [[self navigationItem] setTitle:UCLocalize("MANAGE")]; - UIBarButtonItem *settingsItem = [[UIBarButtonItem alloc] + [[self navigationItem] setLeftBarButtonItem:[[[UIBarButtonItem alloc] initWithTitle:UCLocalize("SETTINGS") style:UIBarButtonItemStylePlain target:self action:@selector(settingsButtonClicked) - ]; - [[self navigationItem] setLeftBarButtonItem:settingsItem]; - [settingsItem release]; + ] autorelease]]; [self queueStatusDidChange]; } return self; @@ -6372,15 +6472,12 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { - (void) queueStatusDidChange { #if !AlwaysReload if (!IsWildcat_ && Queuing_) { - UIBarButtonItem *queueItem = [[UIBarButtonItem alloc] + [[self navigationItem] setRightBarButtonItem:[[[UIBarButtonItem alloc] initWithTitle:UCLocalize("QUEUE") style:UIBarButtonItemStyleDone target:self action:@selector(queueButtonClicked) - ]; - [[self navigationItem] setRightBarButtonItem:queueItem]; - - [queueItem release]; + ] autorelease]]; } else { [[self navigationItem] setRightBarButtonItem:nil]; } @@ -6406,6 +6503,14 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { @implementation RefreshBar +- (void) dealloc { + [indicator_ release]; + [prompt_ release]; + [progress_ release]; + [cancel_ release]; + [super dealloc]; +} + - (void) positionViews { CGRect frame = [cancel_ frame]; frame.origin.x = [self frame].size.width - frame.size.width - 5; @@ -6506,7 +6611,7 @@ bool DepSubstrate(const pkgCache::VerIterator &iterator) { /* Cydia Tab Bar Controller {{{ */ @interface CYTabBarController : UITabBarController { - Database *database_; + _transient Database *database_; } @end @@ -6536,7 +6641,7 @@ freeing the view controllers on tab change */ /* Cydia Navigation Controller {{{ */ @interface CYNavigationController : UINavigationController { _transient Database *database_; - id delegate_; + _transient id delegate_; } - (id) initWithDatabase:(Database *)database; @@ -6737,7 +6842,9 @@ freeing the view controllers on tab change */ static NSString *reuseIdentifier = @"SectionCell"; SectionCell *cell = (SectionCell *) [tableView dequeueReusableCellWithIdentifier:reuseIdentifier]; - if (cell == nil) cell = [[[SectionCell alloc] initWithFrame:CGRectZero reuseIdentifier:reuseIdentifier] autorelease]; + if (cell == nil) + cell = [[[SectionCell alloc] initWithFrame:CGRectZero reuseIdentifier:reuseIdentifier] autorelease]; + [cell setSection:[self sectionAtIndexPath:indexPath] editing:editing_]; return cell; @@ -6806,40 +6913,13 @@ freeing the view controllers on tab change */ [sections_ removeAllObjects]; [filtered_ removeAllObjects]; -#if 0 - typedef __gnu_cxx::hash_map SectionMap; - SectionMap sections; - sections.resize(64); -#else NSMutableDictionary *sections([NSMutableDictionary dictionaryWithCapacity:32]); -#endif _trace(); for (Package *package in packages) { NSString *name([package section]); NSString *key(name == nil ? @"" : name); -#if 0 - Section **section; - - _profile(SectionsView$reloadData$Section) - section = §ions[key]; - if (*section == nil) { - _profile(SectionsView$reloadData$Section$Allocate) - *section = [[[Section alloc] initWithName:name localize:YES] autorelease]; - _end - } - _end - - [*section addToCount]; - - _profile(SectionsView$reloadData$Filter) - if (![package valid] || ![package visible]) - continue; - _end - - [*section addToRow]; -#else Section *section; _profile(SectionsView$reloadData$Section) @@ -6860,16 +6940,10 @@ freeing the view controllers on tab change */ _end [section addToRow]; -#endif } _trace(); -#if 0 - for (SectionMap::const_iterator i(sections.begin()), e(sections.end()); i != e; ++i) - [sections_ addObject:i->second]; -#else [sections_ addObjectsFromArray:[sections allValues]]; -#endif [sections_ sortUsingSelector:@selector(compareByLocalized:)]; @@ -6883,14 +6957,12 @@ freeing the view controllers on tab change */ [filtered_ addObject:section]; } - UIBarButtonItem *rightItem = [[UIBarButtonItem alloc] - initWithTitle:[sections_ count] == 0 ? nil : UCLocalize("EDIT") + [[self navigationItem] setRightBarButtonItem:[[[UIBarButtonItem alloc] + initWithTitle:([sections_ count] == 0 ? nil : UCLocalize("EDIT")) style:UIBarButtonItemStylePlain target:self action:@selector(editButtonClicked) - ]; - [[self navigationItem] setRightBarButtonItem:rightItem animated:[[self navigationItem] rightBarButtonItem] != nil]; - [rightItem release]; + ] autorelease] animated:([[self navigationItem] rightBarButtonItem] != nil)]; [list_ reloadData]; _trace(); @@ -7042,10 +7114,7 @@ freeing the view controllers on tab change */ - (void) _reloadPackages:(NSArray *)packages { _trace(); for (Package *package in packages) - if ( - [package uninstalled] && [package valid] && [package visible] || - [package upgradableAndEssential:YES] - ) + if ([package upgradableAndEssential:YES] || [package visible]) CFArrayAppendValue(packages_, package); _trace(); @@ -7060,10 +7129,9 @@ freeing the view controllers on tab change */ [sections_ removeAllObjects]; -#if 0 +#if 1 UIProgressHUD *hud([delegate_ addProgressHUD]); - // XXX: localize - [hud setText:@"Loading Changes"]; + [hud setText:UCLocalize("LOADING")]; //NSLog(@"HUD:%@::%@", delegate_, hud); [self yieldToSelector:@selector(_reloadPackages:) withObject:packages]; [delegate_ removeProgressHUD:hud]; @@ -7072,9 +7140,9 @@ freeing the view controllers on tab change */ #endif Section *upgradable = [[[Section alloc] initWithName:UCLocalize("AVAILABLE_UPGRADES") localize:NO] autorelease]; - Section *ignored = [[[Section alloc] initWithName:UCLocalize("IGNORED_UPGRADES") localize:NO] autorelease]; + Section *ignored = nil; Section *section = nil; - NSDate *last = nil; + time_t last = 0; upgrades_ = 0; bool unseens = false; @@ -7088,22 +7156,14 @@ freeing the view controllers on tab change */ if (!uae) { unseens = true; - NSDate *seen; - - _profile(ChangesController$reloadData$Remember) - seen = [package seen]; - _end + time_t seen([package seen]); - if (section == nil || last != seen && (seen == nil || [seen compare:last] != NSOrderedSame)) { + if (section == nil || last != seen) { last = seen; NSString *name; - if (seen == nil) - name = UCLocalize("UNKNOWN"); - else { - name = (NSString *) CFDateFormatterCreateStringWithDate(NULL, formatter, (CFDateRef) seen); - [name autorelease]; - } + name = (NSString *) CFDateFormatterCreateStringWithDate(NULL, formatter, (CFDateRef) [NSDate dateWithTimeIntervalSince1970:seen]); + [name autorelease]; _profile(ChangesController$reloadData$Allocate) name = [NSString stringWithFormat:UCLocalize("NEW_AT"), name]; @@ -7113,9 +7173,12 @@ freeing the view controllers on tab change */ } [section addToCount]; - } else if ([package ignored]) + } else if ([package ignored]) { + if (ignored == nil) { + ignored = [[[Section alloc] initWithName:UCLocalize("IGNORED_UPGRADES") row:offset localize:NO] autorelease]; + } [ignored addToCount]; - else { + } else { ++upgrades_; [upgradable addToCount]; } @@ -7138,23 +7201,21 @@ freeing the view controllers on tab change */ [list_ reloadData]; - UIBarButtonItem *rightItem = [[UIBarButtonItem alloc] - initWithTitle:[NSString stringWithFormat:UCLocalize("PARENTHETICAL"), UCLocalize("UPGRADE"), [NSString stringWithFormat:@"%u", upgrades_]] - style:UIBarButtonItemStylePlain - target:self - action:@selector(upgradeButtonClicked) - ]; - if (upgrades_ > 0) [[self navigationItem] setRightBarButtonItem:rightItem]; - [rightItem release]; + if (upgrades_ > 0) + [[self navigationItem] setRightBarButtonItem:[[[UIBarButtonItem alloc] + initWithTitle:[NSString stringWithFormat:UCLocalize("PARENTHETICAL"), UCLocalize("UPGRADE"), [NSString stringWithFormat:@"%u", upgrades_]] + style:UIBarButtonItemStylePlain + target:self + action:@selector(upgradeButtonClicked) + ] autorelease]]; - UIBarButtonItem *leftItem = [[UIBarButtonItem alloc] - initWithTitle:UCLocalize("REFRESH") - style:UIBarButtonItemStylePlain - target:self - action:@selector(refreshButtonClicked) - ]; - if (![delegate_ updating]) [[self navigationItem] setLeftBarButtonItem:leftItem]; - [leftItem release]; + if (![delegate_ updating]) + [[self navigationItem] setLeftBarButtonItem:[[[UIBarButtonItem alloc] + initWithTitle:UCLocalize("REFRESH") + style:UIBarButtonItemStylePlain + target:self + action:@selector(refreshButtonClicked) + ] autorelease]]; } @end @@ -7236,8 +7297,8 @@ freeing the view controllers on tab change */ NSString *name_; Package *package_; UITableView *table_; - id subscribedSwitch_; - id ignoredSwitch_; + UISwitch *subscribedSwitch_; + UISwitch *ignoredSwitch_; UITableViewCell *subscribedCell_; UITableViewCell *ignoredCell_; } @@ -7272,38 +7333,23 @@ freeing the view controllers on tab change */ if (package_ == nil) return 0; - return 1; + return 2; } - (NSString *) tableView:(UITableView *)tableView titleForFooterInSection:(NSInteger)section { return UCLocalize("SHOW_ALL_CHANGES_EX"); } -- (void) onSomething:(BOOL)value withKey:(NSString *)key { +- (void) onSubscribed:(id)control { + bool value([control isOn]); if (package_ == nil) return; - - NSMutableDictionary *metadata([package_ metadata]); - - BOOL before; - if (NSNumber *number = [metadata objectForKey:key]) - before = [number boolValue]; - else - before = NO; - - if (value != before) { - [metadata setObject:[NSNumber numberWithBool:value] forKey:key]; - Changed_ = true; + if ([package_ setSubscribed:value]) [delegate_ updateData]; - } -} - -- (void) onSubscribed:(id)control { - [self onSomething:(int) [control isOn] withKey:@"IsSubscribed"]; } - (void) onIgnored:(id)control { - [self onSomething:(int) [control isOn] withKey:@"IsIgnored"]; + // TODO: set Held state - possibly call out to dpkg, etc. } - (UITableViewCell *) tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath { @@ -7333,11 +7379,11 @@ freeing the view controllers on tab change */ [table_ setAutoresizingMask:UIViewAutoresizingFlexibleBoth]; [[self view] addSubview:table_]; - subscribedSwitch_ = [[objc_getClass("UISwitch") alloc] initWithFrame:CGRectMake(0, 0, 50, 20)]; + subscribedSwitch_ = [[UISwitch alloc] initWithFrame:CGRectMake(0, 0, 50, 20)]; [subscribedSwitch_ setAutoresizingMask:UIViewAutoresizingFlexibleLeftMargin]; [subscribedSwitch_ addTarget:self action:@selector(onSubscribed:) forEvents:UIControlEventValueChanged]; - ignoredSwitch_ = [[objc_getClass("UISwitch") alloc] initWithFrame:CGRectMake(0, 0, 50, 20)]; + ignoredSwitch_ = [[UISwitch alloc] initWithFrame:CGRectMake(0, 0, 50, 20)]; [ignoredSwitch_ setAutoresizingMask:UIViewAutoresizingFlexibleLeftMargin]; [ignoredSwitch_ addTarget:self action:@selector(onIgnored:) forEvents:UIControlEventValueChanged]; @@ -7415,7 +7461,8 @@ freeing the view controllers on tab change */ UITableViewDelegate > { _transient Database *database_; - id roledelegate_; + // XXX: ok, "roledelegate_"?... + _transient id roledelegate_; UITableView *table_; UISegmentedControl *segment_; UIView *container_; @@ -7511,7 +7558,6 @@ freeing the view controllers on tab change */ nil]; [Metadata_ setObject:Settings_ forKey:@"Settings"]; - Changed_ = true; if (rolling) @@ -7525,20 +7571,29 @@ freeing the view controllers on tab change */ [self showDoneButton]; } -- (void) doneButtonClicked { +- (void) saveAndClose { [self save]; + + [[self navigationItem] setRightBarButtonItem:nil]; [[self navigationController] dismissModalViewControllerAnimated:YES]; } +- (void) doneButtonClicked { + UIActivityIndicatorView *spinner = [[[UIActivityIndicatorView alloc] initWithFrame:CGRectMake(0, 0, 20.0f, 20.0f)] autorelease]; + [spinner startAnimating]; + UIBarButtonItem *spinItem = [[[UIBarButtonItem alloc] initWithCustomView:spinner] autorelease]; + [[self navigationItem] setRightBarButtonItem:spinItem]; + + [self performSelector:@selector(saveAndClose) withObject:nil afterDelay:0]; +} + - (void) showDoneButton { - UIBarButtonItem *rightItem = [[UIBarButtonItem alloc] + [[self navigationItem] setRightBarButtonItem:[[[UIBarButtonItem alloc] initWithTitle:UCLocalize("DONE") style:UIBarButtonItemStyleDone target:self action:@selector(doneButtonClicked) - ]; - [[self navigationItem] setRightBarButtonItem:rightItem animated:[[self navigationItem] rightBarButtonItem] == nil]; - [rightItem release]; + ] autorelease] animated:([[self navigationItem] rightBarButtonItem] == nil)]; } - (NSInteger) numberOfSectionsInTableView:(UITableView *)tableView { @@ -7568,22 +7623,21 @@ freeing the view controllers on tab change */ } - (CGFloat) tableView:(UITableView *)tableView heightForHeaderInSection:(NSInteger)section { - if (section == 3) return 44.0f; - else return 0; + return section == 3 ? 44.0f : 0; } - (UIView *) tableView:(UITableView *)tableView viewForHeaderInSection:(NSInteger)section { - if (section == 3) return container_; - else return nil; + return section == 3 ? container_ : nil; } @end /* }}} */ /* Stash Controller {{{ */ @interface CYStashController : CYViewController { - UIActivityIndicatorView *spinner_; - UILabel *status_; - UILabel *caption_; + // XXX: just delete these things + _transient UIActivityIndicatorView *spinner_; + _transient UILabel *status_; + _transient UILabel *caption_; } @end @@ -7592,14 +7646,13 @@ freeing the view controllers on tab change */ if ((self = [super init])) { [[self view] setBackgroundColor:[UIColor viewFlipsideBackgroundColor]]; - spinner_ = [[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleWhiteLarge]; + spinner_ = [[[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleWhiteLarge] autorelease]; CGRect spinrect = [spinner_ frame]; spinrect.origin.x = ([[self view] frame].size.width / 2) - (spinrect.size.width / 2); spinrect.origin.y = [[self view] frame].size.height - 80.0f; [spinner_ setFrame:spinrect]; [spinner_ setAutoresizingMask:UIViewAutoresizingFlexibleLeftMargin | UIViewAutoresizingFlexibleRightMargin | UIViewAutoresizingFlexibleTopMargin]; [[self view] addSubview:spinner_]; - [spinner_ release]; [spinner_ startAnimating]; CGRect captrect; @@ -7607,7 +7660,7 @@ freeing the view controllers on tab change */ captrect.size.height = 40.0f; captrect.origin.x = 0; captrect.origin.y = ([[self view] frame].size.height / 2) - (captrect.size.height * 2); - caption_ = [[UILabel alloc] initWithFrame:captrect]; + caption_ = [[[UILabel alloc] initWithFrame:captrect] autorelease]; [caption_ setText:@"Initializing Filesystem"]; [caption_ setAutoresizingMask:UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleTopMargin | UIViewAutoresizingFlexibleBottomMargin]; [caption_ setFont:[UIFont boldSystemFontOfSize:28.0f]]; @@ -7616,14 +7669,13 @@ freeing the view controllers on tab change */ [caption_ setShadowColor:[UIColor blackColor]]; [caption_ setTextAlignment:UITextAlignmentCenter]; [[self view] addSubview:caption_]; - [caption_ release]; CGRect statusrect; statusrect.size.width = [[self view] frame].size.width; statusrect.size.height = 30.0f; statusrect.origin.x = 0; statusrect.origin.y = ([[self view] frame].size.height / 2) - statusrect.size.height; - status_ = [[UILabel alloc] initWithFrame:statusrect]; + status_ = [[[UILabel alloc] initWithFrame:statusrect] autorelease]; [status_ setAutoresizingMask:UIViewAutoresizingFlexibleLeftMargin | UIViewAutoresizingFlexibleRightMargin | UIViewAutoresizingFlexibleTopMargin | UIViewAutoresizingFlexibleBottomMargin]; [status_ setText:@"(Cydia will exit when complete.)"]; [status_ setFont:[UIFont systemFontOfSize:16.0f]]; @@ -7632,7 +7684,6 @@ freeing the view controllers on tab change */ [status_ setShadowColor:[UIColor blackColor]]; [status_ setTextAlignment:UITextAlignmentCenter]; [[self view] addSubview:status_]; - [status_ release]; } return self; } @@ -7649,8 +7700,10 @@ freeing the view controllers on tab change */ bool dropped_; bool updating_; - id updatedelegate_; - UITabBarController *root_; + // XXX: ok, "updatedelegate_"?... + _transient NSObject *updatedelegate_; + // XXX: can't we query for this variable when we need it? + _transient UITabBarController *root_; } - (void) setTabBarController:(UITabBarController *)controller; @@ -7692,7 +7745,7 @@ freeing the view controllers on tab change */ } - (BOOL) shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)orientation { - return IsWildcat_ || orientation == UIInterfaceOrientationPortrait; + return ![updatedelegate_ hudIsShowing] && (IsWildcat_ || orientation == UIInterfaceOrientationPortrait); } - (void) setTabBarController:(UITabBarController *)controller { @@ -7730,7 +7783,8 @@ freeing the view controllers on tab change */ } - (void) completeUpdate { - if (!updating_) return; + if (!updating_) + return; updating_ = false; [self raiseBar:YES]; @@ -7812,7 +7866,8 @@ freeing the view controllers on tab change */ } - (void) dropBar:(BOOL)animated { - if (dropped_) return; + if (dropped_) + return; dropped_ = true; [[self view] addSubview:refreshbar_]; @@ -7823,12 +7878,14 @@ freeing the view controllers on tab change */ barframe.origin.y = sboffset; [refreshbar_ setFrame:barframe]; - if (animated) [UIView beginAnimations:nil context:NULL]; + if (animated) + [UIView beginAnimations:nil context:NULL]; CGRect viewframe = [[root_ view] frame]; viewframe.origin.y += barframe.size.height + sboffset; viewframe.size.height -= barframe.size.height + sboffset; [[root_ view] setFrame:viewframe]; - if (animated) [UIView commitAnimations]; + if (animated) + [UIView commitAnimations]; // Ensure bar has the proper width for our view, it might have changed barframe.size.width = viewframe.size.width; @@ -7839,20 +7896,23 @@ freeing the view controllers on tab change */ } - (void) raiseBar:(BOOL)animated { - if (!dropped_) return; + if (!dropped_) + return; dropped_ = false; [refreshbar_ removeFromSuperview]; CGFloat sboffset = [self statusBarHeight]; - if (animated) [UIView beginAnimations:nil context:NULL]; + if (animated) + [UIView beginAnimations:nil context:NULL]; CGRect barframe = [refreshbar_ frame]; CGRect viewframe = [[root_ view] frame]; viewframe.origin.y -= barframe.size.height + sboffset; viewframe.size.height += barframe.size.height + sboffset; [[root_ view] setFrame:viewframe]; - if (animated) [UIView commitAnimations]; + if (animated) + [UIView commitAnimations]; // XXX: fix Apple's layout bug [[root_ selectedViewController] _updateLayoutForStatusBarAndInterfaceOrientation]; @@ -7914,11 +7974,14 @@ typedef enum { ConfirmationControllerDelegate, ProgressControllerDelegate, CydiaDelegate, - UINavigationControllerDelegate + UINavigationControllerDelegate, + UITabBarControllerDelegate > { + // XXX: evaluate all fields for _transient + UIWindow *window_; CYContainer *container_; - id tabbar_; + CYTabBarController *tabbar_; NSMutableArray *essential_; NSMutableArray *broken_; @@ -7926,9 +7989,8 @@ typedef enum { Database *database_; int tag_; - - UIKeyboard *keyboard_; - UIProgressHUD *hud_; + int hudcount_; + NSURL *starturl_; SectionsController *sections_; ChangesController *changes_; @@ -7998,21 +8060,24 @@ static _finline void _setHomePage(Cydia *self) { } - (void) _saveConfig { + _trace(); + MetaFile_.Sync(); + _trace(); + if (Changed_) { - _trace(); NSString *error(nil); + if (NSData *data = [NSPropertyListSerialization dataFromPropertyList:Metadata_ format:NSPropertyListBinaryFormat_v1_0 errorDescription:&error]) { _trace(); NSError *error(nil); if (![data writeToFile:@"/var/lib/cydia/metadata.plist" options:NSAtomicWrite error:&error]) NSLog(@"failure to save metadata data: %@", error); _trace(); + + Changed_ = false; } else { NSLog(@"failure to serialize metadata: %@", error); - return; } - - Changed_ = false; } } @@ -8033,7 +8098,8 @@ static _finline void _setHomePage(Cydia *self) { - (int)indexOfTabWithTag:(int)tag { int i = 0; for (UINavigationController *controller in [tabbar_ viewControllers]) { - if ([[controller tabBarItem] tag] == tag) return i; + if ([[controller tabBarItem] tag] == tag) + return i; i += 1; } @@ -8102,7 +8168,8 @@ static _finline void _setHomePage(Cydia *self) { [database_ yieldToSelector:@selector(reloadData) withObject:nil]; - if (hud) [self removeProgressHUD:hud]; + if (hud != nil) + [self removeProgressHUD:hud]; size_t changes(0); @@ -8146,7 +8213,6 @@ static _finline void _setHomePage(Cydia *self) { } - (void) updateData { - [database_ setVisible]; [self _updateData]; } @@ -8174,7 +8240,8 @@ static _finline void _setHomePage(Cydia *self) { ProgressController *progress = [[[ProgressController alloc] initWithDatabase:database_ delegate:self] autorelease]; CYNavigationController *navigation = [[[CYNavigationController alloc] initWithRootViewController:progress] autorelease]; - if (IsWildcat_) [navigation setModalPresentationStyle:UIModalPresentationFormSheet]; + if (IsWildcat_) + [navigation setModalPresentationStyle:UIModalPresentationFormSheet]; [container_ presentModalViewController:navigation animated:YES]; [progress @@ -8209,10 +8276,11 @@ static _finline void _setHomePage(Cydia *self) { ConfirmationController *page([[[ConfirmationController alloc] initWithDatabase:database_] autorelease]); [page setDelegate:self]; - CYNavigationController *confirm_ = [[CYNavigationController alloc] initWithRootViewController:page]; + CYNavigationController *confirm_([[[CYNavigationController alloc] initWithRootViewController:page] autorelease]); [confirm_ setDelegate:self]; - if (IsWildcat_) [confirm_ setModalPresentationStyle:UIModalPresentationFormSheet]; + if (IsWildcat_) + [confirm_ setModalPresentationStyle:UIModalPresentationFormSheet]; [container_ presentModalViewController:confirm_ animated:YES]; return true; @@ -8278,7 +8346,8 @@ static _finline void _setHomePage(Cydia *self) { [navigation pushViewController:progress animated:YES]; } else { navigation = [[[CYNavigationController alloc] initWithRootViewController:progress] autorelease]; - if (IsWildcat_) [navigation setModalPresentationStyle:UIModalPresentationFormSheet]; + if (IsWildcat_) + [navigation setModalPresentationStyle:UIModalPresentationFormSheet]; [container_ presentModalViewController:navigation animated:YES]; } @@ -8299,9 +8368,9 @@ static _finline void _setHomePage(Cydia *self) { CYNavigationController *navController = (CYNavigationController *) [tabbar_ selectedViewController]; [navController setViewControllers:[NSArray arrayWithObject:page]]; - for (CYNavigationController *page in [tabbar_ viewControllers]) { - if (page != navController) [page setViewControllers:nil]; - } + for (CYNavigationController *page in [tabbar_ viewControllers]) + if (page != navController) + [page setViewControllers:nil]; } - (CYViewController *) _pageForURL:(NSURL *)url withClass:(Class)_class { @@ -8328,7 +8397,8 @@ static _finline void _setHomePage(Cydia *self) { _pageForURL:[NSURL fileURLWithPath:[[NSBundle mainBundle] pathForResource:@"manage" ofType:@"html"]] withClass:[ManageController class] ] retain]; - if (!IsWildcat_) queueDelegate_ = manage_; + if (!IsWildcat_) + queueDelegate_ = manage_; } return manage_; } @@ -8348,12 +8418,13 @@ static _finline void _setHomePage(Cydia *self) { - (InstalledController *) installedController { if (installed_ == nil) { installed_ = [[InstalledController alloc] initWithDatabase:database_]; - if (IsWildcat_) queueDelegate_ = installed_; + if (IsWildcat_) + queueDelegate_ = installed_; } return installed_; } -- (void) tabBarController:(id)tabBarController didSelectViewController:(UIViewController *)viewController { +- (void) tabBarController:(UITabBarController *)tabBarController didSelectViewController:(UIViewController *)viewController { int tag = [[viewController tabBarItem] tag]; if (tag == tag_) { [(CYNavigationController *)[tabbar_ selectedViewController] popToRootViewControllerAnimated:YES]; @@ -8379,9 +8450,10 @@ static _finline void _setHomePage(Cydia *self) { } - (void) showSettings { - RoleController *role = [[RoleController alloc] initWithDatabase:database_ delegate:self]; - CYNavigationController *nav = [[CYNavigationController alloc] initWithRootViewController:role]; - if (IsWildcat_) [nav setModalPresentationStyle:UIModalPresentationFormSheet]; + RoleController *role = [[[RoleController alloc] initWithDatabase:database_ delegate:self] autorelease]; + CYNavigationController *nav = [[[CYNavigationController alloc] initWithRootViewController:role] autorelease]; + if (IsWildcat_) + [nav setModalPresentationStyle:UIModalPresentationFormSheet]; [container_ presentModalViewController:nav animated:YES]; } @@ -8402,7 +8474,8 @@ static _finline void _setHomePage(Cydia *self) { // Returns the navigation controller for the queuing badge. - (id) queueBadgeController { int index = [self indexOfTabWithTag:kManageTag]; - if (index == -1) index = [self indexOfTabWithTag:kInstalledTag]; + if (index == -1) + index = [self indexOfTabWithTag:kInstalledTag]; return [[tabbar_ viewControllers] objectAtIndex:index]; } @@ -8410,16 +8483,7 @@ static _finline void _setHomePage(Cydia *self) { - (void) cancelAndClear:(bool)clear { @synchronized (self) { if (clear) { - // Clear all marks. - pkgCacheFile &cache([database_ cache]); - for (pkgCache::PkgIterator iterator = cache->PkgBegin(); !iterator.end(); ++iterator) { - // Unmark method taken from Synaptic Package Manager. - // Thanks for being sane, unlike Aptitude. - if (!cache[iterator].Keep()) { - cache->MarkKeep(iterator, false); - cache->SetReInstall(iterator, false); - } - } + [database_ clear]; // Stop queuing. Queuing_ = false; @@ -8430,8 +8494,7 @@ static _finline void _setHomePage(Cydia *self) { [[[self queueBadgeController] tabBarItem] setBadgeValue:UCLocalize("Q_D")]; } - // Show the changes in the current view. - [(CYNavigationController *) [tabbar_ selectedViewController] reloadData]; + [self _updateData]; [queueDelegate_ queueStatusDidChange]; } } @@ -8489,6 +8552,10 @@ static _finline void _setHomePage(Cydia *self) { [super applicationWillSuspend]; } +- (BOOL) hudIsShowing { + return (hudcount_ > 0); +} + - (void) applicationSuspend:(__GSEvent *)event { // Use external process status API internally. // This is probably a really bad idea. @@ -8499,17 +8566,17 @@ static _finline void _setHomePage(Cydia *self) { notify_cancel(notify_token); } - if (hud_ == nil && status == 0) + if (![self hudIsShowing] && status == 0) [super applicationSuspend:event]; } - (void) _animateSuspension:(BOOL)arg0 duration:(double)arg1 startTime:(double)arg2 scale:(float)arg3 { - if (hud_ == nil) + if (![self hudIsShowing]) [super _animateSuspension:arg0 duration:arg1 startTime:arg2 scale:arg3]; } - (void) _setSuspended:(BOOL)value { - if (hud_ == nil) + if (![self hudIsShowing]) [super _setSuspended:value]; } @@ -8524,6 +8591,7 @@ static _finline void _setHomePage(Cydia *self) { while ([target modalViewController] != nil) target = [target modalViewController]; [[target view] addSubview:hud]; + hudcount_++; return hud; } @@ -8531,6 +8599,7 @@ static _finline void _setHomePage(Cydia *self) { [hud show:NO]; [hud removeFromSuperview]; [window_ setUserInteractionEnabled:YES]; + hudcount_--; } - (CYViewController *) pageForPackage:(NSString *)name { @@ -8594,19 +8663,32 @@ static _finline void _setHomePage(Cydia *self) { return nil; } -- (void) applicationOpenURL:(NSURL *)url { - [super applicationOpenURL:url]; - int tag; - if (CYViewController *page = [self pageForURL:url hasTag:&tag]) { +- (BOOL) openCydiaURL:(NSURL *)url { + CYViewController *page = nil; + int tag = 0; + + NSLog(@"open url: %@", url); + + if ((page = [self pageForURL:url hasTag:&tag])) { [self setPage:page]; tag_ = tag; [tabbar_ setSelectedViewController:(tag_ == -1 ? nil : [[tabbar_ viewControllers] objectAtIndex:tag_])]; } + + return !!page; +} + +- (void) applicationOpenURL:(NSURL *)url { + [super applicationOpenURL:url]; + NSLog(@"first: %@", url); + if (!loaded_) starturl_ = [url retain]; + else [self openCydiaURL:url]; } - (void) applicationWillResignActive:(UIApplication *)application { // Stop refreshing if you get a phone call or lock the device. - if ([container_ updating]) [container_ cancelUpdate]; + if ([container_ updating]) + [container_ cancelUpdate]; if ([[self superclass] instancesRespondToSelector:@selector(applicationWillResignActive:)]) [super applicationWillResignActive:application]; @@ -8672,6 +8754,7 @@ static _finline void _setHomePage(Cydia *self) { } - (void) applicationDidFinishLaunching:(id)unused { +_trace(); [CYBrowserController _initialize]; [NSURLProtocol registerClass:[CydiaURLProtocol class]]; @@ -8707,6 +8790,9 @@ static _finline void _setHomePage(Cydia *self) { false ) { [self addStashController]; + // XXX: this would be much cleaner as a yieldToSelector: + // that way the removeStashController could happen right here inline + // we also could no longer require the useless stash_ field anymore [self performSelector:@selector(stash) withObject:nil afterDelay:0]; return; } @@ -8736,23 +8822,21 @@ _trace(); [window_ setUserInteractionEnabled:NO]; - UIView *container = [[UIView alloc] init]; + UIView *container = [[[UIView alloc] init] autorelease]; [container setAutoresizingMask:UIViewAutoresizingFlexibleTopMargin | UIViewAutoresizingFlexibleLeftMargin | UIViewAutoresizingFlexibleRightMargin | UIViewAutoresizingFlexibleBottomMargin]; - UIActivityIndicatorView *spinner = [[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray]; + UIActivityIndicatorView *spinner = [[[UIActivityIndicatorView alloc] initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray] autorelease]; [spinner startAnimating]; [container addSubview:spinner]; - [spinner release]; - UILabel *label = [[UILabel alloc] init]; + UILabel *label = [[[UILabel alloc] init] autorelease]; [label setFont:[UIFont boldSystemFontOfSize:15.0f]]; [label setBackgroundColor:[UIColor clearColor]]; [label setTextColor:[UIColor blackColor]]; [label setShadowColor:[UIColor whiteColor]]; [label setShadowOffset:CGSizeMake(0, 1)]; - [label setText:UCLocalize("LOADING_DATA")]; + [label setText:[NSString stringWithFormat:Elision_, UCLocalize("LOADING"), nil]]; [container addSubview:label]; - [label release]; CGSize viewsize = [[tabbar_ view] frame].size; CGSize spinnersize = [spinner bounds].size; @@ -8776,14 +8860,19 @@ _trace(); [spinner setFrame:spinrect]; [label setFrame:textrect]; [[container_ view] addSubview:container]; - [container release]; [self reloadData]; PrintTimes(); - // Show the home page - [tabbar_ setSelectedIndex:0]; - _setHomePage(self); + // Show the initial page + if (starturl_ == nil || ![self openCydiaURL:starturl_]) { + [tabbar_ setSelectedIndex:0]; + _setHomePage(self); + } + + [starturl_ release]; + starturl_ = nil; + [window_ setUserInteractionEnabled:YES]; // XXX: does this actually slow anything down? @@ -9028,11 +9117,6 @@ int main(int argc, char *argv[]) { _pooled if (Settings_ != nil) Role_ = [Settings_ objectForKey:@"Role"]; - if (Packages_ == nil) { - Packages_ = [[[NSMutableDictionary alloc] initWithCapacity:128] autorelease]; - [Metadata_ setObject:Packages_ forKey:@"Packages"]; - } - if (Sections_ == nil) { Sections_ = [[[NSMutableDictionary alloc] initWithCapacity:32] autorelease]; [Metadata_ setObject:Sections_ forKey:@"Sections"]; @@ -9044,6 +9128,18 @@ int main(int argc, char *argv[]) { _pooled } /* }}} */ + _trace(); + MetaFile_.Open("/var/lib/cydia/metadata.cb0"); + _trace(); + + if (Packages_ != nil) { + CFDictionaryApplyFunction((CFDictionaryRef) Packages_, &PackageImport, NULL); + _trace(); + [Metadata_ removeObjectForKey:@"Packages"]; + Packages_ = nil; + Changed_ = true; + } + Finishes_ = [NSArray arrayWithObjects:@"return", @"reopen", @"restart", @"reload", @"reboot", nil]; if (substrate && access("/Library/MobileSubstrate/DynamicLibraries/SimulatedKeyEvents.dylib", F_OK) == 0) @@ -9117,6 +9213,7 @@ int main(int argc, char *argv[]) { _pooled /* }}} */ Colon_ = UCLocalize("COLON_DELIMITED"); + Elision_ = UCLocalize("ELISION"); Error_ = UCLocalize("ERROR"); Warning_ = UCLocalize("WARNING");