From a86e34d01f829a8b4f58f6066d78148c0901c1dd Mon Sep 17 00:00:00 2001
From: "Jay Freeman (saurik)" <saurik@saurik.com>
Date: Mon, 16 Nov 2009 21:03:53 +0000
Subject: [PATCH] Cleaned up the scope code (on the way to let blocks), and
 disabled renaming at top-level scope.

---
 Parser.hpp  |  7 +++++--
 Replace.cpp | 38 ++++++++++++++++++++------------------
 todo.txt    |  1 +
 3 files changed, 26 insertions(+), 20 deletions(-)

diff --git a/Parser.hpp b/Parser.hpp
index dd9263e..008be05 100644
--- a/Parser.hpp
+++ b/Parser.hpp
@@ -315,8 +315,9 @@ typedef std::map<CYIdentifier *, CYIdentifierFlags> CYIdentifierAddressFlagsMap;
 
 struct CYScope {
     CYScope *parent_;
-    CYIdentifierValueSet identifiers_;
     CYIdentifierAddressFlagsMap internal_;
+
+    CYIdentifierValueSet identifiers_;
     size_t offset_;
 
     CYScope() :
@@ -325,7 +326,9 @@ struct CYScope {
     {
     }
 
-    void Add(CYContext &context, CYIdentifierAddressVector &external);
+    void Declare(CYContext &context, CYIdentifier *identifier, CYIdentifierFlags flags);
+    virtual CYIdentifier *Lookup(CYContext &context, CYIdentifier *identifier);
+    void Merge(CYContext &context, CYIdentifierAddressVector &external);
     void Scope(CYContext &context, CYStatement *&statements);
 };
 
diff --git a/Replace.cpp b/Replace.cpp
index e376922..1a03a5c 100644
--- a/Replace.cpp
+++ b/Replace.cpp
@@ -180,9 +180,9 @@ CYExpression *CYDeclaration::ForEachIn(CYContext &context) {
 }
 
 CYExpression *CYDeclaration::Replace(CYContext &context) {
-    CYIdentifier *identifier(identifier_->Replace(context));
-    context.scope_->internal_.insert(CYIdentifierAddressFlagsMap::value_type(identifier, CYIdentifierVariable));
-    return $ CYVariable(identifier);
+    context.Replace(identifier_);
+    context.scope_->Declare(context, identifier_, CYIdentifierVariable);
+    return $ CYVariable(identifier_);
 }
 
 CYProperty *CYDeclarations::Property(CYContext &context) { $T(NULL)
@@ -333,7 +333,7 @@ CYStatement *CYForEachInComprehension::Replace(CYContext &context, CYStatement *
 
 void CYFunction::Inject(CYContext &context) {
     name_ = name_->Replace(context);
-    context.scope_->internal_.insert(CYIdentifierAddressFlagsMap::value_type(name_, CYIdentifierOther));
+    context.scope_->Declare(context, name_, CYIdentifierOther);
 }
 
 void CYFunction::Replace_(CYContext &context, bool outer) {
@@ -360,7 +360,7 @@ CYExpression *CYFunctionExpression::Replace(CYContext &context) {
 
 void CYFunctionParameter::Replace(CYContext &context) { $T()
     name_ = name_->Replace(context);
-    context.scope_->internal_.insert(CYIdentifierAddressFlagsMap::value_type(name_, CYIdentifierArgument));
+    context.scope_->Declare(context, name_, CYIdentifierArgument);
     next_->Replace(context);
 }
 
@@ -370,16 +370,9 @@ CYStatement *CYFunctionStatement::Replace(CYContext &context) {
 }
 
 CYIdentifier *CYIdentifier::Replace(CYContext &context) {
-    if (replace_ != NULL)
-        return replace_;
-
-    CYIdentifierValueSet &identifiers(context.scope_->identifiers_);
-    std::pair<CYIdentifierValueSet::iterator, bool> insert(identifiers.insert(this));
-    if (!insert.second)
-        return *insert.first;
-
-    replace_ = this;
-    return this;
+    if (replace_ == NULL)
+        replace_ = context.scope_->Lookup(context, this);
+    return replace_;
 }
 
 CYStatement *CYIf::Replace(CYContext &context) {
@@ -475,8 +468,8 @@ void CYProgram::Replace(CYContext &context) {
     statements_ = statements_->ReplaceAll(context);
 
     context.scope_ = parent_;
-    Scope(context, statements_);
     context.program_ = program;
+    Scope(context, statements_);
 
     size_t offset(0);
 
@@ -523,7 +516,16 @@ CYStatement *CYReturn::Replace(CYContext &context) {
     return this;
 }
 
-void CYScope::Add(CYContext &context, CYIdentifierAddressVector &external) {
+void CYScope::Declare(CYContext &context, CYIdentifier *identifier, CYIdentifierFlags flags) {
+    internal_.insert(CYIdentifierAddressFlagsMap::value_type(identifier, flags));
+}
+
+CYIdentifier *CYScope::Lookup(CYContext &context, CYIdentifier *identifier) {
+    std::pair<CYIdentifierValueSet::iterator, bool> insert(identifiers_.insert(identifier));
+    return *insert.first;
+}
+
+void CYScope::Merge(CYContext &context, CYIdentifierAddressVector &external) {
     for (CYIdentifierAddressVector::const_iterator i(external.begin()); i != external.end(); ++i) {
         std::pair<CYIdentifierAddressSet::iterator, bool> insert(identifiers_.insert(*i));
         if (!insert.second)
@@ -570,7 +572,7 @@ void CYScope::Scope(CYContext &context, CYStatement *&statements) {
     if (parent_ != NULL) {
         if (parent_->offset_ < offset_)
             parent_->offset_ = offset_;
-        parent_->Add(context, external);
+        parent_->Merge(context, external);
     } else if (program != NULL)
         for (CYIdentifierAddressVector::const_iterator i(external.begin()); i != external.end(); ++i)
             program->external_.insert((*i)->Word());
diff --git a/todo.txt b/todo.txt
index 8426abe..7b5bbd3 100644
--- a/todo.txt
+++ b/todo.txt
@@ -26,3 +26,4 @@ NSArray's .toString() and .toLocaleString() fail hard, as Array.prototype.to*Str
 applyOnMainThread, when done at console, loops the cyonifier
 
 !! CYScope has a bunch of STL container objects that are leaking /all/ of their memory
+special work needs to be done to correctly handle the "arguments" symbol: Declare("arguments", ...Special)
-- 
2.45.2