From 61fe0c53a918d8b46284e0e3e6df94dc8273c28b Mon Sep 17 00:00:00 2001
From: "Jay Freeman (saurik)" <saurik@saurik.com>
Date: Tue, 5 Jun 2012 04:56:14 -0700
Subject: [PATCH] Pass var declarations through non-local functions.

---
 Parser.hpp  | 11 ++---------
 Replace.cpp | 29 ++++++++++++++++-------------
 2 files changed, 18 insertions(+), 22 deletions(-)

diff --git a/Parser.hpp b/Parser.hpp
index 69609ad..5e3bfed 100644
--- a/Parser.hpp
+++ b/Parser.hpp
@@ -312,15 +312,8 @@ struct CYIdentifierUsage {
 
 typedef std::vector<CYIdentifierUsage> CYIdentifierUsageVector;
 
-// XXX: strategy pattern, maybe subclass
-enum CYScopeType {
-    CYScopeCatch,
-    CYScopeFunction,
-    CYScopeProgram,
-};
-
 struct CYScope {
-    CYScopeType type_;
+    bool transparent_;
 
     CYContext &context_;
     CYStatement *&statements_;
@@ -330,7 +323,7 @@ struct CYScope {
     CYIdentifierAddressFlagsMap internal_;
     CYIdentifierValueSet identifiers_;
 
-    CYScope(CYScopeType type, CYContext &context, CYStatement *&statements);
+    CYScope(bool transparent, CYContext &context, CYStatement *&statements);
     virtual ~CYScope();
 
     void Close();
diff --git a/Replace.cpp b/Replace.cpp
index 5ec0b93..3565f66 100644
--- a/Replace.cpp
+++ b/Replace.cpp
@@ -24,6 +24,11 @@
 
 #include <iomanip>
 
+CYFunctionExpression *CYNonLocalize(CYContext &context, CYFunctionExpression *function) {
+    function->nonlocal_ = context.nextlocal_;
+    return function;
+}
+
 CYExpression *CYAdd::Replace(CYContext &context) {
     CYInfix::Replace(context);
 
@@ -113,7 +118,7 @@ namespace cy {
 namespace Syntax {
 
 void Catch::Replace(CYContext &context) { $T()
-    CYScope scope(CYScopeCatch, context, code_.statements_);
+    CYScope scope(true, context, code_.statements_);
 
     context.Replace(name_);
     context.scope_->Declare(context, name_, CYIdentifierCatch);
@@ -378,8 +383,6 @@ void CYFunction::Replace_(CYContext &context, bool outer) {
     if (outer)
         Inject(context);
 
-    CYScope scope(CYScopeFunction, context, code_.statements_);
-
     CYNonLocal *nonlocal(context.nonlocal_);
     CYNonLocal *nextlocal(context.nextlocal_);
 
@@ -393,6 +396,8 @@ void CYFunction::Replace_(CYContext &context, bool outer) {
         context.nextlocal_ = nonlocal_;
     }
 
+    CYScope scope(!localize, context, code_.statements_);
+
     if (!outer && name_ != NULL)
         Inject(context);
 
@@ -470,7 +475,7 @@ CYStatement *CYLabel::Replace(CYContext &context) {
 }
 
 CYStatement *CYLet::Replace(CYContext &context) {
-    return $E($ CYCall($ CYFunctionExpression(NULL, declarations_->Parameter(context), code_), declarations_->Argument(context)));
+    return $E($ CYCall(CYNonLocalize(context, $ CYFunctionExpression(NULL, declarations_->Parameter(context), code_)), declarations_->Argument(context)));
 }
 
 namespace cy {
@@ -553,7 +558,7 @@ namespace {
 }
 
 void CYProgram::Replace(CYContext &context) {
-    CYScope scope(CYScopeProgram, context, statements_);
+    CYScope scope(true, context, statements_);
 
     context.nextlocal_ = $ CYNonLocal();
     context.ReplaceAll(statements_);
@@ -631,13 +636,11 @@ CYExpression *CYRubyBlock::Replace(CYContext &context) {
 }
 
 CYExpression *CYRubyProc::Replace(CYContext &context) {
-    CYFunctionExpression *function($ CYFunctionExpression(NULL, parameters_, code_));
-    function->nonlocal_ = context.nextlocal_;
-    return function;
+    return CYNonLocalize(context, $ CYFunctionExpression(NULL, parameters_, code_));
 }
 
-CYScope::CYScope(CYScopeType type, CYContext &context, CYStatement *&statements) :
-    type_(type),
+CYScope::CYScope(bool transparent, CYContext &context, CYStatement *&statements) :
+    transparent_(transparent),
     context_(context),
     statements_(statements),
     parent_(context.scope_)
@@ -654,10 +657,10 @@ void CYScope::Close() {
 }
 
 void CYScope::Declare(CYContext &context, CYIdentifier *identifier, CYIdentifierFlags flags) {
-    if (type_ == CYScopeCatch && flags != CYIdentifierCatch)
-        parent_->Declare(context, identifier, flags);
-    else
+    if (!transparent_ || flags == CYIdentifierArgument || flags == CYIdentifierCatch)
         internal_.insert(CYIdentifierAddressFlagsMap::value_type(identifier, flags));
+    else if (parent_ != NULL)
+        parent_->Declare(context, identifier, flags);
 }
 
 CYIdentifier *CYScope::Lookup(CYContext &context, CYIdentifier *identifier) {
-- 
2.45.2