From: Jay Freeman (saurik) <saurik@saurik.com>
Date: Fri, 14 Sep 2012 06:01:19 +0000 (-0700)
Subject: Fix cy$getProperty so NSArray .length is primitive.
X-Git-Tag: v0.9.460~23
X-Git-Url: https://git.saurik.com/cycript.git/commitdiff_plain/6b9e29d28c4754efd5fcafddd291930bbade6b8a?ds=sidebyside

Fix cy$getProperty so NSArray .length is primitive.
---

diff --git a/ObjectiveC/Library.mm b/ObjectiveC/Library.mm
index 0c7712e..d526163 100644
--- a/ObjectiveC/Library.mm
+++ b/ObjectiveC/Library.mm
@@ -395,6 +395,7 @@ JSObjectRef CYMakeInstance(JSContextRef context, id object, bool transient) {
 
 - (bool) cy$hasProperty:(NSString *)name;
 - (NSObject *) cy$getProperty:(NSString *)name;
+- (JSValueRef) cy$getProperty:(NSString *)name inContext:(JSContextRef)context;
 - (bool) cy$setProperty:(NSString *)name to:(NSObject *)value;
 - (bool) cy$deleteProperty:(NSString *)name;
 - (void) cy$getPropertyNames:(JSPropertyNameAccumulatorRef)names inContext:(JSContextRef)context;
@@ -730,15 +731,6 @@ NSObject *CYCopyNSObject(apr_pool_t *pool, JSContextRef context, JSValueRef valu
 }
 
 - (NSObject *) cy$getProperty:(NSString *)name {
-    if ([name isEqualToString:@"length"]) {
-        NSUInteger count([self count]);
-#ifdef __APPLE__
-        return [NSNumber numberWithUnsignedInteger:count];
-#else
-        return [NSNumber numberWithUnsignedInt:count];
-#endif
-    }
-
     size_t index(CYGetIndex(name));
     if (index == _not(size_t) || index >= [self count])
         return [super cy$getProperty:name];
@@ -746,6 +738,15 @@ NSObject *CYCopyNSObject(apr_pool_t *pool, JSContextRef context, JSValueRef valu
         return [self objectAtIndex:index];
 }
 
+- (JSValueRef) cy$getProperty:(NSString *)name inContext:(JSContextRef)context {
+    CYObjectiveTry_(context) {
+        if ([name isEqualToString:@"length"])
+            return CYCastJSValue(context, [self count]);
+    } CYObjectiveCatch
+
+    return [super cy$getProperty:name inContext:context];
+}
+
 - (void) cy$getPropertyNames:(JSPropertyNameAccumulatorRef)names inContext:(JSContextRef)context {
     [super cy$getPropertyNames:names inContext:context];
 
@@ -997,6 +998,12 @@ NSObject *CYCopyNSObject(apr_pool_t *pool, JSContextRef context, JSValueRef valu
     return nil;
 }
 
+- (JSValueRef) cy$getProperty:(NSString *)name inContext:(JSContextRef)context { CYObjectiveTry_(context) {
+    if (NSObject *value = [self cy$getProperty:name])
+        return CYCastJSValue(context, value);
+    return NULL;
+} CYObjectiveCatch }
+
 - (bool) cy$setProperty:(NSString *)name to:(NSObject *)value {
     return false;
 }
@@ -1663,8 +1670,8 @@ static JSValueRef Instance_getProperty(JSContextRef context, JSObjectRef object,
             return value;
 
     CYPoolTry {
-        if (NSObject *data = [self cy$getProperty:name])
-            return CYCastJSValue(context, data);
+        if (JSValueRef value = [self cy$getProperty:name inContext:context])
+            return value;
     } CYPoolCatch(NULL)
 
     const char *string(CYPoolCString(pool, context, name));