From a0cd287e64e2d53bc5896e0a7c5ad072cb8bf469 Mon Sep 17 00:00:00 2001 From: Akim Demaille Date: Tue, 8 May 2012 12:04:24 +0200 Subject: [PATCH] maint: maintainer-release-check. * tests/Makefile.am (maintainer-release-check): New. * Makefile.am (MAINTAINER_CHECKS): New. Support maintainer-release-check. * README-hacking: Document it, and syntax-check too. --- Makefile.am | 17 +++++++---------- README-hacking | 6 ++++++ tests/Makefile.am | 3 +++ 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/Makefile.am b/Makefile.am index f2b6b207..47c68369 100644 --- a/Makefile.am +++ b/Makefile.am @@ -30,16 +30,13 @@ EXTRA_DIST = .prev-version .version \ djgpp/subpipe.c djgpp/subpipe.h djgpp/djunpack.bat \ djgpp/fnchange.lst djgpp/testsuite.sed -.PHONY: maintainer-check -maintainer-check: - $(AM_V_GEN)cd tests && $(MAKE) $(AM_MAKEFLAGS) $@ - -.PHONY: maintainer-push-check -maintainer-push-check: - $(AM_V_GEN)cd tests && $(MAKE) $(AM_MAKEFLAGS) $@ - -.PHONY: maintainer-xml-check -maintainer-xml-check: +MAINTAINER_CHECKS = \ + maintainer-check \ + maintainer-push-check \ + maintainer-xml-check \ + maintainer-release-check +.PHONY: $(MAINTAINER_CHECKS) +$(MAINTAINER_CHECKS): $(AM_V_GEN)cd tests && $(MAKE) $(AM_MAKEFLAGS) $@ # See comments in build-aux/git-version-gen. However, we make .version depend diff --git a/README-hacking b/README-hacking index 70f346a3..97c73a80 100644 --- a/README-hacking +++ b/README-hacking @@ -180,6 +180,9 @@ release: - Build with -DGNULIB_POSIXCHECK. It suggests gnulib modules that can fix portability issues. +- Check with `make syntax-check' if there are issues diagnosed by + gnulib. + - run `make maintainer-check' which: - runs `valgrind -q bison' to run Bison under Valgrind. - runs the parsers under Valgrind. @@ -197,6 +200,9 @@ release: Bison's included XSLT style sheets with the output of --report=all and --graph. +- running `make maintainer-release-check' takes care of running + maintainer-check, maintainer-push-check and maintainer-xml-check. + - Change tests/atlocal/CFLAGS to add your preferred options. For instance, `-traditional' to check that the parsers are K&R. Note that it does not make sense for glr.c, which should be ANSI, diff --git a/tests/Makefile.am b/tests/Makefile.am index 7a2139df..e3e46a4f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -100,3 +100,6 @@ maintainer-push-check: .PHONY: maintainer-xml-check maintainer-xml-check: BISON_TEST_XML=1 $(MAKE) $(AM_MAKEFLAGS) maintainer-check + +.PHONY: maintainer-release-check +maintainer-release-check: maintainer-check maintainer-push-check maintainer-xml-check -- 2.45.2