From: Akim Demaille <akim@epita.fr>
Date: Wed, 5 Dec 2001 09:28:13 +0000 (+0000)
Subject: * src/lalr.c (initialize_F): Improve variable locality.
X-Git-Tag: before-m4-back-end~210
X-Git-Url: https://git.saurik.com/bison.git/commitdiff_plain/4d4f699ca481fbb1d255ade0561ad6c7a89949ae?ds=inline

* src/lalr.c (initialize_F): Improve variable locality.
Avoid variables used as mere abbreviations.
---

diff --git a/ChangeLog b/ChangeLog
index 067427ba..58926bd1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2001-12-05  Akim Demaille  <akim@epita.fr>
+
+	* src/lalr.c (initialize_F): Improve variable locality.
+	Avoid variables used as mere abbreviations.
+
 2001-12-05  Akim Demaille  <akim@epita.fr>
 
 	* src/derives.c (print_derives): Display the ruleno.
diff --git a/src/lalr.c b/src/lalr.c
index 54b0391c..c2554dcf 100644
--- a/src/lalr.c
+++ b/src/lalr.c
@@ -356,24 +356,14 @@ map_goto (int state, int symbol)
 static void
 initialize_F (void)
 {
-  int i;
-  int j;
-  short *edge;
-  unsigned *rowp;
-  short *rp;
-  short **reads;
-  int nedges;
-  int symbol;
-  int nwords;
+  short **reads = XCALLOC (short *, ngotos);
+  short *edge = XCALLOC (short, ngotos + 1);
+  int nedges = 0;
 
-  nwords = ngotos * tokensetsize;
-  F = XCALLOC (unsigned, nwords);
+  int i;
 
-  reads = XCALLOC (short *, ngotos);
-  edge = XCALLOC (short, ngotos + 1);
-  nedges = 0;
+  F = XCALLOC (unsigned, ngotos * tokensetsize);
 
-  rowp = F;
   for (i = 0; i < ngotos; i++)
     {
       int stateno = to_state[i];
@@ -381,34 +371,30 @@ initialize_F (void)
 
       if (sp)
 	{
+	  int j;
 	  for (j = 0; j < sp->nshifts; j++)
 	    {
-	      symbol = state_table[sp->shifts[j]].accessing_symbol;
+	      int symbol = state_table[sp->shifts[j]].accessing_symbol;
 	      if (ISVAR (symbol))
 		break;
-	      SETBIT (rowp, symbol);
+	      SETBIT (F + i * tokensetsize, symbol);
 	    }
 
 	  for (; j < sp->nshifts; j++)
 	    {
-	      symbol = state_table[sp->shifts[j]].accessing_symbol;
+	      int symbol = state_table[sp->shifts[j]].accessing_symbol;
 	      if (nullable[symbol])
 		edge[nedges++] = map_goto (stateno, symbol);
 	    }
 
 	  if (nedges)
 	    {
-	      reads[i] = rp = XCALLOC (short, nedges + 1);
-
-	      for (j = 0; j < nedges; j++)
-		rp[j] = edge[j];
-
-	      rp[nedges] = -1;
+	      reads[i] = XCALLOC (short, nedges + 1);
+	      shortcpy (reads[i], edge, nedges);
+	      reads[i][nedges] = -1;
 	      nedges = 0;
 	    }
 	}
-
-      rowp += tokensetsize;
     }
 
   digraph (reads);