X-Git-Url: https://git.saurik.com/bison.git/blobdiff_plain/f6b561d9f9cbc6fc95bbb86518372a5cb52f45a6..28be3b8e53cdf664c3f2e59cf5fb6c50266d4a11:/src/tables.c diff --git a/src/tables.c b/src/tables.c index 96354b1a..fa2a90c8 100644 --- a/src/tables.c +++ b/src/tables.c @@ -84,7 +84,7 @@ int nvectors; static base_number **froms; static base_number **tos; static unsigned int **conflict_tos; -static int *tally; +static size_t *tally; static base_number *width; @@ -135,11 +135,11 @@ int high; state_number *yydefgoto; rule_number *yydefact; -/*----------------------------------------------------------------. -| If TABLE (and CHECK) appear to be small to be addressed at | -| DESIRED, grow them. Note that TABLE[DESIRED] is to be used, so | -| the desired size is at least DESIRED + 1. | -`----------------------------------------------------------------*/ +/*-------------------------------------------------------------------. +| If TABLE, CONFLICT_TABLE, and CHECK are too small to be addressed | +| at DESIRED, grow them. TABLE[DESIRED] can be used, so the desired | +| size is at least DESIRED + 1. | +`-------------------------------------------------------------------*/ static void table_grow (int desired) @@ -308,7 +308,7 @@ action_row (state *s) labeled as consistent. */ { char *default_reductions = - muscle_percent_define_get ("lr.default-reductions"); + muscle_percent_define_get ("lr.default-reduction"); if (STRNEQ (default_reductions, "most") && !s->consistent) nodefault = true; free (default_reductions); @@ -382,7 +382,7 @@ static void save_row (state_number s) { symbol_number i; - int count; + size_t count; base_number *sp; base_number *sp1; base_number *sp2; @@ -486,38 +486,33 @@ static void save_column (symbol_number sym, state_number default_state) { goto_number i; - base_number *sp; - base_number *sp1; - base_number *sp2; - int count; - vector_number symno = symbol_number_to_vector_number (sym); - goto_number begin = goto_map[sym - ntokens]; goto_number end = goto_map[sym - ntokens + 1]; /* Number of non default GOTO. */ - count = 0; + size_t count = 0; for (i = begin; i < end; i++) if (to_state[i] != default_state) count++; - if (count == 0) - return; - - /* Allocate room for non defaulted gotos. */ - froms[symno] = sp = sp1 = xnmalloc (count, sizeof *sp1); - tos[symno] = sp2 = xnmalloc (count, sizeof *sp2); - - /* Store the state numbers of the non defaulted gotos. */ - for (i = begin; i < end; i++) - if (to_state[i] != default_state) - { - *sp1++ = from_state[i]; - *sp2++ = to_state[i]; - } - - tally[symno] = count; - width[symno] = sp1[-1] - sp[0] + 1; + if (count) + { + /* Allocate room for non defaulted gotos. */ + vector_number symno = symbol_number_to_vector_number (sym); + base_number *sp1 = froms[symno] = xnmalloc (count, sizeof *sp1); + base_number *sp2 = tos[symno] = xnmalloc (count, sizeof *sp2); + + /* Store the state numbers of the non defaulted gotos. */ + for (i = begin; i < end; i++) + if (to_state[i] != default_state) + { + *sp1++ = from_state[i]; + *sp2++ = to_state[i]; + } + + tally[symno] = count; + width[symno] = sp1[-1] - froms[symno][0] + 1; + } } @@ -596,17 +591,17 @@ sort_actions (void) nentries = 0; for (i = 0; i < nvectors; i++) - if (tally[i] > 0) + if (0 < tally[i]) { int k; - int t = tally[i]; + size_t t = tally[i]; int w = width[i]; int j = nentries - 1; - while (j >= 0 && (width[order[j]] < w)) + while (0 <= j && width[order[j]] < w) j--; - while (j >= 0 && (width[order[j]] == w) && (tally[order[j]] < t)) + while (0 <= j && width[order[j]] == w && tally[order[j]] < t) j--; for (k = nentries - 1; k > j; k--) @@ -618,7 +613,7 @@ sort_actions (void) } -/* If VECTOR is a state which actions (reflected by FROMS, TOS, TALLY +/* If VECTOR is a state whose actions (reflected by FROMS, TOS, TALLY and WIDTH of VECTOR) are common to a previous state, return this state number. @@ -628,7 +623,7 @@ static state_number matching_state (vector_number vector) { vector_number i = order[vector]; - int t; + size_t t; int w; int prev; @@ -660,7 +655,8 @@ matching_state (vector_number vector) return -1; for (k = 0; match && k < t; k++) - if (tos[j][k] != tos[i][k] || froms[j][k] != froms[i][k] + if (tos[j][k] != tos[i][k] + || froms[j][k] != froms[i][k] || (conflict_tos[j] != NULL && conflict_tos[j][k] != 0)) match = 0; @@ -675,42 +671,44 @@ matching_state (vector_number vector) static base_number pack_vector (vector_number vector) { + base_number res; vector_number i = order[vector]; - int j; - int t = tally[i]; - int loc = 0; + size_t t = tally[i]; base_number *from = froms[i]; base_number *to = tos[i]; unsigned int *conflict_to = conflict_tos[i]; aver (t != 0); - for (j = lowzero - from[0]; ; j++) + for (res = lowzero - from[0]; ; res++) { - int k; bool ok = true; - - aver (j < table_size); - - for (k = 0; ok && k < t; k++) - { - loc = j + state_number_as_int (from[k]); - if (table_size <= loc) - table_grow (loc); - - if (table[loc] != 0) - ok = false; - } - - for (k = 0; ok && k < vector; k++) - if (pos[k] == j) - ok = false; + aver (res < table_size); + { + int k; + for (k = 0; ok && k < t; k++) + { + int loc = res + state_number_as_int (from[k]); + if (table_size <= loc) + table_grow (loc); + + if (table[loc] != 0) + ok = false; + } + + if (ok) + for (k = 0; k < vector; k++) + if (pos[k] == res) + ok = false; + } if (ok) { + int loc; + int k; for (k = 0; k < t; k++) { - loc = j + from[k]; + loc = res + state_number_as_int (from[k]); table[loc] = to[k]; if (nondeterministic_parser && conflict_to != NULL) conflict_table[loc] = conflict_to[k]; @@ -720,11 +718,11 @@ pack_vector (vector_number vector) while (table[lowzero] != 0) lowzero++; - if (loc > high) + if (high < loc) high = loc; - aver (BASE_MINIMUM <= j && j <= BASE_MAXIMUM); - return j; + aver (BASE_MINIMUM <= res && res <= BASE_MAXIMUM); + return res; } } }