X-Git-Url: https://git.saurik.com/bison.git/blobdiff_plain/e68e0410aba6a9b976a1e496aa80ffb3d2095fb9..c801dbf7d9e2c8d41917eb12dff81357378d75cd:/src/nullable.c

diff --git a/src/nullable.c b/src/nullable.c
index 635ea619..1a96bef2 100644
--- a/src/nullable.c
+++ b/src/nullable.c
@@ -24,20 +24,21 @@
    do so.  */
 
 #include "system.h"
+
 #include "getargs.h"
-#include "symtab.h"
 #include "gram.h"
-#include "reduce.h"
 #include "nullable.h"
+#include "reduce.h"
+#include "symtab.h"
 
-/* Linked list of rule numbers.  */
-typedef struct rule_list_s
+/* Linked list of rules.  */
+typedef struct rule_list
 {
-  struct rule_list_s *next;
-  rule_number_t value;
-} rule_list_t;
+  struct rule_list *next;
+  rule *value;
+} rule_list;
 
-char *nullable = NULL;
+bool *nullable = NULL;
 
 static void
 nullable_print (FILE *out)
@@ -50,51 +51,48 @@ nullable_print (FILE *out)
 }
 
 void
-set_nullable (void)
+nullable_compute (void)
 {
-  rule_number_t ruleno;
-  symbol_number_t *s1;
-  symbol_number_t *s2;
-  rule_list_t *p;
+  rule_number ruleno;
+  symbol_number *s1;
+  symbol_number *s2;
+  rule_list *p;
 
-  symbol_number_t *squeue = XCALLOC (symbol_number_t, nvars);
-  short *rcount = XCALLOC (short, nrules + 1);
+  symbol_number *squeue = XCALLOC (symbol_number, nvars);
+  short *rcount = XCALLOC (short, nrules);
   /* RITEM contains all the rules, including useless productions.
      Hence we must allocate room for useless nonterminals too.  */
-  rule_list_t **rsets = XCALLOC (rule_list_t *, nvars) - ntokens;
+  rule_list **rsets = XCALLOC (rule_list *, nvars) - ntokens;
   /* This is said to be more elements than we actually use.
      Supposedly NRITEMS - NRULES is enough.  But why take the risk?  */
-  rule_list_t *relts = XCALLOC (rule_list_t, nritems + nvars + 1);
-
-  if (trace_flag)
-    fprintf (stderr, "Entering set_nullable\n");
+  rule_list *relts = XCALLOC (rule_list, nritems + nvars + 1);
 
-  nullable = XCALLOC (char, nvars) - ntokens;
+  nullable = XCALLOC (bool, nvars) - ntokens;
 
   s1 = s2 = squeue;
   p = relts;
 
-  for (ruleno = 1; ruleno < nrules + 1; ++ruleno)
+  for (ruleno = 0; ruleno < nrules; ++ruleno)
     if (rules[ruleno].useful)
       {
-	rule_t *rule = &rules[ruleno];
-	if (rule->rhs[0] >= 0)
+	rule *rules_ruleno = &rules[ruleno];
+	if (rules_ruleno->rhs[0] >= 0)
 	  {
 	    /* This rule has a non empty RHS. */
-	    item_number_t *r = NULL;
+	    item_number *r = NULL;
 	    int any_tokens = 0;
-	    for (r = rule->rhs; *r >= 0; ++r)
+	    for (r = rules_ruleno->rhs; *r >= 0; ++r)
 	      if (ISTOKEN (*r))
 		any_tokens = 1;
 
 	    /* This rule has only nonterminals: schedule it for the second
 	       pass.  */
 	    if (!any_tokens)
-	      for (r = rule->rhs; *r >= 0; ++r)
+	      for (r = rules_ruleno->rhs; *r >= 0; ++r)
 		{
 		  rcount[ruleno]++;
 		  p->next = rsets[*r];
-		  p->value = ruleno;
+		  p->value = rules_ruleno;
 		  rsets[*r] = p;
 		  p++;
 		}
@@ -102,11 +100,12 @@ set_nullable (void)
 	else
 	  {
 	    /* This rule has an empty RHS. */
-	    assert (rule_number_of_item_number (rule->rhs[0]) == ruleno);
-	    if (rule->useful && !nullable[rule->lhs->number])
+	    if (item_number_as_rule_number (rules_ruleno->rhs[0]) != ruleno)
+	      abort ();
+	    if (rules_ruleno->useful && !nullable[rules_ruleno->lhs->number])
 	      {
-		nullable[rule->lhs->number] = 1;
-		*s2++ = rule->lhs->number;
+		nullable[rules_ruleno->lhs->number] = 1;
+		*s2++ = rules_ruleno->lhs->number;
 	      }
 	  }
       }
@@ -114,12 +113,12 @@ set_nullable (void)
   while (s1 < s2)
     for (p = rsets[*s1++]; p; p = p->next)
       {
-	ruleno = p->value;
-	if (--rcount[ruleno] == 0)
-	  if (rules[ruleno].useful && !nullable[rules[ruleno].lhs->number])
+	rule *r = p->value;
+	if (--rcount[r->number] == 0)
+	  if (r->useful && !nullable[r->lhs->number])
 	    {
-	      nullable[rules[ruleno].lhs->number] = 1;
-	      *s2++ = rules[ruleno].lhs->number;
+	      nullable[r->lhs->number] = 1;
+	      *s2++ = r->lhs->number;
 	    }
       }
 
@@ -128,13 +127,13 @@ set_nullable (void)
   XFREE (rsets + ntokens);
   XFREE (relts);
 
-  if (trace_flag)
+  if (trace_flag & trace_sets)
     nullable_print (stderr);
 }
 
 
 void
-free_nullable (void)
+nullable_free (void)
 {
   XFREE (nullable + ntokens);
 }