X-Git-Url: https://git.saurik.com/bison.git/blobdiff_plain/b2a0b7ca70f9490693d517d10c9c4a64c9fc1af0..f72721518b2d8201c9d8d64dbdc0d8649d984383:/tests/input.at diff --git a/tests/input.at b/tests/input.at index 7b009758..cd0dd6ac 100644 --- a/tests/input.at +++ b/tests/input.at @@ -1,31 +1,87 @@ # Checking the Bison scanner. -*- Autotest -*- -# Copyright (C) 2002, 2003, 2004, 2005, 2006 Free Software Foundation, Inc. -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2, or (at your option) -# any later version. +# Copyright (C) 2002-2012 Free Software Foundation, Inc. +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. - +# # You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA -# 02110-1301, USA. +# along with this program. If not, see . AT_BANNER([[Input Processing.]]) # Mostly test that we are robust to mistakes. +## ---------------- ## +## Invalid inputs. ## +## ---------------- ## + +AT_SETUP([Invalid inputs]) + +AT_DATA([input.y], +[[\000\001\002\377? +%% +? +default: 'a' } +%& +%a-does-not-exist +%- +%{ +]]) +AT_CHECK([[$PERL -pi -e 's/\\(\d{3})/chr(oct($1))/ge' input.y || exit 77]]) + +AT_BISON_CHECK([input.y], [1], [], +[[input.y:1.1-2: error: invalid characters: '\0\001\002\377?' +input.y:3.1: error: invalid character: '?' +input.y:4.14: error: invalid character: '}' +input.y:5.1: error: invalid character: '%' +input.y:5.2: error: invalid character: '&' +input.y:6.1-17: error: invalid directive: '%a-does-not-exist' +input.y:7.1: error: invalid character: '%' +input.y:7.2: error: invalid character: '-' +input.y:8.1-9.0: error: missing '%}' at end of file +input.y:8.1-9.0: error: syntax error, unexpected %{...%} +]]) + +AT_CLEANUP + + +AT_SETUP([Invalid inputs with {}]) + +# We used to SEGV here. See +# http://lists.gnu.org/archive/html/bug-bison/2005-07/msg00053.html + +AT_DATA([input.y], +[[ +%destructor +%initial-action +%lex-param +%parse-param +%printer +%union +]]) + +AT_BISON_CHECK([input.y], [1], [], +[[input.y:3.1-15: error: syntax error, unexpected %initial-action, expecting {...} +]]) + +AT_CLEANUP + + + ## ------------ ## ## Invalid $n. ## ## ------------ ## -AT_SETUP([Invalid \$n and @n]) +AT_SETUP([Invalid $n and @n]) AT_DATA([input.y], [[%% @@ -33,9 +89,9 @@ exp: { $$ = $1 ; }; exp: { @$ = @1 ; }; ]]) -AT_CHECK([bison input.y], [1], [], -[[input.y:2.13-14: integer out of range: `$1' -input.y:3.13-14: integer out of range: `@1' +AT_BISON_CHECK([input.y], [1], [], +[[input.y:2.13-14: error: integer out of range: '$1' +input.y:3.13-14: error: integer out of range: '@1' ]]) AT_CLEANUP @@ -58,9 +114,9 @@ exp: foo { $$; } foo { $2; } foo ; ]]) -AT_CHECK([bison input.y], [1], [], -[[input.y:5.12-13: $$ for the midrule at $2 of `exp' has no declared type -input.y:5.24-25: $2 of `exp' has no declared type +AT_BISON_CHECK([input.y], [1], [], +[[input.y:5.12-13: error: $$ for the midrule at $2 of 'exp' has no declared type +input.y:5.24-25: error: $2 of 'exp' has no declared type input.y:5.6-32: warning: type clash on default action: != <> input.y:6.6-8: warning: type clash on default action: != <> input.y:7.5: warning: empty rule for typed nonterminal, and no action @@ -70,7 +126,7 @@ AT_CLEANUP # _AT_UNUSED_VALUES_DECLARATIONS() -# -------------------------------------------- +# -------------------------------- # Generate the token, type, and destructor # declarations for the unused values tests. @@ -80,13 +136,15 @@ m4_define([_AT_UNUSED_VALUES_DECLARATIONS], %destructor { destroy ($$); } INT a b c d e f g h i j k l;]]]) -# AT_CHECK_UNUSED_VALUES(DECLARATIONS_AFTER) -# -------------------------------------------- +# AT_CHECK_UNUSED_VALUES(DECLARATIONS_AFTER, CHECK_MIDRULE_VALUES) +# ------------------------------------------------------------------ # Generate a grammar to test unused values, # compile it, run it. If DECLARATIONS_AFTER # is set, then the token, type, and destructor # declarations are generated after the rules -# rather than before. +# rather than before. If CHECK_MIDRULE_VALUES +# is set, then --warnings=midrule-values is +# set. m4_define([AT_CHECK_UNUSED_VALUES], [AT_DATA([input.y], @@ -96,16 +154,16 @@ m4_ifval($1, [ ], [_AT_UNUSED_VALUES_DECLARATIONS ])[[%% start: - 'a' a { $]2[ } | 'b' b { $]2[ } | 'c' c { $]2[ } | 'd' d { $]2[ } | 'e' e { $]2[ } -| 'f' f { $]2[ } | 'g' g { $]2[ } | 'h' h { $]2[ } | 'i' i { $]2[ } | 'j' j { $]2[ } -| 'k' k { $]2[ } | 'l' l { $]2[ } + 'a' a { $]2[; } | 'b' b { $]2[; } | 'c' c { $]2[; } | 'd' d { $]2[; } +| 'e' e { $]2[; } | 'f' f { $]2[; } | 'g' g { $]2[; } | 'h' h { $]2[; } +| 'i' i { $]2[; } | 'j' j { $]2[; } | 'k' k { $]2[; } | 'l' l { $]2[; } ; a: INT | INT { } INT { } INT { }; b: INT | /* empty */; -c: INT | INT { $]1[ } INT { } INT { }; -d: INT | INT { } INT { $]1[ } INT { }; -e: INT | INT { } INT { } INT { $]1[ }; +c: INT | INT { $]1[; } INT { $2; } INT { $4; }; +d: INT | INT { } INT { $]1[; } INT { $2; }; +e: INT | INT { } INT { } INT { $]1[; }; f: INT | INT { } INT { } INT { $]$[ = $]1[ + $]3[ + $]5[; }; g: INT | INT { $$; } INT { $$; } INT { }; h: INT | INT { $$; } INT { $$ = $2; } INT { }; @@ -116,38 +174,41 @@ l: INT | INT { $$ = $1; } INT { $$ = $2 + $< _AT_UNUSED_VALUES_DECLARATIONS]) ) -AT_CHECK([bison input.y], [0], [], +AT_BISON_CHECK(m4_ifval($2, [ --warnings=midrule-values ])[ input.y], [0], [], [[input.y:11.10-32: warning: unset value: $]$[ input.y:11.10-32: warning: unused value: $]1[ input.y:11.10-32: warning: unused value: $]3[ input.y:11.10-32: warning: unused value: $]5[ input.y:12.9: warning: empty rule for typed nonterminal, and no action -input.y:13.10-35: warning: unset value: $]$[ -input.y:13.10-35: warning: unused value: $]3[ -input.y:13.10-35: warning: unused value: $]5[ -input.y:14.10-35: warning: unset value: $]$[ -input.y:14.10-35: warning: unused value: $]3[ -input.y:14.10-35: warning: unused value: $]5[ -input.y:15.10-36: warning: unset value: $]$[ -input.y:15.10-36: warning: unused value: $]3[ -input.y:15.10-36: warning: unused value: $]5[ +]]m4_ifval($2, [[[input.y:13.14-20: warning: unset value: $$ +input.y:13.26-41: warning: unset value: $$ +]]])[[input.y:13.10-62: warning: unset value: $]$[ +input.y:13.10-62: warning: unused value: $]3[ +input.y:13.10-62: warning: unused value: $]5[ +]]m4_ifval($2, [[[input.y:14.14-16: warning: unset value: $$ +]]])[[input.y:14.10-49: warning: unset value: $]$[ +input.y:14.10-49: warning: unused value: $]3[ +input.y:14.10-49: warning: unused value: $]5[ +input.y:15.10-37: warning: unset value: $]$[ +input.y:15.10-37: warning: unused value: $]3[ +input.y:15.10-37: warning: unused value: $]5[ input.y:17.10-58: warning: unset value: $]$[ input.y:17.10-58: warning: unused value: $]1[ -input.y:17.10-58: warning: unused value: $]2[ -input.y:17.10-58: warning: unused value: $]3[ -input.y:17.10-58: warning: unused value: $]4[ -input.y:17.10-58: warning: unused value: $]5[ +]]m4_ifval($2, [[[input.y:17.10-58: warning: unused value: $]2[ +]]])[[input.y:17.10-58: warning: unused value: $]3[ +]]m4_ifval($2, [[[input.y:17.10-58: warning: unused value: $]4[ +]]])[[input.y:17.10-58: warning: unused value: $]5[ input.y:18.10-72: warning: unset value: $]$[ input.y:18.10-72: warning: unused value: $]1[ input.y:18.10-72: warning: unused value: $]3[ -input.y:18.10-72: warning: unused value: $]4[ -input.y:18.10-72: warning: unused value: $]5[ -input.y:20.10-55: warning: unused value: $]3[ -input.y:21.10-68: warning: unset value: $]$[ +]]m4_ifval($2, [[[input.y:18.10-72: warning: unused value: $]4[ +]]])[[input.y:18.10-72: warning: unused value: $]5[ +]]m4_ifval($2, [[[input.y:20.10-55: warning: unused value: $]3[ +]]])[[input.y:21.10-68: warning: unset value: $]$[ input.y:21.10-68: warning: unused value: $]1[ input.y:21.10-68: warning: unused value: $]2[ -input.y:21.10-68: warning: unused value: $]4[ -]])]) +]]m4_ifval($2, [[[input.y:21.10-68: warning: unused value: $]4[ +]]]))]) ## --------------- ## @@ -156,6 +217,7 @@ input.y:21.10-68: warning: unused value: $]4[ AT_SETUP([Unused values]) AT_CHECK_UNUSED_VALUES +AT_CHECK_UNUSED_VALUES(, [1]) AT_CLEANUP @@ -165,6 +227,7 @@ AT_CLEANUP AT_SETUP([Unused values before symbol declarations]) AT_CHECK_UNUSED_VALUES([1]) +AT_CHECK_UNUSED_VALUES([1], [1]) AT_CLEANUP @@ -175,33 +238,54 @@ AT_CLEANUP AT_SETUP([Default %printer and %destructor redeclared]) AT_DATA([[input.y]], -[[%destructor { destroy ($$); } %symbol-default %symbol-default -%printer { destroy ($$); } %symbol-default %symbol-default +[[%destructor { destroy ($$); } <*> <*> +%printer { print ($$); } <*> <*> + +%destructor { destroy ($$); } <*> +%printer { print ($$); } <*> -%destructor { destroy ($$); } %symbol-default -%printer { destroy ($$); } %symbol-default +%destructor { destroy ($$); } <> <> +%printer { print ($$); } <> <> + +%destructor { destroy ($$); } <> +%printer { print ($$); } <> %% start: ; -%destructor { destroy ($$); } %symbol-default; -%printer { destroy ($$); } %symbol-default; +%destructor { destroy ($$); } <*>; +%printer { print ($$); } <*>; + +%destructor { destroy ($$); } <>; +%printer { print ($$); } <>; ]]) -AT_CHECK([bison input.y], [1], [], -[[input.y:1.13-29: redeclaration for default %destructor -input.y:1.13-29: previous declaration -input.y:2.10-26: redeclaration for default %printer -input.y:2.10-26: previous declaration -input.y:4.13-29: redeclaration for default %destructor -input.y:1.13-29: previous declaration -input.y:5.10-26: redeclaration for default %printer -input.y:2.10-26: previous declaration -input.y:11.13-29: redeclaration for default %destructor -input.y:4.13-29: previous declaration -input.y:12.10-26: redeclaration for default %printer -input.y:5.10-26: previous declaration +AT_BISON_CHECK([input.y], [1], [], +[[input.y:1.13-29: error: redeclaration for default tagged %destructor +input.y:1.13-29: previous declaration +input.y:2.10-24: error: redeclaration for default tagged %printer +input.y:2.10-24: previous declaration +input.y:4.13-29: error: redeclaration for default tagged %destructor +input.y:1.13-29: previous declaration +input.y:5.10-24: error: redeclaration for default tagged %printer +input.y:2.10-24: previous declaration +input.y:7.13-29: error: redeclaration for default tagless %destructor +input.y:7.13-29: previous declaration +input.y:8.10-24: error: redeclaration for default tagless %printer +input.y:8.10-24: previous declaration +input.y:10.13-29: error: redeclaration for default tagless %destructor +input.y:7.13-29: previous declaration +input.y:11.10-24: error: redeclaration for default tagless %printer +input.y:8.10-24: previous declaration +input.y:17.13-29: error: redeclaration for default tagged %destructor +input.y:4.13-29: previous declaration +input.y:18.10-24: error: redeclaration for default tagged %printer +input.y:5.10-24: previous declaration +input.y:20.13-29: error: redeclaration for default tagless %destructor +input.y:10.13-29: previous declaration +input.y:21.10-24: error: redeclaration for default tagless %printer +input.y:11.10-24: previous declaration ]]) AT_CLEANUP @@ -215,36 +299,36 @@ AT_SETUP([Per-type %printer and %destructor redeclared]) AT_DATA([[input.y]], [[%destructor { destroy ($$); } -%printer { destroy ($$); } +%printer { print ($$); } %destructor { destroy ($$); } -%printer { destroy ($$); } +%printer { print ($$); } %% start: ; %destructor { destroy ($$); } ; -%printer { destroy ($$); } ; +%printer { print ($$); } ; ]]) -AT_CHECK([bison input.y], [1], [], -[[input.y:4.13-29: %destructor redeclaration for -input.y:1.13-29: previous declaration -input.y:4.13-29: %destructor redeclaration for -input.y:4.13-29: previous declaration -input.y:5.10-26: %printer redeclaration for -input.y:2.10-26: previous declaration -input.y:5.10-26: %printer redeclaration for -input.y:5.10-26: previous declaration -input.y:11.13-29: %destructor redeclaration for -input.y:4.13-29: previous declaration -input.y:11.13-29: %destructor redeclaration for -input.y:1.13-29: previous declaration -input.y:12.10-26: %printer redeclaration for -input.y:2.10-26: previous declaration -input.y:12.10-26: %printer redeclaration for -input.y:5.10-26: previous declaration +AT_BISON_CHECK([input.y], [1], [], +[[input.y:4.13-29: error: %destructor redeclaration for +input.y:1.13-29: previous declaration +input.y:4.13-29: error: %destructor redeclaration for +input.y:4.13-29: previous declaration +input.y:5.10-24: error: %printer redeclaration for +input.y:2.10-24: previous declaration +input.y:5.10-24: error: %printer redeclaration for +input.y:5.10-24: previous declaration +input.y:11.13-29: error: %destructor redeclaration for +input.y:4.13-29: previous declaration +input.y:11.13-29: error: %destructor redeclaration for +input.y:1.13-29: previous declaration +input.y:12.10-24: error: %printer redeclaration for +input.y:2.10-24: previous declaration +input.y:12.10-24: error: %printer redeclaration for +input.y:5.10-24: previous declaration ]]) AT_CLEANUP @@ -257,18 +341,36 @@ AT_CLEANUP AT_SETUP([Unused values with default %destructor]) AT_DATA([[input.y]], -[[%destructor { destroy ($$); } %symbol-default +[[%destructor { destroy ($$); } <> +%type tagged %% -start: end end { $1; } ; -end: { } ; +start: end end tagged tagged { $1; $3; } ; +end: { } ; +tagged: { } ; +]]) + +AT_BISON_CHECK([input.y], [0], [], +[[input.y:6.8-45: warning: unset value: $$ +input.y:6.8-45: warning: unused value: $2 +input.y:7.6-8: warning: unset value: $$ +]]) + +AT_DATA([[input.y]], +[[%destructor { destroy ($$); } <*> +%type tagged + +%% + +start: end end tagged tagged { $1; $3; } ; +end: { } ; +tagged: { } ; ]]) -AT_CHECK([bison input.y], [0], [], -[[input.y:5.8-22: warning: unset value: $$ -input.y:5.8-22: warning: unused value: $2 -input.y:6.6-8: warning: unset value: $$ +AT_BISON_CHECK([input.y], [0], [], +[[input.y:6.8-45: warning: unused value: $4 +input.y:8.9-11: warning: unset value: $$ ]]) AT_CLEANUP @@ -290,7 +392,7 @@ start: end end { $1; } ; end: { } ; ]]) -AT_CHECK([bison input.y], [0], [], +AT_BISON_CHECK([input.y], [0], [], [[input.y:6.8-22: warning: unset value: $$ input.y:6.8-22: warning: unused value: $2 input.y:7.6-8: warning: unset value: $$ @@ -322,15 +424,15 @@ AT_DATA([input.y], exp: foo; ]]) -AT_CHECK([bison input.y], [1], [], -[[input.y:8.7-11: %type redeclaration for foo -input.y:3.7-11: previous declaration -input.y:10.13-17: %destructor redeclaration for foo -input.y:5.13-17: previous declaration -input.y:9.10-14: %printer redeclaration for foo -input.y:4.10-14: previous declaration -input.y:11.1-5: %left redeclaration for foo -input.y:6.1-5: previous declaration +AT_BISON_CHECK([input.y], [1], [], +[[input.y:8.7-11: error: %type redeclaration for foo +input.y:3.7-11: previous declaration +input.y:10.13-17: error: %destructor redeclaration for foo +input.y:5.13-17: previous declaration +input.y:9.10-14: error: %printer redeclaration for foo +input.y:4.10-14: previous declaration +input.y:11.1-5: error: %left redeclaration for foo +input.y:6.1-5: previous declaration ]]) AT_CLEANUP @@ -346,18 +448,18 @@ AT_CLEANUP AT_SETUP([Torturing the Scanner]) - +AT_BISON_OPTION_PUSHDEFS AT_DATA([input.y], []) -AT_CHECK([bison input.y], [1], [], -[[input.y:1.1: syntax error, unexpected end of file +AT_BISON_CHECK([input.y], [1], [], +[[input.y:1.1: error: syntax error, unexpected end of file ]]) AT_DATA([input.y], [{} ]) -AT_CHECK([bison input.y], [1], [], -[[input.y:1.1-2: syntax error, unexpected {...} +AT_BISON_CHECK([input.y], [1], [], +[[input.y:1.1-2: error: syntax error, unexpected {...} ]]) @@ -396,6 +498,8 @@ char apostrophe = '\''; #endif #include +#include +#include %} /* %{ and %} can be here too. */ @@ -422,8 +526,8 @@ char quote[] = "@:>@@:>@,"; %} %{ -static void yyerror (const char *s); -static int yylex (void); +]AT_YYERROR_DECLARE[ +]AT_YYLEX_DECLARE[ %} %type '@<:@' @@ -455,25 +559,21 @@ value_as_yystype (value val) res.ival = val; return res; } - +]AT_YYERROR_DEFINE[ static int yylex (void) { - static const char *input = "@<:@\1\2$@{@oline@__@&t@oline__\ + static char const input[] = "@<:@\1\2$@{@oline@__@&t@oline__\ #output "; /* " */ - yylval = value_as_yystype (*input); - return *input++; -} - -static void -yyerror (const char *msg) -{ - fprintf (stderr, "%s\n", msg); + static size_t toknum; + assert (toknum < sizeof input); + yylval = value_as_yystype (input[toknum]); + return input[toknum++]; } ]]) -# Pacify Emacs'font-lock-mode: " +# Pacify Emacs' font-lock-mode: " AT_DATA([main.c], [[typedef int value; @@ -487,10 +587,11 @@ main (void) return yyparse (); } ]]) +AT_BISON_OPTION_POPDEFS -AT_CHECK([bison -d -v -o input.c input.y]) -AT_COMPILE([input.o], [-c input.c]) -AT_COMPILE([main.o], [-c main.c]) +AT_BISON_CHECK([-d -v -o input.c input.y]) +AT_COMPILE([input.o]) +AT_COMPILE([main.o]) AT_COMPILE([input], [input.o main.o]) AT_PARSER_CHECK([./input], 0, [[[@<:@], @@ -519,7 +620,7 @@ exp: "MY TOKEN"; %% ]]) -AT_CHECK([bison -o input.c input.y]) +AT_BISON_CHECK([-o input.c input.y]) AT_CLEANUP @@ -535,7 +636,7 @@ AT_DATA_GRAMMAR([input.y], %% empty_file:; ]]) -AT_CHECK([bison -o input.c input.y], $2, [], ignore) +AT_BISON_CHECK([-o input.c input.y], $2, [], ignore) AT_CLEANUP ]) @@ -561,7 +662,111 @@ start: 'a'; %% ]]) -AT_CHECK([bison -o input.c input.y]) +AT_BISON_CHECK([-o input.c input.y]) + +AT_CLEANUP + + +## -------------- ## +## Symbol names. ## +## -------------- ## + +AT_SETUP([Symbols]) + +AT_BISON_OPTION_PUSHDEFS +AT_DATA_GRAMMAR([input.y], +[[%token WITH-DASH +%token WITHOUT_DASH "WITHOUT-DASH" +%token WITH.PERIOD +%token WITHOUT_PERIOD "WITHOUT.PERIOD" +%code { + ]AT_YYERROR_DECLARE[ + ]AT_YYLEX_DECLARE[ +} +%% +start: with-dash without_dash with.period without_period; +with-dash: WITH-DASH; +without_dash: "WITHOUT-DASH"; +with.period: WITH.PERIOD; +without_period: "WITHOUT.PERIOD"; +%% +]AT_YYERROR_DEFINE[ +]AT_YYLEX_DEFINE[ +]]) +AT_BISON_OPTION_POPDEFS + +# POSIX Yacc accept periods, but not dashes. +AT_BISON_CHECK([--yacc input.y], [1], [], +[[input.y:9.8-16: POSIX Yacc forbids dashes in symbol names: WITH-DASH +input.y:18.8-16: POSIX Yacc forbids dashes in symbol names: with-dash +]]) + +# So warn about them. +AT_BISON_CHECK([-Wyacc input.y], [], [], +[[input.y:9.8-16: warning: POSIX Yacc forbids dashes in symbol names: WITH-DASH +input.y:18.8-16: warning: POSIX Yacc forbids dashes in symbol names: with-dash +]]) + +# Dashes are fine for GNU Bison. +AT_BISON_CHECK([-o input.c input.y]) + +# Make sure we don't export silly token identifiers with periods or dashes. +AT_COMPILE([input.o]) + + +# Periods are genuine letters, they can start identifiers. +# Digits and dashes cannot. +AT_DATA_GRAMMAR([input.y], +[[%token .GOOD + -GOOD + 1NV4L1D + -123 +%% +start: .GOOD GOOD +]]) +AT_BISON_CHECK([-o input.c input.y], [1], [], +[[input.y:10.10: error: invalid character: '-' +input.y:11.10-16: error: invalid identifier: '1NV4L1D' +input.y:12.10: error: invalid character: '-' +]]) + +AT_CLEANUP + + +## ----------------- ## +## Numbered tokens. ## +## ----------------- ## + +AT_SETUP([Numbered tokens]) + +AT_DATA_GRAMMAR([redecl.y], +[[%token DECIMAL_1 11259375 + HEXADECIMAL_1 0xabcdef + HEXADECIMAL_2 0xFEDCBA + DECIMAL_2 16702650 +%% +start: DECIMAL_1 HEXADECIMAL_2; +]]) + +AT_BISON_CHECK([redecl.y], [1], [], +[[redecl.y:10.10-22: error: user token number 11259375 redeclaration for HEXADECIMAL_1 +redecl.y:9.8-16: previous declaration for DECIMAL_1 +redecl.y:12.10-18: error: user token number 16702650 redeclaration for DECIMAL_2 +redecl.y:11.10-22: previous declaration for HEXADECIMAL_2 +]]) + +AT_DATA_GRAMMAR([too-large.y], +[[%token TOO_LARGE_DEC 999999999999999999999 + TOO_LARGE_HEX 0xFFFFFFFFFFFFFFFFFFF +%% +start: TOO_LARGE_DEC TOO_LARGE_HEX +%% +]]) + +AT_BISON_CHECK([too-large.y], [1], [], +[[too-large.y:9.22-42: error: integer out of range: '999999999999999999999' +too-large.y:10.24-44: error: integer out of range: '0xFFFFFFFFFFFFFFFFFFF' +]]) AT_CLEANUP @@ -599,13 +804,32 @@ start: ; %destructor { free ($$) ]]) -AT_CHECK([bison -o input.c input.y], 1, [], -[[input.y:1.10-2.0: missing `"' at end of line -input.y:4.10-5.0: missing `'' at end of line -input.y:14.11-15.0: missing `'' at end of line -input.y:16.11-17.0: missing `"' at end of line -input.y:19.13-20.0: missing `}' at end of file -input.y:20.1: syntax error, unexpected end of file +AT_BISON_CHECK([-o input.c input.y], 1, [], +[[input.y:1.10-2.0: error: missing '"' at end of line +input.y:4.10-5.0: error: missing "'" at end of line +input.y:14.11-15.0: error: missing "'" at end of line +input.y:16.11-17.0: error: missing '"' at end of line +input.y:19.13-20.0: error: missing '}' at end of file +input.y:20.1: error: syntax error, unexpected end of file +]]) + +AT_BISON_CHECK([-fcaret -o input.c input.y], 1, [], +[[input.y:1.10-2.0: error: missing '"' at end of line + %token A "a + ^^ +input.y:4.10-5.0: error: missing "'" at end of line + %token C '1 + ^^ +input.y:14.11-15.0: error: missing "'" at end of line + %type 'a + ^^ +input.y:16.11-17.0: error: missing '"' at end of line + %type "a + ^^ +input.y:19.13-20.0: error: missing '}' at end of file + %destructor { free ($$) + ^^^^^^^^^^^ +input.y:20.1: error: syntax error, unexpected end of file ]]) AT_CLEANUP @@ -627,6 +851,707 @@ start: false_start ; %start start; ]]) -AT_CHECK([bison -o input.c input.y]) +AT_BISON_CHECK([-o input.c input.y]) + +AT_CLEANUP + + +## --------------------- ## +## %prec takes a token. ## +## --------------------- ## + +AT_SETUP([%prec takes a token]) + +# Bison once allowed %prec sym where sym was a nonterminal. + +AT_DATA([input.y], +[[%% +start: PREC %prec PREC ; +PREC: ; +]]) + +AT_BISON_CHECK([input.y], [1], [], +[[input.y:3.1-4: error: rule given for PREC, which is a token +]]) + +AT_CLEANUP + + +## ------------------------------- ## +## %prec's token must be defined. ## +## ------------------------------- ## + +AT_SETUP([[%prec's token must be defined]]) + +# According to POSIX, a %prec token must be defined separately. + +AT_DATA([[input.y]], +[[%% +start: %prec PREC ; +]]) + +AT_BISON_CHECK([[input.y]], [[0]], [], +[[input.y:2.8-17: warning: token for %prec is not defined: PREC +]]) + +AT_CLEANUP + + +## -------------------------------- ## +## Reject unused %code qualifiers. ## +## -------------------------------- ## + +AT_SETUP([Reject unused %code qualifiers]) + +AT_DATA([input-c.y], +[[%code q {} +%code bad {} +%code bad {} +%code format {} +%% +start: ; +]]) +AT_BISON_CHECK([[input-c.y]], [[1]], [], +[[input-c.y:1.7: error: %code qualifier 'q' is not used +input-c.y:2.7-9: error: %code qualifier 'bad' is not used +input-c.y:3.7-9: error: %code qualifier 'bad' is not used +input-c.y:4.7-12: error: %code qualifier 'format' is not used +]]) + +AT_DATA([input-c-glr.y], +[[%code q {} +%code bad {} + %code bad {} +%% +start: ; +]]) +AT_BISON_CHECK([[input-c-glr.y]], [[1]], [], +[[input-c-glr.y:1.7: error: %code qualifier 'q' is not used +input-c-glr.y:2.7-9: error: %code qualifier 'bad' is not used +input-c-glr.y:3.8-10: error: %code qualifier 'bad' is not used +]]) + +AT_DATA([input-c++.y], +[[%code q {} +%code bad {} + %code q {} +%% +start: ; +]]) +AT_BISON_CHECK([[input-c++.y]], [[1]], [], +[[input-c++.y:1.7: error: %code qualifier 'q' is not used +input-c++.y:2.7-9: error: %code qualifier 'bad' is not used +input-c++.y:3.8: error: %code qualifier 'q' is not used +]]) + +AT_DATA([input-c++-glr.y], +[[%code bad {} +%code q {} +%code q {} +%% +start: ; +]]) +AT_BISON_CHECK([[input-c++-glr.y]], [[1]], [], +[[input-c++-glr.y:1.7-9: error: %code qualifier 'bad' is not used +input-c++-glr.y:2.7: error: %code qualifier 'q' is not used +input-c++-glr.y:3.7: error: %code qualifier 'q' is not used +]]) + +AT_DATA([special-char-@@.y], +[[%code bad {} +%code q {} +%code q {} +%% +start: ; +]]) +AT_BISON_CHECK([[special-char-@@.y]], [[1]], [], +[[special-char-@@.y:1.7-9: error: %code qualifier 'bad' is not used +special-char-@@.y:2.7: error: %code qualifier 'q' is not used +special-char-@@.y:3.7: error: %code qualifier 'q' is not used +]]) + +AT_DATA([special-char-@:>@.y], +[[%code bad {} +%code q {} +%code q {} +%% +start: ; +]]) +AT_BISON_CHECK([[special-char-@:>@.y]], [[1]], [], +[[special-char-@:>@.y:1.7-9: error: %code qualifier 'bad' is not used +special-char-@:>@.y:2.7: error: %code qualifier 'q' is not used +special-char-@:>@.y:3.7: error: %code qualifier 'q' is not used +]]) + +AT_CLEANUP + + +## ---------------- ## +## %define errors. ## +## ---------------- ## + +AT_SETUP([%define errors]) + +AT_DATA([input-redefined.y], +[[%define var "value1" +%define var "value1" + %define var "value2" +%define special1 "@:>@" +%define special2 "@<:@" +%% +start: ; +]]) + +AT_BISON_CHECK([[input-redefined.y]], [[1]], [], +[[input-redefined.y:2.9-11: error: %define variable 'var' redefined +input-redefined.y:1.9-11: previous definition +input-redefined.y:3.10-12: error: %define variable 'var' redefined +input-redefined.y:2.9-11: previous definition +]]) + +AT_DATA([input-unused.y], +[[%define var "value" +%% +start: ; +]]) + +AT_BISON_CHECK([[input-unused.y]], [[1]], [], +[[input-unused.y:1.9-11: error: %define variable 'var' is not used +]]) + +AT_CLEANUP + + +## ----------------------------------- ## +## %define, --define, --force-define. ## +## ----------------------------------- ## + +AT_SETUP([[%define, --define, --force-define]]) + +AT_DATA([[skel.c]], +[[m4@&t@_divert_push(0)@ +@output(b4_parser_file_name@)@ +[var-dd: ]b4_percent_define_get([[var-dd]])[ +var-ff: ]b4_percent_define_get([[var-ff]])[ +var-dfg: ]b4_percent_define_get([[var-dfg]])[ +var-fd: ]b4_percent_define_get([[var-fd]]) +m4@&t@_divert_pop(0) +]]) +AT_DATA([[input.y]], +[[%define var-dfg "gram" +%% +start: ; +]]) +AT_BISON_CHECK([[-Dvar-dd=cmd-d1 -Dvar-dd=cmd-d2 \ + -Fvar-ff=cmd-f1 -Fvar-ff=cmd-f2 \ + -Dvar-dfg=cmd-d -Fvar-dfg=cmd-f \ + -Fvar-fd=cmd-f -Dvar-fd=cmd-d \ + --skeleton ./skel.c input.y]]) +AT_CHECK([[cat input.tab.c]], [[0]], +[[var-dd: cmd-d2 +var-ff: cmd-f2 +var-dfg: cmd-f +var-fd: cmd-d +]]) + +AT_DATA([[input-dg.y]], +[[%define var "gram" +%% +start: ; +]]) +AT_BISON_CHECK([[-Dvar=cmd-d input-dg.y]], [[1]], [], +[[input-dg.y:1.9-11: error: %define variable 'var' redefined +:1: previous definition +]]) + +AT_DATA([[input-dg.y]], +[[%define var "gram" +%% +start: ; +]]) +AT_BISON_CHECK([[-fcaret -Dvar=cmd-d input-dg.y]], [[1]], [], +[[input-dg.y:1.9-11: error: %define variable 'var' redefined + %define var "gram" + ^^^ +:2: previous definition +]]) + +AT_DATA([[input-unused.y]], +[[%% +start: ; +]]) +AT_BISON_CHECK([[-Dunused-d -Funused-f input-unused.y]], [[1]], [], +[[:1: error: %define variable 'unused-d' is not used +:2: error: %define variable 'unused-f' is not used +]]) + +AT_CLEANUP + +## --------------------------- ## +## %define Boolean variables. ## +## --------------------------- ## + +AT_SETUP([[%define Boolean variables]]) + +AT_DATA([Input.y], +[[%language "Java" +%define public "maybe" +%define parser_class_name "Input" +%% +start: ; +]]) + +AT_BISON_CHECK([[Input.y]], [1], [], +[[Input.y:2.9-14: error: invalid value for %define Boolean variable 'public' +]]) + +AT_CLEANUP + +## ------------------------ ## +## %define enum variables. ## +## ------------------------ ## + +AT_SETUP([[%define enum variables]]) + +# Front-end. +AT_DATA([[input.y]], +[[%define lr.default-reductions bogus +%% +start: ; +]]) +AT_BISON_CHECK([[input.y]], [[1]], [[]], +[[input.y:1.9-29: error: invalid value for %define variable 'lr.default-reductions': 'bogus' +input.y:1.9-29: accepted value: 'most' +input.y:1.9-29: accepted value: 'consistent' +input.y:1.9-29: accepted value: 'accepting' +]]) + +# Back-end. +# FIXME: these should be indented, but we shouldn't mess with the m4 yet +AT_DATA([[input.y]], +[[%define api.push-pull neither +%% +start: ; +]]) +AT_BISON_CHECK([[input.y]], [1], [], +[[input.y:1.9-21: error: invalid value for %define variable 'api.push-pull': 'neither' +input.y:1.9-21: error: accepted value: 'pull' +input.y:1.9-21: error: accepted value: 'push' +input.y:1.9-21: error: accepted value: 'both' +]]) + +AT_CLEANUP + +## -------------------------------- ## +## %define backward compatibility. ## +## -------------------------------- ## + +AT_SETUP([[%define backward compatibility]]) + +# The error messages tell us whether underscores in these variables are +# being converted to dashes. + +AT_DATA([[input.y]], +[[%define api.push_pull "neither" +%% +start: ; +]]) +AT_BISON_CHECK([[input.y]], [1], [], +[[input.y:1.9-21: error: invalid value for %define variable 'api.push-pull': 'neither' +input.y:1.9-21: error: accepted value: 'pull' +input.y:1.9-21: error: accepted value: 'push' +input.y:1.9-21: error: accepted value: 'both' +]]) + +AT_DATA([[input.y]], +[[%define lr.keep_unreachable_states maybe +%% +start: ; +]]) +AT_BISON_CHECK([[input.y]], [1], [], +[[input.y:1.9-34: error: invalid value for %define Boolean variable 'lr.keep-unreachable-states' +]]) + +AT_DATA([[input.y]], +[[%define foo_bar "baz" +%% +start: ; +]]) +AT_BISON_CHECK([[input.y]], [[1]], [], +[[input.y:1.9-15: error: %define variable 'foo_bar' is not used +]]) + +AT_CLEANUP + +## ------------------------- ## +## Unused %define api.pure. ## +## ------------------------- ## + +AT_SETUP([[Unused %define api.pure]]) + +# AT_CHECK_API_PURE(DECLS, VALUE) +# ------------------------------- +# Make sure Bison reports that `%define api.pure VALUE' is unused when DECLS +# are specified. +m4_define([AT_CHECK_API_PURE], +[ +AT_DATA([[input.y]], +[[%define api.pure ]$2[ +]$1[ +%% +start: ; +]]) + +AT_BISON_CHECK([[input.y]], [[1]], [], +[[input.y:1.9-16: error: %define variable 'api.pure' is not used +]]) +]) + +AT_CHECK_API_PURE([[%language "c++" %defines]], [[]]) +AT_CHECK_API_PURE([[%language "c++" %defines]], [[false]]) +AT_CHECK_API_PURE([[%language "c++" %defines %glr-parser]], [[""]]) +AT_CHECK_API_PURE([[%language "c++" %defines %glr-parser]], [[false]]) +AT_CHECK_API_PURE([[%language "java"]], [[true]]) +AT_CHECK_API_PURE([[%language "java"]], [[false]]) + +AT_CLEANUP + +## -------------------------------- ## +## C++ namespace reference errors. ## +## -------------------------------- ## + +AT_SETUP([[C++ namespace reference errors]]) + +# AT_CHECK_NAMESPACE_ERROR(NAMESPACE-DECL, ERROR, [ERROR], ...) +# ------------------------------------------------------------- +# Make sure Bison reports all ERROR's for %define namespace "NAMESPACE-DECL". +m4_define([AT_CHECK_NAMESPACE_ERROR], +[ +AT_DATA([[input.y]], +[[%language "C++" +%defines +%define namespace "]$1[" +%% +start: ; +]]) + +AT_BISON_CHECK([[input.y]], [1], [], +[m4_foreach([b4_arg], m4_dquote(m4_shift($@)), +[[input.y:3.9-17: error: ]b4_arg[ +]])]) +]) + +AT_CHECK_NAMESPACE_ERROR([[]], + [[namespace reference is empty]]) +AT_CHECK_NAMESPACE_ERROR([[ ]], + [[namespace reference is empty]]) +AT_CHECK_NAMESPACE_ERROR([[foo::::bar]], + [[namespace reference has consecutive "::"]]) +AT_CHECK_NAMESPACE_ERROR([[foo:: ::bar]], + [[namespace reference has consecutive "::"]]) +AT_CHECK_NAMESPACE_ERROR([[::::bar]], + [[namespace reference has consecutive "::"]]) +AT_CHECK_NAMESPACE_ERROR([[:: ::bar]], + [[namespace reference has consecutive "::"]]) +AT_CHECK_NAMESPACE_ERROR([[foo::bar:: ::]], + [[namespace reference has consecutive "::"]], + [[namespace reference has a trailing "::"]]) +AT_CHECK_NAMESPACE_ERROR([[foo::bar::]], + [[namespace reference has a trailing "::"]]) +AT_CHECK_NAMESPACE_ERROR([[foo::bar:: ]], + [[namespace reference has a trailing "::"]]) +AT_CHECK_NAMESPACE_ERROR([[::]], + [[namespace reference has a trailing "::"]]) + +AT_CLEANUP + +## ------------------------ ## +## Bad character literals. ## +## ------------------------ ## + +# Bison used to accept character literals that were empty or contained +# too many characters. + +# FIXME: AT_DATA or some variant of AT_DATA may eventually permit +# the final newline to be omitted. See the threads starting at +# . + +AT_SETUP([[Bad character literals]]) + +AT_DATA([empty.y], +[[%% +start: ''; +start: ' +]]) +AT_CHECK([[$PERL -e "print 'start: \'';" >> empty.y || exit 77]]) + +AT_BISON_CHECK([empty.y], [1], [], +[[empty.y:2.8-9: warning: empty character literal +empty.y:3.8-4.0: warning: empty character literal +empty.y:3.8-4.0: error: missing "'" at end of line +empty.y:4.8: warning: empty character literal +empty.y:4.8: error: missing "'" at end of file +]]) + +AT_DATA([two.y], +[[%% +start: 'ab'; +start: 'ab +]]) +AT_CHECK([[$PERL -e "print 'start: \'ab';" >> two.y || exit 77]]) + +AT_BISON_CHECK([two.y], [1], [], +[[two.y:2.8-11: warning: extra characters in character literal +two.y:3.8-4.0: warning: extra characters in character literal +two.y:3.8-4.0: error: missing "'" at end of line +two.y:4.8-10: warning: extra characters in character literal +two.y:4.8-10: error: missing "'" at end of file +]]) + +AT_DATA([three.y], +[[%% +start: 'abc'; +start: 'abc +]]) +AT_CHECK([[$PERL -e "print 'start: \'abc';" >> three.y || exit 77]]) + +AT_BISON_CHECK([three.y], [1], [], +[[three.y:2.8-12: warning: extra characters in character literal +three.y:3.8-4.0: warning: extra characters in character literal +three.y:3.8-4.0: error: missing "'" at end of line +three.y:4.8-11: warning: extra characters in character literal +three.y:4.8-11: error: missing "'" at end of file +]]) + +AT_CLEANUP + +## ------------------------- ## +## Bad escapes in literals. ## +## ------------------------- ## + +AT_SETUP([[Bad escapes in literals]]) + +AT_DATA([input.y], +[[%% +start: '\777' '\0' '\xfff' '\x0' + '\uffff' '\u0000' '\Uffffffff' '\U00000000' + '\ ' '\A'; +]]) + +# It is not easy to create special characters, we cannot even trust tr. +# Beside we cannot even expect "echo '\0'" to output two characters +# (well three with \n): at least Bash 3.2 converts the two-character +# sequence "\0" into a single NUL character. +AT_CHECK([[$PERL -e 'print "start: \"\\\t\\\f\\\0\\\1\" ;";' >> input.y \ + || exit 77]]) + +AT_BISON_CHECK([input.y], [1], [], +[[input.y:2.9-12: error: invalid number after \-escape: 777 +input.y:2.8-13: warning: empty character literal +input.y:2.16-17: error: invalid number after \-escape: 0 +input.y:2.15-18: warning: empty character literal +input.y:2.21-25: error: invalid number after \-escape: xfff +input.y:2.20-26: warning: empty character literal +input.y:2.29-31: error: invalid number after \-escape: x0 +input.y:2.28-32: warning: empty character literal +input.y:3.9-14: error: invalid number after \-escape: uffff +input.y:3.8-15: warning: empty character literal +input.y:3.18-23: error: invalid number after \-escape: u0000 +input.y:3.17-24: warning: empty character literal +input.y:3.27-36: error: invalid number after \-escape: Uffffffff +input.y:3.26-37: warning: empty character literal +input.y:3.40-49: error: invalid number after \-escape: U00000000 +input.y:3.39-50: warning: empty character literal +input.y:4.9-10: error: invalid character after \-escape: ' ' +input.y:4.8-11: warning: empty character literal +input.y:4.14-15: error: invalid character after \-escape: A +input.y:4.13-16: warning: empty character literal +input.y:5.9-16: error: invalid character after \-escape: \t +input.y:5.17: error: invalid character after \-escape: \f +input.y:5.18: error: invalid character after \-escape: \0 +input.y:5.19: error: invalid character after \-escape: \001 +]]) + +AT_CLEANUP + +## ------------------------- ## +## LAC: Errors for %define. ## +## ------------------------- ## + +AT_SETUP([[LAC: Errors for %define]]) + +AT_DATA([[input.y]], +[[%% +start: ; +]]) + +# parse.lac.* options are useless if LAC isn't actually activated. +AT_BISON_CHECK([[-Dparse.lac.es-capacity-initial=1 input.y]], + [[1]], [], +[[:1: error: %define variable 'parse.lac.es-capacity-initial' is not used +]]) +AT_BISON_CHECK([[-Dparse.lac.memory-trace=full input.y]], + [[1]], [], +[[:1: error: %define variable 'parse.lac.memory-trace' is not used +]]) + +AT_CLEANUP + +## --------------------------------------------- ## +## -Werror is not affected by -Wnone and -Wall. ## +## --------------------------------------------- ## + +AT_SETUP([[-Werror is not affected by -Wnone and -Wall]]) + +AT_DATA([[input.y]], +[[%% +foo-bar: ; +]]) + +# -Werror is not enabled by -Wall or equivalent. +AT_BISON_CHECK([[-Wall input.y]], [[0]], [[]], +[[input.y:2.1-7: warning: POSIX Yacc forbids dashes in symbol names: foo-bar +]]) +AT_BISON_CHECK([[-W input.y]], [[0]], [[]], +[[input.y:2.1-7: warning: POSIX Yacc forbids dashes in symbol names: foo-bar +]]) +AT_BISON_CHECK([[-Wno-none input.y]], [[0]], [[]], +[[input.y:2.1-7: warning: POSIX Yacc forbids dashes in symbol names: foo-bar +]]) + +# -Werror is not disabled by -Wnone or equivalent. +AT_BISON_CHECK([[-Werror,none,yacc input.y]], [[1]], [[]], [[stderr]]) +AT_CHECK([[sed 's/^.*bison:/bison:/' stderr]], [[0]], +[[bison: warnings being treated as errors +input.y:2.1-7: warning: POSIX Yacc forbids dashes in symbol names: foo-bar +]]) +[mv stderr experr] +AT_BISON_CHECK([[-Werror,no-all,yacc input.y]], [[1]], [[]], [[experr]]) + +AT_CLEANUP + + +## ------------------------------------------------------ ## +## %name-prefix and %define api.prefix are incompatible. ## +## ------------------------------------------------------ ## + +AT_SETUP([[%name-prefix and %define api.prefix are incompatible]]) + +# AT_TEST(DIRECTIVES, OPTIONS, ERROR-LOCATION) +# -------------------------------------------- +m4_pushdef([AT_TEST], +[AT_DATA([[input.y]], +[[$1 +%% +exp:; +]]) +AT_BISON_CHECK([[$2 input.y]], [[1]], [[]], +[[$3: error: '%name-prefix' and '%define api.prefix' cannot be used together +]]) +]) + +AT_TEST([%define api.prefix foo %name-prefix "bar"], [], [input.y:1.9-18]) +AT_TEST([], [-Dapi.prefix=foo -p bar], [:1]) +AT_TEST([%name-prefix "bar"], [-Dapi.prefix=foo], [:1]) +AT_TEST([%define api.prefix foo], [-p bar], [input.y:1.9-18]) + +m4_popdef([AT_TEST]) + +AT_CLEANUP + + +## -------------- ## +## Stray $ or @. ## +## -------------- ## + +AT_SETUP([[Stray $ or @]]) + +# Give %printer and %destructor "<*> exp TOK" instead of "<*>" to +# check that the warnings are reported once, not three times. + +AT_DATA_GRAMMAR([[input.y]], +[[%token TOK +%destructor { $%; @%; } <*> exp TOK; +%initial-action { $%; @%; }; +%printer { $%; @%; } <*> exp TOK; +%% +exp: TOK { $%; @%; $$ = $1; }; +]]) + +AT_BISON_CHECK([[input.y]], 0, [], +[[input.y:10.19: warning: stray '$' +input.y:10.23: warning: stray '@' +input.y:11.19: warning: stray '$' +input.y:11.23: warning: stray '@' +input.y:12.19: warning: stray '$' +input.y:12.23: warning: stray '@' +input.y:14.19: warning: stray '$' +input.y:14.23: warning: stray '@' +]]) + +AT_CLEANUP + + + +## ---------------- ## +## Code injection. ## +## ---------------- ## + + +AT_SETUP([[Code injection]]) + +m4_pattern_allow([^m4_errprintn$]) + +# AT_TEST([MACRO]) +# ---------------- +# Try to have MACRO be run by bison. +m4_pushdef([AT_TEST], +[AT_DATA([[input.y]], +[[%type <$1(DEAD %type)> exp +%token <$1(DEAD %token)> a +%initial-action +{ + $$; + $<$1(DEAD %initial-action)>$ +}; +%printer +{ + $$ + $<$1(DEAD %printer)>$ +} <> <*>; +%lex-param +{ + $1(DEAD %lex-param) +}; +%parse-param +{ + $1(DEAD %parse-param) +}; +%% +exp: + a a[last] + { + $$; + $][1; + $<$1(DEAD action 1)>$ + $<$1(DEAD action 2)>1 + $<$1(DEAD action 3)>last + $<$1(DEAD action 4)>0 + ; + }; +]]) + +# FIXME: Provide a means to iterate over all the skeletons. +AT_BISON_CHECK([[-d input.y]]) +AT_BISON_CHECK([[-d -S glr.c input.y]]) +AT_BISON_CHECK([[-d -S lalr1.cc input.y]]) +AT_BISON_CHECK([[-d -S glr.cc input.y]]) +AT_BISON_CHECK([[ -S lalr1.java input.y]]) +]) + +AT_TEST([m4_errprintn]) +AT_TEST([@:>@m4_errprintn]) + +m4_popdef([AT_TEST]) AT_CLEANUP