X-Git-Url: https://git.saurik.com/bison.git/blobdiff_plain/836dc3342b26ecd944bf3c91a9990f49f46ca9ef..465df9c65c7022a66e9cea7145b80886174e90af:/TODO?ds=sidebyside diff --git a/TODO b/TODO index 2907d992..e8509e3c 100644 --- a/TODO +++ b/TODO @@ -1,4 +1,17 @@ * Short term +** Graphviz display code thoughts +The code for the --graph option is over two files: print_graph, and +graphviz. I believe this is because Bison used to also produce VCG graphs, +but since this is no longer true, maybe we could consider these files for +fusion. + +Little effort factoring seems to have been given to factoring in these files, +and their print-xml and print counterpart. We would very much like to re-use +the pretty format of states from .output in the .dot + +Also, the underscore in print_graph.[ch] isn't very fitting considering +the dashes in the other filenames. + ** push-parser Check it too when checking the different kinds of parsers. And be sure to check that the initial-action is performed once per parsing. @@ -7,8 +20,28 @@ sure to check that the initial-action is performed once per parsing. b4_shared_declarations is no longer what it is. Make it b4_parser_declaration for instance. -** glr.cc: %defines -it should not be mandatory. +** yychar in lalr1.cc +There is a large difference bw maint and master on the handling of +yychar (which was removed in lalr1.cc). See what needs to be +back-ported. + + + /* User semantic actions sometimes alter yychar, and that requires + that yytoken be updated with the new translation. We take the + approach of translating immediately before every use of yytoken. + One alternative is translating here after every semantic action, + but that translation would be missed if the semantic action + invokes YYABORT, YYACCEPT, or YYERROR immediately after altering + yychar. In the case of YYABORT or YYACCEPT, an incorrect + destructor might then be invoked immediately. In the case of + YYERROR, subsequent parser actions might lead to an incorrect + destructor call or verbose syntax error message before the + lookahead is translated. */ + + /* Make sure we have latest lookahead translation. See comments at + user semantic actions for why this is necessary. */ + yytoken = yytranslate_ (yychar); + ** $ and others in epilogue A stray $ is a warning in the actions, but an error in the epilogue.