X-Git-Url: https://git.saurik.com/bison.git/blobdiff_plain/4a38e61393479c4c6006236205e42c9647a776ab..3a7456dd96820eea36e9f9656c7f5e29714f78d4:/src/LR0.c

diff --git a/src/LR0.c b/src/LR0.c
index ef5624d4..6910f3e0 100644
--- a/src/LR0.c
+++ b/src/LR0.c
@@ -30,7 +30,7 @@
 #include "complain.h"
 #include "closure.h"
 #include "LR0.h"
-
+#include "reduce.h"
 
 int nstates;
 int final_state;
@@ -63,11 +63,13 @@ static void
 allocate_itemsets (void)
 {
   int i;
-  int count;
-  short *symbol_count = NULL;
 
-  count = 0;
-  symbol_count = XCALLOC (short, nsyms);
+  /* Count the number of occurrences of all the symbols in RITEMS.
+     Note that useless productions (hence useless nonterminals) are
+     browsed too, hence we need to allocate room for _all_ the
+     symbols.  */
+  int count = 0;
+  short *symbol_count = XCALLOC (short, nsyms + nuseless_nonterminals);
 
   for (i = 0; ritem[i]; ++i)
     if (ritem[i] > 0)
@@ -93,7 +95,7 @@ allocate_itemsets (void)
       count += symbol_count[i];
     }
 
-  shift_symbol = symbol_count;
+  free (symbol_count);
   kernel_size = XCALLOC (int, nsyms);
 }
 
@@ -112,13 +114,13 @@ allocate_storage (void)
 static void
 free_storage (void)
 {
-  XFREE (shift_symbol);
-  XFREE (redset);
-  XFREE (shiftset);
-  XFREE (kernel_base);
-  XFREE (kernel_size);
+  free (shift_symbol);
+  free (redset);
+  free (shiftset);
+  free (kernel_base);
+  free (kernel_size);
   XFREE (kernel_items);
-  XFREE (state_table);
+  free (state_table);
 }
 
 
@@ -148,6 +150,7 @@ new_itemsets (void)
   for (i = 0; i < nsyms; i++)
     kernel_size[i] = 0;
 
+  shift_symbol = XCALLOC (short, nsyms);
   shiftcount = 0;
 
   for (i = 0; i < itemsetsize; ++i)
@@ -311,19 +314,6 @@ new_states (void)
 }
 
 
-/*---------------------------------.
-| Create a new array of N shitfs.  |
-`---------------------------------*/
-
-static shifts *
-shifts_new (int n)
-{
-  shifts *res = SHIFTS_ALLOC (n);
-  res->nshifts = n;
-  return res;
-}
-
-
 /*------------------------------------------------------------.
 | Save the NSHIFTS of SHIFTSET into the current linked list.  |
 `------------------------------------------------------------*/
@@ -384,114 +374,110 @@ insert_start_shift (void)
 static void
 augment_automaton (void)
 {
-  int i;
-  int k;
   core *statep;
   shifts *sp;
-  shifts *sp2;
   shifts *sp1 = NULL;
 
   sp = first_shift;
 
-  if (sp)
+  if (!sp->nshifts)
     {
-      if (sp->number == 0)
-	{
-	  k = sp->nshifts;
-	  statep = first_state->next;
+      /* There are no shifts for any state.  Make one shift, from the
+	 initial state to the next-to-final state.  */
 
-	  /* The states reached by shifts from first_state are numbered 1...K.
-	     Look for one reached by start_symbol.  */
-	  while (statep->accessing_symbol < start_symbol
-		 && statep->number < k)
-	    statep = statep->next;
-
-	  if (statep->accessing_symbol == start_symbol)
-	    {
-	      /* We already have a next-to-final state.
-	         Make sure it has a shift to what will be the final state.  */
-	      k = statep->number;
+      sp = shifts_new (1);
+      sp->shifts[0] = nstates;
 
-	      while (sp && sp->number < k)
-		{
-		  sp1 = sp;
-		  sp = sp->next;
-		}
+      /* Initialize the chain of shifts with sp.  */
+      first_shift = sp;
+      last_shift = sp;
 
-	      if (sp && sp->number == k)
-		{
-		  sp2 = shifts_new (sp->nshifts + 1);
-		  sp2->number = k;
-		  sp2->shifts[0] = nstates;
-		  for (i = sp->nshifts; i > 0; i--)
-		    sp2->shifts[i] = sp->shifts[i - 1];
-
-		  /* Patch sp2 into the chain of shifts in place of sp,
-		     following sp1.  */
-		  sp2->next = sp->next;
-		  sp1->next = sp2;
-		  if (sp == last_shift)
-		    last_shift = sp2;
-		  XFREE (sp);
-		}
-	      else
-		{
-		  sp2 = shifts_new (1);
-		  sp2->number = k;
-		  sp2->shifts[0] = nstates;
-
-		  /* Patch sp2 into the chain of shifts between sp1 and sp.  */
-		  sp2->next = sp;
-		  sp1->next = sp2;
-		  if (sp == 0)
-		    last_shift = sp2;
-		}
-	    }
-	  else
-	    {
-	      /* There is no next-to-final state as yet.  */
-	      /* Add one more shift in first_shift,
-	         going to the next-to-final state (yet to be made).  */
-	      sp = first_shift;
+      /* Create the next-to-final state, with shift to
+         what will be the final state.  */
+      insert_start_shift ();
+    }
+  else if (sp->number == 0)
+    {
+      statep = first_state->next;
 
-	      sp2 = shifts_new (sp->nshifts + 1);
+      /* The states reached by shifts from FIRST_STATE are numbered
+	 1..(SP->NSHIFTS).  Look for one reached by START_SYMBOL.  */
+      while (statep->accessing_symbol < start_symbol
+	     && statep->number < sp->nshifts)
+	statep = statep->next;
 
-	      /* Stick this shift into the vector at the proper place.  */
-	      statep = first_state->next;
-	      for (k = 0, i = 0; i < sp->nshifts; k++, i++)
-		{
-		  if (statep->accessing_symbol > start_symbol && i == k)
-		    sp2->shifts[k++] = nstates;
-		  sp2->shifts[k] = sp->shifts[i];
-		  statep = statep->next;
-		}
-	      if (i == k)
-		sp2->shifts[k++] = nstates;
+      if (statep->accessing_symbol == start_symbol)
+	{
+	  /* We already have a next-to-final state.
+	     Make sure it has a shift to what will be the final state.  */
+	  while (sp && sp->number < statep->number)
+	    {
+	      sp1 = sp;
+	      sp = sp->next;
+	    }
 
-	      /* Patch sp2 into the chain of shifts
-	         in place of sp, at the beginning.  */
+	  if (sp && sp->number == statep->number)
+	    {
+	      int i;
+	      shifts *sp2 = shifts_new (sp->nshifts + 1);
+	      sp2->number = statep->number;
+	      sp2->shifts[0] = nstates;
+	      for (i = sp->nshifts; i > 0; i--)
+		sp2->shifts[i] = sp->shifts[i - 1];
+
+	      /* Patch sp2 into the chain of shifts in place of sp,
+		 following sp1.  */
 	      sp2->next = sp->next;
-	      first_shift = sp2;
-	      if (last_shift == sp)
+	      sp1->next = sp2;
+	      if (sp == last_shift)
 		last_shift = sp2;
-
 	      XFREE (sp);
-
-	      /* Create the next-to-final state, with shift to
-	         what will be the final state.  */
-	      insert_start_shift ();
+	    }
+	  else
+	    {
+	      shifts *sp2 = shifts_new (1);
+	      sp2->number = statep->number;
+	      sp2->shifts[0] = nstates;
+
+	      /* Patch sp2 into the chain of shifts between sp1 and sp.  */
+	      sp2->next = sp;
+	      sp1->next = sp2;
+	      if (sp == 0)
+		last_shift = sp2;
 	    }
 	}
       else
 	{
-	  /* The initial state didn't even have any shifts.
-	     Give it one shift, to the next-to-final state.  */
-	  sp = shifts_new (1);
-	  sp->shifts[0] = nstates;
+	  int i, k;
+	  shifts *sp2;
+
+	  /* There is no next-to-final state as yet.  */
+	  /* Add one more shift in first_shift,
+	     going to the next-to-final state (yet to be made).  */
+	  sp = first_shift;
+
+	  sp2 = shifts_new (sp->nshifts + 1);
+
+	  /* Stick this shift into the vector at the proper place.  */
+	  statep = first_state->next;
+	  for (k = 0, i = 0; i < sp->nshifts; k++, i++)
+	    {
+	      if (statep->accessing_symbol > start_symbol && i == k)
+		sp2->shifts[k++] = nstates;
+	      sp2->shifts[k] = sp->shifts[i];
+	      statep = statep->next;
+	    }
+	  if (i == k)
+	    sp2->shifts[k++] = nstates;
 
-	  /* Patch sp into the chain of shifts at the beginning.  */
-	  sp->next = first_shift;
-	  first_shift = sp;
+	  /* Patch sp2 into the chain of shifts
+	     in place of sp, at the beginning.  */
+	  sp2->next = sp->next;
+	  first_shift = sp2;
+	  if (last_shift == sp)
+	    last_shift = sp2;
+
+	  XFREE (sp);
 
 	  /* Create the next-to-final state, with shift to
 	     what will be the final state.  */
@@ -500,18 +486,17 @@ augment_automaton (void)
     }
   else
     {
-      /* There are no shifts for any state.
-         Make one shift, from the initial state to the next-to-final state.  */
-
+      /* The initial state didn't even have any shifts.
+	 Give it one shift, to the next-to-final state.  */
       sp = shifts_new (1);
       sp->shifts[0] = nstates;
 
-      /* Initialize the chain of shifts with sp.  */
+      /* Patch sp into the chain of shifts at the beginning.  */
+      sp->next = first_shift;
       first_shift = sp;
-      last_shift = sp;
 
       /* Create the next-to-final state, with shift to
-         what will be the final state.  */
+	 what will be the final state.  */
       insert_start_shift ();
     }
 
@@ -612,8 +597,7 @@ generate_states (void)
 
       /* create the shifts structures for the shifts to those states,
          now that the state numbers transitioning to are known */
-      if (nshifts > 0)
-	save_shifts ();
+      save_shifts ();
 
       /* states are queued when they are created; process them all */
       this_state = this_state->next;