X-Git-Url: https://git.saurik.com/bison.git/blobdiff_plain/45eebca42dbcc60074000828ec8422ef99d979f6..534497f54ba955ba2173ecb9eb8128b45c745b62:/src/muscle-tab.c diff --git a/src/muscle-tab.c b/src/muscle-tab.c index 8060a2c2..cc5d01df 100644 --- a/src/muscle-tab.c +++ b/src/muscle-tab.c @@ -28,6 +28,31 @@ #include "muscle-tab.h" #include "quote.h" +muscle_kind +muscle_kind_new (char const *k) +{ + if (STREQ (k, "code")) + return muscle_code; + else if (STREQ (k, "keyword")) + return muscle_keyword; + else if (STREQ (k, "string")) + return muscle_string; + aver (0); +} + +char const * +muscle_kind_string (muscle_kind k) +{ + switch (k) + { + case muscle_code: return "code"; + case muscle_keyword: return "keyword"; + case muscle_string: return "string"; + } + aver (0); +} + + /* A key-value pair, along with storage that can be reclaimed when this pair is no longer needed. */ typedef struct @@ -35,8 +60,21 @@ typedef struct char const *key; char const *value; char *storage; + muscle_kind kind; } muscle_entry; + +/* The name of muscle for the %define variable VAR (corresponding to + FIELD, if defined). */ +static uniqstr +muscle_name (char const *var, char const *field) +{ + if (field) + return UNIQSTR_CONCAT ("percent_define_", field, "(", var, ")"); + else + return UNIQSTR_CONCAT ("percent_define(", var, ")"); +} + /* An obstack used to create some entries. */ struct obstack muscle_obstack; @@ -60,10 +98,18 @@ hash_muscle (const void *x, size_t tablesize) return hash_string (m->key, tablesize); } -/*-----------------------------------------------------------------. -| Create the MUSCLE_TABLE, and initialize it with default values. | -| Also set up the MUSCLE_OBSTACK. | -`-----------------------------------------------------------------*/ +/* Create a fresh muscle name KEY, and insert in the hash table. */ +static void * +muscle_entry_new (char const *key) +{ + muscle_entry *res = xmalloc (sizeof *res); + res->key = key; + res->value = NULL; + res->storage = NULL; + if (!hash_insert (muscle_table, res)) + xalloc_die (); + return res; +} static void muscle_entry_free (void *entry) @@ -87,10 +133,6 @@ muscle_init (void) } -/*------------------------------------------------------------. -| Free all the memory consumed by the muscle machinery only. | -`------------------------------------------------------------*/ - void muscle_free (void) { @@ -98,71 +140,64 @@ muscle_free (void) obstack_free (&muscle_obstack, NULL); } +/* Look for the muscle named KEY. Return NULL if does not exist. */ +static +muscle_entry * +muscle_lookup (char const *key) +{ + muscle_entry probe; + probe.key = key; + return hash_lookup (muscle_table, &probe); +} -/*------------------------------------------------------------. -| Insert (KEY, VALUE). If KEY already existed, overwrite the | -| previous value. | -`------------------------------------------------------------*/ - void muscle_insert (char const *key, char const *value) { - muscle_entry probe; - muscle_entry *entry; - - probe.key = key; - entry = hash_lookup (muscle_table, &probe); - - if (!entry) - { - /* First insertion in the hash. */ - entry = xmalloc (sizeof *entry); - entry->key = key; - if (!hash_insert (muscle_table, entry)) - xalloc_die (); - } - else + muscle_entry *entry = muscle_lookup (key); + if (entry) free (entry->storage); + else + /* First insertion in the hash. */ + entry = muscle_entry_new (key); entry->value = value; entry->storage = NULL; } -/*-------------------------------------------------------------------. -| Append VALUE to the current value of KEY. If KEY did not already | -| exist, create it. Use MUSCLE_OBSTACK. De-allocate the previously | -| associated value. Copy VALUE and SEPARATOR. | -`-------------------------------------------------------------------*/ +/* Append VALUE to the current value of KEY. If KEY did not already + exist, create it. Use MUSCLE_OBSTACK. De-allocate the previously + associated value. Copy VALUE and SEPARATOR. If VALUE does not end + with TERMINATOR, append one. */ -void -muscle_grow (const char *key, const char *val, const char *separator) +static void +muscle_grow (const char *key, const char *val, + const char *separator, const char *terminator) { - muscle_entry probe; - muscle_entry *entry = NULL; + muscle_entry *entry = muscle_lookup (key); + size_t vals = strlen (val); + size_t terms = strlen (terminator); - probe.key = key; - entry = hash_lookup (muscle_table, &probe); - - if (!entry) - { - /* First insertion in the hash. */ - entry = xmalloc (sizeof *entry); - entry->key = key; - if (!hash_insert (muscle_table, entry)) - xalloc_die (); - entry->value = entry->storage = xstrdup (val); - } - else + if (entry) { - /* Grow the current value. */ - char *new_val; - obstack_printf (&muscle_obstack, "%s%s%s", entry->value, separator, val); + obstack_sgrow (&muscle_obstack, entry->value); + obstack_sgrow (&muscle_obstack, separator); free (entry->storage); - new_val = obstack_finish0 (&muscle_obstack); - entry->value = entry->storage = xstrdup (new_val); - obstack_free (&muscle_obstack, new_val); } + else + entry = muscle_entry_new (key); + + obstack_sgrow (&muscle_obstack, val); + + if (terms <= vals + && STRNEQ (val + vals - terms, terminator)) + obstack_sgrow (&muscle_obstack, terminator); + + { + char *new_val = obstack_finish0 (&muscle_obstack); + entry->value = entry->storage = xstrdup (new_val); + obstack_free (&muscle_obstack, new_val); + } } /*------------------------------------------------------------------. @@ -179,7 +214,7 @@ muscle_syncline_grow (char const *key, location loc) quotearg_style (c_quoting_style, loc.start.file)); obstack_sgrow (&muscle_obstack, ")["); extension = obstack_finish0 (&muscle_obstack); - muscle_grow (key, extension, ""); + muscle_grow (key, extension, "", ""); obstack_free (&muscle_obstack, extension); } @@ -193,12 +228,13 @@ void muscle_code_grow (const char *key, const char *val, location loc) { muscle_syncline_grow (key, loc); - muscle_grow (key, val, "\n"); + muscle_grow (key, val, "\n", "\n"); } -void muscle_pair_list_grow (const char *muscle, - const char *a1, const char *a2) +void +muscle_pair_list_grow (const char *muscle, + const char *a1, const char *a2) { char *pair; obstack_sgrow (&muscle_obstack, "["); @@ -207,48 +243,27 @@ void muscle_pair_list_grow (const char *muscle, obstack_quote (&muscle_obstack, a2); obstack_sgrow (&muscle_obstack, "]"); pair = obstack_finish0 (&muscle_obstack); - muscle_grow (muscle, pair, ",\n"); + muscle_grow (muscle, pair, ",\n", ""); obstack_free (&muscle_obstack, pair); } -/*----------------------------------------------------------------------------. -| Find the value of muscle KEY. Unlike MUSCLE_FIND, this is always reliable | -| to determine whether KEY has a value. | -`----------------------------------------------------------------------------*/ - char const * muscle_find_const (char const *key) { - muscle_entry probe; - muscle_entry *result = NULL; - - probe.key = key; - result = hash_lookup (muscle_table, &probe); - if (result) - return result->value; - return NULL; + muscle_entry *entry = muscle_lookup (key); + return entry ? entry->value : NULL; } -/*----------------------------------------------------------------------------. -| Find the value of muscle KEY. Abort if muscle_insert was invoked more | -| recently than muscle_grow for KEY since muscle_find can't return a | -| char const *. | -`----------------------------------------------------------------------------*/ - char * muscle_find (char const *key) { - muscle_entry probe; - muscle_entry *result = NULL; - - probe.key = key; - result = hash_lookup (muscle_table, &probe); - if (result) + muscle_entry *entry = muscle_lookup (key); + if (entry) { - aver (result->value == result->storage); - return result->storage; + aver (entry->value == entry->storage); + return entry->storage; } return NULL; } @@ -265,7 +280,7 @@ muscle_boundary_grow (char const *key, boundary bound) obstack_escape (&muscle_obstack, bound.file); obstack_printf (&muscle_obstack, ":%d.%d]]", bound.line, bound.column); extension = obstack_finish0 (&muscle_obstack); - muscle_grow (key, extension, ""); + muscle_grow (key, extension, "", ""); obstack_free (&muscle_obstack, extension); } @@ -278,7 +293,7 @@ static void muscle_location_grow (char const *key, location loc) { muscle_boundary_grow (key, loc.start); - muscle_grow (key, "", ", "); + muscle_grow (key, "", ", ", ""); muscle_boundary_grow (key, loc.end); } @@ -329,10 +344,9 @@ string_decode (char const *key) /* Reverse of muscle_location_grow. */ static location -location_decode (char const *key) +location_decode (char const *value) { location loc; - char const *value = muscle_find_const (key); aver (value); aver (*value == '['); aver (*++value == '['); @@ -377,11 +391,11 @@ void muscle_user_name_list_grow (char const *key, char const *user_name, location loc) { - muscle_grow (key, "[[[[", ","); - muscle_grow (key, user_name, ""); - muscle_grow (key, "]], ", ""); + muscle_grow (key, "[[[[", ",", ""); + muscle_grow (key, user_name, "", ""); + muscle_grow (key, "]], ", "", ""); muscle_location_grow (key, loc); - muscle_grow (key, "]]", ""); + muscle_grow (key, "]]", "", ""); } @@ -475,16 +489,17 @@ muscle_percent_variable_update (char const *variable, location variable_loc, void muscle_percent_define_insert (char const *var, location variable_loc, + muscle_kind kind, char const *value, muscle_percent_define_how how) { /* Backward compatibility. */ char *variable = muscle_percent_variable_update (var, variable_loc, &value); - char const *name = UNIQSTR_CONCAT ("percent_define(", variable, ")"); - char const *loc_name = UNIQSTR_CONCAT ("percent_define_loc(", variable, ")"); - char const *syncline_name = - UNIQSTR_CONCAT ("percent_define_syncline(", variable, ")"); - char const *how_name = UNIQSTR_CONCAT ("percent_define_how(", variable, ")"); + uniqstr name = muscle_name (variable, NULL); + uniqstr loc_name = muscle_name (variable, "loc"); + uniqstr syncline_name = muscle_name (variable, "syncline"); + uniqstr how_name = muscle_name (variable, "how"); + uniqstr kind_name = muscle_name (variable, "kind"); /* Command-line options are processed before the grammar file. */ if (how == MUSCLE_PERCENT_DEFINE_GRAMMAR_FILE @@ -510,6 +525,7 @@ muscle_percent_define_insert (char const *var, location variable_loc, muscle_user_name_list_grow ("percent_define_user_variables", variable, variable_loc); MUSCLE_INSERT_INT (how_name, how); + MUSCLE_INSERT_STRING (kind_name, muscle_kind_string (kind)); end: free (variable); } @@ -520,85 +536,120 @@ void muscle_percent_define_ensure (char const *variable, location loc, bool value) { + uniqstr name = muscle_name (variable, NULL); char const *val = value ? "" : "false"; - char const *name = UNIQSTR_CONCAT ("percent_define(", variable, ")"); - /* %pure-parser is deprecated in favor of '%define api.pure', so use - '%define api.pure' in a backward-compatible manner here. First, - don't complain if %pure-parser is specified multiple times. */ - if (!muscle_find_const (name)) - muscle_percent_define_insert (variable, loc, val, - MUSCLE_PERCENT_DEFINE_GRAMMAR_FILE); - /* In all cases, use api.pure now so that the backend doesn't complain if - the skeleton ignores api.pure, but do warn now if there's a previous - conflicting definition from an actual %define. */ - if (muscle_percent_define_flag_if (variable) != value) - muscle_percent_define_insert (variable, loc, val, + /* Don't complain is VARIABLE is already defined, but be sure to set + its value to VAL. */ + if (!muscle_find_const (name) + || muscle_percent_define_flag_if (variable) != value) + muscle_percent_define_insert (variable, loc, muscle_keyword, val, MUSCLE_PERCENT_DEFINE_GRAMMAR_FILE); } +/* Mark %define VARIABLE as used. */ +static void +muscle_percent_define_use (char const *variable) +{ + muscle_insert (muscle_name (variable, "bison_variables"), ""); +} + +/* The value of %define variable VARIABLE (corresponding to FIELD, if + defined). Do not register as used, but diagnose unset variables. */ + +static +char const * +muscle_percent_define_get_raw (char const *variable, char const *field) +{ + uniqstr name = muscle_name (variable, field); + char const *res = muscle_find_const (name); + if (!res) + complain (NULL, fatal, _("%s: undefined %%define variable %s"), + "muscle_percent_define_get_raw", quote (variable)); + return res; +} + char * muscle_percent_define_get (char const *variable) { - char const *name = UNIQSTR_CONCAT ("percent_define(", variable, ")"); - char const *usage_name = - UNIQSTR_CONCAT ("percent_define_bison_variables(", variable, ")"); + uniqstr name = muscle_name (variable, NULL); char *value = string_decode (name); if (!value) value = xstrdup (""); - - muscle_insert (usage_name, ""); + muscle_percent_define_use (variable); return value; } +/* The kind of VARIABLE. An error if undefined. */ +static muscle_kind +muscle_percent_define_get_kind (char const *variable) +{ + return muscle_kind_new (muscle_percent_define_get_raw (variable, "kind")); +} + +/* Check the kind of VARIABLE. An error if undefined. */ +static void +muscle_percent_define_check_kind (char const *variable, muscle_kind kind) +{ + if (muscle_percent_define_get_kind (variable) != kind) + { + location loc = muscle_percent_define_get_loc (variable); + switch (kind) + { + case muscle_code: + complain (&loc, Wdeprecated, + "%%define variable '%s' requires '{...}' values", + variable); + break; + case muscle_keyword: + complain (&loc, Wdeprecated, + "%%define variable '%s' requires keyword values", + variable); + break; + case muscle_string: + complain (&loc, Wdeprecated, + "%%define variable '%s' requires '\"...\"' values", + variable); + break; + } + } +} + + location muscle_percent_define_get_loc (char const *variable) { - char const *loc_name = UNIQSTR_CONCAT ("percent_define_loc(", variable, ")"); - if (!muscle_find_const (loc_name)) - complain (NULL, fatal, _("%s: undefined %%define variable %s"), - "muscle_percent_define_get_loc", quote (variable)); - return location_decode (loc_name); + return location_decode (muscle_percent_define_get_raw (variable, "loc")); } char const * muscle_percent_define_get_syncline (char const *variable) { - char const *syncline_name = - UNIQSTR_CONCAT ("percent_define_syncline(", variable, ")"); - char const *syncline = muscle_find_const (syncline_name); - if (!syncline) - complain (NULL, fatal, _("%s: undefined %%define variable %s"), - "muscle_percent_define_get_syncline", quote (variable)); - return syncline; + return muscle_percent_define_get_raw (variable, "syncline"); } bool muscle_percent_define_ifdef (char const *variable) { - char const *name = UNIQSTR_CONCAT ("percent_define(", variable, ")"); - char const *usage_name = - UNIQSTR_CONCAT ("percent_define_bison_variables(", variable, ")"); - char const *value = muscle_find_const (name); - if (value) + if (muscle_find_const (muscle_name (variable, NULL))) { - muscle_insert (usage_name, ""); + muscle_percent_define_use (variable); return true; } - - return false; + else + return false; } bool muscle_percent_define_flag_if (char const *variable) { - char const *invalid_boolean_name = - UNIQSTR_CONCAT ("percent_define_invalid_boolean(", variable, ")"); + uniqstr invalid_boolean_name = muscle_name (variable, "invalid_boolean"); bool result = false; if (muscle_percent_define_ifdef (variable)) { char *value = muscle_percent_define_get (variable); + muscle_percent_define_check_kind (variable, muscle_keyword); if (value[0] == '\0' || STREQ (value, "true")) result = true; else if (STREQ (value, "false")) @@ -623,20 +674,21 @@ muscle_percent_define_flag_if (char const *variable) void muscle_percent_define_default (char const *variable, char const *value) { - char const *name = UNIQSTR_CONCAT ("percent_define(", variable, ")"); - char const *loc_name = UNIQSTR_CONCAT ("percent_define_loc(", variable, ")"); - char const *syncline_name = - UNIQSTR_CONCAT ("percent_define_syncline(", variable, ")"); + uniqstr name = muscle_name (variable, NULL); if (!muscle_find_const (name)) { - location loc; MUSCLE_INSERT_STRING (name, value); - loc.start.file = loc.end.file = ""; - loc.start.line = loc.end.line = -1; - loc.start.column = loc.end.column = -1; - muscle_insert (loc_name, ""); - muscle_location_grow (loc_name, loc); - muscle_insert (syncline_name, ""); + MUSCLE_INSERT_STRING (muscle_name (variable, "kind"), "keyword"); + { + uniqstr loc_name = muscle_name (variable, "loc"); + location loc; + loc.start.file = loc.end.file = ""; + loc.start.line = loc.end.line = -1; + loc.start.column = loc.end.column = -1; + muscle_insert (loc_name, ""); + muscle_location_grow (loc_name, loc); + } + muscle_insert (muscle_name (variable, "syncline"), ""); } } @@ -646,8 +698,9 @@ muscle_percent_define_check_values (char const * const *values) for (; *values; ++values) { char const * const *variablep = values; - char const *name = UNIQSTR_CONCAT ("percent_define(", *variablep, ")"); + uniqstr name = muscle_name (*variablep, NULL); char *value = string_decode (name); + muscle_percent_define_check_kind (*variablep, muscle_keyword); if (value) { for (++values; *values; ++values) @@ -711,11 +764,6 @@ muscle_m4_output_processor (void *entry, void *out) } -/*----------------------------------------------------------------. -| Output the definition of all the current muscles into a list of | -| m4_defines. | -`----------------------------------------------------------------*/ - void muscles_m4_output (FILE *out) {