From: Adrian Wielgosik <adrian.wielgosik@gmail.com>
Date: Fri, 29 Apr 2016 08:38:02 +0000 (+0200)
Subject: Don't copy strings in Startswith, Endswith
X-Git-Tag: 1.3_exp1~5^2~1
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/c1f961ecbb1119b9ba6b5a67930d50490f8b0fb5

Don't copy strings in Startswith, Endswith
---

diff --git a/apt-pkg/contrib/strutl.cc b/apt-pkg/contrib/strutl.cc
index d388cbda3..24fca5174 100644
--- a/apt-pkg/contrib/strutl.cc
+++ b/apt-pkg/contrib/strutl.cc
@@ -71,14 +71,14 @@ bool Endswith(const std::string &s, const std::string &end)
 {
    if (end.size() > s.size())
       return false;
-   return (s.substr(s.size() - end.size(), s.size()) == end);
+   return (s.compare(s.size() - end.size(), end.size(), end) == 0);
 }
 
 bool Startswith(const std::string &s, const std::string &start)
 {
    if (start.size() > s.size())
       return false;
-   return (s.substr(0, start.size()) == start);
+   return (s.compare(0, start.size(), start) == 0);
 }
 
 }