From: Michael Vogt Date: Wed, 18 Jun 2014 08:46:08 +0000 (+0200) Subject: Merge remote-tracking branch 'mvo/feature/update-by-hash' into debian/experimental X-Git-Tag: 1.1.exp1~13 X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/b6fea8bbe25e3c0312de72c99b0d49c699d02b7b?hp=-c Merge remote-tracking branch 'mvo/feature/update-by-hash' into debian/experimental --- b6fea8bbe25e3c0312de72c99b0d49c699d02b7b diff --combined apt-pkg/acquire-item.cc index 70d03b845,e111ed4ca..e45308557 --- a/apt-pkg/acquire-item.cc +++ b/apt-pkg/acquire-item.cc @@@ -1018,6 -1018,8 +1018,8 @@@ void pkgAcqIndex::Init(string const &UR indexRecords::checkSum *Record = MetaIndexParser->Lookup(MetaKey); if(Record) FileSize = Record->Size; + + InitByHashIfNeeded(MetaKey); } Desc.Description = URIDesc; @@@ -1027,6 -1029,38 +1029,38 @@@ QueueURI(Desc); } /*}}}*/ + // AcqIndex::AdjustForByHash - modify URI for by-hash support /*{{{*/ + // --------------------------------------------------------------------- + /* */ + void pkgAcqIndex::InitByHashIfNeeded(const std::string MetaKey) + { + // TODO: + // - (maybe?) add support for by-hash into the sources.list as flag + // - make apt-ftparchive generate the hashes (and expire?) + std::string HostKnob = "APT::Acquire::" + ::URI(Desc.URI).Host + "::By-Hash"; + if(_config->FindB("APT::Acquire::By-Hash", false) == true || + _config->FindB(HostKnob, false) == true || + MetaIndexParser->GetSupportsAcquireByHash()) + { + indexRecords::checkSum *Record = MetaIndexParser->Lookup(MetaKey); + if(Record) + { + // FIXME: should we really use the best hash here? or a fixed one? + const HashString *TargetHash = Record->Hashes.find(""); + std::string ByHash = "/by-hash/" + TargetHash->HashType() + "/" + TargetHash->HashValue(); + size_t trailing_slash = Desc.URI.find_last_of("/"); + Desc.URI = Desc.URI.replace( + trailing_slash, + Desc.URI.substr(trailing_slash+1).size()+1, + ByHash); + } else { + _error->Warning( + "Fetching ByHash requested but can not find record for %s", + MetaKey.c_str()); + } + } + } + /*}}}*/ // AcqIndex::Custom600Headers - Insert custom request headers /*{{{*/ // --------------------------------------------------------------------- /* The only header we use is the last-modified header. */ @@@ -1620,6 -1654,7 +1654,6 @@@ void pkgAcqMetaIndex::QueueIndexes(boo // at this point the real Items are loaded in the fetcher ExpectedAdditionalItems = 0; - for (vector ::const_iterator Target = IndexTargets->begin(); Target != IndexTargets->end(); ++Target) diff --combined apt-pkg/acquire-item.h index 6e204813a,cda92e84f..b4cac2f04 --- a/apt-pkg/acquire-item.h +++ b/apt-pkg/acquire-item.h @@@ -713,6 -713,9 +713,9 @@@ class pkgAcqIndex : public pkgAcqBaseIn */ std::string CompressionExtension; + /** \brief Do the changes needed to fetch via AptByHash (if needed) */ + void InitByHashIfNeeded(const std::string MetaKey); + public: // Specialized action members @@@ -745,7 -748,7 +748,7 @@@ std::string ShortDesc, HashStringList const &ExpectedHashes, std::string compressExt=""); pkgAcqIndex(pkgAcquire *Owner, - struct IndexTarget const * const Target, + IndexTarget const * const Target, HashStringList const &ExpectedHash, indexRecords *MetaIndexParser); void Init(std::string const &URI, std::string const &URIDesc,