From: Michael Vogt <michael.vogt@ubuntu.com>
Date: Thu, 28 Jul 2011 07:28:29 +0000 (+0200)
Subject: merged from lp:~donkult/apt/sid
X-Git-Tag: 0.8.15.5~1
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/b433026f2803b42904937059cc62d902f2ca6294?ds=inline;hp=--cc

merged from lp:~donkult/apt/sid
---

b433026f2803b42904937059cc62d902f2ca6294
diff --cc apt-pkg/deb/deblistparser.cc
index 651fa2a81,fd5a1e475..73628c741
--- a/apt-pkg/deb/deblistparser.cc
+++ b/apt-pkg/deb/deblistparser.cc
@@@ -784,7 -784,7 +784,9 @@@ bool debListParser::LoadReleaseInfo(pkg
        size_t len = 0;
  
        // Skip empty lines
--      for (; buffer[len] == '\r' && buffer[len] == '\n'; ++len);
++      for (; buffer[len] == '\r' && buffer[len] == '\n'; ++len)
++         /* nothing */
++         ;
        if (buffer[len] == '\0')
  	 continue;
  
@@@ -798,13 -798,17 +800,25 @@@
        }
  
        // seperate the tag from the data
--      for (; buffer[len] != ':' && buffer[len] != '\0'; ++len);
++      for (; buffer[len] != ':' && buffer[len] != '\0'; ++len)
++         /* nothing */
++         ;
        if (buffer[len] == '\0')
  	 continue;
        char* dataStart = buffer + len;
--      for (++dataStart; *dataStart == ' '; ++dataStart);
++      for (++dataStart; *dataStart == ' '; ++dataStart)
++         /* nothing */
++         ;
        char* dataEnd = dataStart;
--      for (++dataEnd; *dataEnd != '\0'; ++dataEnd);
++      for (++dataEnd; *dataEnd != '\0'; ++dataEnd)
++         /* nothing */
++         ;
+       // The last char should be a newline, but we can never be sure: #633350
+       char* lineEnd = dataEnd;
 -      for (--lineEnd; *lineEnd == '\r' || *lineEnd == '\n'; --lineEnd);
++      for (--lineEnd; *lineEnd == '\r' || *lineEnd == '\n'; --lineEnd)
++         /* nothing */
++         ;
+       ++lineEnd;
  
        // which datastorage need to be updated
        map_ptrloc* writeTo = NULL;