From: Julian Andres Klode <jak@debian.org>
Date: Sat, 15 Aug 2015 08:44:57 +0000 (+0200)
Subject: update: Check if the cache could be opened, don't just assume it
X-Git-Tag: 1.1.exp9~19
X-Git-Url: https://git.saurik.com/apt.git/commitdiff_plain/7a139fa8bf2c18da54b5837c9290ba5b77e9c629

update: Check if the cache could be opened, don't just assume it

This seems to cause Bug#756162, as in that case the depcache
was NULL.

I'm not entirely sure how that happens, but it's better to
be check here rather then crash later on.

Closes: #756162
---

diff --git a/apt-private/private-update.cc b/apt-private/private-update.cc
index 73a82e988..1323771f0 100644
--- a/apt-private/private-update.cc
+++ b/apt-private/private-update.cc
@@ -84,7 +84,8 @@ bool DoUpdate(CommandLine &CmdL)
    if (_config->FindB("APT::Cmd::Show-Update-Stats", false) == true)
    {
       int upgradable = 0;
-      Cache.Open();
+      if (Cache.Open() == false)
+         return false;
       for (pkgCache::PkgIterator I = Cache->PkgBegin(); I.end() != true; ++I)
       {
          pkgDepCache::StateCache &state = Cache[I];